athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-06-26T03:02:22+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/44697LArMonitoring: Fix clang warnings.2021-06-26T03:02:22+02:00Scott SnyderLArMonitoring: Fix clang warnings.Unused private data members.Unused private data members.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44696ClassIDSvc: read CLID database on first use2021-06-29T03:04:10+02:00Frank WinklmeierClassIDSvc: read CLID database on first useThe `ClassIDSvc` is sometimes used before it has been initialized
properly itself (e.g. other services using it during their `initialize`).
To avoid enforcing an initialization order, ensure that the CLID
database is read on the first in...The `ClassIDSvc` is sometimes used before it has been initialized
properly itself (e.g. other services using it during their `initialize`).
To avoid enforcing an initialization order, ensure that the CLID
database is read on the first invocation (and latest during
`initialize`).
Fixes ATR-23634.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44695valid_cov, rename to indicate what it actually does.2021-06-29T03:02:44+02:00Christos Anastopouloschristos.anastopoulos@cern.chvalid_cov, rename to indicate what it actually does.valid_cov, rename to indicate what it actually does and follow more the "camel" ATLAS name convention.
We have/had cases where the matrix is not semi pos def and still has non-0 diagonal elements etc.
Also use std::numeric_limits<dou...valid_cov, rename to indicate what it actually does and follow more the "camel" ATLAS name convention.
We have/had cases where the matrix is not semi pos def and still has non-0 diagonal elements etc.
Also use std::numeric_limits<double>::epsilon() rather than have it as magic number.
Mentiong @wleight and @jojunggehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/44692Bug fixes to configuration of mc20e ART tests2021-06-26T03:03:17+02:00Mark HodgkinsonBug fixes to configuration of mc20e ART testsUnset ATHENA_PROC_NUMBER in mc20e tests to bypass ATLASJT-418.
Remove some not needed return statements from test scripts.Unset ATHENA_PROC_NUMBER in mc20e tests to bypass ATLASJT-418.
Remove some not needed return statements from test scripts.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44691AnalysisTop: Disable FFJetSmearingTool when running nominal-only2021-06-25T09:39:56+02:00Oliver MajerskyAnalysisTop: Disable FFJetSmearingTool when running nominal-onlyThis is a work-around which disables the initialization of the FFJetSmearingTool for jet mass resolution uncertainties, when not running systematic uncertainties. Under normal circumstances, we don't have to resort to such actions, but t...This is a work-around which disables the initialization of the FFJetSmearingTool for jet mass resolution uncertainties, when not running systematic uncertainties. Under normal circumstances, we don't have to resort to such actions, but this tool consumes significant amount of memory (~2GB). The issue with the tool is being followed-up with JetEtMiss experts.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44690gFEX Mapping2022-07-13T14:04:27+02:00Cecilia ToscirigFEX MappingThis is the bitwise simulation for gFEX. It includes the gFEX JetFinder algorithm. TOB words are created within the AlgoTool, and saved in the OutputCollection. The gTowers mapping has been validated.This is the bitwise simulation for gFEX. It includes the gFEX JetFinder algorithm. TOB words are created within the AlgoTool, and saved in the OutputCollection. The gTowers mapping has been validated.https://gitlab.cern.ch/atlas/athena/-/merge_requests/4468922.0-TSoS-unique_ptr-InDetTrackHoleSearch2021-06-26T03:04:14+02:00Shaun Roe22.0-TSoS-unique_ptr-InDetTrackHoleSearchThis should complete the conversion of InDetRecTools packages to use the new TrackStateOnSurface constructor taking unique_ptr arguments in place of bare pointers. Work undertaken in the context of ATLASRECTS-6384.This should complete the conversion of InDetRecTools packages to use the new TrackStateOnSurface constructor taking unique_ptr arguments in place of bare pointers. Work undertaken in the context of ATLASRECTS-6384.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44687TrigCost: Fix unique rates calculation2021-06-26T03:02:51+02:00Aleksandra PorebaTrigCost: Fix unique rates calculation- read right global group name to calculate unique rates correctly
- read athena prescales to disable items that were disabled in athena job
Related to ATR-23716
Tagging @tamartin- read right global group name to calculate unique rates correctly
- read athena prescales to disable items that were disabled in athena job
Related to ATR-23716
Tagging @tamartinhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/44685fix python3 problems producing NANs in Powheg output2021-06-26T03:04:17+02:00Ewelina Maria Lobodzinskafix python3 problems producing NANs in Powheg outputfix python3 problems producing NANs in Powheg outputfix python3 problems producing NANs in Powheg outputhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/44684After https://gitlab.cern.ch/atlas/athena/-/merge_requests/44652 we do not ne...2021-06-26T03:04:35+02:00Christos Anastopouloschristos.anastopoulos@cern.chAfter https://gitlab.cern.ch/atlas/athena/-/merge_requests/44652 we do not need to clear before moving. This quick patch served its roleAfter https://gitlab.cern.ch/atlas/athena/-/merge_requests/44652 we do not need to clear before moving. This quick patch served its roleAfter https://gitlab.cern.ch/atlas/athena/-/merge_requests/44652 we do not need to clear before moving. This quick patch served its rolehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/44683Improve doc egamma with image alg2021-06-26T03:03:09+02:00Ruggero TurraImprove doc egamma with image algAdding a large image of egamma algorithm classes in the documentation
Fix English in the docAdding a large image of egamma algorithm classes in the documentation
Fix English in the dochttps://gitlab.cern.ch/atlas/athena/-/merge_requests/4468222.0-cppcheck-InDetAlignmentMonitoring2021-07-02T22:00:47+02:00Shaun Roe22.0-cppcheck-InDetAlignmentMonitoringFixes from cppcheck scan. Accesses out of bounds are fixed, in particular.Fixes from cppcheck scan. Accesses out of bounds are fixed, in particular.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44680MadGraphControl: fix on-the-fly dictionary tweak for Python32021-06-26T03:03:34+02:00Christian GutschowMadGraphControl: fix on-the-fly dictionary tweak for Python3Couple more instances of dictionaries being modified while looping over them, which needs a bit of TLC in Python3.
Fix by making a genuine clone of the list.
cc @ewelinaCouple more instances of dictionaries being modified while looping over them, which needs a bit of TLC in Python3.
Fix by making a genuine clone of the list.
cc @ewelinahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/44679update inDetector method for handling ITkStrip sensors with mutliple SiDetect...2021-06-26T03:05:17+02:00Nicholas Stylesupdate inDetector method for handling ITkStrip sensors with mutliple SiDetectorElements per moduleAs above; porting changes from ~"21.9" merge request !42739
Updates for inDetector checks, to allow geometries with split rows to do this check based on their motherDesign, and thus avoid returning an `outside` status more often than in...As above; porting changes from ~"21.9" merge request !42739
Updates for inDetector checks, to allow geometries with split rows to do this check based on their motherDesign, and thus avoid returning an `outside` status more often than intended (i.e. when at edge of row, but not at edge of sensor).
FYI @hhayward @ncalace @tstreblehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/44677Adding "analysis strategy" and PCBT to fixed cut efficiency conversion for GNN2021-07-27T10:08:29+02:00Nilotpal KakatiAdding "analysis strategy" and PCBT to fixed cut efficiency conversion for GNNThe MR includes the following features-
* Calculating Fixed cut efficiencies from PCBT efficiencies when using GNN. (GNN will always return PCBT efficiencies)
* Analysis Strategy "Leading2SignalJets" is added.
Previously with maps, we ...The MR includes the following features-
* Calculating Fixed cut efficiencies from PCBT efficiencies when using GNN. (GNN will always return PCBT efficiencies)
* Analysis Strategy "Leading2SignalJets" is added.
Previously with maps, we used to pass only the jets we want to truth tag, but now with the GNN, we need to pass all the jets (the GNN takes into consideration all the jet-jet dependencies); but we still want to truth tag only the jets we care about.
* Whether to use CDI or GNN for efficiencies is decided based on node_feat.size() now. (It used to be based on whether m_path2onnx property is set or not). It enables us to use the maps if we want, even though we have initialized the tool with ONNX support.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44676update of the ID GPU demonstrator2021-06-30T03:04:24+02:00Dmitry Emeliyanovupdate of the ID GPU demonstratorThis update includes:
1) new memory management scheme using CUDA Unified Memory Architecture
2) no-PPS option for GPU-based track seed generator to keep it compatible with the CPU-based version
no changes in unit/integration tests result...This update includes:
1) new memory management scheme using CUDA Unified Memory Architecture
2) no-PPS option for GPU-based track seed generator to keep it compatible with the CPU-based version
no changes in unit/integration tests results are expected.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44675adding an option to overwrite the DB value by the input2021-06-26T03:05:13+02:00Soshi Tsunoadding an option to overwrite the DB value by the inputJust add an option for override the DB contents via job option.
But by default, this is inactivated, thus, the q-test will not change.Just add an option for override the DB contents via job option.
But by default, this is inactivated, thus, the q-test will not change.https://gitlab.cern.ch/atlas/athena/-/merge_requests/4467322.0-TSoS-unique_ptr-InDetConversionFinderTools2021-06-26T03:05:33+02:00Shaun Roe22.0-TSoS-unique_ptr-InDetConversionFinderToolsPart of ATLASRECTS-6384, making use of the new all-unique_ptr constructor of TrackStateOfSurface.Part of ATLASRECTS-6384, making use of the new all-unique_ptr constructor of TrackStateOfSurface.https://gitlab.cern.ch/atlas/athena/-/merge_requests/4467222.0-cleanup-SiClusterizationTool (cppcheck)2021-06-26T03:04:06+02:00Shaun Roe22.0-cleanup-SiClusterizationTool (cppcheck)Addressing cppcheck issues, in particular pathological out-of-bounds access in TruthPixelClusterSplitter.cxx which will now throw an exception instead of continuing blindly. Other changes are mainly replacing use of iterator post-increme...Addressing cppcheck issues, in particular pathological out-of-bounds access in TruthPixelClusterSplitter.cxx which will now throw an exception instead of continuing blindly. Other changes are mainly replacing use of iterator post-increment with pre-increment (or writing the code concerned in a more succinct way to avoid use of iterators altogether)https://gitlab.cern.ch/atlas/athena/-/merge_requests/44671Replaced decorators around functions that use flags2021-06-26T03:03:32+02:00Kacper Wojciech TopolnickiReplaced decorators around functions that use flagsThe `@memoize` and `@lru_cache` decorators around functions
that use flags were replaced with `@AccumulatorCache`. This
new decorator is intended to be used with
functions that take `AthConfigFlags` objects as arguments
and is describe...The `@memoize` and `@lru_cache` decorators around functions
that use flags were replaced with `@AccumulatorCache`. This
new decorator is intended to be used with
functions that take `AthConfigFlags` objects as arguments
and is described in:
<https://gitlab.cern.ch/atlas/athena/-/merge_requests/43559>
Some additional improvements were added to `AccumulatorCache`.
@tbold @rbielski ATR-23200