athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-05-15T03:03:28+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/43515xAODMissingET: Fix cppcheck warnings.2021-05-15T03:03:28+02:00Scott SnyderxAODMissingET: Fix cppcheck warnings.Fix cppcheck warnings.Fix cppcheck warnings.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43514xAODPrimitives: Fix cppcheck warnings.2021-05-15T03:04:31+02:00Scott SnyderxAODPrimitives: Fix cppcheck warnings.Argument name mismatch between declaration and definition.Argument name mismatch between declaration and definition.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43513xAODJet: Fix cppcheck warnings.2021-05-15T03:03:21+02:00Scott SnyderxAODJet: Fix cppcheck warnings.Fix cppcheck warnings.Fix cppcheck warnings.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43512LArROD: Fix clang warning.2021-05-15T03:03:58+02:00Scott SnyderLArROD: Fix clang warning.Unused private data member.Unused private data member.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43511Slight cleanup for b-jet trigger EDM2021-05-18T03:04:36+02:00Dan GuestSlight cleanup for b-jet trigger EDMA bit of cleanup around the b-jet trigger EDM:
- Remove some vector-per-jet (one entry per track) variables for IPxD taggers. None of what I've removed is required for training any part of the training, and I don't remember using any of...A bit of cleanup around the b-jet trigger EDM:
- Remove some vector-per-jet (one entry per track) variables for IPxD taggers. None of what I've removed is required for training any part of the training, and I don't remember using any of it for useful diagnostics in quite a few years. We're also trying to get away from using IPxD at all.
- Add the `Jvt` and the JVT inputs to the b-jets. The interplay between JVT and b-tagging in the trigger is something we're going to need to study.
Any opinions from @cpollard ?https://gitlab.cern.ch/atlas/athena/-/merge_requests/43509Reco ART test updates2021-05-15T03:03:32+02:00Mark HodgkinsonReco ART test updatesUpdate pflow from ESD test to use latest job options file. Remove older deprecated pflow job options file.
Update MC reco test to not specify an output histogram file. Doing this prevents monitoring from being run, which
is what we usual...Update pflow from ESD test to use latest job options file. Remove older deprecated pflow job options file.
Update MC reco test to not specify an output histogram file. Doing this prevents monitoring from being run, which
is what we usually do in MC production workflows.
Bug fix to mcLatest tests such that MT=8 is used in all non-HITtoRDO steps.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43508Create test with reduced tau PT threshold2021-05-15T03:04:30+02:00Mark SuttonCreate test with reduced tau PT thresholdAdd a test wit hthe reduced PT threshold for the tu signature chainAdd a test wit hthe reduced PT threshold for the tu signature chainhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43507InDetAlignMon Generic Tracks: remove LW-Histograms references2021-05-15T03:03:23+02:00Salvador Marti I Garciasalvador.marti@cern.chInDetAlignMon Generic Tracks: remove LW-Histograms referencesAs commented in MR !43432, InDetAlignMonGenericTracks made use of thread-hostile LW-Histograms :(
All TH1F-LW has been replaced by TH1FAs commented in MR !43432, InDetAlignMonGenericTracks made use of thread-hostile LW-Histograms :(
All TH1F-LW has been replaced by TH1Fhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43505Add Precision Tracking to the existing Fullscan LRT Chains2021-05-15T03:05:52+02:00Benjamin Philip KerridgeAdd Precision Tracking to the existing Fullscan LRT ChainsThese changes add Precision Tracking to the existing fullscan LRT chains.
Changes:
- EDM Changes to support PT (adds 2 collections `HLT_IDTrack_FSLRT_IDTrig` and `HLT_IDTrack_FSLRT_IDTrigAux`)
- Adds Precision Tracking as part of the LRT...These changes add Precision Tracking to the existing fullscan LRT chains.
Changes:
- EDM Changes to support PT (adds 2 collections `HLT_IDTrack_FSLRT_IDTrig` and `HLT_IDTrack_FSLRT_IDTrigAux`)
- Adds Precision Tracking as part of the LRT tracking step
Jira: ATR-22502 ATR-22311https://gitlab.cern.ch/atlas/athena/-/merge_requests/43504Commenting out JetInputProviderFEX for L1Topo - ATR-234402021-05-15T03:04:28+02:00Anil Sonayanil.sonay@cern.chCommenting out JetInputProviderFEX for L1Topo - ATR-23440Since jFEX EDM is not ready to use, JetInputProviderFEX commented out in Lvl1 configuration.Since jFEX EDM is not ready to use, JetInputProviderFEX commented out in Lvl1 configuration.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43503Fixed typo in Local/Global coordinates in XMLs. Added lines to plots all...2021-05-15T03:04:00+02:00Paul JonesFixed typo in Local/Global coordinates in XMLs. Added lines to plots all...Fixed typo in Local/Global coordinates in XMLs. Added lines to plots all stations as well as BIS alone. Added units to some histograms - more to be added later.Fixed typo in Local/Global coordinates in XMLs. Added lines to plots all stations as well as BIS alone. Added units to some histograms - more to be added later.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43502TileSimAlgs: Make Tile hit to TTL1 algorithm reentrant2021-05-15T03:04:48+02:00Siarhei HarkushaTileSimAlgs: Make Tile hit to TTL1 algorithm reentrantTile hit to TTL1 algorithm has been migrated to reentrant one.Tile hit to TTL1 algorithm has been migrated to reentrant one.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43501TileRecUtils: Fix Tile raw channels OF1 corrections (ATLASRECTS-6300)2021-05-15T03:03:12+02:00Siarhei HarkushaTileRecUtils: Fix Tile raw channels OF1 corrections (ATLASRECTS-6300)Tile OF1 raw channels corrections have been fixed for online.
Tile OF1 OFC and online timing tools are not needed when
pedestal correction is not applied.Tile OF1 raw channels corrections have been fixed for online.
Tile OF1 OFC and online timing tools are not needed when
pedestal correction is not applied.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43500Fix in ElectronSelectorHelpers passAmbiguity2021-05-15T03:03:50+02:00Philip SommerFix in ElectronSelectorHelpers passAmbiguityThe passAmbiguity method in `ElectronSelectorHelpers` takes the requirement to cut on as a `uint8_t` bitword. Since we have nine ambiguity types in master, a `uint8_t` can't hold all possible cuts. So, let's better change that to a `uint...The passAmbiguity method in `ElectronSelectorHelpers` takes the requirement to cut on as a `uint8_t` bitword. Since we have nine ambiguity types in master, a `uint8_t` can't hold all possible cuts. So, let's better change that to a `uint16_t`.
Cheers,
Philiphttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43499tauRecTools: add missing tool to dictionary2021-05-14T03:05:19+02:00Bertrand Martin Dit LatourtauRecTools: add missing tool to dictionaryHello,
It seems we are missing the TauVertexedClusterDecorator tool in the tauRecTools dictionary, this MR is add it.
Cheers,
BertrandHello,
It seems we are missing the TauVertexedClusterDecorator tool in the tauRecTools dictionary, this MR is add it.
Cheers,
Bertrandhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43498AddDirectory false if we are running DQ monitoring2021-06-09T16:53:56+02:00Peter OnyisiAddDirectory false if we are running DQ monitoringSet a ROOT global flag to False - prevents histograms from being assigned to a TDirectory by default, an action that is thread-unsafe and causes subtle bugs in MT. (e.g. ATLASRECTS-6029 probably.)
I've done this in the base class of the...Set a ROOT global flag to False - prevents histograms from being assigned to a TDirectory by default, an action that is thread-unsafe and causes subtle bugs in MT. (e.g. ATLASRECTS-6029 probably.)
I've done this in the base class of the new-style monitoring which I don't think is really optimal, since it definitely will cause other code to see different ROOT environments depending on whether monitoring is on or off, but perhaps someone can make a better suggestion.
Attn @wlampl @ssnyderhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43497Switch off old-style trigger DQ monitoring algorithms by default (ATR-23399 a...2021-05-16T03:03:05+02:00Peter OnyisiSwitch off old-style trigger DQ monitoring algorithms by default (ATR-23399 and related)Disable mixed mode by defaultDisable mixed mode by defaulthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43496muonEvent+CaloEvent: Fix cppcheck warnings.2021-05-15T03:05:06+02:00Scott SnydermuonEvent+CaloEvent: Fix cppcheck warnings.Avoid postincrement for iterator classes.Avoid postincrement for iterator classes.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43495fix compilation error in AnaAlgorithm package2021-05-14T10:06:25+02:00Nils Erik Krumnackfix compilation error in AnaAlgorithm packageThat was introduced by two recent merge requests crossing.That was introduced by two recent merge requests crossing.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43494Sweeping !43421 from 21.3 to 21.9.
Migrate preInclude.Run3G4Optimiziations.py...2021-05-14T03:06:19+02:00Atlas NightlybuildSweeping !43421 from 21.3 to 21.9.
Migrate preInclude.Run3G4Optimiziations.py back to python 2 syntaxMigrate preInclude.Run3G4Optimiziations.py back to python 2 syntax
See merge request atlas/athena!43421Migrate preInclude.Run3G4Optimiziations.py back to python 2 syntax
See merge request atlas/athena!43421