athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-06-25T03:04:17+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/44654Ep/add stgc channels2021-06-25T03:04:17+02:00Enrico PasqualucciEp/add stgc channelsOffline channel number for sTGC strips addedOffline channel number for sTGC strips addedhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/44653FlavourTaggingTests: Fix clang warnings.2021-06-25T03:03:06+02:00Scott SnyderFlavourTaggingTests: Fix clang warnings.Missing override keywords.
Spurious copies in range-for.Missing override keywords.
Spurious copies in range-for.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44651IDPVM truthProb cut configurable2021-06-25T03:06:04+02:00Thomas StreblerIDPVM truthProb cut configurableSelf-explanatory
FYI @ncalace @aschuySelf-explanatory
FYI @ncalace @aschuyhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/44650TrigCost: Add number of PU prediction2021-06-25T03:02:59+02:00Aleksandra PorebaTrigCost: Add number of PU predictionCalculate PU number prediction and error as a part of the Global summary. Can be used in cost reprocessings
`PU = mean_event_time * L1_input_rate`
Tagging @tamartinCalculate PU number prediction and error as a part of the Global summary. Can be used in cost reprocessings
`PU = mean_event_time * L1_input_rate`
Tagging @tamartinhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/44648Ignore d0 cut for electron LRT if idperf chain2021-06-26T03:02:57+02:00Jonathan LongIgnore d0 cut for electron LRT if idperf chainThis changes the configuration of the electron LRT chain to ignore the cut on d0 if it's an idperf chain as it should. I've also tried to harmonize the config setup with the other options.
cc: @dbakshig if you have time to take a quick...This changes the configuration of the electron LRT chain to ignore the cut on d0 if it's an idperf chain as it should. I've also tried to harmonize the config setup with the other options.
cc: @dbakshig if you have time to take a quick look I'd appreciate it.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44647conf2toConfigurable: sort new items in PrivateToolHandleArray2021-06-25T03:05:04+02:00Rafal Bielskirafal.bielski@cern.chconf2toConfigurable: sort new items in PrivateToolHandleArrayAdditional fix to !44516. Sort the new components list when adding new tools to PrivateToolHandleArray. The iteration is done over `set` difference which has undefined (random) ordering in python so it needs to be sorted if we want repro...Additional fix to !44516. Sort the new components list when adding new tools to PrivateToolHandleArray. The iteration is done over `set` difference which has undefined (random) ordering in python so it needs to be sorted if we want reproducible job configuration (we do!).
Fixes ATR-22505
cc @tboldhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/4464622.0-unique_ptr-TRT_SeededTrackFinder2021-06-25T03:03:45+02:00Shaun Roe22.0-unique_ptr-TRT_SeededTrackFinderconverting TRT_SeededTrackFinder to use all-unique_ptr version of the TrackStateOnSurface constructor. Additional cleanups (principally reformatting, and using cmath functions) performed. Part of ATLASRECTS-6384.converting TRT_SeededTrackFinder to use all-unique_ptr version of the TrackStateOnSurface constructor. Additional cleanups (principally reformatting, and using cmath functions) performed. Part of ATLASRECTS-6384.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44645updates from M8 of online pixel monitoring histograms2021-06-25T03:04:12+02:00Iskander Ibragimovupdates from M8 of online pixel monitoring histograms- local fix of kLive histograms by booking a shorter range (=kLive) initially
- match booking and filling for online histograms.- local fix of kLive histograms by booking a shorter range (=kLive) initially
- match booking and filling for online histograms.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44644AnalysisTop: Port missing large-R jet stuff from 21.2 to master2021-06-25T03:03:26+02:00Oliver MajerskyAnalysisTop: Port missing large-R jet stuff from 21.2 to masterThis essentially a manual sweep of
https://gitlab.cern.ch/atlas/athena/-/merge_requests/39069
https://gitlab.cern.ch/atlas/athena/-/merge_requests/41540
https://gitlab.cern.ch/atlas/athena/-/merge_requests/42568
https://gitlab.cern.c...This essentially a manual sweep of
https://gitlab.cern.ch/atlas/athena/-/merge_requests/39069
https://gitlab.cern.ch/atlas/athena/-/merge_requests/41540
https://gitlab.cern.ch/atlas/athena/-/merge_requests/42568
https://gitlab.cern.ch/atlas/athena/-/merge_requests/43010
https://gitlab.cern.ch/atlas/athena/-/merge_requests/43845
https://gitlab.cern.ch/atlas/athena/-/merge_requests/43937
to get the large-R jet recommendations in AnalysisTop in sync between 21.2 and master.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44643Changing L1 seed of forward jet chains in physics menu2021-06-25T03:02:39+02:00Marco ValenteChanging L1 seed of forward jet chains in physics menuAs correctly pointed out by @khoo, this modifies the wrong L1 seed used in recently added forward jet chains to the physics menu in !44561
@dzanzi @khooAs correctly pointed out by @khoo, this modifies the wrong L1 seed used in recently added forward jet chains to the physics menu in !44561
@dzanzi @khooMarco ValenteMarco Valentehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/44642Added chains for top analysis from ART-235772021-06-25T03:04:54+02:00Tomasz BoldAdded chains for top analysis from ART-23577As the title says. It is additions to the menu related to:
ART-23577
Tagging @amoreira as we coordinate updates related to the same MRAs the title says. It is additions to the menu related to:
ART-23577
Tagging @amoreira as we coordinate updates related to the same MRhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/44641remove unsignificant dcube tests2021-06-25T03:06:05+02:00Marcin Wolterremove unsignificant dcube testshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/44640AthenaPoolUtilities: Add missing warning pattern in post_tpcnvtest.sh2021-06-25T03:03:39+02:00Rafal Bielskirafal.bielski@cern.chAthenaPoolUtilities: Add missing warning pattern in post_tpcnvtest.shFixes spurious unit test failures in CI, like seen in https://gitlab.cern.ch/atlas/athena/-/merge_requests/44516#note_4586583 and https://gitlab.cern.ch/atlas/athena/-/merge_requests/44583#note_4591115.
Discussed with and suggested by @...Fixes spurious unit test failures in CI, like seen in https://gitlab.cern.ch/atlas/athena/-/merge_requests/44516#note_4586583 and https://gitlab.cern.ch/atlas/athena/-/merge_requests/44583#note_4591115.
Discussed with and suggested by @jchapman in "Merge Request shifter" mattermost channel:
https://mattermost.web.cern.ch/atlassoftware/pl/if8i74jfdbdntkfzjr8qy6qd3w
_MR submitted from GitLab Web Editor, so the branch is on the main repo_https://gitlab.cern.ch/atlas/athena/-/merge_requests/44639updates to CollectionMerger for Upgrade detectors2021-06-25T03:03:48+02:00Nicholas Stylesupdates to CollectionMerger for Upgrade detectorsAdd ```ITkPixel```, ```ITkStrip``` and ```HGTD``` to ```CollectionMerger``` to resolve ATLASSIM-5287Add ```ITkPixel```, ```ITkStrip``` and ```HGTD``` to ```CollectionMerger``` to resolve ATLASSIM-5287https://gitlab.cern.ch/atlas/athena/-/merge_requests/4463822.0-testing-AthContainers2021-06-26T03:05:41+02:00Shaun Roe22.0-testing-AthContainersPertinent test to ATLASRECTS-6431: extending the existing test to check leaks on DataVector assignment and move assignmentPertinent test to ATLASRECTS-6431: extending the existing test to check leaks on DataVector assignment and move assignmenthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/44637TrigP1Test: update beamspot test reference2021-06-25T03:03:56+02:00Frank WinklmeierTrigP1Test: update beamspot test referenceUpdate ART log file reference for the beamspot test.
Closes ATR-23721.Update ART log file reference for the beamspot test.
Closes ATR-23721.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44636ATLASRECTS-6431 dirty patch2021-06-24T03:04:44+02:00Christos Anastopouloschristos.anastopoulos@cern.chATLASRECTS-6431 dirty patchSince the move assignment of DataVector does not clean ``this``,
patch it client side.
Note depending on the outcome of the discussion
1. This will need to be removed as will be un-needed if the ``DataVector`` is fixed
or
2. Need to ...Since the move assignment of DataVector does not clean ``this``,
patch it client side.
Note depending on the outcome of the discussion
1. This will need to be removed as will be un-needed if the ``DataVector`` is fixed
or
2. Need to write a custom move assignment for ``Trk::Track`` as the current (although not used)
depends on the same assumption for the ``DataVector`` move assignment
one or the other.
Mentioning @sroe @ssnyder
Unit test for the current behavious (needing client side clear) is coming from @sroe here https://gitlab.cern.ch/atlas/athena/-/merge_requests/44638.
What is the proper way is up to @ssnyder .
If a proper fix appears we should close this one .
i.e this one is just because
of the "critical" nature which I guess means that a fix (even dirty ) is needed today.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44635Improve readability of trigger ID tracking config by using more getPrimaryAnd...2021-06-26T03:04:44+02:00Tomasz BoldImprove readability of trigger ID tracking config by using more getPrimaryAndMerge functionalityThis is a tiny restructure of trigger FTF new JO config code to make i more robust (and less verbose).
Tagging @sutt FIThis is a tiny restructure of trigger FTF new JO config code to make i more robust (and less verbose).
Tagging @sutt FIhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/44634LArCalibProcessing/Flags: global tag as class-variable2021-06-25T03:02:44+02:00Walter LamplLArCalibProcessing/Flags: global tag as class-variableFixes a bug in the old-style config of LAr Electronic Calibration processing jobs.Fixes a bug in the old-style config of LAr Electronic Calibration processing jobs.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44633ATLASRECTS-6432: MuonMDT_CablingMap debug initialization fix2021-06-25T03:05:14+02:00Adam Edward BartonATLASRECTS-6432: MuonMDT_CablingMap debug initialization fixthe `m_debug` variable was not being initialized. I remove it and take it from the input msgstream on a local basis.the `m_debug` variable was not being initialized. I remove it and take it from the input msgstream on a local basis.