athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-05-20T03:03:07+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/43569Fix of memory overhead2021-05-20T03:03:07+02:00Constantin HeideggerFix of memory overheadShould be fixing https://its.cern.ch/jira/browse/ATLASRECTS-6342Should be fixing https://its.cern.ch/jira/browse/ATLASRECTS-6342Constantin HeideggerConstantin Heideggerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43622LRT electrons - Ensure that they are written to the AODs in any case2021-05-20T03:03:04+02:00Giuliano GustavinoLRT electrons - Ensure that they are written to the AODs in any caseHi,
similarly to the case of LRT muons:
https://gitlab.cern.ch/atlas/athena/-/merge_requests/43455
LRT electron containers are not added in the AODs because the flag doR3LargeD0() is reset to false in the ESDToAOD step.
This merge reques...Hi,
similarly to the case of LRT muons:
https://gitlab.cern.ch/atlas/athena/-/merge_requests/43455
LRT electron containers are not added in the AODs because the flag doR3LargeD0() is reset to false in the ESDToAOD step.
This merge request removes that condition in order to fix the issue in that workflow.
Adding @goblirsc, @christos, @mdanninghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43636Navigator remove seemingly unused option and no-op empty method2021-05-20T03:02:54+02:00Christos Anastopouloschristos.anastopoulos@cern.chNavigator remove seemingly unused option and no-op empty methodNavigator remove seemingly unused option and no-op empty method
Mentioning @sroeNavigator remove seemingly unused option and no-op empty method
Mentioning @sroehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43632TriggerFlags: delete obsolete HLT menu files flags2021-05-20T03:02:40+02:00Frank WinklmeierTriggerFlags: delete obsolete HLT menu files flagsDelete the following three flags:
- `input`/`outputHLTconfigFile`: XML-based settings no longer supported
- `outputHLTmenuJsonFile`: not used and superseded by new-style
`Trigger.HLTMenuFile` config flagDelete the following three flags:
- `input`/`outputHLTconfigFile`: XML-based settings no longer supported
- `outputHLTmenuJsonFile`: not used and superseded by new-style
`Trigger.HLTMenuFile` config flaghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43293add mbts energy & timing histograms2021-05-20T03:02:33+02:00Klaudia Majadd mbts energy & timing histogramsThis MR is to add MBTS monitoring histograms: energy & timing per MBTS channel, and MBTS A&C side hits correlation. Tag @tboldThis MR is to add MBTS monitoring histograms: energy & timing per MBTS channel, and MBTS A&C side hits correlation. Tag @tboldKlaudia MajKlaudia Majhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43538Pixel digitization: reduce unnecessary conditions access2021-05-20T03:02:22+02:00Tadej Novaktadej.novak@cern.chPixel digitization: reduce unnecessary conditions accessReduce unnecessary conditions access in pixel digitisation:
- `PixelOfflineCalibCondAlg` seems not to be necessary at all
- cabling is only needed for data overlay
- `PixelCablingSvc` does not actually need conditions
/cc @stsuno @jc...Reduce unnecessary conditions access in pixel digitisation:
- `PixelOfflineCalibCondAlg` seems not to be necessary at all
- cabling is only needed for data overlay
- `PixelCablingSvc` does not actually need conditions
/cc @stsuno @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/39905Herwig721 library loading order issue2021-05-19T17:11:46+02:00Ian Allan ConnellyHerwig721 library loading order issueAs described in AGENE-1877, it is observed that the order of these libraries causes a problem in Herwig721 where the LesHouches class does not have any of the required functionality. This has been verified using Herwig721 interactively, ...As described in AGENE-1877, it is observed that the order of these libraries causes a problem in Herwig721 where the LesHouches class does not have any of the required functionality. This has been verified using Herwig721 interactively, and is fixed by setting up the LHEHandler before the LHEReader. Further study may be required but in the current format, Powheg+Herwig721 is not functioning.
Tagging @dhirsch as he is also looking into this and the library inclusion.https://gitlab.cern.ch/atlas/athena/-/merge_requests/40338FastCaloSim: add mechanism to better clean up the AuxInfo in the simulation s...2021-05-19T13:49:39+02:00Michael Duehrssen-DeblingFastCaloSim: add mechanism to better clean up the AuxInfo in the simulation stateAdd a standard mechanism to cleanup AuxInfo in the simulation state of FastCaloSim. This should help to avoid memory leaks when parametrizations use AuxInfo objectsAdd a standard mechanism to cleanup AuxInfo in the simulation state of FastCaloSim. This should help to avoid memory leaks when parametrizations use AuxInfo objectshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43575add further staging dictionary2021-05-19T03:07:04+02:00Nicholas Stylesadd further staging dictionaryAs above - a further staging option, no outer barrel or endcap
FYI @tlari @ncalace @tstrebleAs above - a further staging option, no outer barrel or endcap
FYI @tlari @ncalace @tstreblehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43597Removing HGTD_setOff() from ID_setOff()2021-05-19T03:06:58+02:00Thomas StreblerRemoving HGTD_setOff() from ID_setOff()Self-explanatory
FYI @tadej @cohm @nstylesSelf-explanatory
FYI @tadej @cohm @nstyleshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43620switch to MG default version 2.8.1p3.atlas102021-05-19T03:06:48+02:00Ewelina Maria Lobodzinskaswitch to MG default version 2.8.1p3.atlas10switch to MG default version 2.8.1p3.atlas10switch to MG default version 2.8.1p3.atlas10https://gitlab.cern.ch/atlas/athena/-/merge_requests/43596HIGG1D1 Derivation config update2021-05-19T03:06:04+02:00Alkaid ChengHIGG1D1 Derivation config updateUpdate MC samples in HiggsMCsamples.cfg requested by JIRA HGAMSW-952Update MC samples in HiggsMCsamples.cfg requested by JIRA HGAMSW-952https://gitlab.cern.ch/atlas/athena/-/merge_requests/43586Introduce CaloCellPedCorr CondAlg2021-05-19T03:05:39+02:00Walter LamplIntroduce CaloCellPedCorr CondAlgWhile profiling the Calo-Reconstruction I noticed that the CaloCellPedestalCorr AlgTool (one of several cell-correction tools called from the CaloCellMaker) is surprisingly slow. A closer look revealed that other classes used by this too...While profiling the Calo-Reconstruction I noticed that the CaloCellPedestalCorr AlgTool (one of several cell-correction tools called from the CaloCellMaker) is surprisingly slow. A closer look revealed that other classes used by this tool check the same things (ranges, versions, ..) for every cell and every event. To avoid these frequent checks, I introduced a ConditionsAlgorithm that reads the conditions values once, does all these checks once and prepares the data as flat vector (per gain). My measurements indicate this saves 10ms/event.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43604HLT Met mon update 202105142021-05-19T03:05:31+02:00Kenji HamanoHLT Met mon update 20210514The axis label of 3 offline HLT MET monitoring histograms were changed to list specified names.
ATR-19971The axis label of 3 offline HLT MET monitoring histograms were changed to list specified names.
ATR-19971https://gitlab.cern.ch/atlas/athena/-/merge_requests/43576Added functionality to declare config differneces as known (and thus ignored)2021-05-19T03:05:29+02:00Tomasz BoldAdded functionality to declare config differneces as known (and thus ignored)This functionality is useful to declutter the output of the difference from the conf tool.
It eliminates from the output the noise because of intentionally different settings.
Also added a file that contains an example of such a differe...This functionality is useful to declutter the output of the difference from the conf tool.
It eliminates from the output the noise because of intentionally different settings.
Also added a file that contains an example of such a differently configured component.
@wlampl @goetz @emoyse
Maybe you see some of the settings that should be added there immediately having a look at:
http://tbold.web.cern.ch/tbold/diff-raw-14may.htmlhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43474Cleanup PixelGmxInterface (part 1)2021-05-19T03:05:26+02:00Tadej Novaktadej.novak@cern.chCleanup PixelGmxInterface (part 1)First step of cleaning up `PixelGmxInterface`. It's a bit heavy on whitespace change so putting in a separate MR. It mainly adds `AthMessaging` and uses `std` namespace.
I moved some helper functions to the base `GmxInterface`, I hope t...First step of cleaning up `PixelGmxInterface`. It's a bit heavy on whitespace change so putting in a separate MR. It mainly adds `AthMessaging` and uses `std` namespace.
I moved some helper functions to the base `GmxInterface`, I hope that's fine.
/cc @dellacqu @nstyleshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43587Move ITk.useLocalGeometry to GeoModel.useLocalGeometry2021-05-19T03:05:24+02:00Tadej Novaktadej.novak@cern.chMove ITk.useLocalGeometry to GeoModel.useLocalGeometryMove `ITk.useLocalGeometry` to `GeoModel.useLocalGeometry` to support `AthSimulation`. Fixes ATLASSIM-5251.
Running ~"full-unit-tests" to confirm.
/cc @nstylesMove `ITk.useLocalGeometry` to `GeoModel.useLocalGeometry` to support `AthSimulation`. Fixes ATLASSIM-5251.
Running ~"full-unit-tests" to confirm.
/cc @nstyleshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43547Stop the comparitor exiting if it cannot open the reference file2021-05-19T03:05:21+02:00Mark SuttonStop the comparitor exiting if it cannot open the reference fileFor a corrupt reference file, the comparitor would exit, so now it no longer exits,
but carries on without the references
Lots of other minopr changes to prevent collisions of points with the labels, plot the
expert histograms on a line...For a corrupt reference file, the comparitor would exit, so now it no longer exits,
but carries on without the references
Lots of other minopr changes to prevent collisions of points with the labels, plot the
expert histograms on a linear x scale, fix the keys etchttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43600Disable the clone removal for the cloneremoval test2021-05-19T03:05:17+02:00Mark SuttonDisable the clone removal for the cloneremoval testThe clone removal was left on in the test for evaluating the clone removal, so this disables it, as was intended.The clone removal was left on in the test for evaluating the clone removal, so this disables it, as was intended.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43585Remove the MuonStraightLineExtrapolator from the MooCandidateMatchingTool2021-05-19T03:05:13+02:00William Axel LeightRemove the MuonStraightLineExtrapolator from the MooCandidateMatchingToolThere is no difference between the MuonStraightLineExtrapolator and the ordinary extrapolator, so there's no reason to have both. RunTier0Tests.py confirms no differences in the results from these changes.
Closes ATLASRECTS-6343There is no difference between the MuonStraightLineExtrapolator and the ordinary extrapolator, so there's no reason to have both. RunTier0Tests.py confirms no differences in the results from these changes.
Closes ATLASRECTS-6343