athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-10-28T15:46:26+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/47692Update MC20 overlay ART tests2021-10-28T15:46:26+02:00Tadej Novaktadej.novak@cern.chUpdate MC20 overlay ART testsUpdate overlay ART tests with the final MC20 configuration.
/cc @jchapmanUpdate overlay ART tests with the final MC20 configuration.
/cc @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47667Fix ATLFAST3MT simulator configuration2021-10-28T15:43:44+02:00John Derek ChapmanFix ATLFAST3MT simulator configurationFYI @keliFYI @kelihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47690Sweeping !47445 from 22.0-mc20 to master.
TrkExUtils - Escape from infinite loop2021-10-28T15:43:49+02:00Atlas NightlybuildSweeping !47445 from 22.0-mc20 to master.
TrkExUtils - Escape from infinite loopTrkExUtils - Escape from infinite loop
See merge request atlas/athena!47445TrkExUtils - Escape from infinite loop
See merge request atlas/athena!47445https://gitlab.cern.ch/atlas/athena/-/merge_requests/47696Fixed the access to CaloDetDescrManager in TBRec (part I)2021-10-28T15:42:46+02:00Vakhtang TsulaiaFixed the access to CaloDetDescrManager in TBRec (part I)1. Switched `TBCellContainerFillerTool` to reading `CaloDetDescrManager` from
the Condition Store
2. Dropped the redundant dependencies on `CaloDetDescrManager` from
`TBClusterMaker`, `TBECLArRawChannelBuilder` and `TBEMECXTalkToyModel`....1. Switched `TBCellContainerFillerTool` to reading `CaloDetDescrManager` from
the Condition Store
2. Dropped the redundant dependencies on `CaloDetDescrManager` from
`TBClusterMaker`, `TBECLArRawChannelBuilder` and `TBEMECXTalkToyModel`.
Instead they now retrieve `CaloCell` ID helpers directly from the
Detector Store
This is part of the ongoing migration of all clients of `CaloDetDescrManager`https://gitlab.cern.ch/atlas/athena/-/merge_requests/47694Update MC20 reco chain ART tests2021-10-28T15:47:52+02:00Tadej Novaktadej.novak@cern.chUpdate MC20 reco chain ART testsUpdate MC20 reco chain ART tests (fixes ATLASRECTS-6650). I deleted one of the tests as two tests were both running trigger.
/cc @mhodgkinUpdate MC20 reco chain ART tests (fixes ATLASRECTS-6650). I deleted one of the tests as two tests were both running trigger.
/cc @mhodgkinhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47492Introduce MM_RawData_p22021-10-28T15:47:38+02:00Patrick ScholerIntroduce MM_RawData_p2This MR is a follow up of https://gitlab.cern.ch/atlas/athena/-/merge_requests/46995. It introduces the _p2 version of the MM_RawData to maintain the backwards readability of RDO files.This MR is a follow up of https://gitlab.cern.ch/atlas/athena/-/merge_requests/46995. It introduces the _p2 version of the MM_RawData to maintain the backwards readability of RDO files.https://gitlab.cern.ch/atlas/athena/-/merge_requests/47592Fix for handling ROIs with zero tracks2021-10-28T15:48:14+02:00Edson Carquin LopezFix for handling ROIs with zero tracksAttempt to fix the handling of zero track taus pinging @tamartin @ademaria @martindl & @iriu
Should fix ATR-24371Attempt to fix the handling of zero track taus pinging @tamartin @ademaria @martindl & @iriu
Should fix ATR-24371https://gitlab.cern.ch/atlas/athena/-/merge_requests/47693Disable muon inputs to legacy L1Topo simulation2021-10-28T15:47:10+02:00Rafal Bielskirafal.bielski@cern.chDisable muon inputs to legacy L1Topo simulationTwo commits:
1. Disable muon inputs to legacy L1Topo simulation
2. Revert a workaround !46682 since this is a proper fix for ATR-24179
Closes ATR-24187 and unblocks ATR-24356Two commits:
1. Disable muon inputs to legacy L1Topo simulation
2. Revert a workaround !46682 since this is a proper fix for ATR-24179
Closes ATR-24187 and unblocks ATR-24356https://gitlab.cern.ch/atlas/athena/-/merge_requests/47691Sweeping !47646 from 22.0-mc20 to master.
TrkTrack: More TrackStateOnSurface ...2021-10-28T15:47:01+02:00Atlas NightlybuildSweeping !47646 from 22.0-mc20 to master.
TrkTrack: More TrackStateOnSurface diagnostics.TrkTrack: More TrackStateOnSurface diagnostics.
See merge request atlas/athena!47646TrkTrack: More TrackStateOnSurface diagnostics.
See merge request atlas/athena!47646https://gitlab.cern.ch/atlas/athena/-/merge_requests/47673Prepare egamma output and LRT2021-10-28T15:48:19+02:00Jean-Baptiste De Vivie De RegiePrepare egamma output and LRTWrite the egamma related containers to the output stream. Also prepare egamma configuration using large radius tracking (but not enabling it in RecoSteering)Write the egamma related containers to the output stream. Also prepare egamma configuration using large radius tracking (but not enabling it in RecoSteering)https://gitlab.cern.ch/atlas/athena/-/merge_requests/47674TileRecEx: Add python module to file Tile input files2021-10-28T15:48:11+02:00Siarhei HarkushaTileRecEx: Add python module to file Tile input filesPython module has been added to find Tile input files (mostly from calibration runs).
In old-style JO such code is scattered around many files.
So, it is attempt to put it one place to simplify maintanability.
Test for this module has b...Python module has been added to find Tile input files (mostly from calibration runs).
In old-style JO such code is scattered around many files.
So, it is attempt to put it one place to simplify maintanability.
Test for this module has been addded also.https://gitlab.cern.ch/atlas/athena/-/merge_requests/47632B-physics trigger: update fit procedure for cascade decays of the B_c+2021-10-28T15:44:45+02:00Vladimir LyubushkinB-physics trigger: update fit procedure for cascade decays of the B_c+This MR introduces a new approach for the cascade decays of B_c+:
* B_c+ -> J/psi(-> mu+ mu-) D_s+(->phi(-> K+ K-) pi+)
* B_c+ -> J/psi(-> mu+ mu-) D+(-> K- pi+ pi+) now are
There is no possibility to run cascade vertex fitter at HLT l...This MR introduces a new approach for the cascade decays of B_c+:
* B_c+ -> J/psi(-> mu+ mu-) D_s+(->phi(-> K+ K-) pi+)
* B_c+ -> J/psi(-> mu+ mu-) D+(-> K- pi+ pi+) now are
There is no possibility to run cascade vertex fitter at HLT level due to the CPU limitations.
So that, three tracks from D+/D_s+ are fitted to the standalone secondary vertex.
The combined momentum of D+/D_s+ candidate is constrained to point to the dimuon vertex.
We found that simplified approach is efficient enough to select requested decay topologies.
Affected chains:
* 'HLT_2mu4_bBmumux_BcmumuDsloose_L12MU3V'
* 'HLT_2mu4_bBmumux_BcmumuDploose_L12MU3V'
CC: @abartonhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47681Add function decorator2021-10-28T15:44:32+02:00Carlo Varnicarlo.varni@cern.chAdd function decoratorAdding a Python's Decorator (`acts_sequence_configuration`) to be used for all the functions that will prepare the sequence of our ACTS algorithms. The wrapper will take care of setting the `OutputLevel` to the desired value and change a...Adding a Python's Decorator (`acts_sequence_configuration`) to be used for all the functions that will prepare the sequence of our ACTS algorithms. The wrapper will take care of setting the `OutputLevel` to the desired value and change all the sequence names to the correct value (e.g. supporting Serial and MT Athena).
Moving all of this in the decoration for reducing the copy-paste of the same piece of code: less maintenance and less bug-pronehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47689Sweeping !47672 from 21.2 to master.
Remove variables availability check in M...2021-10-28T15:48:28+02:00Atlas NightlybuildSweeping !47672 from 21.2 to master.
Remove variables availability check in MuonSelectorToolsTesterRemove variables availability check in MuonSelectorToolsTester
See merge request atlas/athena!47672Remove variables availability check in MuonSelectorToolsTester
See merge request atlas/athena!47672https://gitlab.cern.ch/atlas/athena/-/merge_requests/47666Always create the check histogram ConfigConsistency_HLT [ATR-24420]2021-10-28T15:48:23+02:00Elin Bergeaas KuutmannAlways create the check histogram ConfigConsistency_HLT [ATR-24420]As discovered in ATR-24302 the important cross-check histogram ConfigConsistency_HLT does not get created when no inconsistencies are found. This is not the desired behaviour and this change makes sure the histogram is always created. It...As discovered in ATR-24302 the important cross-check histogram ConfigConsistency_HLT does not get created when no inconsistencies are found. This is not the desired behaviour and this change makes sure the histogram is always created. It will be empty if all is OK.
This fixes ATR-24420.https://gitlab.cern.ch/atlas/athena/-/merge_requests/47574implement TLA selector in HypoAlg2021-10-28T15:42:20+02:00Francesca Pastoreimplement TLA selector in HypoAlgTest to implement the TLA selector functionalities within a HypoAlg, was suggested in ATR-24263. The test is with one muon chain running this command:
```
athenaHLT.py -c "selectChains=['HLT_2mu4_L12MU3V','HLT_mu10_mu6_probe_PhysicsTLA_L...Test to implement the TLA selector functionalities within a HypoAlg, was suggested in ATR-24263. The test is with one muon chain running this command:
```
athenaHLT.py -c "selectChains=['HLT_2mu4_L12MU3V','HLT_mu10_mu6_probe_PhysicsTLA_L1MU8F','HLT_mu10_PhysicsTLA_L1MU8F'];setMenu='LS2_v1_TriggerValidation_prescale';doL1Sim=True;fpeAuditor=True;" -o output --dump-config-reload --imf --perfmon --threads=1 --concurrent-events=1 --nprocs=1 --number-of-events=4 --file=/cvmfs/atlas-nightlies.cern.ch/repo/data/data-art/Tier0ChainTests/data17_13TeV.00330470.physics_Main.merge.DRAW_ZMUMU.f843_m1831._0200.1 TriggerJobOpts/runHLT_standalone.py >athenaHLT.WriteBS.log 2>&1
```
It implements two additional steps:
```
Step5_filter [Seq] [Concurrent] [OR]
FStep5_1muonTLA [Alg] [n= 0]
Step5_reco [Seq] [Concurrent] [OR]
Step5_1muonTLA [Seq] [Sequential] [Prompt]
FStep5_1muonTLA [Alg] [n= 0]
Step5_1muonTLA_view [Seq] [Sequential] [Prompt]
Step5_1muonTLA_reco [Seq] [Concurrent] [OR]
TLAMuonAthSequence [Seq] [Sequential] [Prompt]
IM_TLAMuons [Alg] [n= 0]
MuonTLASeq [Seq] [Sequential] [Prompt]
tlaMuonInViewAlgs [Seq] [Concurrent] [OR]
TLAMuonViewDataVerifier [Alg] [n= 0]
TrigMuonTLAHypoAlg [Alg] [n= 0]
ComboHypo_Step5_1muonTLA [Alg] [n= 0]
TriggerSummaryStep5 [Alg] [n= 0]
Step6_filter [Seq] [Concurrent] [OR]
FStep6_merged1_PEBInfoWriter_PhysicsTLA [Alg] [n= 0]
Step6_reco [Seq] [Concurrent] [OR]
Step6_merged1_PEBInfoWriter_PhysicsTLA [Seq] [Sequential] [Prompt]
FStep6_merged1_PEBInfoWriter_PhysicsTLA [Alg] [n= 0]
Step6_merged1_PEBInfoWriter_PhysicsTLA_view [Seq] [Sequential] [Prompt]
Step6_merged1_PEBInfoWriter_PhysicsTLA_reco [Seq] [Concurrent] [OR]
pebSequence_PhysicsTLA [Seq] [Sequential] [Prompt]
IMpeb_PhysicsTLA [Alg] [n= 0]
PEBInfoWriterAlg_PhysicsTLA [Alg] [n= 0]
ComboHypo_Step6_merged1_PEBInfoWriter_PhysicsTLA [Alg] [n= 0]
TriggerSummaryStep6 [Alg] [n= 0]
```
The target is to collect the selected muons in the new EDM collection: HLT_Muons_RoI_TLA
tagging @mmontell, @tamartin , @rbielskiFrancesca PastoreFrancesca Pastorehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47661Support multiple indexes2021-10-28T15:43:37+02:00Carlo Varnicarlo.varni@cern.chSupport multiple indexesTagging @pagessinTagging @pagessinhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47704fix file renaming2021-10-28T15:44:51+02:00Christian Sanderfix file renamingminor fix to not rename hist files, that are not producedminor fix to not rename hist files, that are not producedhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/47701BSOverlayFilter: lock ConfigFlags2021-10-28T15:44:26+02:00Frank WinklmeierBSOverlayFilter: lock ConfigFlagsLock `ConfigFlags` before configuring trigger.
Relates to ATLASSIM-5459.Lock `ConfigFlags` before configuring trigger.
Relates to ATLASSIM-5459.https://gitlab.cern.ch/atlas/athena/-/merge_requests/47700add REGTEST output to allow removal of trigger xAODCnv ATR-244372021-10-28T15:46:49+02:00Jiri Masikadd REGTEST output to allow removal of trigger xAODCnv ATR-24437add REGTEST output used in the trigger validationadd REGTEST output used in the trigger validation