athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-06-05T03:02:42+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/44030MET chains moved from LS2 to Physics_pp menu ATR-234972021-06-05T03:02:42+02:00Mario CampanelliMET chains moved from LS2 to Physics_pp menu ATR-23497HLT_xe65_cell_xe90_pfopufit_L1XE50
HLT_xe75_cell_xe65_tcpufit_xe90_trkmht_L1XE50
HLT_xe60_cell_xe95_pfsum_cssk_L1XE50
HLT_xe55_cell_xe70_tcpufit_xe90_pfsum_vssk_L1XE50
HLT_xe65_cell_xe105_mhtpufit_em_subjesgscIS_L1XE50
HLT_xe65_cell_xe10...HLT_xe65_cell_xe90_pfopufit_L1XE50
HLT_xe75_cell_xe65_tcpufit_xe90_trkmht_L1XE50
HLT_xe60_cell_xe95_pfsum_cssk_L1XE50
HLT_xe55_cell_xe70_tcpufit_xe90_pfsum_vssk_L1XE50
HLT_xe65_cell_xe105_mhtpufit_em_subjesgscIS_L1XE50
HLT_xe65_cell_xe100_mhtpufit_pf_subjesgscIS_L1XE50
HLT_xe55_cell_xe70_tcpufit_xe95_pfsum_cssk_L1XE50
HLT_xe65_cell_xe95_pfsum_vssk_L1XE50
have been moved from LS2 to Physics_pp menu, and the placeholders
HLT_xe65_cell_L1XE50
HLT_xe100_mht_L1XE50
HLT_xe100_tcpufit_L1XE50
HLT_xe100_trkmht_L1XE50
HLT_xe100_pfsum_L1XE50
have been removed from Physics_pphttps://gitlab.cern.ch/atlas/athena/-/merge_requests/44029Bug fix for ART test running new jet config from ESD2021-06-03T03:04:34+02:00Mark HodgkinsonBug fix for ART test running new jet config from ESDFix the path used to find the configuration file for the small R jet finding to take into account its new location.Fix the path used to find the configuration file for the small R jet finding to take into account its new location.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44027PyAnalysisUtils: Avoid a RecursiveRemove crash.2021-06-03T03:02:29+02:00Scott SnyderPyAnalysisUtils: Avoid a RecursiveRemove crash.Avoid a RecursiveRemove crash in draw_obj.Avoid a RecursiveRemove crash in draw_obj.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44026Primary prescale set2021-06-07T15:54:09+02:00Daniele ZanziPrimary prescale set- fix menu name in json file (ATR-20878)
- create prescale set from TMMT with only primaries, mostly for rate estimate in reprocessings (ATR-23380)- fix menu name in json file (ATR-20878)
- create prescale set from TMMT with only primaries, mostly for rate estimate in reprocessings (ATR-23380)https://gitlab.cern.ch/atlas/athena/-/merge_requests/44025Clean up isolation WPs in rel222021-06-30T08:40:44+02:00Yohei YamaguchiClean up isolation WPs in rel22This MR removes some obsolete/unavailable isolation WPs from IsolationSelectionTool.
## PLV WPs are temporally removed since PLV is not working yet
| particle | WP |
| ------ | ------ |
| muon | FixedCutLoosePLV |
| | PLVLoose |
| | P...This MR removes some obsolete/unavailable isolation WPs from IsolationSelectionTool.
## PLV WPs are temporally removed since PLV is not working yet
| particle | WP |
| ------ | ------ |
| muon | FixedCutLoosePLV |
| | PLVLoose |
| | PLVTight |
| electron | FixedCutLoosePLV |
| | PLVLoose |
| | PLVLoose_noLooseCone |
| | PLVTight |
| | PLVTight_noLooseCone |
## Gradient WPs are not supported
| particle | WP |
| ------ | ------ |
| electron | Gradient |
| | Gradient_exp |
| | GradientLoose |
## WPs using not recommended isolation variables are removed
| particle | WP |
| ------ | ------ |
| muon | FixedCutHighPtTrackOnly |
| electron | FixedCutTight |
| | FixedCutTightTrackOnly |
| | FixedCutLoose |
| | FCTight_FixedRad |
| | FCLoose_FixedRad |
| | FCTight |
| | FCLoose |
| | FixedCutPflowTight |
| | FixedCutPflowLoose |
| | TightTrackCone40 |
tagging @htorres and @fcardill
tagging @mvanadia , @gartoni , @jmaurer and @jpoveda as wellhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/44024[ATR-23191] Always import Combined slice so that topo ComboHypos can be confi...2021-06-03T03:03:13+02:00Teng Jian Khoo[ATR-23191] Always import Combined slice so that topo ComboHypos can be configuredThe Combined signature configuration is needed to add certain generic ComboHypos to chains in any signature. Consequently if we want to use these ComboHypos we need to activate the Combined signature.
Addresses ATR-23191, regarding fail...The Combined signature configuration is needed to add certain generic ComboHypos to chains in any signature. Consequently if we want to use these ComboHypos we need to activate the Combined signature.
Addresses ATR-23191, regarding failure of the tau slice tests on chains containing a deltaR ComboHypo.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44023Reduce verbosity of OutputStreamCfg2021-06-04T03:03:01+02:00Tadej Novaktadej.novak@cern.chReduce verbosity of OutputStreamCfgReduce verbosity of `OutputStreamCfg`. Running ~"full-unit-tests" to avoid broken test references.Reduce verbosity of `OutputStreamCfg`. Running ~"full-unit-tests" to avoid broken test references.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44022ATR-23160 - move XE to FSNOSEED2021-06-05T03:03:59+02:00Lidija ZivkovicATR-23160 - move XE to FSNOSEEDMET chains should be seeded from FSNOSEED rather than from XEMET chains should be seeded from FSNOSEED rather than from XEhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/44021Restoring Analysis<X> containers to DAOD_PHYSLITE in master2021-06-04T03:03:23+02:00James CatmoreRestoring Analysis<X> containers to DAOD_PHYSLITE in masterThis MR restores the following calibrated object types to
DAOD_PHYSLITE in master:
- AnalysisElectrons
- AnalysisPhotons
- AnalysisTauJets
- AnalysisMuons
- AnalysisJets
This is achieved largely by uncommenting previously commented bloc...This MR restores the following calibrated object types to
DAOD_PHYSLITE in master:
- AnalysisElectrons
- AnalysisPhotons
- AnalysisTauJets
- AnalysisMuons
- AnalysisJets
This is achieved largely by uncommenting previously commented blocks of code. The pile-up reweighting tool is run via a sequence set up by the `PileupAnalysisSequence.py`, rather than directly.
Numerous error messages of the type `12:36:14 PathResolver ERROR Use of an absolute file name: /cvmfs/atlas.cern.ch/repo/sw/database/GroupData/egammaMVACalib/offline/v7/MVACalib_electron.weights.root` are fixed through a change to the path handling of the calibration files in `egammaMVACalib.cxx`
Not addressed here:
- MET is currently still broken and commented out, this will be addressed in a separate MR once the issue is understood
- There is a clash with DAOD_PHYS when run in trains, described in ATLASG-1594. This problem is independent of the changes in this MR; to avoid confusion, this will be addressed in a separate MR once the issue is understoodhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/44020default L1Mu CondDbTag from v03 to v042021-06-02T03:04:42+02:00Masato Aokidefault L1Mu CondDbTag from v03 to v04Changing the default condition tag from OFLCOND-MC16-SDR-RUN2-03 to OFLCOND-MC16-SDR-RUN2-04 for L1Muon simulation. This may improve agreements between rerunLVL1 and online L1 muon performance (being discussed in ATR-23463). In particula...Changing the default condition tag from OFLCOND-MC16-SDR-RUN2-03 to OFLCOND-MC16-SDR-RUN2-04 for L1Muon simulation. This may improve agreements between rerunLVL1 and online L1 muon performance (being discussed in ATR-23463). In particular, this DB change affects the endcap region. No changes are expected for the barrel region.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44019removing tracktwoEF tau triggers chains2021-06-09T03:03:20+02:00Antonio De Mariaremoving tracktwoEF tau triggers chainsThis MR is meant to remove "tracktwoEF" tau trigger sequence from the master.
"tracktwoEF" was used throughout 2018 data-taking, but later it was superseded by "tracktwoMVA" trigger sequence (same as tracktwoEF selection but with MVA pt...This MR is meant to remove "tracktwoEF" tau trigger sequence from the master.
"tracktwoEF" was used throughout 2018 data-taking, but later it was superseded by "tracktwoMVA" trigger sequence (same as tracktwoEF selection but with MVA pt calibration).
"tracktwoEF" was meant to be used together with BDT TauID which has been superseded by the RNN TauID and it won't be retrained for Run3
Therefore we believe this trigger chain can be safely removed since it won't be used in Run3
Pinging @bernius, @aranzazu, @dzanzi, @khoo, @markowen, @iriu, @carquin and @martindl
If there is any reason to keep this chain in, please feel free to comment on this MR :)https://gitlab.cern.ch/atlas/athena/-/merge_requests/44018Fixed View name typo for TLA Photons in TriggerEDMRun3.py2021-06-02T03:03:52+02:00Marco MontellaFixed View name typo for TLA Photons in TriggerEDMRun3.pyThis merge request solves the minor typo in the EDM definition for the TLA Photon Container, as discussed in [[ATR-23447]](https://its.cern.ch/jira/browse/ATR-23447).
Tagging @okumura.This merge request solves the minor typo in the EDM definition for the TLA Photon Container, as discussed in [[ATR-23447]](https://its.cern.ch/jira/browse/ATR-23447).
Tagging @okumura.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44017L1 AFP menu2021-06-04T03:04:45+02:00Daniele ZanziL1 AFP menuImplementation of new L1 AFP menu (ATR-23476)Implementation of new L1 AFP menu (ATR-23476)https://gitlab.cern.ch/atlas/athena/-/merge_requests/44016TrigT1MuctpiPhase1: make simulation algorithm non-reentrant2021-06-04T03:04:48+02:00Frank WinklmeierTrigT1MuctpiPhase1: make simulation algorithm non-reentrantThe MuCTPI simulation is not actually thread-safe. Until this is fixed
(ATR-23540) revert the algorithm to be non-reentrant.The MuCTPI simulation is not actually thread-safe. Until this is fixed
(ATR-23540) revert the algorithm to be non-reentrant.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44015Fix DecayTimeFilter2021-06-02T03:04:17+02:00Andrii VerbytskyiFix DecayTimeFilterFix DecayTimeFilter for HEPMC3 branch.Fix DecayTimeFilter for HEPMC3 branch.https://gitlab.cern.ch/atlas/athena/-/merge_requests/44014Tracking : make some more methods not using 'this' static2021-06-02T03:04:01+02:00Christos Anastopouloschristos.anastopoulos@cern.chTracking : make some more methods not using 'this' staticTracking : make some more methods not using 'this' staticTracking : make some more methods not using 'this' statichttps://gitlab.cern.ch/atlas/athena/-/merge_requests/44013Add Sherpa ART tests2021-06-02T03:03:48+02:00Luzhan YueAdd Sherpa ART testshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/44012TrigInDetAnalysisUser: Adding of the LRT electron chains to the postprocessin...2021-06-02T03:02:45+02:00Eva Guillotoneva.guilloton@cern.chTrigInDetAnalysisUser: Adding of the LRT electron chains to the postprocessing stepsTrigInDetValidation: Adding of the precision tracking LRT electron chains to the Validation
Modification of the truth matching option in the test for LRT electron chains on StauStau samplesTrigInDetValidation: Adding of the precision tracking LRT electron chains to the Validation
Modification of the truth matching option in the test for LRT electron chains on StauStau samplesJulie KirkJulie Kirkhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/44011MdtDigitization - Use calibration tool by default2021-07-09T18:00:44+02:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMdtDigitization - Use calibration tool by defaultHi,
as discussed in ATLASRECTS-6203, a potential reason for the low MDT efficiencies in the run IV layout could be the usage of the default drift-time relations instead of the proper ones in the calibration database. From this MR on, we...Hi,
as discussed in ATLASRECTS-6203, a potential reason for the low MDT efficiencies in the run IV layout could be the usage of the default drift-time relations instead of the proper ones in the calibration database. From this MR on, we use the calibration tool by default and remove the property to switch it off optionally. These developments have been made by @nkoehler. They are his last ones before moving on to other tasks outside ATLAS. Marking the end of an era @minions:
![image](https://media.giphy.com/media/oW7fkm9V1sYEg/giphy.gif)
To continue the game philosopher of the day let me also mention: @goblirsc, @sroe, @npetters, @pgadow, @fsforza, @szambito, @sabidi, @gartoni, @mvanadia:
![image](/uploads/da005f12642ccee130fe9b9da2ef7b1f/image.png)https://gitlab.cern.ch/atlas/athena/-/merge_requests/44010Fix for ATLASRECTS-63832021-06-03T03:04:53+02:00William Axel LeightFix for ATLASRECTS-6383This expands a previous FPE fix to also veto attempts to extrapolate into the MS from the MS entrance if the pT is less than 500 MeV.
Closes ATLASRECTS-6383This expands a previous FPE fix to also veto attempts to extrapolate into the MS from the MS entrance if the pT is less than 500 MeV.
Closes ATLASRECTS-6383