athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-05-05T03:03:19+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/43180LArRawConditions: Remove references to LArMCSymTool.2021-05-05T03:03:19+02:00Scott SnyderLArRawConditions: Remove references to LArMCSymTool.Remove vestigial references to LArMCSymTool.
Also fix a typo in comments.Remove vestigial references to LArMCSymTool.
Also fix a typo in comments.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43187DerivationFrameworkEGamma cleanup /tidy after ATLASRECTS-61252021-05-05T03:02:57+02:00Christos Anastopouloschristos.anastopoulos@cern.chDerivationFrameworkEGamma cleanup /tidy after ATLASRECTS-6125DerivationFrameworkEGamma , use private Tools via new Gaudi style. format the code , std::abs and tidyDerivationFrameworkEGamma , use private Tools via new Gaudi style. format the code , std::abs and tidyhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43184Trig met mon update may20212021-05-05T03:02:49+02:00Kenji HamanoTrig met mon update may2021The names of monitoring chains and efficiency histograms updated.The names of monitoring chains and efficiency histograms updated.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43176MuonCnvToolInterfaces: Make RpcPadContByteStreamCnv const.2021-05-05T03:02:45+02:00Scott SnyderMuonCnvToolInterfaces: Make RpcPadContByteStreamCnv const.Use AthConstConverter.Use AthConstConverter.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42467Removed MuonTruthSummaryTool & MuonRecoValidationTool2021-05-04T21:48:58+02:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chRemoved MuonTruthSummaryTool & MuonRecoValidationToolHi,
as discussed in ATLASRECTS-6179, the `MuonTruthSummaryTool` and the `MuonRecoValidationTool` are obsolete and hence deleted in this MR.Hi,
as discussed in ATLASRECTS-6179, the `MuonTruthSummaryTool` and the `MuonRecoValidationTool` are obsolete and hence deleted in this MR.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41208Allow digitization of split strip sensors2021-05-04T18:08:32+02:00Nicholas StylesAllow digitization of split strip sensorsAdd functionality in ```StripDigitization``` for processing HITS in a scheme where a single simulated sensor will get split into multiple ```SiDetectorElements``` (one per row).
NB, the ```StripDigitization``` is currently not used by d...Add functionality in ```StripDigitization``` for processing HITS in a scheme where a single simulated sensor will get split into multiple ```SiDetectorElements``` (one per row).
NB, the ```StripDigitization``` is currently not used by default, and is envisaged to become the specialized package for ITk strip digitization, while ```SCT_Digitization``` will remain in use for the current detector.
FYI @hhaywardhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43118Merge 21.0.125 and 21.0.126 into 21.3 branch2021-05-04T16:16:56+02:00John Derek ChapmanMerge 21.0.125 and 21.0.126 into 21.3 branchThis is the list of merge requests that were included bewtween [release/21.0.125](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.125) and the previous release [release/21.0.124](https://gitlab.cern.ch/atlas/athena/tags/release/21....This is the list of merge requests that were included bewtween [release/21.0.125](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.125) and the previous release [release/21.0.124](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.124):
- !42930 : Reporting events which passed ISF_SimEventFilter for ReSim jobs (ATLASJT-417)
- !42865 : Add property to scale xtalk between middle and back layer of LArEM
- !42861 : Sweeping !42812 from 21.3 to 21.0.
- !42789 : egamma ART change from master to rel21
- !42474 : Sweeping !42384 from 21.2 to 21.0.
- !42530 : additional histograms for egamma ART
- !42307 : Add missing Charginos package to AthSimulation project
- !42294 : Apply ZeroLifetimePositioner to all neutral mesons with oscillations: B0, B0s, D0
- !42337 : Changes to propagate Pile-up xAOD::Truth information to HITS files
- !42172 : Adding LAr cell DQ plots to UPC stream
- !42332 : TCT: Increasing memory for AthenaMP tests and updating the comparison step
- !41970 : Fix test_Sim_FullG4_ZPrime_QuasiStable.sh in AthSimulation nightlies
- !42031 : Fix for ALFA_SimHitsTestTool (ATLASSIM-5034)
This is the list of merge requests that were included bewtween [release/21.0.126](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.126) and the previous release [release/21.0.125](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.125):
* !42991 : Reporting ReSim events to the jobReport (ATLASJT-417)
Link to the full diff between [release/21.0.126](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.126) and
[release/21.0.124](https://gitlab.cern.ch/atlas/athena/tags/release/21.0.124)
is available at https://gitlab.cern.ch/atlas/athena/compare/release/21.0.124...release/21.0.126https://gitlab.cern.ch/atlas/athena/-/merge_requests/42938jet hypo - use Pt rather than Et as a threshold variable.2021-05-04T15:46:17+02:00Peter Sherwoodjet hypo - use Pt rather than Et as a threshold variable.For the simple variable, the et thresholds have been switched variable has been
switched from et to pt.
For the dijet scenario, either 'et' or 'pt' may appear in the scenario string.
The HT scenario has not been changed. This will be c...For the simple variable, the et thresholds have been switched variable has been
switched from et to pt.
For the dijet scenario, either 'et' or 'pt' may appear in the scenario string.
The HT scenario has not been changed. This will be changed once othercurrently ongoing
work has been completed.
The fbdj scenarios remain with et cuts. pt cuts may be enabled later.
Small differences in the chain counts were observed.
Add support for pt cuts:
TrigHLTJetHypo/python/ConditionDefaults.py
python/FastReductionAlgToolFactory.py
TrigHLTJetHypo/src/PtConditionMT.cxx, h
TrigHLTJetHypo/src/TrigJetConditionConfig_pt.cxx, h
TrigHLTJetHypo/src/components/TrigHLTJetHypo_entries.cxx
allow pt cuts for the dijet scenario:
TrigHLTJetHypo/python/scenario_dijet.py
witch to using pt as a threshold variable for the simple scenario:
TrigHLTJetHypo/python/scenario_simple.py
update menu items:
HLTMenuConfig/python/HLTMenuConfig/Menu/LS2_v1.py
HLTMenuConfig/Menu/SignatureDicts.py
update Trigger Art reference files:
TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref
TriggerTest/share/ref_data_v1Dev_build.ref
ATR-19908
@jbossio @valentem @peterPeter SherwoodPeter Sherwoodhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43181MG2.9.3.atlas2021-05-04T03:06:17+02:00Ewelina Maria LobodzinskaMG2.9.3.atlasMG2.9.3.atlasMG2.9.3.atlashttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43156update to Pythia8.245p3.lhcb72021-05-04T03:06:12+02:00Ewelina Maria Lobodzinskaupdate to Pythia8.245p3.lhcb7update to Pythia8.245p3.lhcb7update to Pythia8.245p3.lhcb7https://gitlab.cern.ch/atlas/athena/-/merge_requests/43136Enable passthrough for BPHY42021-05-04T03:05:56+02:00Peter OnyisiEnable passthrough for BPHY4Changes needed to allow BPHY4 to run in passThrough modeChanges needed to allow BPHY4 to run in passThrough modehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43154TrkAlignGenTools new switch for the preprocessor track selection2021-05-04T03:05:22+02:00Salvador Marti I Garciasalvador.marti@cern.chTrkAlignGenTools new switch for the preprocessor track selectionTrkAlignGenTools new switch for the preprocessor track selection. Default is ON. But it can act on the input track collection and on the refitted tracks as wellTrkAlignGenTools new switch for the preprocessor track selection. Default is ON. But it can act on the input track collection and on the refitted tracks as wellhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43129Fix abspath error from PathResolver in Ringer ONNX init.2021-05-04T03:05:13+02:00Joao Victor Da Fonseca PintoFix abspath error from PathResolver in Ringer ONNX init.Fix the abs path problem in path resolver ONNX ringer init.Fix the abs path problem in path resolver ONNX ringer init.Joao Victor Da Fonseca PintoJoao Victor Da Fonseca Pintohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43120MTCalibPebConfig: Fix hackCA2Global and disable detector configuration2021-05-04T03:05:10+02:00Rafal Bielskirafal.bielski@cern.chMTCalibPebConfig: Fix hackCA2Global and disable detector configurationTwo small updates in `MTCalibPebConfig.py`:
* Make the CA2Global hack more general/flexible, fixes ATR-23353
* Disable detector geometry/cabling configuration irrelevant for this data flow framework test by disabling the `Trigger.do[ID...Two small updates in `MTCalibPebConfig.py`:
* Make the CA2Global hack more general/flexible, fixes ATR-23353
* Disable detector geometry/cabling configuration irrelevant for this data flow framework test by disabling the `Trigger.do[ID|Calo|Muon]` flags. Speeds up the test configuration.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43071Tau and Large R jet EDM for jFEX for the L1Calo Bitwise offline software simu...2021-05-04T03:05:06+02:00Sergi Rodriguez BoscaTau and Large R jet EDM for jFEX for the L1Calo Bitwise offline software simulationMerge Request for two EDMs for the L1Calo Bitwise Offline Simulation.
First EDM is for the Tau algorithm, and second is for the Large R Jet algorithm both for the jets FEX, jFEX.
New RoI files have been made in xAODTrigger and xAODAthena...Merge Request for two EDMs for the L1Calo Bitwise Offline Simulation.
First EDM is for the Tau algorithm, and second is for the Large R Jet algorithm both for the jets FEX, jFEX.
New RoI files have been made in xAODTrigger and xAODAthenaPool.
The EDMs are filled with TOBs in the TrigL1 L1CaloFEXSim inside the algorithm Driver, SysSim and Sim cxx files for jFEX.
@vasothilhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43117MuonPRDTest: Add TGC/CSC local and global position variables2021-05-04T03:05:02+02:00Minlin WuMuonPRDTest: Add TGC/CSC local and global position variablesAdd local position and global position variables to TGCDigitVariables, TGC/CSCRDOVariables scripts. The TgcReadoutElement.h was modified to avoid the inline warning.Add local position and global position variables to TGCDigitVariables, TGC/CSCRDOVariables scripts. The TgcReadoutElement.h was modified to avoid the inline warning.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43140ATLASRECTS-6125: TruthCaloShowerDecorator move to data handles2021-05-04T03:04:55+02:00Oleh KivernykATLASRECTS-6125: TruthCaloShowerDecorator move to data handlesMigration of TruthCaloShowerDecorator tool to data Handles.Migration of TruthCaloShowerDecorator tool to data Handles.Oleh KivernykOleh Kivernykhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43142tauRecTools: fix severe bug with neutral PFOs in tau substructure reconstruction2021-05-04T03:04:44+02:00Bertrand Martin Dit LatourtauRecTools: fix severe bug with neutral PFOs in tau substructure reconstructionHello,
This MR is fixing a very problematic behaviour with neutral PFOs in the tau substructure reconstruction.
When we process a tau, we check if there are EM clusters within 0.4 of the tau and if so, we create new neutral PFOs that we...Hello,
This MR is fixing a very problematic behaviour with neutral PFOs in the tau substructure reconstruction.
When we process a tau, we check if there are EM clusters within 0.4 of the tau and if so, we create new neutral PFOs that we push to the neutral PFO container (1 neutral PFO per EM cluster).
However, when we run the substructure reconstruction for the current tau, we loop over all the PFOs from the neutral PFO container, which means we also pick up the PFOs from previous taus in the event, not only those of the current tau.
And... we overwrite the properties of all PFOs (which are non-const)...
Fortunately, for the tau itself, it is mostly OK, because the PFOs of the current tau are ~properly computed.
So the tau variables (including those depending on the substructure reconstruction output) are mostly OK at reconstruction time.
However, the PFOs we store in xAODs are nonsense, as all the PFOs in an event are last altered by the last tau of the event.
Also, there can be very weird situations (fortunately not too frequent) where duplicate PFOs are created, in case an EM cluster is shared by 2 taus, and in this case, the tau reconstruction itself is affected.
Adding the 'urgent' flag, as we'd really need to have this merged in the release that will be used for Round2 MC preproduction expected imminently.
Cheers,
Bertrandhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/43166L1Decoder: Fix uninitialised data handle2021-05-04T03:04:37+02:00Rafal Bielskirafal.bielski@cern.chL1Decoder: Fix uninitialised data handleOne-line change, fix an uninitialised handle missed in !42899. Closes ATR-23369.One-line change, fix an uninitialised handle missed in !42899. Closes ATR-23369.https://gitlab.cern.ch/atlas/athena/-/merge_requests/43125another update of trigger matching code in TgcRawDataMonitoring2021-05-04T03:04:23+02:00Masato Aokianother update of trigger matching code in TgcRawDataMonitoringThis is to try fixing crashes in ATLASRECTS-6215. (Hope this would improve the situation...)
Also, fixing a memory leak in ATLASRECTS-6292.This is to try fixing crashes in ATLASRECTS-6215. (Hope this would improve the situation...)
Also, fixing a memory leak in ATLASRECTS-6292.