athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2022-01-06T21:42:38+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/48768Make changes to compile against ACTS v15.0.02022-01-06T21:42:38+01:00Paul Gessinger-BefurtMake changes to compile against ACTS v15.0.0/cc @corentin @cvarni @lfaldaul/cc @corentin @cvarni @lfaldaulhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/48769FastChainPileup: add trigger to test_fastchain_fatras_mc16a_ttbar.sh2021-12-06T15:42:57+01:00Liza MijovicFastChainPileup: add trigger to test_fastchain_fatras_mc16a_ttbar.sh- Test_fastchain_fatras_mc16a_ttbar Reco_tf ran without trigger. This is suboptimal, as we want to have the trigger tested as well.
- This MR adds flags to the tests to enable trigger running, thanks to Tim Martin's recommendations in [...- Test_fastchain_fatras_mc16a_ttbar Reco_tf ran without trigger. This is suboptimal, as we want to have the trigger tested as well.
- This MR adds flags to the tests to enable trigger running, thanks to Tim Martin's recommendations in [ATLASSIM-5523](https://its.cern.ch/jira/browse/ATLASSIM-5523), and closes [ATLASSIM-5523](https://its.cern.ch/jira/browse/ATLASSIM-5523)
- local test logs: /afs/cern.ch/work/l/lmijovic/public/sim/jira/ATLASSIM-5523_Nov2021/RAWtoESD_no_BCMrdo/art_fix_logs_allMThttps://gitlab.cern.ch/atlas/athena/-/merge_requests/48770TrigMatching - Try to reenable it2021-12-03T21:41:58+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chTrigMatching - Try to reenable itTagging: @dcieri, @tamartin, @mvanadia, @sabidi, @goblirscTagging: @dcieri, @tamartin, @mvanadia, @sabidi, @goblirschttps://gitlab.cern.ch/atlas/athena/-/merge_requests/48771Use NSW Veto Mode switch for NSW emulator which runs on Run2 data2021-12-03T21:43:24+01:00Masato AokiUse NSW Veto Mode switch for NSW emulator which runs on Run2 dataThis is to introduce the NSW Veto Mode switch into the NSW emulator which runs on Run2 data. With this option=False we will see what the trigger rate is during the NSW commissioning period (i.e. when the NSW-TGC coincidence is not activa...This is to introduce the NSW Veto Mode switch into the NSW emulator which runs on Run2 data. With this option=False we will see what the trigger rate is during the NSW commissioning period (i.e. when the NSW-TGC coincidence is not activated).https://gitlab.cern.ch/atlas/athena/-/merge_requests/48772egamma minor clang-tidy related fixes2021-12-05T21:42:16+01:00Christos Anastopouloschristos.anastopoulos@cern.chegamma minor clang-tidy related fixesegamma minor clang-tidy related fixesegamma minor clang-tidy related fixeshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/48773Remove un-needed protection causing a cppcheck warning2021-12-03T21:43:56+01:00Christos Anastopouloschristos.anastopoulos@cern.chRemove un-needed protection causing a cppcheck warningRemove un-needed protection causing a cppcheck warningRemove un-needed protection causing a cppcheck warninghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/48774Fixed SuperCluster collection names2021-12-03T21:43:14+01:00Fernando MonticelliFixed SuperCluster collection namesThis is related to ATR-22529.
Setting up EgammaSuperCluster collection names in TrigElectron and TrigPhoton super cluster builders and also the output Photon and Electron SuperCluster names. All set via TrigEgammaKeys.
None of these co...This is related to ATR-22529.
Setting up EgammaSuperCluster collection names in TrigElectron and TrigPhoton super cluster builders and also the output Photon and Electron SuperCluster names. All set via TrigEgammaKeys.
None of these collections are saved in xAODs so no change at all expected in the result.
Pinging @cjmeyer @jodafons @dbakshig and @christoshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/48775EMExtrapolationTool rm unused arguments2021-12-03T21:43:11+01:00Christos Anastopouloschristos.anastopoulos@cern.chEMExtrapolationTool rm unused argumentsEMExtrapolationTool rm unused argumentsEMExtrapolationTool rm unused argumentshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/48776AnalysisTop: Support for heavy ion electron scale factors2021-12-06T08:47:43+01:00Marcel NiemeyerAnalysisTop: Support for heavy ion electron scale factorsE/gamma has released electron SFs for heavy ion collisions. Related JIRA: ANALYSISTO-1157
This change consists of two minor modifications for the case that the flag `UseHItoolsConfiguration` is set to `True` in the cut file. First, it w...E/gamma has released electron SFs for heavy ion collisions. Related JIRA: ANALYSISTO-1157
This change consists of two minor modifications for the case that the flag `UseHItoolsConfiguration` is set to `True` in the cut file. First, it will choose a different SF map. Second, the trigger is set to the trigger requested by the analysers in the ticket (`2016_e15_lhloose_nod0`).https://gitlab.cern.ch/atlas/athena/-/merge_requests/48777Egamma should not be neededing the cache produced by CaloExtensionBuilderAlg2021-12-03T21:43:54+01:00Christos Anastopouloschristos.anastopoulos@cern.chEgamma should not be neededing the cache produced by CaloExtensionBuilderAlgEgamma should not be neededing the cache produced by CaloExtensionBuilderAlg
This cache should be needed by Tau and PFO.
ping @jdevivi , @turraEgamma should not be neededing the cache produced by CaloExtensionBuilderAlg
This cache should be needed by Tau and PFO.
ping @jdevivi , @turrahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/48778TrackingVolumeArrayCreator use prefix and format consistently2021-12-05T21:43:51+01:00Christos Anastopouloschristos.anastopoulos@cern.chTrackingVolumeArrayCreator use prefix and format consistentlyTrackingVolumeArrayCreator use prefix and format consistentlyTrackingVolumeArrayCreator use prefix and format consistentlyhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/48779add trigger test with feature counts for heavy ion2021-12-10T18:28:01+01:00Ran Biadd trigger test with feature counts for heavy ionadd trigger test (RDO > RDO_Trig) for heavy ion menu, with reference counts. runs successfully on an earlier nightly release, but failing on the latest release because of ATR-24673. @qhu @jkremer @mrybaradd trigger test (RDO > RDO_Trig) for heavy ion menu, with reference counts. runs successfully on an earlier nightly release, but failing on the latest release because of ATR-24673. @qhu @jkremer @mrybarhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/48780PhysicsAnalysisEgamma Move ATLAS_CHECK_THREAD_SAFETY to header folders2021-12-03T21:43:47+01:00Christos Anastopouloschristos.anastopoulos@cern.chPhysicsAnalysisEgamma Move ATLAS_CHECK_THREAD_SAFETY to header foldersPhysicsAnalysisEgamma Move ATLAS_CHECK_THREAD_SAFETY to header foldersPhysicsAnalysisEgamma Move ATLAS_CHECK_THREAD_SAFETY to header foldershttps://gitlab.cern.ch/atlas/athena/-/merge_requests/48781Remove header that should not be in use anymore2021-12-03T21:43:32+01:00Christos Anastopouloschristos.anastopoulos@cern.chRemove header that should not be in use anymoreRemove header that should not be in use anymoreRemove header that should not be in use anymorehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/48782Bumped release version to 22.0.502021-12-03T12:51:43+01:00Vakhtang TsulaiaBumped release version to 22.0.50Affected projects:
* AthDataQuality
* AthSimulation
* Athena
* DetCommon
* VP1LightAffected projects:
* AthDataQuality
* AthSimulation
* Athena
* DetCommon
* VP1Lighthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/48783AFP_Geometry: Fix clang warnings.2021-12-03T21:42:10+01:00Scott SnyderAFP_Geometry: Fix clang warnings.Unused variables.Unused variables.https://gitlab.cern.ch/atlas/athena/-/merge_requests/48784Fixes in IsInInputFile and MetaReaderPeeker2021-12-07T15:43:29+01:00Vakhtang TsulaiaFixes in IsInInputFile and MetaReaderPeeker1. `IsInInputFile`. Add graceful handling for non-existing input files
2. `MetaReaderPeeker`. Get input file names from `ConfigFlags`.
In case `ConfigFlags.Input.Files` has not been set, then fall back to the
legacy configuration mechanisms1. `IsInInputFile`. Add graceful handling for non-existing input files
2. `MetaReaderPeeker`. Get input file names from `ConfigFlags`.
In case `ConfigFlags.Input.Files` has not been set, then fall back to the
legacy configuration mechanismshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/48785BeamHaloGenerator: Fix cppcheck warnings.2021-12-07T15:42:24+01:00Scott SnyderBeamHaloGenerator: Fix cppcheck warnings.Fix cppcheck warnings.Fix cppcheck warnings.https://gitlab.cern.ch/atlas/athena/-/merge_requests/48786PATCore: Fix cppcheck warnings.2021-12-03T21:42:30+01:00Scott SnyderPATCore: Fix cppcheck warnings.Use range-for.Use range-for.https://gitlab.cern.ch/atlas/athena/-/merge_requests/48787sTGC_Digitization+MuonFastDigitization+MDT_Digitization: Remove reference to ...2021-12-03T21:44:05+01:00Scott SnydersTGC_Digitization+MuonFastDigitization+MDT_Digitization: Remove reference to IAtRndmGenSvc.Remove (unused) references to deprecated IAtRndmGenSvc.Remove (unused) references to deprecated IAtRndmGenSvc.