athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-02-16T03:05:31+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/40660MuidCaloEnergyTools Add ATLAS_CHECK_THREAD_SAFETY..2021-02-16T03:05:31+01:00Christos Anastopouloschristos.anastopoulos@cern.chMuidCaloEnergyTools Add ATLAS_CHECK_THREAD_SAFETY..MuidCaloEnergyTools Add ATLAS_CHECK_THREAD_SAFETY.
Format tables and make then constexpr where applicable.
use std::abs.
Use nullptrMuidCaloEnergyTools Add ATLAS_CHECK_THREAD_SAFETY.
Format tables and make then constexpr where applicable.
use std::abs.
Use nullptrhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/40529Fix const correctness in codes related to HepMC (small MR)2021-02-16T03:05:24+01:00Andrii VerbytskyiFix const correctness in codes related to HepMC (small MR)Fix const correctness in codes related to HepMC.
The changes will reduce the number of warnings in the nightlies by ~10.Fix const correctness in codes related to HepMC.
The changes will reduce the number of warnings in the nightlies by ~10.https://gitlab.cern.ch/atlas/athena/-/merge_requests/40658Sel.isolation selection 202102142021-02-16T03:05:20+01:00Scott SnyderSel.isolation selection 20210214https://gitlab.cern.ch/atlas/athena/-/merge_requests/40680correct old and add new ART tests2021-02-16T03:05:13+01:00Ewelina Maria Lobodzinskacorrect old and add new ART testscorrect old and add new local ART testscorrect old and add new local ART testshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/40666egamma ART: fix missing WPs ATLASRECTS-60282021-02-16T03:05:12+01:00Daniela Kuchleregamma ART: fix missing WPs ATLASRECTS-6028After !38439, isolation WPs for electrons did not exist. Remove accessing those in ART and remove all corresponding plots.After !38439, isolation WPs for electrons did not exist. Remove accessing those in ART and remove all corresponding plots.https://gitlab.cern.ch/atlas/athena/-/merge_requests/40583add primary flag in TMMT and flattens group lists (ATR-22819)2021-02-16T03:05:07+01:00Daniele Zanziadd primary flag in TMMT and flattens group lists (ATR-22819)https://gitlab.cern.ch/atlas/athena/-/merge_requests/40645tauRecTools: support RNN ID for 2p taus2021-02-16T03:04:11+01:00Bertrand Martin Dit LatourtauRecTools: support RNN ID for 2p tausHello,
This MR adds support for a dedicated 2p RNN ID network, as we are developing one for R22 (ATLTAU-1766, ATLTAU-1729).
So far we had networks for 1p, 3p (applied to >=2 prong), and 0p (trigger only).
The 0p and 2p networks are made...Hello,
This MR adds support for a dedicated 2p RNN ID network, as we are developing one for R22 (ATLTAU-1766, ATLTAU-1729).
So far we had networks for 1p, 3p (applied to >=2 prong), and 0p (trigger only).
The 0p and 2p networks are made optional, but the 1p and 3p are now mandatory (ERROR + FAILURE if not properly initialised).
I have verified that if no 2p network is given to the TauJetRNNEvaluator tool, the reconstruction output is unchanged.
Also, if we give the same network for 2p and 3p, the reconstruction output is unchanged, as expected.
To come: add support for efficiency flattening and working point calculation for 2p taus.
Cheers,
Bertrandhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/40646tauRecTools: add tau ID working points for 2-prong2021-02-16T03:03:54+01:00Bertrand Martin Dit LatourtauRecTools: add tau ID working points for 2-prongHello,
Support for a dedicated 2-prong tau ID network was just implemented in !40645 (ATLTAU-1766, ATLTAU-1729).
This MR is implementing the corresponding working points calculation.
I have checked that this MR does not change the recon...Hello,
Support for a dedicated 2-prong tau ID network was just implemented in !40645 (ATLTAU-1766, ATLTAU-1729).
This MR is implementing the corresponding working points calculation.
I have checked that this MR does not change the reconstruction output in the following cases: no calibration file used for 2p taus, or same calibration file used for 2p and 3p taus. As expected.
Cheers, Bertrandhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/40656DerivationFrameworkSUSY+DerivationFrameworkJetEtMiss+DerivationFrameworkMCTru...2021-02-16T03:03:52+01:00Scott SnyderDerivationFrameworkSUSY+DerivationFrameworkJetEtMiss+DerivationFrameworkMCTruth: Fix clang warnings.Don't use references in a range-for if the object must be copied.Don't use references in a range-for if the object must be copied.https://gitlab.cern.ch/atlas/athena/-/merge_requests/4067822.0-unique_ptr-MuidTrackBuilder2021-02-16T03:03:49+01:00Shaun Roe22.0-unique_ptr-MuidTrackBuilderWork undertaken in context of ATLASRECTS-5967, items 6 and 7, to propagate usage of unique_ptr for TrackParemeters.
Small cleanup of include headers there also.Work undertaken in context of ATLASRECTS-5967, items 6 and 7, to propagate usage of unique_ptr for TrackParemeters.
Small cleanup of include headers there also.https://gitlab.cern.ch/atlas/athena/-/merge_requests/40655Remove explicit Eigen usage from muon packages2021-02-16T03:03:48+01:00Nicolas KoehlerRemove explicit Eigen usage from muon packagesHi,
this MR removes the explicit includes of Eigen from muon packages where the Eigen functionality is used via e.g. `GeoPrimitives` indirectly. But no `find_package(Eigen)` is required for that.
Best, NicoHi,
this MR removes the explicit includes of Eigen from muon packages where the Eigen functionality is used via e.g. `GeoPrimitives` indirectly. But no `find_package(Eigen)` is required for that.
Best, Nicohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/40651ISF_PunchThroughTools: Fix clang warning.2021-02-16T03:03:36+01:00Scott SnyderISF_PunchThroughTools: Fix clang warning.clang doesn't allow using math functions in constexpr expressions.clang doesn't allow using math functions in constexpr expressions.https://gitlab.cern.ch/atlas/athena/-/merge_requests/40621Add protection for debug statement in MuonTrackExtrapolationTool2021-02-16T03:03:34+01:00Savanna ShawAdd protection for debug statement in MuonTrackExtrapolationToolMoving a debug statement for the 'secondPergiee' slightly so it only gets orinted if the perigee actually exists.Moving a debug statement for the 'secondPergiee' slightly so it only gets orinted if the perigee actually exists.https://gitlab.cern.ch/atlas/athena/-/merge_requests/40591Configure CaloOffsetCorrection in newJO test2021-02-16T03:03:30+01:00Tomasz BoldConfigure CaloOffsetCorrection in newJO testThis MR adds BCID calo offset correction to the new JO HLT test.
It is leveraging from earlier MR: !40415
The exact setting of all the components may not be identical to our mainline but as of now this serves as an example for HLT devel...This MR adds BCID calo offset correction to the new JO HLT test.
It is leveraging from earlier MR: !40415
The exact setting of all the components may not be identical to our mainline but as of now this serves as an example for HLT developers on how to create CA that inserts algorithms in designated (here HLTBeginSeq) sequence and at the same time in HLT CF controlled by the menu.
Taggin @damazio for info.https://gitlab.cern.ch/atlas/athena/-/merge_requests/40650TrigDecisionEventTPCnv+TrigMuonEventTPCnv+TrigParticleTPCnv+TrigSteeringEvent...2021-02-16T03:03:12+01:00Scott SnyderTrigDecisionEventTPCnv+TrigMuonEventTPCnv+TrigParticleTPCnv+TrigSteeringEventTPCnv: Tweak leak-checking for gcc10.Need to call currentContext() before starting leakcheck.Need to call currentContext() before starting leakcheck.https://gitlab.cern.ch/atlas/athena/-/merge_requests/40643tauRec: add art-athena-mt option to MT test2021-02-16T03:03:08+01:00Bertrand Martin Dit LatourtauRec: add art-athena-mt option to MT testHello,
This is a follow up of !40577 where the q221 test was migrated from serial to MT.
But aparently we are missing an art-athena-mt option to book multiple cores.
Cheers,
BertrandHello,
This is a follow up of !40577 where the q221 test was migrated from serial to MT.
But aparently we are missing an art-athena-mt option to book multiple cores.
Cheers,
Bertrandhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/40647Cleanup muon includes following IWYU (1)2021-02-16T03:03:05+01:00Nicolas KoehlerCleanup muon includes following IWYU (1)Hi,
this MR is the result of applying 'include-what-you-use' to `MuonGeoModel` and `MuonReadoutGeometry`.
Best, NicoHi,
this MR is the result of applying 'include-what-you-use' to `MuonGeoModel` and `MuonReadoutGeometry`.
Best, Nicohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/40635Add a test with the new muIso performance chains2021-02-16T03:03:00+01:00Mark SuttonAdd a test with the new muIso performance chainsPreviously we were monitoring selecting ivarmedium chains, as not muIso performance chain
was available.
We have a the ivarperf chain now, added by Savanna, which run the same as the ivarmedium
chain, but runs the final hypo in passthro...Previously we were monitoring selecting ivarmedium chains, as not muIso performance chain
was available.
We have a the ivarperf chain now, added by Savanna, which run the same as the ivarmedium
chain, but runs the final hypo in passthrough.https://gitlab.cern.ch/atlas/athena/-/merge_requests/40652Epos_i: Fix ubsan warnings.2021-02-16T03:02:58+01:00Scott SnyderEpos_i: Fix ubsan warnings.We were getting ubsan warnings because the Epos_i class is too large.
Fix by changing the very large arrays to vectors.We were getting ubsan warnings because the Epos_i class is too large.
Fix by changing the very large arrays to vectors.https://gitlab.cern.ch/atlas/athena/-/merge_requests/40490Add InvariantMassDeltaPhiInclusive2Charge to L1TopoAlgorithms2021-02-16T03:02:48+01:00Paula Martinez SuarezAdd InvariantMassDeltaPhiInclusive2Charge to L1TopoAlgorithmsCreate a new L1Topo algorithm based on [ATR-19639](https://its.cern.ch/jira/browse/ATR-19639) using L1Muon flags ([ATR-22574](https://its.cern.ch/jira/browse/ATR-22574)), following the requirement in [ATR-19593](https://its.cern.ch/jira/...Create a new L1Topo algorithm based on [ATR-19639](https://its.cern.ch/jira/browse/ATR-19639) using L1Muon flags ([ATR-22574](https://its.cern.ch/jira/browse/ATR-22574)), following the requirement in [ATR-19593](https://its.cern.ch/jira/browse/ATR-19593).
@orlando @iriu @asonay @cmorenom @masato