athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-04-23T03:05:09+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/42836removed optional argument from -AthConfigFlags- constructor2021-04-23T03:05:09+02:00Kacper Wojciech Topolnickiremoved optional argument from -AthConfigFlags- constructorNo invocations of the -AthConfigFlags- constructor that use the
optional -inputflags- argument were found outside of
-Control/AthenaConfiguration-. Using this argument without -deepcopy-
might be problematic. Two methods
from the -AthCon...No invocations of the -AthConfigFlags- constructor that use the
optional -inputflags- argument were found outside of
-Control/AthenaConfiguration-. Using this argument without -deepcopy-
might be problematic. Two methods
from the -AthConfigFlags- class that used this argument
were modified appropriately.
Tests performed:
Test project /afs/cern.ch/user/k/ktopolni/private/git_tutorial_15_03_2020/build
Start 1: AthenaConfiguration_AthConfigFlagsTest_ctest
Start 2: AthenaConfiguration_MainServicesConfig_ctest
Start 3: AthenaConfiguration_ComponentAccumulatorTest_ctest
1/11 Test #1: AthenaConfiguration_AthConfigFlagsTest_ctest ............. Passed 1.01 sec
Start 4: AthenaConfiguration_AllConfigFlagsTest_EVNT_test_ctest
2/11 Test #2: AthenaConfiguration_MainServicesConfig_ctest ............. Passed 1.83 sec
Start 5: AthenaConfiguration_DetectorConfigFlags_test_ctest
3/11 Test #3: AthenaConfiguration_ComponentAccumulatorTest_ctest ....... Passed 3.07 sec
Start 6: AthenaConfiguration_AllConfigFlagsTest_HITS_test_ctest
4/11 Test #5: AthenaConfiguration_DetectorConfigFlags_test_ctest ....... Passed 1.80 sec
Start 7: AthenaConfiguration_AllConfigFlagsTest_RDO_test_ctest
5/11 Test #4: AthenaConfiguration_AllConfigFlagsTest_EVNT_test_ctest ... Passed 11.68 sec
Start 8: AthenaConfiguration_AllConfigFlagsTest_ctest
6/11 Test #6: AthenaConfiguration_AllConfigFlagsTest_HITS_test_ctest ... Passed 9.79 sec
Start 9: AthenaConfiguration_ComponentAccumulatorTestReco_ctest
7/11 Test #9: AthenaConfiguration_ComponentAccumulatorTestReco_ctest ... Passed 1.34 sec
Start 10: TrigInDetConfig_trigInDetFastTrackingCfg_ctest
8/11 Test #10: TrigInDetConfig_trigInDetFastTrackingCfg_ctest ........... Passed 9.01 sec
Start 11: TrigInDetConfig_TrigTrackingCutFlags_ctest
9/11 Test #11: TrigInDetConfig_TrigTrackingCutFlags_ctest ............... Passed 1.18 sec
10/11 Test #7: AthenaConfiguration_AllConfigFlagsTest_RDO_test_ctest .... Passed 25.95 sec
11/11 Test #8: AthenaConfiguration_AllConfigFlagsTest_ctest ............. Passed 71.81 sec
100% tests passed, 0 tests failed out of 11
@tbold @rbielski ATR-23200
https://its.cern.ch/jira/browse/ATR-23200https://gitlab.cern.ch/atlas/athena/-/merge_requests/42835Improve Pythia8B and Add Lifetime Cut2021-04-24T03:06:54+02:00Adam Edward BartonImprove Pythia8B and Add Lifetime Cut@tursom In this MR are some optimizations for pythia8B and also a segment of code for some upcoming new job options.
Can you see if you have any objections to this way of cutting on the lifetime, or is there a better way?@tursom In this MR are some optimizations for pythia8B and also a segment of code for some upcoming new job options.
Can you see if you have any objections to this way of cutting on the lifetime, or is there a better way?https://gitlab.cern.ch/atlas/athena/-/merge_requests/42834RecExRecoTest: Fix syntax error in test_recexreco_art_q431_compareMultipleThr...2021-04-23T03:05:30+02:00Alaettin Serhan MeteRecExRecoTest: Fix syntax error in test_recexreco_art_q431_compareMultipleThreads.shThis MR fixes the missing `"` in `test_recexreco_art_q431_compareMultipleThreads.sh`.
cc: @mhodgkinThis MR fixes the missing `"` in `test_recexreco_art_q431_compareMultipleThreads.sh`.
cc: @mhodgkinhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42833new b-jet trigger calibration chains2021-04-29T03:05:21+02:00Chris Pollardnew b-jet trigger calibration chainsI've added a few chains (as well as the MuonBjet and EgammaBJet groups) in preparation for the calibration of the b-jet trigger efficiency.I've added a few chains (as well as the MuonBjet and EgammaBJet groups) in preparation for the calibration of the b-jet trigger efficiency.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42832Fixed handle conditional initialisation2021-04-23T03:04:17+02:00Benjamin Michael WynneFixed handle conditional initialisationHandles should always be initialised: if they are not used, initialise with false as an argument.Handles should always be initialised: if they are not used, initialise with false as an argument.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42831Use same RoIs for L2 and EF combined muons2021-04-24T03:03:51+02:00Savanna ShawUse same RoIs for L2 and EF combined muonsAs pointed out in ATR-23252, it would be better to use the same RoIs for the fast and precision tracking and combined muon building steps. To do this, have added a link to the RoI in the L2 combined muon hypo alg, and switched the EF com...As pointed out in ATR-23252, it would be better to use the same RoIs for the fast and precision tracking and combined muon building steps. To do this, have added a link to the RoI in the L2 combined muon hypo alg, and switched the EF combined muon input maker to use the NamedRoITool instead of just fetching the RoI from the previous step (the EF SA muon rois from the previous step are similar but not quite identical to the combined muon RoIs). Also update the ID track monitoring to accordingly get the RoIs for the precision tracks.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42830IDPerfMonZmumu compute sigma_pt2021-04-23T03:04:51+02:00Salvador Marti I Garciasalvador.marti@cern.chIDPerfMonZmumu compute sigma_ptIn the IDPerfMonZmumu package the sigma_pt is computed from the sigma_qOverP, sigma_theta and the correlation between q/P and thetaIn the IDPerfMonZmumu package the sigma_pt is computed from the sigma_qOverP, sigma_theta and the correlation between q/P and thetahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42829Changing base IONNXRuntimeSvc from IService to ASGService2021-08-25T03:03:44+02:00Debottam Bakshi GuptaChanging base IONNXRuntimeSvc from IService to ASGServiceChanging the base class of IONNXRuntimeSvc from IService to IAsgService. Adding @krumnack , @sschramm , @afarbin , @jraine so onnxruntime can be used in analysisbase.Changing the base class of IONNXRuntimeSvc from IService to IAsgService. Adding @krumnack , @sschramm , @afarbin , @jraine so onnxruntime can be used in analysisbase.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42828AssociationBuilder: delete obsolete DAOD making packages2021-04-23T03:06:27+02:00Frank WinklmeierAssociationBuilder: delete obsolete DAOD making packagesDelete the obsolete `AssociationKernel` and `AssociationComps` packages that have zero references in `git`. Jira only has [related recent tickets](https://its.cern.ch/jira/issues/?jql=text%20~%20AssociationBuilder%20ORDER%20BY%20updated%...Delete the obsolete `AssociationKernel` and `AssociationComps` packages that have zero references in `git`. Jira only has [related recent tickets](https://its.cern.ch/jira/issues/?jql=text%20~%20AssociationBuilder%20ORDER%20BY%20updated%20DESC) that mention problems with these packages and the only mention in the TWiki to these 15-year old packages is in retired software tutorials on [DAOD making](https://twiki.cern.ch/twiki/bin/view/AtlasComputing/SoftwareTutorialDAODMaking#Matching_or_overlap_flagging).
cc a few experts who may object in case they are still useful: @krumnack @akraszna @lheinric @jcatmore
P.S.: I came across these packages when trying to cleanup some of the trigger matching code.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42827Create the Trig Egamma Fast Reconstruction package2021-04-26T06:44:21+02:00Joao Victor Da Fonseca PintoCreate the Trig Egamma Fast Reconstruction packageHarmonisation and fix trigger e/g code;
- Migrate fast electron and photon fex algos to reentrant Athena algorithm;
- Transfer all FEX algos (electron and photon) from e/g hypo to e/g fast reco package (make more sense);
**NOTE** This ...Harmonisation and fix trigger e/g code;
- Migrate fast electron and photon fex algos to reentrant Athena algorithm;
- Transfer all FEX algos (electron and photon) from e/g hypo to e/g fast reco package (make more sense);
**NOTE** This MR must be in ASAP
Ping: @cjmeyer, @dbakshig, @fernando, @mverissi @jlieberm and @eegidiopJoao Victor Da Fonseca PintoJoao Victor Da Fonseca Pintohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42826AsgComponentConfig dictionary fix2021-04-23T03:05:58+02:00Nils Erik KrumnackAsgComponentConfig dictionary fixI thought the last update (!42628) would completely fix using the EventLoop python configuration on the grid, but it did not. This should fix things. I also updated one of the CP algorithm unit tests, so that it should (hopefully) catc...I thought the last update (!42628) would completely fix using the EventLoop python configuration on the grid, but it did not. This should fix things. I also updated one of the CP algorithm unit tests, so that it should (hopefully) catch these kind of problems in the future.
Marking this as ~urgent, as I really want this in before the weekend, preferably before Friday.
cc @khamanohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42825AthContainers+AthContainersInterfaces+PyDumper: Split off ConstAuxElement fro...2021-04-24T03:04:21+02:00Scott SnyderAthContainers+AthContainersInterfaces+PyDumper: Split off ConstAuxElement from AuxElement.Split off ConstAuxElement from AuxElement, making it a base.
Refactoring to allow iterating using AuxElement instances directly
(without going though the pointers).Split off ConstAuxElement from AuxElement, making it a base.
Refactoring to allow iterating using AuxElement instances directly
(without going though the pointers).https://gitlab.cern.ch/atlas/athena/-/merge_requests/42824Sweeping !42776 from 21.2 to master.
AnalysisTop: add new shower types to the...2021-04-23T03:06:33+02:00Atlas NightlybuildSweeping !42776 from 21.2 to master.
AnalysisTop: add new shower types to the check when submitting to the gridAnalysisTop: add new shower types to the check when submitting to the grid
See merge request atlas/athena!42776AnalysisTop: add new shower types to the check when submitting to the grid
See merge request atlas/athena!42776https://gitlab.cern.ch/atlas/athena/-/merge_requests/42823Add L1TE Info for monitoring2021-04-23T03:06:00+02:00Somadutta BhattaAdd L1TE Info for monitoringThis MR is to add L1 TE info for monitoring for MinBias triggers.
Tagging @tboldThis MR is to add L1 TE info for monitoring for MinBias triggers.
Tagging @tboldhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42822Draft: First draft of RDO testers for BIS78 RPC and sMDT2021-04-25T19:25:19+02:00Paul JonesDraft: First draft of RDO testers for BIS78 RPC and sMDTA first draft of the RPCRDOVariables class has been created and changes were made to NSWPRDValAlg and the digi and reco python scripts to integrate the new class to MuonPRDTest. This will give RPC related variables in the reco output ntu...A first draft of the RPCRDOVariables class has been created and changes were made to NSWPRDValAlg and the digi and reco python scripts to integrate the new class to MuonPRDTest. This will give RPC related variables in the reco output ntuple.
MDTRDOVariables class to be added soon.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42821Divide MDT HPTDC ADC/TDC by 42021-04-27T03:05:08+02:00Edward DiehlDivide MDT HPTDC ADC/TDC by 4Divide the ADC/TDC by 4 for MDT chambers which use HPTDC chip (BMG, sMDT BIS7), so these chambers have same ticksize as other MDTs. Do change in MuonMDT_CnvTool/MdtRdoToPrepDataToolCore where MdtDigits are put into PRD. Correspondingl...Divide the ADC/TDC by 4 for MDT chambers which use HPTDC chip (BMG, sMDT BIS7), so these chambers have same ticksize as other MDTs. Do change in MuonMDT_CnvTool/MdtRdoToPrepDataToolCore where MdtDigits are put into PRD. Correspondingly, remove special treatment of BMG in MdtCalibSvc/MdtCalibrationTool (special ticksize). This change will permit proper reconstruction of HPTDC chambers, timeslew correction will work (based on ADC), and ADC cuts will now work.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42820RecExTB: Remove references to LArOFCTool.2021-04-23T03:04:20+02:00Scott SnyderRecExTB: Remove references to LArOFCTool.Remove references to obsolete tool LArOFCTool.Remove references to obsolete tool LArOFCTool.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42819TBRec: Remove references to LArOFCTool.2021-04-23T03:06:04+02:00Scott SnyderTBRec: Remove references to LArOFCTool.Remove references to obsolete tool LArOFCTool.Remove references to obsolete tool LArOFCTool.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42818LArCalibTools: Remove references to LArOFCTool.2021-04-23T03:04:30+02:00Scott SnyderLArCalibTools: Remove references to LArOFCTool.Change uses of the obsolete LArOFCTool to use the conditions algorithm instead.
Clean up LArOFC2Ntuple a bit.Change uses of the obsolete LArOFCTool to use the conditions algorithm instead.
Clean up LArOFC2Ntuple a bit.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42817MuonCnvToolInterfaces+Muon*_CnvTools: Make interfaces const.2021-04-23T03:06:07+02:00Scott SnyderMuonCnvToolInterfaces+Muon*_CnvTools: Make interfaces const.Make all methods of IMuonRawDataProviderTool and IMuonRdoToPrepDataTool const.Make all methods of IMuonRawDataProviderTool and IMuonRdoToPrepDataTool const.