athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-04-26T15:08:04+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/42879update to Genser LCG layer python3_ATLAS_112021-04-26T15:08:04+02:00Ewelina Maria Lobodzinskaupdate to Genser LCG layer python3_ATLAS_11update to Genser LCG layer python3_ATLAS_11, which includes new MC versionsupdate to Genser LCG layer python3_ATLAS_11, which includes new MC versionshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42871conf2Toconfigurable warning fix2021-08-31T10:37:41+02:00Walter Lamplconf2Toconfigurable warning fixWith GaudiConfig2, ServiceHandles on the jobOption side are just strings (type/name). This is on purpose, since they are considered pointers to (shared) components owned by the ComponentAccumulator. Therefore it doesn't make sense to rec...With GaudiConfig2, ServiceHandles on the jobOption side are just strings (type/name). This is on purpose, since they are considered pointers to (shared) components owned by the ComponentAccumulator. Therefore it doesn't make sense to recursively check properties of ServiceHandles.
Reduces the number of warnings in the log.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42848Draft: Allow adding MAXIMUM_BUFFERSIZE to limit baskets for writing via TMemFile2021-04-23T20:57:12+02:00Peter Van GemmerenDraft: Allow adding MAXIMUM_BUFFERSIZE to limit baskets for writing via TMemFileThis will allow to decrease I/O buffer size allocated by worker in ROOT TMemFile SharedWriter mode and should not have a huge effect on output compression.This will allow to decrease I/O buffer size allocated by worker in ROOT TMemFile SharedWriter mode and should not have a huge effect on output compression.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42822Draft: First draft of RDO testers for BIS78 RPC and sMDT2021-04-25T19:25:19+02:00Paul JonesDraft: First draft of RDO testers for BIS78 RPC and sMDTA first draft of the RPCRDOVariables class has been created and changes were made to NSWPRDValAlg and the digi and reco python scripts to integrate the new class to MuonPRDTest. This will give RPC related variables in the reco output ntu...A first draft of the RPCRDOVariables class has been created and changes were made to NSWPRDValAlg and the digi and reco python scripts to integrate the new class to MuonPRDTest. This will give RPC related variables in the reco output ntuple.
MDTRDOVariables class to be added soon.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42813Draft: Remove unused static thread_local variable from LArG4Identifier2021-04-23T00:45:35+02:00John Derek ChapmanDraft: Remove unused static thread_local variable from LArG4IdentifierIn ATLASSIM-5215 it was noted that there was a lot of thread local storage
access when `LArG4Identifier` objects were created/copied. This was caused
by a static thread_local variable in the `set_last_error` method, which was
called mult...In ATLASSIM-5215 it was noted that there was a lot of thread local storage
access when `LArG4Identifier` objects were created/copied. This was caused
by a static thread_local variable in the `set_last_error` method, which was
called multiple times, but the output was not used elsewhere in the code.
Removing the variable/method results in no change to the simulation output
in local tests.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42793WIP: ATR-22696: CalRatio triggers migration2021-10-06T13:14:49+02:00Emma Torro PastorWIP: ATR-22696: CalRatio triggers migrationMigration for the CalRatio triggers based on the CalRatio code in:
https://gitlab.cern.ch/atlas/athena/-/tree/release/20.7.8.11/Trigger/TrigHypothesis/TrigLongLivedParticlesHypo
and
https://gitlab.cern.ch/atlas/athena/-/tree/release/20.7...Migration for the CalRatio triggers based on the CalRatio code in:
https://gitlab.cern.ch/atlas/athena/-/tree/release/20.7.8.11/Trigger/TrigHypothesis/TrigLongLivedParticlesHypo
and
https://gitlab.cern.ch/atlas/athena/-/tree/release/20.7.8.11/Trigger/TrigAlgorithms/TrigL2LongLivedParticleshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42771Draft: L1Topo muon simulation update2021-04-28T11:19:03+02:00Paula Martinez SuarezDraft: L1Topo muon simulation updateL1Topo muon simulation update for Run 3:
- Fix typo in MuonTOB header
- Add new monitoring histograms to the muon input provider
- Update Et treatment in muon TOB and the corresponding generic TOB
- Update muon eta and phi calculation to...L1Topo muon simulation update for Run 3:
- Fix typo in MuonTOB header
- Add new monitoring histograms to the muon input provider
- Update Et treatment in muon TOB and the corresponding generic TOB
- Update muon eta and phi calculation to retrieve the correct values and avoid crash due to max number of bits
@orlando @iriu @asonay @cmorenom @masatohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42770TrigT1CaloSim: Migrate to MT-safe random number service.2021-04-23T09:27:47+02:00Scott SnyderTrigT1CaloSim: Migrate to MT-safe random number service.Change from using AtRndmGenSvc to AthRNGSvc, so avoid running thread-unsafe
code in an incident handler.
May change trigger simulation results due to changing the random number stream.
Random number streams are now reseeded on each even...Change from using AtRndmGenSvc to AthRNGSvc, so avoid running thread-unsafe
code in an incident handler.
May change trigger simulation results due to changing the random number stream.
Random number streams are now reseeded on each event.
May possibly be related to crashes described in ATR-23052.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42752Fix for TopRecon UserHook2021-04-20T18:05:52+02:00Dominic HirschbuehlFix for TopRecon UserHookChanged the variable type for one input parameter from int to double.
This makes the TopRecon UserHook now usable.Changed the variable type for one input parameter from int to double.
This makes the TopRecon UserHook now usable.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42736WIP: egamma ART change from master to rel212021-04-21T14:25:31+02:00Daniela KuchlerWIP: egamma ART change from master to rel21Port changes made to egamma ART master branch to rel 21: relates to additonal histograms (photon ID !42097) and to python code cleaning (!42526)Port changes made to egamma ART master branch to rel 21: relates to additonal histograms (photon ID !42097) and to python code cleaning (!42526)https://gitlab.cern.ch/atlas/athena/-/merge_requests/42713Draft: Tier0Tests modernisation and cleanup2021-11-28T15:15:45+01:00Tadej Novaktadej.novak@cern.chDraft: Tier0Tests modernisation and cleanupTier0 tests (`RunTier0Tests.py`) are a popular and nice tool but which unfortunately got a bit too big. In an effort to make the infrastructure reusable (for example for `RunUpgradeTests.py`) I started some cleanup. The idea is to have o...Tier0 tests (`RunTier0Tests.py`) are a popular and nice tool but which unfortunately got a bit too big. In an effort to make the infrastructure reusable (for example for `RunUpgradeTests.py`) I started some cleanup. The idea is to have object-based base infrastructure which can then be implemented for individual tests.
For now I created a base `Tier0Test` which can be executed in a clean or patched environment. The overlay test was ported over and integrated in the existing steering.
@amete, does this look similar enough to what you proposed?
/cc @jchapman @nstyleshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42701Draft: 22.0-cleanup-TrkGlobalChi2Fitter2021-04-23T13:51:24+02:00Shaun RoeDraft: 22.0-cleanup-TrkGlobalChi2FitterSmall refactoringSmall refactoringhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42691Try to use fabs with std::abs everywhere2021-04-19T19:16:07+02:00Christos Anastopouloschristos.anastopoulos@cern.chTry to use fabs with std::abs everywhereThis is one of the things one wonders if is possible to do everywhere...
Anyhow as per ATLAS coding guidelines
lets try to use ``std::abs`` everywhere
or at least see where we can not and why ...
The MR is more or less the the result...This is one of the things one wonders if is possible to do everywhere...
Anyhow as per ATLAS coding guidelines
lets try to use ``std::abs`` everywhere
or at least see where we can not and why ...
The MR is more or less the the result of running
``find . -type f -name "*.cxx" | xargs sed -i 's/\<fabs\>/std::abs/g' ``
We might need to bail out in some cases lets seehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42678MuonClusterSegmentFinderTool - Remove mutable keyword from ToolHandle member2021-04-18T10:47:07+02:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuonClusterSegmentFinderTool - Remove mutable keyword from ToolHandle memberThis is part of the efforts described in ATLASRECTS-6171This is part of the efforts described in ATLASRECTS-6171https://gitlab.cern.ch/atlas/athena/-/merge_requests/42656WIP: Adding beex triggers2021-04-21T15:52:30+02:00Debottam Bakshi GuptaWIP: Adding beex triggersAs mentioned in ATR-22749 the trggers needed for b->eex decays this MR is based on !41588 I am keeping it WIP as @hrussell is looking after itAs mentioned in ATR-22749 the trggers needed for b->eex decays this MR is based on !41588 I am keeping it WIP as @hrussell is looking after ithttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42646Draft: 22.0-fpe_debug-TrkGlobalChi2Fitter2021-04-17T21:49:39+02:00Shaun RoeDraft: 22.0-fpe_debug-TrkGlobalChi2FitterHopefully addressing ATLASRECTS-6137 and (just locally) factoring out common code.Hopefully addressing ATLASRECTS-6137 and (just locally) factoring out common code.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42627WIP: Add Precision Tracking to fullscan LRT performance chain2021-05-13T15:57:09+02:00Benjamin Philip KerridgeWIP: Add Precision Tracking to fullscan LRT performance chainThis merge request adds LRT precision tracking to the performance chains for fullscan LRT tracking.
Changes:
- Adjusts references to EFIDTrackingCuts to the LRT variant when `config.isLRT` is true in PT setup
- Adjusts FSLRT chain to ad...This merge request adds LRT precision tracking to the performance chains for fullscan LRT tracking.
Changes:
- Adjusts references to EFIDTrackingCuts to the LRT variant when `config.isLRT` is true in PT setup
- Adjusts FSLRT chain to add PT algs
Jira: ATR-22502 ATR-22311https://gitlab.cern.ch/atlas/athena/-/merge_requests/42601Switch ringer selector to ONNX core2021-04-30T19:53:03+02:00Joao Victor Da Fonseca PintoSwitch ringer selector to ONNX coremove the ringer selector at e/g fast step to ONNX API.
Note: Count changes it is expected.move the ringer selector at e/g fast step to ONNX API.
Note: Count changes it is expected.Joao Victor Da Fonseca PintoJoao Victor Da Fonseca Pintohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42587Draft: Add new variables to RPCDigitVariables class2021-04-20T22:31:39+02:00Paul JonesDraft: Add new variables to RPCDigitVariables classNew variables (e.g. strip, time, measuresPhi) added to RPCDigitVariables class.New variables (e.g. strip, time, measuresPhi) added to RPCDigitVariables class.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42580Add the option to set ML extensions for the FS tracking by default2021-04-25T16:47:46+02:00Mark SuttonAdd the option to set ML extensions for the FS tracking by defaultBy default, enable the ML etensions for eth FS tracking. Switch the ML nightly
test to *disable* the ML extensions. Also set the road width from a parameter,
rather than as a hardcoded parameter.
Would expect the counts to chain for all...By default, enable the ML etensions for eth FS tracking. Switch the ML nightly
test to *disable* the ML extensions. Also set the road width from a parameter,
rather than as a hardcoded parameter.
Would expect the counts to chain for all FS tracking dependent chains, Jet, MET, Bjets, BeamspotFS etc.