athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-04-23T03:05:47+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/42782TrigCost: package cleanup2021-04-23T03:05:47+02:00Aleksandra PorebaTrigCost: package cleanup- remove `TrigCostAnalysis_JobOptions.py` - replaced with `RunTrigCostAnalysis.py`
- remove `trigCostHistToCSV.cxx` and associated c++ files - replaced with python version `CostAnalysisPostProcessing.py`
- split `TableSepcifications` in...- remove `TrigCostAnalysis_JobOptions.py` - replaced with `RunTrigCostAnalysis.py`
- remove `trigCostHistToCSV.cxx` and associated c++ files - replaced with python version `CostAnalysisPostProcessing.py`
- split `TableSepcifications` into separate files per class
tagging @tamartinhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42781Externals Update, master branch (2021.04.21.)2021-04-28T11:56:03+02:00Attila KrasznahorkayExternals Update, master branch (2021.04.21.)Updated all the projects to [atlasexternals-2.0.105](https://gitlab.cern.ch/atlas/atlasexternals/-/tags/2.0.105). The updates wrt. to [atlasexternals-2.0.104](https://gitlab.cern.ch/atlas/atlasexternals/-/tags/2.0.104) are the following ...Updated all the projects to [atlasexternals-2.0.105](https://gitlab.cern.ch/atlas/atlasexternals/-/tags/2.0.105). The updates wrt. to [atlasexternals-2.0.104](https://gitlab.cern.ch/atlas/atlasexternals/-/tags/2.0.104) are the following (https://gitlab.cern.ch/atlas/atlasexternals/-/compare/2.0.104...2.0.105):
- Updated `FindSuperchic.cmake` to add the Superchic executables to the environment, and set up `SUPERCHICPATH` in the runtime environment as well (thanks to @wmccorma);
- Removed the `PACKAGE_VERSION_UQ` definition from the compilation commands (thanks to @fwinkl);
- Added the `ATLAS_PACKAGE_NAME` definition to all compilation commands executed in "ATLAS packages";
- Removed the global setting of the `HAVE_64_BITS`, `__IDENTIFIER_64BIT__` and `FVOIDP` compiler definitions.
The removal of `PACKAGE_VERSION_UQ` is related to the discussion going on in ATEAM-731, and @fwinkl's changes in !42543.
I also wanted to get rid of the global setting of `HAVE_64_BITS`, `__IDENTIFIER_64BIT__` and `FVOIDP` for a long time now, and Frank's changes were a good trigger to do that now. As it turns out, we've not been using `HAVE_64_BITS` **anywhere** in our code by now, and `__IDENTIFIER_64BIT__` was used in exactly one place. I removed the logic from that one place, since we'll not be going back to 32-bit identifiers at any point by now.
`FVOIDP` has a couple of users, but in the greater scheme of things, it was still better to set that definition specifically in those 3 places than to turn it on globally for all Fortran compilation commands in this repository.
Because of the `PACKAGE_VERSION_UQ` removal I think a thorough test is warranted for this MR... (It should be safe to merge afterwards, ~"full-build" should not scare the release manager. I'm only turning it on to make sure that nothing would be left over from previous builds with that flag still set.)https://gitlab.cern.ch/atlas/athena/-/merge_requests/42780HLT: Move COOL update configuration2021-04-23T10:33:30+02:00Frank WinklmeierHLT: Move COOL update configurationMove the `enableCOOLFolderUpdates` configuration into the HLT framework
itself. COOL updates have become such an integral part of running the
HLT (e.g. HLT prescale updates) that this should be configured
centrally so it works also for n...Move the `enableCOOLFolderUpdates` configuration into the HLT framework
itself. COOL updates have become such an integral part of running the
HLT (e.g. HLT prescale updates) that this should be configured
centrally so it works also for non-`runHLT`-based jobs.
This **may** also help in fixing the irreproducibilities seen in ATR-23272.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42779TrigInDetValidation: add new chain to MuonLRT tests2021-04-23T03:03:30+02:00Julie KirkTrigInDetValidation: add new chain to MuonLRT testsAdd new chain to TIDV muon LRT tests - this chain includes Precision TrackingAdd new chain to TIDV muon LRT tests - this chain includes Precision Trackinghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42778LArHVIdMappingAlg: Use addDependency synax, eliminate constructor2021-04-23T03:06:03+02:00Walter LamplLArHVIdMappingAlg: Use addDependency synax, eliminate constructorThe title says it all ...The title says it all ...https://gitlab.cern.ch/atlas/athena/-/merge_requests/42777MuonCaloEnergyTool - Avoid FPEs by calculating the metric in an alternative way2021-04-23T03:03:51+02:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuonCaloEnergyTool - Avoid FPEs by calculating the metric in an alternative wayHi,
although the changeset looks quite big, it's actually pretty minor. In the first commit, I just reindented the whole package using `clang-format` and then the second commit contains the actual changes primarily targeting the issue in...Hi,
although the changeset looks quite big, it's actually pretty minor. In the first commit, I just reindented the whole package using `clang-format` and then the second commit contains the actual changes primarily targeting the issue in ATLASRECTS-6272.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42776AnalysisTop: add new shower types to the check when submitting to the grid2021-04-22T19:03:54+02:00Tomas DadoAnalysisTop: add new shower types to the check when submitting to the gridThis is needed for submitting jobs to the grid when using the new ftag MC/MC SFs.This is needed for submitting jobs to the grid when using the new ftag MC/MC SFs.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42775Sweeping !42728 from 21.2 to master.
AT: Fixing isolation SFs for electrons w...2021-04-23T03:05:45+02:00Atlas NightlybuildSweeping !42728 from 21.2 to master.
AT: Fixing isolation SFs for electrons when no isolation is usedAT: Fixing isolation SFs for electrons when no isolation is used
See merge request atlas/athena!42728AT: Fixing isolation SFs for electrons when no isolation is used
See merge request atlas/athena!42728https://gitlab.cern.ch/atlas/athena/-/merge_requests/42774Sweeping !42734 from 21.2 to master.
Updated to the new April 2021 FTag CDI f...2021-04-23T03:03:38+02:00Atlas NightlybuildSweeping !42734 from 21.2 to master.
Updated to the new April 2021 FTag CDI file in ATUpdated to the new April 2021 FTag CDI file in AT
See merge request atlas/athena!42734Updated to the new April 2021 FTag CDI file in AT
See merge request atlas/athena!42734https://gitlab.cern.ch/atlas/athena/-/merge_requests/42773Additional digit variables for BIS78 RPC and sMDT2021-04-27T03:04:48+02:00Paul JonesAdditional digit variables for BIS78 RPC and sMDTAdditional variables added to RPCDigitVariables: time, strip, stripNumber, channel, measuresPhi.
localX/Y transformation now included.
Additional variables added to MDTDigitVariables: time, charge, tube, tubelayer, multilayer.Additional variables added to RPCDigitVariables: time, strip, stripNumber, channel, measuresPhi.
localX/Y transformation now included.
Additional variables added to MDTDigitVariables: time, charge, tube, tubelayer, multilayer.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42772Adding HGTD_Cluster and its TP converter2021-07-11T20:23:07+02:00Alexander LeopoldAdding HGTD_Cluster and its TP converterSplitting MR [42529](https://gitlab.cern.ch/atlas/athena/-/merge_requests/42529) into parts. This one includes the addition of the HGTD_Cluster (that extends PrepRawData) and its TP converter.
Structures for the cluster collections and...Splitting MR [42529](https://gitlab.cern.ch/atlas/athena/-/merge_requests/42529) into parts. This one includes the addition of the HGTD_Cluster (that extends PrepRawData) and its TP converter.
Structures for the cluster collections and containers are also added, tests for TP converters run now. A simple structure for the converters has been chosen as discussed in the comments here and the the Upgrade SW meeting.
For reviewers (in case this is useful): As this MR contains several changes, I wanted to point out that the main focus here is the HGTD_PrepRawData/HGTD_Cluster class. This extends the tracking interface classes needed for reco in HGTD. The MR includes also the necessary "container" objects. The ClusterCollection contains all HGTD_Clusters on a given detector module, while the ClusterContainer contains all the collections in an event.
The HGTD_EventTPCnv package contains the T/P converters for the HGTD_Cluster and its container.
Tests are set up for both packages to test that things are working as expected.
Tagging: @ncalace @nstyles @tadej @cohm @dshope @asalzburAlexander LeopoldAlexander Leopoldhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42771Draft: L1Topo muon simulation update2021-04-28T11:19:03+02:00Paula Martinez SuarezDraft: L1Topo muon simulation updateL1Topo muon simulation update for Run 3:
- Fix typo in MuonTOB header
- Add new monitoring histograms to the muon input provider
- Update Et treatment in muon TOB and the corresponding generic TOB
- Update muon eta and phi calculation to...L1Topo muon simulation update for Run 3:
- Fix typo in MuonTOB header
- Add new monitoring histograms to the muon input provider
- Update Et treatment in muon TOB and the corresponding generic TOB
- Update muon eta and phi calculation to retrieve the correct values and avoid crash due to max number of bits
@orlando @iriu @asonay @cmorenom @masatohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42770TrigT1CaloSim: Migrate to MT-safe random number service.2021-04-23T09:27:47+02:00Scott SnyderTrigT1CaloSim: Migrate to MT-safe random number service.Change from using AtRndmGenSvc to AthRNGSvc, so avoid running thread-unsafe
code in an incident handler.
May change trigger simulation results due to changing the random number stream.
Random number streams are now reseeded on each even...Change from using AtRndmGenSvc to AthRNGSvc, so avoid running thread-unsafe
code in an incident handler.
May change trigger simulation results due to changing the random number stream.
Random number streams are now reseeded on each event.
May possibly be related to crashes described in ATR-23052.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42769add cut-based selectors to precision electron hypo alg2021-05-06T03:03:48+02:00Ran Biadd cut-based selectors to precision electron hypo algadd cut-based selectors (`AsgElectronIsEMSelector`) to the precision electron hypo alg. add bit mask definitions for the heavy-ion 'loose' and 'medium' working points, taken from rel 21.0add cut-based selectors (`AsgElectronIsEMSelector`) to the precision electron hypo alg. add bit mask definitions for the heavy-ion 'loose' and 'medium' working points, taken from rel 21.0https://gitlab.cern.ch/atlas/athena/-/merge_requests/42768CaloCondPhysAlgs: Remove references to CaloMBAverageTool.2021-04-22T03:02:28+02:00Scott SnyderCaloCondPhysAlgs: Remove references to CaloMBAverageTool.Remove references to obsolete/MT-incompatible CaloMBAverageTool.Remove references to obsolete/MT-incompatible CaloMBAverageTool.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42767CaloCellCorrection: Remove CaloCellMBAverageCorr.2021-04-22T03:03:19+02:00Scott SnyderCaloCellCorrection: Remove CaloCellMBAverageCorr.Remove CaloCellMBAverageCorr. It's not used anymore, and relies on a
MT-incompatible tool.Remove CaloCellMBAverageCorr. It's not used anymore, and relies on a
MT-incompatible tool.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42766CaloRec: Remove doMinBiasAverage.2021-04-22T03:03:42+02:00Scott SnyderCaloRec: Remove doMinBiasAverage.Remove doMinBiasAverage flag and associated configuration.
This is not currently used by anything, and the tools that implement it
are not MT-compatibile. So just remove it.Remove doMinBiasAverage flag and associated configuration.
This is not currently used by anything, and the tools that implement it
are not MT-compatibile. So just remove it.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42765remove preselections for e/g triggers for heavy ion2021-05-06T03:02:59+02:00Ran Biremove preselections for e/g triggers for heavy ionremove preselections for e/g triggers for heavy ion. these selections are not optimal for heavy ion collisions and result in large inefficiencies. consistent with what was done in run2 (rel 21.0)remove preselections for e/g triggers for heavy ion. these selections are not optimal for heavy ion collisions and result in large inefficiencies. consistent with what was done in run2 (rel 21.0)https://gitlab.cern.ch/atlas/athena/-/merge_requests/42764implement UE subtraction for e/g triggers for heavy ion2021-05-13T03:03:18+02:00Ran Biimplement UE subtraction for e/g triggers for heavy ionimplement UE subtraction in the precision calo sequence for e/g triggers. an `xAOD::HIEventShapeContainer` collection is produced from FS calo info, which is then used to correct the calo cells in RoIs. the correction is done by a new al...implement UE subtraction in the precision calo sequence for e/g triggers. an `xAOD::HIEventShapeContainer` collection is produced from FS calo info, which is then used to correct the calo cells in RoIs. the correction is done by a new algorithm, `HLTCaloCellCorrector`, based on HICaloCellCorectionTool [[1]] which was removed in rel 22.0.
configure triggers to use the sequences with UE-subtraction when the 'ion' tag is present in the name.
add the event shape collection to trigger edm.
[[1]]: https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/Trigger/TrigHypothesis/TrigHIHypo/src/HICaloCellCorectionTool.cxx?v=21.0https://gitlab.cern.ch/atlas/athena/-/merge_requests/42763TrigT1CaloFexPerf: Remove references to CaloNoiseTool.2021-04-22T03:04:18+02:00Scott SnyderTrigT1CaloFexPerf: Remove references to CaloNoiseTool.Remove vestigial references to CaloNoiseTool.Remove vestigial references to CaloNoiseTool.