athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-04-23T03:08:43+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/42741ConfiguredNewTrackingCuts printInfo change2021-04-23T03:08:43+02:00Luka NedicConfiguredNewTrackingCuts printInfo changeUpdated the printInfo function to output "minPTSeed" for "min pT for seeding" print statement as this is the value used by the seeding algorithm.Updated the printInfo function to output "minPTSeed" for "min pT for seeding" print statement as this is the value used by the seeding algorithm.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42740moving primary/backup single tau and tau+X triggers from LS2_v1 to Physics me...2021-04-21T00:21:20+02:00Antonio De Mariamoving primary/backup single tau and tau+X triggers from LS2_v1 to Physics menu (V2)look at
https://gitlab.cern.ch/atlas/athena/-/merge_requests/42654look at
https://gitlab.cern.ch/atlas/athena/-/merge_requests/42654https://gitlab.cern.ch/atlas/athena/-/merge_requests/42739updates for inDetector checks for geometries split by rows2021-06-24T14:47:31+02:00Nicholas Stylesupdates for inDetector checks for geometries split by rowsUpdates for inDetector checks, to allow geometries with split rows to do this check based on their motherDesign, and thus avoid returning an ```outside``` status more often than intended (i.e. when at edge of row, but not at edge of sens...Updates for inDetector checks, to allow geometries with split rows to do this check based on their motherDesign, and thus avoid returning an ```outside``` status more often than intended (i.e. when at edge of row, but not at edge of sensor).
Should bring number of holes distributions into closer agreement for geometries with/without splitting DetectorElements into rows.
FYI @ncalace @tstreblehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42738RpcCablingCondAlg: Use addDependency instead of manual iov-range intersection2021-04-22T03:02:55+02:00Walter LamplRpcCablingCondAlg: Use addDependency instead of manual iov-range intersectionUse addDependency instead of manual iov-range intersection
See also discussion at ATLASRECTS-5708.Use addDependency instead of manual iov-range intersection
See also discussion at ATLASRECTS-5708.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42737Remove HLT_HLT from chain names2021-04-23T03:04:33+02:00Teng Jian KhooRemove HLT_HLT from chain namesSelf-explanatorySelf-explanatoryhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42736WIP: egamma ART change from master to rel212021-04-21T14:25:31+02:00Daniela KuchlerWIP: egamma ART change from master to rel21Port changes made to egamma ART master branch to rel 21: relates to additonal histograms (photon ID !42097) and to python code cleaning (!42526)Port changes made to egamma ART master branch to rel 21: relates to additonal histograms (photon ID !42097) and to python code cleaning (!42526)https://gitlab.cern.ch/atlas/athena/-/merge_requests/42735Clean up references to IBeamCondSvc2021-04-23T03:03:32+02:00Adam Edward BartonClean up references to IBeamCondSvcCleanup unused references and some repeated python codeCleanup unused references and some repeated python codehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42734Updated to the new April 2021 FTag CDI file in AT2021-04-22T17:59:47+02:00Laurynas MinceUpdated to the new April 2021 FTag CDI file in ATThis MR updates the default FTag CDI file in AnalysisTop to the latest April 2021 CDI file. The new CDI fixes a bug in the previous December 2020 CDI that affects the PCBT DL1r WP for PFlow and VR-track jets. In addition, the CDI include...This MR updates the default FTag CDI file in AnalysisTop to the latest April 2021 CDI file. The new CDI fixes a bug in the previous December 2020 CDI that affects the PCBT DL1r WP for PFlow and VR-track jets. In addition, the CDI includes the MC-MC maps for Sherpa 2.2.10 and Herwig 7.2.1 samples.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42733Addition and modification of Trigger ATR python executables (ATR-23287)2021-04-23T03:04:41+02:00Yasuyuki OkumuraAddition and modification of Trigger ATR python executables (ATR-23287)This MR is for:
- Addition of new ART test executable python script (`Trigger/TrigValidation/TriggerTest/test/test_trig_data_v1Dev_rerunL1_phase1_build.py`) and
- Modification of input data samples in an existing test of `Trigger/TrigVa...This MR is for:
- Addition of new ART test executable python script (`Trigger/TrigValidation/TriggerTest/test/test_trig_data_v1Dev_rerunL1_phase1_build.py`) and
- Modification of input data samples in an existing test of `Trigger/TrigValidation/TriggerTest/test/test_trig_mc_v1Dev_slice_muon_phase1_build.py`.
The details are mentioned in ATR-23287.
No impact on others is expected with this modification.
Best regards,
Yasu Okumura
for trigger validation teamhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42732ATR-22749 - B-phys di-electron chain2021-04-28T03:03:45+02:00Heather RussellATR-22749 - B-phys di-electron chainAs in run 2, this chain just selects on di-electrons. Thus, the name has been changed from `bBeeXM6000t` to `bBeeM6000` to avoid the seemingly endless confusion on whether or not this trigger also uses tracks, like bBmumux.
A more app...As in run 2, this chain just selects on di-electrons. Thus, the name has been changed from `bBeeXM6000t` to `bBeeM6000` to avoid the seemingly endless confusion on whether or not this trigger also uses tracks, like bBmumux.
A more appropriate name would probably be mirroring `bDimu`, but `bDie` doesn't strike me as a particularly great trigger name. Additionally, the "t" was a tight distinction referring to improved selection in run 2 from M6000, this is not needed for the new algorithm.
I've only implemented one simple chain for now: `HLT_2e5_lhvloose_bBeeM6000_L12EM3`. The L1 seed is not currently correct, since `L1_2EM3` obviously will not run online with any appreciable rate, but in MC/rerunLvl1 reprocessing tests this is equivalent to our unseeded trigger, and somewhat simpler to implement as a first test of the algorithms, for validation.
The trigger is fully defined in the electron slice, like Zee and Jpsiee chains, which seems to work ok. It uses the TrigMultiTrkComboHypo (and associated tool) just like in Run 2, and I've currently just copied the muon code into identical functions for electrons. I'd prefer to template the functions so that we don't e.g. fix a bug in muons but forget to fix the electron code, but I wasn't sure of the best way of getting around the fact that muon tracks are accessed with `muon->InDetTrackParticle()` whereas electrons need to use `electron->trackParticle()`.
edit: the relevant functions are now templated and can handle both electrons and muons.
If there are suggestions for this, please let me know and I can update the algorithms!https://gitlab.cern.ch/atlas/athena/-/merge_requests/42731Update grid queues in ART tests2021-04-22T03:04:33+02:00Mark HodgkinsonUpdate grid queues in ART testsUpdate grid queue type for 3 ART Heavy Ion Reco tests.
May partly solve ATLASRECTS-6260Update grid queue type for 3 ART Heavy Ion Reco tests.
May partly solve ATLASRECTS-6260https://gitlab.cern.ch/atlas/athena/-/merge_requests/42730MuonStauRecoTool - Skip hits with zero error2021-04-22T03:03:47+02:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuonStauRecoTool - Skip hits with zero errorCloses ATLASRECTS-6265Closes ATLASRECTS-6265https://gitlab.cern.ch/atlas/athena/-/merge_requests/42729MuonSegmentRegionRecoveryTool -- Check validity of covariance before calculat...2021-04-22T03:03:33+02:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuonSegmentRegionRecoveryTool -- Check validity of covariance before calculating the errorCloses ATLASRECTS-6262Closes ATLASRECTS-6262https://gitlab.cern.ch/atlas/athena/-/merge_requests/42728AT: Fixing isolation SFs for electrons when no isolation is used2021-04-22T09:36:12+02:00Bjoern WendlandAT: Fixing isolation SFs for electrons when no isolation is usedIt was discovered that the electron isolation SFs were not set to 1.0 when AT is configured to use `None` electron isolation. These changes will prevent SF tools to be set up for electron isolation when `None` isolation is used and ensur...It was discovered that the electron isolation SFs were not set to 1.0 when AT is configured to use `None` electron isolation. These changes will prevent SF tools to be set up for electron isolation when `None` isolation is used and ensures that electron isolation SFs are set to 1.0 for this case.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42727TrigValSteering: Skip CountRefComp and MessageCount if athena crashes2021-04-22T03:02:45+02:00Rafal Bielskirafal.bielski@cern.chTrigValSteering: Skip CountRefComp and MessageCount if athena crashesResolving a long-standing annoyance particularly affecting failing CI jobs. When athena step fails in tests enforcing the CountRefComp and MessageCount checks, their printout may get very long, which makes the actual athena errors diffic...Resolving a long-standing annoyance particularly affecting failing CI jobs. When athena step fails in tests enforcing the CountRefComp and MessageCount checks, their printout may get very long, which makes the actual athena errors difficult to find or even impossible in case of log truncation like in the CI log viewer. Add an option to skip certain CheckSteps (post-exec checks) if the ExecSteps (athena) fail, in order to avoid the long and irrelevant printouts. Apply this new option to CountRefComp and MessageCount.
A little bonus fix #1: Make MessageCount failure when no logs are found more informative.
A little bonus fix #2: Correct the log name setting for MessageCount in `test_trig_data_newJO_build.py`https://gitlab.cern.ch/atlas/athena/-/merge_requests/42726update version of AthGeneration and for externals2021-04-21T03:06:11+02:00Ewelina Maria Lobodzinskaupdate version of AthGeneration and for externalsupdate version of AthGeneration and for externalsupdate version of AthGeneration and for externalshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42725Changes to support BS writing in newJO2021-04-28T03:04:24+02:00Tomasz BoldChanges to support BS writing in newJOThis the set of changes that were required to support the BS writing in newJO.
- got rid of special property ClassesToSerialize because our custon ordered dict was not storable in pickle. It turned out that after introduction fo the hel...This the set of changes that were required to support the BS writing in newJO.
- got rid of special property ClassesToSerialize because our custon ordered dict was not storable in pickle. It turned out that after introduction fo the helper methods this whole functionality does not seem be needed. Tagging @rbielski on that
- added "configOnly" CI test verifying that there are no new/rec-ex-common impedances (i.e. getType() does not exist in newJO) - it had to be only with muons because there timeout otherwise
PS. I tried to run it all with athenaHLT but more work on basic infrastructure (like options parsing) is needed therehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/42724Fixes for cosmic trigger tests in MC2021-04-22T03:02:39+02:00Savanna ShawFixes for cosmic trigger tests in MCA couple of fixes for cosmic trigger MC tests (ATR-23207):
- Adding BG3 (EMPTY) to the bunch group set and setting ForceBunchGroupPattern=False for the CTP simulation when running in cosmics mode so that the EMPTY L1 triggers are active....A couple of fixes for cosmic trigger MC tests (ATR-23207):
- Adding BG3 (EMPTY) to the bunch group set and setting ForceBunchGroupPattern=False for the CTP simulation when running in cosmics mode so that the EMPTY L1 triggers are active.
- Updating the MC art tests to include the doCosmics=True option so that the everything (including the HLT reconstruction) is configured for cosmics.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42723Use IClassIDSvc header from GaudiKernel2021-04-23T03:04:45+02:00Frank WinklmeierUse IClassIDSvc header from GaudiKernelDelete the "forwarding-header" `AthenaKernel/IClassIDSvc.h` and change all clients to use `GaudiKernel/IClassIDSvc.h`.Delete the "forwarding-header" `AthenaKernel/IClassIDSvc.h` and change all clients to use `GaudiKernel/IClassIDSvc.h`.https://gitlab.cern.ch/atlas/athena/-/merge_requests/42722Enable TruthMetaDataTool when it is needed to propagate TruthMetaData from in...2021-04-22T03:03:35+02:00Vakhtang TsulaiaEnable TruthMetaDataTool when it is needed to propagate TruthMetaData from input to outputAddresses ATEAM-711
CC: @tadej @zmarshal @jcatmore @lcorpe @herrmant @berghausAddresses ATEAM-711
CC: @tadej @zmarshal @jcatmore @lcorpe @herrmant @berghaus