athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2020-08-28T16:17:15+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/34776WIP adding isolation variables but variables return 0 values2020-08-28T16:17:15+02:00Batool Safarzadeh SamaniWIP adding isolation variables but variables return 0 valuesadding the electron isolation, but they are all 0adding the electron isolation, but they are all 0https://gitlab.cern.ch/atlas/athena/-/merge_requests/34763Fix L1_4jJ15.0ETA25 item definition (ATR-21261)2020-07-15T12:30:54+02:00Joerg StelzerFix L1_4jJ15.0ETA25 item definition (ATR-21261)The item definition specified only 3 instead of 4 central jets.
Closes ATR-21261The item definition specified only 3 instead of 4 central jets.
Closes ATR-21261https://gitlab.cern.ch/atlas/athena/-/merge_requests/34746WIP: Implement muComb plots to Offline MonitoringMT (comment)2021-01-07T08:27:51+01:00Moe WakidaWIP: Implement muComb plots to Offline MonitoringMT (comment)web display:
[https://mwakida.web.cern.ch/mwakida/ATR-20317/test3/MuonMon/L2muComb/HLT_mu26_ivarmedium_L1MU20/index.html](https://mwakida.web.cern.ch/mwakida/ATR-20317/test3/MuonMon/L2muComb/HLT_mu26_ivarmedium_L1MU20/index.html)web display:
[https://mwakida.web.cern.ch/mwakida/ATR-20317/test3/MuonMon/L2muComb/HLT_mu26_ivarmedium_L1MU20/index.html](https://mwakida.web.cern.ch/mwakida/ATR-20317/test3/MuonMon/L2muComb/HLT_mu26_ivarmedium_L1MU20/index.html)https://gitlab.cern.ch/atlas/athena/-/merge_requests/34743WIP: CaloMonitoring: Conditions dependency fix.2020-07-24T06:14:45+02:00Scott SnyderWIP: CaloMonitoring: Conditions dependency fix.Disable use of luminosity in LArCellMonAlg for cosmics runs.
Avoids declaring dependencies on non-existent conditions objects.Disable use of luminosity in LArCellMonAlg for cosmics runs.
Avoids declaring dependencies on non-existent conditions objects.https://gitlab.cern.ch/atlas/athena/-/merge_requests/3473421.0 fix dq servers2020-07-14T23:50:49+02:00Peter Onyisi21.0 fix dq serversUrgent fix to use new DQ serversUrgent fix to use new DQ servershttps://gitlab.cern.ch/atlas/athena/-/merge_requests/34731Migration of more GeneratorFilters to HepMC3 (part6)2020-07-15T12:02:39+02:00Andrii VerbytskyiMigration of more GeneratorFilters to HepMC3 (part6)In this MR:
- Migration of more Generator filters to hepmc3In this MR:
- Migration of more Generator filters to hepmc3https://gitlab.cern.ch/atlas/athena/-/merge_requests/34724Remove non-ascii characters from codes. Mostly comments are affected.2020-09-21T16:11:20+02:00Andrii VerbytskyiRemove non-ascii characters from codes. Mostly comments are affected.This is a general cleanup MR.
In this MR the non-acsii charactes are removed from the *.cxx, *.h and *.f files.
The search fro files with non-ascii (almost) characters was performed with:
```
find . -type f -not -path "./.git/*"...This is a general cleanup MR.
In this MR the non-acsii charactes are removed from the *.cxx, *.h and *.f files.
The search fro files with non-ascii (almost) characters was performed with:
```
find . -type f -not -path "./.git/*" -name "*.h" -exec grep -lP '[^\0-\x7f]' {} \;
```
- Most of the replaced characters are in comments and originate from a copy-pasted documentation (e.g. from PDF files).
- Some are just math symbols greek letters/umlauts/ characters with grave/acute accents, etc.
- Some charactes are "special empty spaces" or quotes.
- Virtually all the occurances are in the comments. Some exceptions are attempts to cout:: greek letters.
The author names with umlauts/grave/acute accents were left "as is".Edward MoyseEdward Moysehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/34714Fill in missing new config for tools and services required for ISF Services2020-07-15T18:26:58+02:00Rupert TombsFill in missing new config for tools and services required for ISF ServicesResolve TODOs left by !34362 in ISF Services configuration.
Move some functions between (Core/not Core) files to avoid circular dependence. Correct imports from these.
Change tool configuration functions to return ComponentAccumulator ...Resolve TODOs left by !34362 in ISF Services configuration.
Move some functions between (Core/not Core) files to avoid circular dependence. Correct imports from these.
Change tool configuration functions to return ComponentAccumulator with tools attached.
Add flake8 cmake options for affected packages.https://gitlab.cern.ch/atlas/athena/-/merge_requests/34712JetRecConfig.py2020-08-18T18:00:32+02:00Mikael ChalaJetRecConfig.pyAdded a new version of JetRecConfig.py that implements getJetRecAlg, which substitutes JetRecTool + JetAlgorithm (although these are still present for backwards compatibility).Added a new version of JetRecConfig.py that implements getJetRecAlg, which substitutes JetRecTool + JetAlgorithm (although these are still present for backwards compatibility).https://gitlab.cern.ch/atlas/athena/-/merge_requests/34683Allow some track manipulation for the cosmic analyses2020-07-13T21:39:03+02:00Mark SuttonAllow some track manipulation for the cosmic analysesIn some cases the cosmic tracks in the trigger and offline may use a different convention,
offline tracks always travelling downwards, but the trigger, travelling outwards from
the beamline.
These changes allow the direction of th the t...In some cases the cosmic tracks in the trigger and offline may use a different convention,
offline tracks always travelling downwards, but the trigger, travelling outwards from
the beamline.
These changes allow the direction of th the trigger tracks to be reversed and so restore
the correspondence between trigger and offline tracks.
In additon, becaus eof the wider d0 and z0 ranges that are possible with cosmics, the
histogram ranges can be modified from dat file.https://gitlab.cern.ch/atlas/athena/-/merge_requests/34682Allow some track manipulation for the cosmic analyses2020-07-13T15:28:39+02:00Mark SuttonAllow some track manipulation for the cosmic analysesIn some cases the cosmic tracks in the trigger and offline may use a different convention,
offline tracks always travelling downwards, but the trigger, travelling outwards from
the beamline.
These changes allow the direction of th t...In some cases the cosmic tracks in the trigger and offline may use a different convention,
offline tracks always travelling downwards, but the trigger, travelling outwards from
the beamline.
These changes allow the direction of th the trigger tracks to be reversed and so restore
the correspondence between trigger and offline tracks.
In additon, becaus eof the wider d0 and z0 ranges that are possible with cosmics, the
histogram ranges can be modified from dat file.https://gitlab.cern.ch/atlas/athena/-/merge_requests/34673TrigCommon: Update unit test references2020-07-13T14:22:02+02:00Frank WinklmeierTrigCommon: Update unit test referencesFix unit test failures introduced with !34654.Fix unit test failures introduced with !34654.https://gitlab.cern.ch/atlas/athena/-/merge_requests/34638PixelDigitization: Conditions dependency fixes2020-07-15T15:32:54+02:00Scott SnyderPixelDigitization: Conditions dependency fixesDon't declare dependencies on conditions objects that we won't read.Don't declare dependencies on conditions objects that we won't read.https://gitlab.cern.ch/atlas/athena/-/merge_requests/34635WIP: Avoid using NN clustering by default2020-09-16T20:15:04+02:00Benjamin Michael WynneWIP: Avoid using NN clustering by defaultInitialising from a default toolhandle avoids configuring the corresponding conditions algorithms. This required some unpleasant hackery to get around.
This MR provides an explicit alternative to the NN clusterisation tool, and remove...Initialising from a default toolhandle avoids configuring the corresponding conditions algorithms. This required some unpleasant hackery to get around.
This MR provides an explicit alternative to the NN clusterisation tool, and removes the corresponding hackery.
Tagging @jmasik since he was interestedhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/34615dqm_algorithms CMake Cleanup, master branch (2020.07.10.)2021-01-04T15:37:38+01:00Attila Krasznahorkaydqm_algorithms CMake Cleanup, master branch (2020.07.10.)I noticed [dqm_algorithms](DataQuality/dqm_algorithms) as a surprising entry in my [build time spreadsheets](https://docs.google.com/spreadsheets/d/1phkOu3uky68DpGk61d_xgd9F6o3WaoBx9qfcqFQKRnc/edit?usp=sharing), and had a closer look. Si...I noticed [dqm_algorithms](DataQuality/dqm_algorithms) as a surprising entry in my [build time spreadsheets](https://docs.google.com/spreadsheets/d/1phkOu3uky68DpGk61d_xgd9F6o3WaoBx9qfcqFQKRnc/edit?usp=sharing), and had a closer look. Since I really didn't like its CMake configuration, I decided to clean it up a bit.
First off, the package builds 3 shared libraries. `dqm_algorithms`, `dqm_tools` and `dqm_summaries`. The source file layout in the package is a little weird, but I decided that the original intention of the writer must have been to make `dqm_tools` depend on only externals, and then `dqm_algorithms` and `dqm_summaries` to depend on `dqm_tools`. (Beside the same externals.) So I re-shuffled the sources between the libraries like that, and updated the link relationships between them to behave this way.
The package also builds 2 dictionaries, separately for symbols defined in `dqm_tools` and `dqm_algorithms`. I simplified the build setup of these to have only these library dependencies.
Finally, and I was quite surprised about this, neither of the executables of the package directly use any of the above mentioned 3 libraries directly. They only use them at runtime. So I simplified the build setup of the executables as well.
I also removed the setup of the aliases for the executables, as I could not find any reference to the "`.exe` names" in the repository. @ponyisi, do you guys ever refer to these executables as `dqm_print_algorithms.exe` or `dqm_print_summarymakers.exe`? You would have seen a warning about doing that since some time, so I guess not. But let me know if I made a mistake with this.
Unfortunately all this update does not make the build of the package faster in any noticeable way. (The package takes long to build because it has a **lot** of source files.) But at least it makes it a bit more "parallel"...Peter OnyisiPeter Onyisihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/34595WIP: Refactor bytestream configuration for component accumulator2020-07-15T10:01:36+02:00Frank Berghausfrank.berghaus@cern.chWIP: Refactor bytestream configuration for component accumulatorThis pull request started from the quest to add a CI test for ByteStreamMetadata reading and writing. The configuration module to read from and write to bytestream was functional but could use improvement. Since my investigation has take...This pull request started from the quest to add a CI test for ByteStreamMetadata reading and writing. The configuration module to read from and write to bytestream was functional but could use improvement. Since my investigation has taken me to find out whether something is missing in the Read configuration of bytestream it seemed like a good plan to spruce up the configuration before doing any more work on it.
@tadej @gemmerenhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/34590WIP: AthenaKernel+StoreGate: Change storeName to std::string_view2021-02-22T20:05:34+01:00Frank WinklmeierWIP: AthenaKernel+StoreGate: Change storeName to std::string_viewChange the `StoreID::storeName` helper to return a `std::string_view`
and adjust all handles to accept a `std::string_view` instead of `const
std::string&`. This allows the helper function to become `constexpr`. A
few explicit `std::stri...Change the `StoreID::storeName` helper to return a `std::string_view`
and adjust all handles to accept a `std::string_view` instead of `const
std::string&`. This allows the helper function to become `constexpr`. A
few explicit `std::string` conversions had to be added for calls that do
not support `std::string_view`, i.e. construction of ServiceHandles.https://gitlab.cern.ch/atlas/athena/-/merge_requests/3458322.0-bugfix-TrkAmbiguityProcessor2020-07-13T12:18:09+02:00Shaun Roe22.0-bugfix-TrkAmbiguityProcessorThis fixes a bug in the event counting in AmbiCounter.icc by removing the 'all' category of the counters and fixing the eta bounds dimension to four (barrel, transition, endcap and 'forward'). The 'all' category statistics are now calcul...This fixes a bug in the event counting in AmbiCounter.icc by removing the 'all' category of the counters and fixing the eta bounds dimension to four (barrel, transition, endcap and 'forward'). The 'all' category statistics are now calculated on-the-fly by summing the regions using std::accumulate. Changes were made to clients to ensure the eta bounds inputs are the correct size. Other changes (formatting, principally) were incidental to the debugging.https://gitlab.cern.ch/atlas/athena/-/merge_requests/34570WIP: Implementation of full Standard jet definitions and basic tests of them2021-02-23T08:42:50+01:00Pierre Antoine DelsartWIP: Implementation of full Standard jet definitions and basic tests of themWe implement Standard jet definitions for the RunIII config system.
This is based on and evolve the existing new jet config.
This might be the most visible part of the new jet config, so I'm adding relevant experts & conveners to the di...We implement Standard jet definitions for the RunIII config system.
This is based on and evolve the existing new jet config.
This might be the most visible part of the new jet config, so I'm adding relevant experts & conveners to the discussion.
Tagging @cdelitzs, @sschramm , @wbalunas , @sawyer , @loch , @khoo, @mhodgkinPierre Antoine DelsartPierre Antoine Delsarthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/34532WIP:[ATR-21375] Bugfix to findFile in JsonFileLoader.cxx2021-02-26T16:05:07+01:00Tim MartinWIP:[ATR-21375] Bugfix to findFile in JsonFileLoader.cxxFixes finding files in `$XMLPATH`
Thanks to @lshi for the patch.
cc @stelzerFixes finding files in `$XMLPATH`
Thanks to @lshi for the patch.
cc @stelzer