athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-03-23T09:29:17+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/41842Migrate DRAW_ZMUMU_SkimmingTool to data handles.2021-03-23T09:29:17+01:00Goetz GayckenMigrate DRAW_ZMUMU_SkimmingTool to data handles.Use data handles instead of direct storegate access.
Also made mutable counters atomic to allow the tool being used
in reentrant algorithms.
This addresses part of ATLASRECTS-6090.Use data handles instead of direct storegate access.
Also made mutable counters atomic to allow the tool being used
in reentrant algorithms.
This addresses part of ATLASRECTS-6090.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41838Draft: 21.9: Updating combinatorial track finder for fast tracking2021-03-23T09:02:56+01:00Noemi CalaceDraft: 21.9: Updating combinatorial track finder for fast trackingUpdating combinatorial track finder for fast tracking: includes usage of conservative cluster errors for track finding and refitting of precise clusters covariance matrix.
OBO: @gavrilenko
FYI: @tstreble @elsing @iene @hgrayUpdating combinatorial track finder for fast tracking: includes usage of conservative cluster errors for track finding and refitting of precise clusters covariance matrix.
OBO: @gavrilenko
FYI: @tstreble @elsing @iene @hgrayNoemi CalaceNoemi Calacehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/41835added complete Pythia_8 ART tests2021-03-23T19:20:12+01:00Luzhan Yueadded complete Pythia_8 ART testshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/41808Nightly art jetrec2021-03-22T01:57:05+01:00Christina NelsonNightly art jetrec- The changes to these files make ART nightly comparisons to the previous nightly instead of a static reference file. This is the desired comparison for Jet/EtMiss.
- Grid tests have ran well, and the outputs look fine.
- https://bigpa...- The changes to these files make ART nightly comparisons to the previous nightly instead of a static reference file. This is the desired comparison for Jet/EtMiss.
- Grid tests have ran well, and the outputs look fine.
- https://bigpanda.cern.ch/task/24611172/
- https://bigpanda.cern.ch/task/24611566/
- https://bigpanda.cern.ch/task/24611571/
- tagging @tcuhadarhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/41774MuonPRDTest: Add CSC/TGCRDOVariables.cxx/.h2021-03-22T10:49:34+01:00Minlin WuMuonPRDTest: Add CSC/TGCRDOVariables.cxx/.hNSWPRDValAlg.cxx/.h are modified in order to use the TGC cabling service to retrieve the identifier.NSWPRDValAlg.cxx/.h are modified in order to use the TGC cabling service to retrieve the identifier.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41749Draft: Break geometry flags master2021-06-23T09:55:04+02:00John Derek ChapmanDraft: Break geometry flags masterhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/41718TrigT1CaloFexPerf: Fix thread-safety checker warnings.2021-03-17T22:17:35+01:00Scott SnyderTrigT1CaloFexPerf: Fix thread-safety checker warnings.Rework to avoid using mutable members.Rework to avoid using mutable members.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41715WIP: jet hypo - generalisation of jet hypo Filters2021-04-04T16:25:41+02:00Peter SherwoodWIP: jet hypo - generalisation of jet hypo FiltersFilters are used to reduce the number of jets from an input jet vector.
Until now the filters have been confined to those that use a sequence of capacity = 1
Conditions to make the selection. Dummy filtering (ie no selection) was arrange...Filters are used to reduce the number of jets from an input jet vector.
Until now the filters have been confined to those that use a sequence of capacity = 1
Conditions to make the selection. Dummy filtering (ie no selection) was arranged by
having the dummy filter have no conditions.
A new use case has come up where filtering is needed, but cannot be done as described above.
A new oure interface is now used ot allow different filtering implementations. Dummy filtering
is now down with a dedicated named implementation class.
Filtering currently is done both on the input vector beore the hypo code proper is run, and
as a jet selector to Fast Reducer leaf Conditions
Other changes: Repeated Condition can now invert its decision base on a configurable boolean flag.
ConditionFilter uses Repeated Condition, rather than CompoundCondition directly
New interfaces:
IHypoJetVectorFilter.h
ITrigHypoJetVectorFilterConfig.h
Pass through filtering
PassThroughFilter.h, cxx
TrigJetPassThroughFilterConfig.h, cxx
New filter configurers
TrigJetConditionFilterConfig.cxx, h
TrigJetPassThroughFilterConfig.cxx, h
TrigJetRangeFilterConfig.cxx, h
TrigJetHypoToolHelperNoGrouper.h, cxx
Condition inversion:
RepeatedCondition.cxx, h
TrigJetConditionConfig_repeated.cxx, h
ITrigJetRepeatedConditionConfig.h
Move to use RepeatedCondition
ConditionFilter.cxx, h
TrigJetHypoToolConfig_fastreduction.cxx
ATR-22914
@jbossios @valentem @peterPeter SherwoodPeter Sherwoodhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/41705Draft: Migrate RpvEgammaIDTool to Datahandles2021-03-19T13:23:34+01:00Walter LamplDraft: Migrate RpvEgammaIDTool to DatahandlesRelates to ATLASRECTS-6090Relates to ATLASRECTS-6090https://gitlab.cern.ch/atlas/athena/-/merge_requests/41672TrigConfL1Data: Protect against division by zero.2021-03-17T21:34:42+01:00Scott SnyderTrigConfL1Data: Protect against division by zero.Protect getCutFromPrescale against division by zero if given a prescale of 0.Protect getCutFromPrescale against division by zero if given a prescale of 0.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41659WIP: adding support for xAOD::Truth-to-HepMC::GenEvent conversion2021-03-17T15:36:48+01:00Aidan Sean KellyWIP: adding support for xAOD::Truth-to-HepMC::GenEvent conversionThe purpose of this change set is to pull some logic (e.g. the `TruthConverter`) from 21.2 and use (+ extend) it in `Rivet_i` to allow AODs and TRUTH1 DAOD to be read in and their xAOD::Truth format to be converted back to HepMC::GenEven...The purpose of this change set is to pull some logic (e.g. the `TruthConverter`) from 21.2 and use (+ extend) it in `Rivet_i` to allow AODs and TRUTH1 DAOD to be read in and their xAOD::Truth format to be converted back to HepMC::GenEvent, so that it can be passed on to Rivet.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41655Draft: Special MR for CI testing optimization (never merge)2021-09-29T20:42:53+02:00Alexander UndrusDraft: Special MR for CI testing optimization (never merge)This MR request is for triggering experimental CI jobs with modified settings. It is used for CI testing optimization. Please do not accept it.This MR request is for triggering experimental CI jobs with modified settings. It is used for CI testing optimization. Please do not accept it.Alexander UndrusAlexander Undrushttps://gitlab.cern.ch/atlas/athena/-/merge_requests/41650adding useful postIncludes for ITk2021-03-20T13:33:58+01:00Nicholas Stylesadding useful postIncludes for ITkAdd some initial postIncludes for ITk validation. These can be added to a transform e.g. as follows:
```
Sim_tf.py \
--CA \
--inputEVNTFile "/cvmfs/atlas-nightlies.cern.ch/repo/data/data-art/SimCoreTests/valid1.410000.PowhegPythiaEvtGen...Add some initial postIncludes for ITk validation. These can be added to a transform e.g. as follows:
```
Sim_tf.py \
--CA \
--inputEVNTFile "/cvmfs/atlas-nightlies.cern.ch/repo/data/data-art/SimCoreTests/valid1.410000.PowhegPythiaEvtGen_P2012_ttbar_hdamp172p5_nonallhad.evgen.EVNT.e4993.EVNT.08166201._000012.pool.root.1" \
--outputHITSFile "test.NEW.HITS.pool.root" \
--maxEvents 1 \
--detectors ITkStrip ITkPixel Bpipe \
--geometryVersion 'default:ATLAS-P2-ITK-24-00-00' \
--conditionsTag 'default:OFLCOND-MC16-SDR-14' \
--DataRunNumber '284500' \
--physicsList 'FTFP_BERT_ATL' \
--truthStrategy 'MC15aPlus' \
--simulator 'FullG4MT' \
--postInclude 'PyJobTransforms.UseFrontier,InDetConfig.HitValidation' \
--preInclude 'SimuJobTransforms.BeamPipeKill,SimuJobTransforms.FrozenShowersFCalOnly,SimuJobTransforms.TightMuonStepping' \
--imf False
```
FYI @tadej @jchapman - seems everything works well within Sim_tf so we will start using those as our standard basis for testing, to avoid re-implementing things.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41632Fix clang warnings.2021-03-16T13:21:45+01:00Goetz GayckenFix clang warnings.Fix clang warnings concerning:
- unused arguments (also changed other places to [[maybe_unused]]),
- side effects of typeid usage, and
- unused variable.Fix clang warnings concerning:
- unused arguments (also changed other places to [[maybe_unused]]),
- side effects of typeid usage, and
- unused variable.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41630WIP: This is a complete waste of time2021-03-31T13:15:26+02:00Mark SuttonWIP: This is a complete waste of timehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/41621InDetCoolCoralClientUtils: Fix cppcheck warnings.2021-03-16T15:15:02+01:00Scott SnyderInDetCoolCoralClientUtils: Fix cppcheck warnings.Fix cppcheck warnings.Fix cppcheck warnings.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41588Draft: BLS trigger: Beex Alg (ATR-22749)2021-04-20T13:03:55+02:00Adam Edward BartonDraft: BLS trigger: Beex Alg (ATR-22749)@lyubushk @tursom @hrussell @jakoubek
I have ported the old Beex algorithm using the logic Vladimir established in the BmumuX code.
I have removed the 2 track vertexing as this seems useless?
Can you check and make any comments on th...@lyubushk @tursom @hrussell @jakoubek
I have ported the old Beex algorithm using the logic Vladimir established in the BmumuX code.
I have removed the 2 track vertexing as this seems useless?
Can you check and make any comments on the logic or cuts. We still need to set up the chain and I've asked the egamma people for some help.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41576WIP: Update the ID Trigger configuration class2021-03-31T13:14:03+02:00Mark SuttonWIP: Update the ID Trigger configuration classAdded additional variables and implemented the fetching of the
configuration from the Config Settings for the InDetTrigConfig code
and the FTF Configuration
Parameters can be set in pre-includes etc using eg
```
from InDetTrigConfig.Co...Added additional variables and implemented the fetching of the
configuration from the Config Settings for the InDetTrigConfig code
and the FTF Configuration
Parameters can be set in pre-includes etc using eg
```
from InDetTrigConfig.ConfgSettings import getInDetTrigConfig ; getInDetTrigConfig("Muon")._etaHalfWidth = 0.1
```
Also, for these changes we rename many of the variables, such that they more
properly correspond to the class variables that they are actually being used to set, to make
it clearer what is actually being set and wherehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/41575Draft: A draft for particle converters in HepMC3 branch2021-03-19T19:16:06+01:00Andrii VerbytskyiDraft: A draft for particle converters in HepMC3 branchA draft for particle converters in HepMC3 branch
Hi @ssnyder, @jchapman
so tweaking the smart pointers should look like this?
Best regards,
AndriiA draft for particle converters in HepMC3 branch
Hi @ssnyder, @jchapman
so tweaking the smart pointers should look like this?
Best regards,
Andriihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/41549ITk fast LRT speed up2021-03-16T15:07:41+01:00Thomas StreblerITk fast LRT speed upThis MR brings some speed up to fast LRT exploiting:
- generic LRT updates from !41481
- some early rejection of strip spaceports in strip formation (no seed lost but x2 speed-up! TBC in standard tracking at some point)
- increase of th...This MR brings some speed up to fast LRT exploiting:
- generic LRT updates from !41481
- some early rejection of strip spaceports in strip formation (no seed lost but x2 speed-up! TBC in standard tracking at some point)
- increase of the pT threshold to 5 GeV
Based on low-stat tests, the track finder timing for LRT is thus made equivalent to the default one run with fast tracking.
FYI @ncalace @aroepe