athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2022-03-29T21:42:37+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/51655Update RPD Decoding for MuCalStreamerTool2022-03-29T21:42:37+02:00Roberto Di NardoUpdate RPD Decoding for MuCalStreamerToolUpdating the MuCalStreamer tool to use proper xAOD::MuonRoI accessor methods for run-3 decoding ([ATR-25233](https://its.cern.ch/jira/browse/ATR-25233))Updating the MuCalStreamer tool to use proper xAOD::MuonRoI accessor methods for run-3 decoding ([ATR-25233](https://its.cern.ch/jira/browse/ATR-25233))https://gitlab.cern.ch/atlas/athena/-/merge_requests/51641TRT is not used for Muon ID by default2022-03-29T21:43:41+02:00Yohei YamaguchiTRT is not used for Muon ID by defaultThis MR is for fixing a bug in MuonSelectionTool. TRT criteria should be applied when `m_TrtCutOff = false`. But currently it's the opposite wrongly.
ping @gabarone and @mvanadiaThis MR is for fixing a bug in MuonSelectionTool. TRT criteria should be applied when `m_TrtCutOff = false`. But currently it's the opposite wrongly.
ping @gabarone and @mvanadiahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/51705PowhegControl: fixing MadSpin issue - AGENE-21322022-04-11T11:44:01+02:00Timothee Theveneaux-PelzerPowhegControl: fixing MadSpin issue - AGENE-2132This MR fixes the issue with MadSpin decays in PowhegControl encoutered after update to MadGraph5-2.9.9.atlas2 in AthGeneration,21.6.91. Instead of executing the madspin python executable directly, we call it using the python executable ...This MR fixes the issue with MadSpin decays in PowhegControl encoutered after update to MadGraph5-2.9.9.atlas2 in AthGeneration,21.6.91. Instead of executing the madspin python executable directly, we call it using the python executable to avoid issues with the shebang which now calls for python3 explicitely.https://gitlab.cern.ch/atlas/athena/-/merge_requests/51660TriggerEDM: preserve order in getPreregistrationList2022-03-30T15:44:09+02:00Frank WinklmeierTriggerEDM: preserve order in getPreregistrationListMake `getPreregistrationList` reproducible by preserving the order of
collection names when removing duplicates. This is useful when comparing jobs that deserialize Run-1 data as the order of registered collections does seem to influence...Make `getPreregistrationList` reproducible by preserving the order of
collection names when removing duplicates. This is useful when comparing jobs that deserialize Run-1 data as the order of registered collections does seem to influence the size of the serialized data.
Also remove Python2 backwards compatibility code.https://gitlab.cern.ch/atlas/athena/-/merge_requests/5164922.0-cppcheck-MuonSimHitToPrdTest2022-03-30T15:44:32+02:00Shaun Roe22.0-cppcheck-MuonSimHitToPrdTestsolve cppcheck warnings for error, portability, performancesolve cppcheck warnings for error, portability, performancehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/51668TrigT1RPChardware: Fix clang warnings.2022-03-30T15:43:20+02:00Scott SnyderTrigT1RPChardware: Fix clang warnings.Missing override keywords.Missing override keywords.https://gitlab.cern.ch/atlas/athena/-/merge_requests/51669TrigInDetAnalysisExample: Fix clang warnings.2022-03-30T15:43:42+02:00Scott SnyderTrigInDetAnalysisExample: Fix clang warnings.Missing override keywords.Missing override keywords.https://gitlab.cern.ch/atlas/athena/-/merge_requests/51506Only use TRT_Phase in monitoring if it is available.2022-03-30T15:42:14+02:00Goetz GayckenOnly use TRT_Phase in monitoring if it is available.- introduce flag to toggle TRT_Phase computation or availability.
- disbale usage of TRT_Phase in TRTMonitoringRun3ESD_Alg if the
TRT_Phase is not available.
- Remove unused read handle
Closes ATLASRECTS-6886- introduce flag to toggle TRT_Phase computation or availability.
- disbale usage of TRT_Phase in TRTMonitoringRun3ESD_Alg if the
TRT_Phase is not available.
- Remove unused read handle
Closes ATLASRECTS-6886https://gitlab.cern.ch/atlas/athena/-/merge_requests/51639CA-tracking configuration per package: CaloClusterROI_Selector2022-03-30T15:42:39+02:00Thomas StreblerCA-tracking configuration per package: CaloClusterROI_SelectorContinuation of updates of tracking CA configs, moving together the configs of the same C++ tools. This MR covers the `CaloClusterROI_Selector`.Continuation of updates of tracking CA configs, moving together the configs of the same C++ tools. This MR covers the `CaloClusterROI_Selector`.https://gitlab.cern.ch/atlas/athena/-/merge_requests/5164522.0-cppcheck-TopParticleLevel2022-03-30T15:44:07+02:00Shaun Roe22.0-cppcheck-TopParticleLevelSolve cppcheck warnings by throwing an actual exception; some (false positive) cppcheck warnings added to local suppressions list.Solve cppcheck warnings by throwing an actual exception; some (false positive) cppcheck warnings added to local suppressions list.https://gitlab.cern.ch/atlas/athena/-/merge_requests/51651TileMonitoring: Fix Tile cells number vs LB monitoring for Run 32022-03-30T15:44:34+02:00Siarhei HarkushaTileMonitoring: Fix Tile cells number vs LB monitoring for Run 3Monitoring of Tile cells number vs lumiblock
has been fixed if fill is outside axis range.Monitoring of Tile cells number vs lumiblock
has been fixed if fill is outside axis range.https://gitlab.cern.ch/atlas/athena/-/merge_requests/51662TrigCost, RatesAnalysis: Add an option to pass JIRA number2022-03-31T13:42:04+02:00Aleksandra PorebaTrigCost, RatesAnalysis: Add an option to pass JIRA number- add an option to pass the JIRA number in the rates and cost postprocessing, which will be saved to metadata
- skip `STREAM:express` stream group, follow up to !51307 ([Tim's comment](https://gitlab.cern.ch/atlas/athena/-/merge_requests...- add an option to pass the JIRA number in the rates and cost postprocessing, which will be saved to metadata
- skip `STREAM:express` stream group, follow up to !51307 ([Tim's comment](https://gitlab.cern.ch/atlas/athena/-/merge_requests/51307#note_5380273))
- print and save to metadata processed ranges
Tagging @tamartin @markhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/51678ATLASRECTS-6926, ATR-25239, ATLASRECTS-6928: fixes for b-tagging2022-03-30T15:43:02+02:00Dan GuestATLASRECTS-6926, ATR-25239, ATLASRECTS-6928: fixes for b-tagging!51419 broke some things. I'm trying to fix them:
- ATLASRECTS-6926: Fix for config function that was renamed
- ATR-25239: remove online monitoring access to `MV2c10_discriminant`
- ATLASRECTS-6928: remove skimming strings that use `MV2c...!51419 broke some things. I'm trying to fix them:
- ATLASRECTS-6926: Fix for config function that was renamed
- ATR-25239: remove online monitoring access to `MV2c10_discriminant`
- ATLASRECTS-6928: remove skimming strings that use `MV2c10_discriminant`
This should close the above issues. It turns out it's also blocking some cleanup for the EDM (ATLASRECTS-6833) because MV2 asks for `SV1_p*`, which isn't ever set.
Tagging @duperrin @thuffmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/51699LArCalibUtils: Fix setting of property default value.2022-03-30T15:42:59+02:00Scott SnyderLArCalibUtils: Fix setting of property default value.Skipped property default value.Skipped property default value.https://gitlab.cern.ch/atlas/athena/-/merge_requests/51702TrkVKalVrtCore: Fix compilation with gcc12.2022-03-30T15:42:35+02:00Scott SnyderTrkVKalVrtCore: Fix compilation with gcc12.Missing #include <array>.Missing #include <array>.https://gitlab.cern.ch/atlas/athena/-/merge_requests/51701DetDescrCondTools: Fix cppcheck warning.2022-03-30T15:42:57+02:00Scott SnyderDetDescrCondTools: Fix cppcheck warning.Pass strings by const reference, not by value.Pass strings by const reference, not by value.https://gitlab.cern.ch/atlas/athena/-/merge_requests/51703TrkDetDescrGeoModelCnv: Enable thread-safety checking.2022-03-30T15:42:16+02:00Scott SnyderTrkDetDescrGeoModelCnv: Enable thread-safety checking.Enable thread-safety checking and fix warnings.Enable thread-safety checking and fix warnings.https://gitlab.cern.ch/atlas/athena/-/merge_requests/51687fix per-event warning about missing (legacy) EventInfo object2022-03-30T15:43:34+02:00Walter Lamplfix per-event warning about missing (legacy) EventInfo objectFixes ATLASRECTS-6888Fixes ATLASRECTS-6888https://gitlab.cern.ch/atlas/athena/-/merge_requests/51685Adding analysis package in Tracking/Acts2022-03-30T15:44:28+02:00Noemi CalaceAdding analysis package in Tracking/ActsThis MR includes the ActsTrkAnalysis package under Tracking/Acts.
It includes, at the time being, the implementation of the `PixelClusterAnalysis`, `StripClusterAnalysis` and `SpacePointAnalysis`. They are used to check the properties o...This MR includes the ActsTrkAnalysis package under Tracking/Acts.
It includes, at the time being, the implementation of the `PixelClusterAnalysis`, `StripClusterAnalysis` and `SpacePointAnalysis`. They are used to check the properties of objects in `xAOD::PixelClusterContainer`, `xAOD::StripClusterContainer`, and `ActsTrk::SpacePointContainer` and compare them with the output of equivalent algorithms processing `InDet::PixelClusterContainer`, `InDet::SCT_ClusterContainer` and `Trk::SpacePointContainer`.
FYI: @pagessin @lgagnon @cvarni @toyamaza @npetters @tadejNoemi CalaceNoemi Calacehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/51561Cleanup PixelModuleData, part 12022-03-30T15:43:14+02:00Tadej Novaktadej.novak@cern.chCleanup PixelModuleData, part 1First part of cleanup of `PixelModuleData` with the aim of:
- do not silently return default values, throw an exception instead
- avoid casting as much as possible
- return by reference if possible
The motivation is to start preparing t...First part of cleanup of `PixelModuleData` with the aim of:
- do not silently return default values, throw an exception instead
- avoid casting as much as possible
- return by reference if possible
The motivation is to start preparing the infrastructure for ITk and at the moment we can share the majority of it with InDet Pixel. In the future we may want to reorganise this a bit as some (default) values could probably be moved to clients directly (e.g. charge calibration defaults).
This MR is not supposed to change the output but it may break Run 1. Still testing so keeping draft while allowing people to already provide feedback.
/cc @stsuno @battagl @sroe @nstyles @npetters