athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-03-18T03:02:16+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/41687DetCommon Fixes, master branch (2021.03.17.)2021-03-18T03:02:16+01:00Attila KrasznahorkayDetCommon Fixes, master branch (2021.03.17.)This MR is trying to address 2 issues:
- The modification in [DetCommon/cmake/PreConfig.cmake.in](Projects/DetCommon/cmake/PreConfig.cmake.in) makes sure that the following wouldn't happen:
```
[bash][atlas]:build-test > cmake ../sour...This MR is trying to address 2 issues:
- The modification in [DetCommon/cmake/PreConfig.cmake.in](Projects/DetCommon/cmake/PreConfig.cmake.in) makes sure that the following wouldn't happen:
```
[bash][atlas]:build-test > cmake ../source/
-- The CXX compiler identification is Clang 12.0.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /opt/intel-clang/12.0.0/x86_64-centos7/bin/clang++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found DetCommon: /cvmfs/atlas.cern.ch/repo/sw/software/22.0/DetCommon/22.0.28.1/InstallArea/x86_64-centos7-gcc8-opt/cmake/DetCommonConfig.cmake (version: 22.0.28.1)
-- Setting up LCG release "LCG_98python3" for platform: x86_64-centos7-gcc8-opt
-- Setting up LCG release using: /cvmfs/atlas.cern.ch/repo/sw/software/22.0/sw/lcg/releases/LCG_98python3/LCG_externals_x86_64-centos7-gcc8-opt.txt
-- Setting ATLAS specific build flags
-- Configuring done
CMake Error at CMakeLists.txt:10 (add_executable):
Target "testExe" links to target "Threads::Threads" but the target was not
found. Perhaps a find_package() call is missing for an IMPORTED target, or
an ALIAS target is missing?
CMake Error at CMakeLists.txt:10 (add_executable):
Target "testExe" links to target "Threads::Threads" but the target was not
found. Perhaps a find_package() call is missing for an IMPORTED target, or
an ALIAS target is missing?
-- Generating done
CMake Generate step failed. Build files cannot be regenerated correctly.
[bash][atlas]:build-test >
```
- The change in [TrigConfData/CMakeLists.txt](Trigger/TrigConfiguration/TrigConfData/CMakeLists.txt) is there to make it easier to compile the L1Calo and CTP code at Point-1. As discussed in ATLINFR-3977.
Pinging @fwinkl and @rhauser.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41686Add adaptive vertexing to the tau slice2021-03-27T03:03:03+01:00Mark SuttonAdd adaptive vertexing to the tau sliceAdd the adaptive vertexing to the tau slice, using a vertex collection HLT_IDVertex_TauAdd the adaptive vertexing to the tau slice, using a vertex collection HLT_IDVertex_Tauhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/41685TrigT1CaloFexPerf: fix thread checker warning and link dependencies2021-03-18T03:04:04+01:00Frank WinklmeierTrigT1CaloFexPerf: fix thread checker warning and link dependenciesFix thread-checker warnings by marking two mutables as thread-safe (they
are protected by a mutex). The warning skipped the CI due to interference between !41450 and !41585.
Also tidy link dependencies.
cc @bcarlsonFix thread-checker warnings by marking two mutables as thread-safe (they
are protected by a mutex). The warning skipped the CI due to interference between !41450 and !41585.
Also tidy link dependencies.
cc @bcarlsonhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/41684ATR-23009 - remove FSNOSEED from egamma chains2021-03-20T03:03:15+01:00Lidija ZivkovicATR-23009 - remove FSNOSEED from egamma chainsNeed to remove FSNOSEED from gamma chains since they are not meant to be on full scan.
Besides chains described in ATR-23009 one gamma+jets chan was also changed so no FSNOSEED for gamma part. Also I noticed that one chain had "__" inste...Need to remove FSNOSEED from gamma chains since they are not meant to be on full scan.
Besides chains described in ATR-23009 one gamma+jets chan was also changed so no FSNOSEED for gamma part. Also I noticed that one chain had "__" instead of "_", chawed that.
And I removed "boffperf_split" and added 0deta320 for non tagged jets in two b+j chains (ATR-22937).
All tests passed and reference files are updated.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41683First version of the SqliteReadSvc2021-03-19T03:03:08+01:00Vakhtang TsulaiaFirst version of the SqliteReadSvcThe new Athena Service has been introduced to allow reading detector description
parameters from plain SQLite tables, which are collocated in the same SQLite
database together with the persistent representation of the `GeoModel` descript...The new Athena Service has been introduced to allow reading detector description
parameters from plain SQLite tables, which are collocated in the same SQLite
database together with the persistent representation of the `GeoModel` description
tree.
In order to allow for smooth transition of clients from the `RDBAccessSvc` to
the new `SqliteReadSvc`, the latter implements the `IRDBAccessSvc` interface.
The functionality that is yet to be implemented: an analogue of the `RDBQuery` for
reading data from SQLite tables.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41682Sweeping !41605 from 21.9 to 21.3.
Manual sweep of !41572 and !41597 (Enable ...2021-03-18T03:05:23+01:00Atlas NightlybuildSweeping !41605 from 21.9 to 21.3.
Manual sweep of !41572 and !41597 (Enable running full muon chain using phase2 layout and add ART test)Manual sweep of !41572 and !41597 (Enable running full muon chain using phase2 layout and add ART test)
See merge request atlas/athena!41605Manual sweep of !41572 and !41597 (Enable running full muon chain using phase2 layout and add ART test)
See merge request atlas/athena!41605https://gitlab.cern.ch/atlas/athena/-/merge_requests/41681Sweeping !41598 from 21.3 to 21.9.
small bug fix for printout warning that is...2021-03-18T03:06:01+01:00Atlas NightlybuildSweeping !41598 from 21.3 to 21.9.
small bug fix for printout warning that is not actually an errorsmall bug fix for printout warning that is not actually an error
See merge request atlas/athena!41598small bug fix for printout warning that is not actually an error
See merge request atlas/athena!41598https://gitlab.cern.ch/atlas/athena/-/merge_requests/4168021.6 save reduced truth particle container to EVNT for pileup minbias samples2021-03-23T03:06:25+01:00Jeff Dandoy21.6 save reduced truth particle container to EVNT for pileup minbias samplesThis MR adds a new `xAOD::TruthPileupParticleContainer` output container which includes any final (no same-daughter) truth-level photons, electrons, or muons with pt > 8 GeV & eta < 4.5. This info will be added for the upcoming R22 minb...This MR adds a new `xAOD::TruthPileupParticleContainer` output container which includes any final (no same-daughter) truth-level photons, electrons, or muons with pt > 8 GeV & eta < 4.5. This info will be added for the upcoming R22 minbias samples, and will be collected at digitization to provide pileup truth information. This container is only created if `Generators/GeneratorFilters/share/common/AddPileupTruthParticles.py` is added, and the output is only saved if `evgenConfig.savePileupTruthParticles` is set to true.
Tagging @jkatzy @cgutscho @jkretz @jchapman @mduehrss @zmarshal @ewelina for feedback on the placement and details of this functionality.
Jeffhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/41679TrkExTools: Fix cppcheck warnings.2021-03-19T03:04:38+01:00Scott SnyderTrkExTools: Fix cppcheck warnings.Remove redundant comparisons.Remove redundant comparisons.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41678GeneratorFilters: Fix cppcheck warning.2021-03-18T03:03:36+01:00Scott SnyderGeneratorFilters: Fix cppcheck warning.Suppress cppcheck false positive.Suppress cppcheck false positive.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41677TRT_G4Utilities: Fix cppcheck warning.2021-03-18T03:04:48+01:00Scott SnyderTRT_G4Utilities: Fix cppcheck warning.Use std::to_string rather than reimplementing it here.
In passing, fixes a cppcheck warning.Use std::to_string rather than reimplementing it here.
In passing, fixes a cppcheck warning.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41676TileRecUtils: Fix cppcheck warnings.2021-03-18T03:02:52+01:00Scott SnyderTileRecUtils: Fix cppcheck warnings.Potential out-of-bounds array indexing.Potential out-of-bounds array indexing.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41675TrigDecisionTool: Fix cppcheck warning.2021-03-18T03:02:58+01:00Scott SnyderTrigDecisionTool: Fix cppcheck warning.Potential null pointer dereference.Potential null pointer dereference.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41674ISF_FastCaloSimServices: Increase test timeout.2021-03-18T03:04:12+01:00Scott SnyderISF_FastCaloSimServices: Increase test timeout.Test has been timing out frequently in debug builds.Test has been timing out frequently in debug builds.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41673MuonTGC_CnvTools: Interface cleanups.2021-03-18T03:03:44+01:00Scott SnyderMuonTGC_CnvTools: Interface cleanups.Clean up ITGC_RodDecoder / TGC_RodDecoderRawData / TGC_RodDecoderReadout.
Use extends<> / DeclareInterfaceID.
Use override keyword.
Make a couple counters atomic.Clean up ITGC_RodDecoder / TGC_RodDecoderRawData / TGC_RodDecoderReadout.
Use extends<> / DeclareInterfaceID.
Use override keyword.
Make a couple counters atomic.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41672TrigConfL1Data: Protect against division by zero.2021-03-17T21:34:42+01:00Scott SnyderTrigConfL1Data: Protect against division by zero.Protect getCutFromPrescale against division by zero if given a prescale of 0.Protect getCutFromPrescale against division by zero if given a prescale of 0.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41671tauRecTools: Fix ubsan warnings.2021-03-18T03:04:46+01:00Scott SnydertauRecTools: Fix ubsan warnings.Make sure all members of LayerConfig are initialized.Make sure all members of LayerConfig are initialized.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41670update default alternative PDF sets2021-03-24T03:06:08+01:00Christian Gutschowupdate default alternative PDF sets... the new OpenLoops (being installed by Genser) could be a good excuse to update these to the latest PDF sets. Would be nice to have them in the new V+jets as well, seeing as they will be for legacy analyses.
cc @fsiegert @mgignac... the new OpenLoops (being installed by Genser) could be a good excuse to update these to the latest PDF sets. Would be nice to have them in the new V+jets as well, seeing as they will be for legacy analyses.
cc @fsiegert @mgignachttps://gitlab.cern.ch/atlas/athena/-/merge_requests/41669InDetAlignmentMonitoring: Fix ubsan warning.2021-03-18T03:04:15+01:00Scott SnyderInDetAlignmentMonitoring: Fix ubsan warning.Fix undefined conversion between TH1F* and TH1D*.Fix undefined conversion between TH1F* and TH1D*.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41668MuonCombinedTrackFindingTools: Fix ubsan warning.2021-03-18T03:04:35+01:00Scott SnyderMuonCombinedTrackFindingTools: Fix ubsan warning.Protect against out-of-bounds vector access.Protect against out-of-bounds vector access.