athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2021-03-10T03:04:52+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/41427Fix for BCIDAvgAlg sequence2021-03-10T03:04:52+01:00Benjamin Michael WynneFix for BCIDAvgAlg sequencehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/40675 was intended to ensure CaloBCIDAvgAlg runs in HLTBeginSeq
There were two bugs - firstly that sequence wasn't created yet, and second the capitalisation was wrong.
This MR shoul...https://gitlab.cern.ch/atlas/athena/-/merge_requests/40675 was intended to ensure CaloBCIDAvgAlg runs in HLTBeginSeq
There were two bugs - firstly that sequence wasn't created yet, and second the capitalisation was wrong.
This MR should fix that.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41426Trying a less memory-hungry way of reading2021-03-16T03:06:06+01:00Zach MarshallTrying a less memory-hungry way of readingThis should prevent the entire LHE file from being read into memory at
once, which will reduce the use of memory for very large files.This should prevent the entire LHE file from being read into memory at
once, which will reduce the use of memory for very large files.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41425Further Simulation Configuration fixes (ATLASSIM-5147)2021-03-10T03:03:05+01:00John Derek ChapmanFurther Simulation Configuration fixes (ATLASSIM-5147)This merge request adjusts two simulation test scripts and the CA-based simulation job transform skeletons to use `ConfigFlags.Exec.MaxEvents` to control how many events should be run, rather than explicitly setting the `maxEvents` argum...This merge request adjusts two simulation test scripts and the CA-based simulation job transform skeletons to use `ConfigFlags.Exec.MaxEvents` to control how many events should be run, rather than explicitly setting the `maxEvents` argument of `cfg.run(...)`.
This should also fix ATLASSIM-5147.
FYI @tadej, @dnoel, @blebanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/41424Fix cluster->cell links in EGAM72021-03-10T03:05:31+01:00Giovanni MarchioriFix cluster->cell links in EGAM7Fix problem with cluster->cell links in EGAM7 reported in https://its.cern.ch/jira/projects/ATLEGAMDPD/issues/ATLEGAMDPD-147.
Also update old list of cluster sizes for gain decorations in a few EGAM derivations.Fix problem with cluster->cell links in EGAM7 reported in https://its.cern.ch/jira/projects/ATLEGAMDPD/issues/ATLEGAMDPD-147.
Also update old list of cluster sizes for gain decorations in a few EGAM derivations.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41423Implementation of TrigEFTauDiKaonHypoTool for Run-3 meson+gamma triggers2021-04-06T03:03:58+02:00Robert James WardImplementation of TrigEFTauDiKaonHypoTool for Run-3 meson+gamma triggersImplements the purely tau meson-mass hypothesis tool, `TrigEFTauDiKaonHypoTool`, for the following trigger chains used in exclusive meson+photon Higgs/Z/W boson decay searches:
- HLT_g25_medium_tau25_dikaonmass_tracktwoMVA_50mVis10000
...Implements the purely tau meson-mass hypothesis tool, `TrigEFTauDiKaonHypoTool`, for the following trigger chains used in exclusive meson+photon Higgs/Z/W boson decay searches:
- HLT_g25_medium_tau25_dikaonmass_tracktwoMVA_50mVis10000
- HLT_g25_medium_tau25_kaonpi1_tracktwoMVA_50mVis10000
- HLT_g25_medium_tau25_kaonpi2_tracktwoMVA_50mVis10000
- HLT_g25_medium_tau25_singlepion_tracktwoMVA_50mVis10000
- HLT_g35_medium_tau25_dipion3_tracktwoMVA_60mVis10000
Related JIRA ticket: https://its.cern.ch/jira/browse/ATR-22644
The chain segments `dikaonmass`, `kaonpi1/2`, `singlepion` and `dipion3` are purely tau hypotheses that use the `TrigEFTauDiKaonHypoTool` class, which has been ported from its Run-2 equivalent. The chain segments are entered in the tau `selection` chain-part in the signature dictionary. This hypothesis is based on `TrigEFTauMVHypoTool`, and is implemented on the menu side as an alternative option in within `TrigEFTauMVHypoToolFromDict`.
The chain segment `50mVis10000` is a tau+photon combo invariant mass hypothesis. This will be implemented in a later merge request.
This implementation does not affect chains that use the standard `TrigEFTauMVHypoTool` tool.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41422Removing PHYS2 DAOD format2021-03-10T03:02:28+01:00James CatmoreRemoving PHYS2 DAOD formatThe PHYS2 format was a demonstrator for applying lossy compression to the PHYS format. This is now superseded by !41018 which allows the lossy compression to be switched on via a post-include for the PHYS format itself. Consequently the ...The PHYS2 format was a demonstrator for applying lossy compression to the PHYS format. This is now superseded by !41018 which allows the lossy compression to be switched on via a post-include for the PHYS format itself. Consequently the obsolete job options and fragments are deleted with this MR.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41421Adjust JetUncertainties mass-scale accessors to be created where they are used2021-03-11T23:02:29+01:00Steven SchrammAdjust JetUncertainties mass-scale accessors to be created where they are used@janders encountered a problem when trying to implement the recent jet recommendations which was traced back to how the accessors were being created. I'm not sure why it worked for some users but it didn't work in SUSYTools, but either ...@janders encountered a problem when trying to implement the recent jet recommendations which was traced back to how the accessors were being created. I'm not sure why it worked for some users but it didn't work in SUSYTools, but either way it's good to fix this problem. Anyone who already has the recent jet recommendations working is unaffected, while those who were getting auxdata exceptions when using the tool should no longer receive such errors.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41420MuonTrackSummary remove default constructor2021-03-11T03:03:46+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuonTrackSummary remove default constructorHi @emoyse,
has reported compilation warnings in ATLASRECTS-5930, which should be fixed in this ticket.
Cheers,
JohannesHi @emoyse,
has reported compilation warnings in ATLASRECTS-5930, which should be fixed in this ticket.
Cheers,
Johanneshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/41419MSVertexRecoTools use thread-safe random numbers2021-03-10T03:04:54+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMSVertexRecoTools use thread-safe random numbersHi everyone,
in ATLASRECTS-6040, @nkoehler has raised a potential issue in terms of thread safety for the random numbers. This issue should be fixed now following the route of implementation suggested by @nkoehler.
Best,
JohannesHi everyone,
in ATLASRECTS-6040, @nkoehler has raised a potential issue in terms of thread safety for the random numbers. This issue should be fixed now following the route of implementation suggested by @nkoehler.
Best,
Johanneshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/41418L1TopoCoreSim: add missing include and link dependencies2021-03-10T03:04:47+01:00Frank WinklmeierL1TopoCoreSim: add missing include and link dependenciesFix build failures in DetCommon project.
Required for starting the CI builds for this project: ATLINFR-4008Fix build failures in DetCommon project.
Required for starting the CI builds for this project: ATLINFR-4008https://gitlab.cern.ch/atlas/athena/-/merge_requests/41417TrfTestsART: Add AODMerge_tf tests2021-03-10T03:05:08+01:00Johannes ElmsheuserTrfTestsART: Add AODMerge_tf testsAdd a serial and a MT AODMerge_tf test processing 1k events.Add a serial and a MT AODMerge_tf test processing 1k events.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41416Remove unused old RegSelSvc Tables.2021-03-10T03:02:42+01:00Denis Oliveira DamazioRemove unused old RegSelSvc Tables.Some tables and AlgTools to fill these tables became useless in both LAr and Tile code with the new RegSel Condition Algorithms and should now be removed. I hope this is enough to clean up centrally the RegSelSvc itself from master.
Requ...Some tables and AlgTools to fill these tables became useless in both LAr and Tile code with the new RegSel Condition Algorithms and should now be removed. I hope this is enough to clean up centrally the RegSelSvc itself from master.
Required by @sutt, discussed with @fwinkl and @pavol. @solodkov and @harkusha should also be informed for the Tile part, which, curiously, had a funny copy of the IRegionLUT_Creator table in it.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41415fixing condition to retrieve RNN and track clusters in tau trigger legacy mon...2021-03-12T03:03:24+01:00Antonio De Mariafixing condition to retrieve RNN and track clusters in tau trigger legacy monitoringhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/41414Using a much smaller minimum weight value in Pythia82021-03-10T10:47:34+01:00Zach MarshallUsing a much smaller minimum weight value in Pythia8We seem to have an old check for a "very small" weight, where that very
small value is fairly arbitrary. This seems to now be actually affecting
some BSM samples that are being generated.
Changing the check to use float minimum, because...We seem to have an old check for a "very small" weight, where that very
small value is fairly arbitrary. This seems to now be actually affecting
some BSM samples that are being generated.
Changing the check to use float minimum, because I fear these weights
are cast into floats at some point in the analysis chain even if they
aren't right here in this class. Also printing a warning in case the
weight is between double and float mins, to at least tell the user
what's happening a bit more clearly.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41413User/jahreda/truth jet filter update 21.6 (fix missing filter)2021-03-10T03:06:25+01:00Jahred Adelmanjahreda@gmail.comUser/jahreda/truth jet filter update 21.6 (fix missing filter)The new branch that I added last week that got merged was of course missing a line, and the debug statements weren't enough of a cross check. I now ran a small JZ3 check and I get the phi values expected (0.3-0.5) Apologies!
![hpt](/up...The new branch that I added last week that got merged was of course missing a line, and the debug statements weren't enough of a cross check. I now ran a small JZ3 check and I get the phi values expected (0.3-0.5) Apologies!
![hpt](/uploads/c70c4aaa4e6610ec186557d823e8cdec/hpt.png)
![hleadphi](/uploads/61a69d5d2862a6b5dbeb7cf6cf1874d2/hleadphi.png)
![hleadpt](/uploads/0259a1a95f2c0061bace13c5eeda9dc3/hleadpt.png)
![hphi](/uploads/9068a0c96f0b0c973a82d7fd8215002a/hphi.png)
It works as expected and it's a small update. Merci!
-jahredhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/41412TrackParticleAthenaPool: Incease test timeout.2021-03-10T03:02:58+01:00Scott SnyderTrackParticleAthenaPool: Incease test timeout.Increase slightly the timeout for the TrackParticleTPCnv_16.6.3 test.
It has been timing out frequently in dbg builds.Increase slightly the timeout for the TrackParticleTPCnv_16.6.3 test.
It has been timing out frequently in dbg builds.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41411Update ERROR message2021-03-09T14:33:01+01:00Edward DiehlUpdate ERROR messageMdtCalibDbAlg.cxx => Change error message; no longer skip sMDT BIS7
MuonFixedIdUnpack.py => Decode tube numbers > 99 (e.g. sMDT BIS7)MdtCalibDbAlg.cxx => Change error message; no longer skip sMDT BIS7
MuonFixedIdUnpack.py => Decode tube numbers > 99 (e.g. sMDT BIS7)https://gitlab.cern.ch/atlas/athena/-/merge_requests/41410TrigFastTrackFinder: Fix clang warning.2021-03-10T03:03:39+01:00Scott SnyderTrigFastTrackFinder: Fix clang warning.No-op statement. Deliberately left commented-out for now.No-op statement. Deliberately left commented-out for now.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41409ISF_ActsTools+TrigT1MuctpiPhase1: Fix clang warnings.2021-03-10T03:03:26+01:00Scott SnyderISF_ActsTools+TrigT1MuctpiPhase1: Fix clang warnings.Missing override keywords.
Unused private data members.Missing override keywords.
Unused private data members.https://gitlab.cern.ch/atlas/athena/-/merge_requests/41408TrigT2BeamSpot: Fix clang warnings.2021-03-09T03:04:31+01:00Scott SnyderTrigT2BeamSpot: Fix clang warnings.Braces in initializers.Braces in initializers.