athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2020-04-24T19:46:33+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/32326FastCaloSim: Update test reference file.2020-04-24T19:46:33+02:00Scott SnyderFastCaloSim: Update test reference file.For magfield changes.For magfield changes.https://gitlab.cern.ch/atlas/athena/-/merge_requests/32353WIP: Fix rare bug in jet smearing RNG seed2020-04-24T15:40:18+02:00William Keaton BalunasWIP: Fix rare bug in jet smearing RNG seedThis fixes a bug affecting the smearing step of jet calibration for jets with eta values very close to zero (roughly |eta| < 1e-5). These jets would result in passing an argument of 0 to TRandom3, which is a special value resulting in no...This fixes a bug affecting the smearing step of jet calibration for jets with eta values very close to zero (roughly |eta| < 1e-5). These jets would result in passing an argument of 0 to TRandom3, which is a special value resulting in nondeterministic behavior. This simply adds an offset to the seed so that this can't happen anymore.
Note that this will change the output for smearing of **all** jets with respect to previous versions. This is fine, but anyone doing precise validation checks, CI tests, etc. should be aware of it.
This has already been fixed in master, so no sweep is needed.
Tagging @sschramm, @cdelitzs, @sawyer for their info - we should probably make analysis groups at large aware of this, it came up because a SUSY analysis noticed the effect in one of their CI tests.https://gitlab.cern.ch/atlas/athena/-/merge_requests/28949WIP: setup HI menus for run3 ( ATR-20673 )2020-04-24T15:39:14+02:00Ligang XiaWIP: setup HI menus for run3 ( ATR-20673 )Two menus:
- PhysicsP1_HI_run3_v1: the same chains in Physics_pp_run3_v1 + HLT_mu4_L1MU4
- Dev_HI_run3_v1: empty, but import menu from PhysicsP1_HI_run3_v1 Two menus:
- PhysicsP1_HI_run3_v1: the same chains in Physics_pp_run3_v1 + HLT_mu4_L1MU4
- Dev_HI_run3_v1: empty, but import menu from PhysicsP1_HI_run3_v1 https://gitlab.cern.ch/atlas/athena/-/merge_requests/31863WIP: MM stereo strips fix2020-04-24T15:18:17+02:00Stefano RosatiWIP: MM stereo strips fixFix in the local position of the MM stereo stripsFix in the local position of the MM stereo stripshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/31821Trigger: Added several new variables to B-Jet Trigger Online Monitoring (ATR-...2020-04-23T08:59:56+02:00Chris MilkeTrigger: Added several new variables to B-Jet Trigger Online Monitoring (ATR-20301)In response to https://its.cern.ch/jira/browse/ATR-20301:
Several new monitored variables have been added to the TrigBtagFexMT_OnlineMonitoring folder of expert-monitoring.root. In addition to the original jet_pt, the list of produced h...In response to https://its.cern.ch/jira/browse/ATR-20301:
Several new monitored variables have been added to the TrigBtagFexMT_OnlineMonitoring folder of expert-monitoring.root. In addition to the original jet_pt, the list of produced histograms now includes:
* jet_count
* jet_eta
* track_count
* track_d0err
* track_d0sig
* track_d0
* track_eta
* track_Et
* track_phi
* track_phi_vs_track_eta
* track_z0err
* track_z0
* track_z0sig
* vertex_count
This commit was tested using the "runTrigART.py -m -j4" test, and the "ctest -j4" test, and successfully passed both.https://gitlab.cern.ch/atlas/athena/-/merge_requests/32191GeneratorModules: Update for python Configurable changes.2020-04-22T21:12:43+02:00Scott SnyderGeneratorModules: Update for python Configurable changes.name is no longer a method.name is no longer a method.https://gitlab.cern.ch/atlas/athena/-/merge_requests/32265WIP: Proof that HDF5Utils will build2020-04-22T17:25:50+02:00Dan GuestWIP: Proof that HDF5Utils will buildThis should **absolutely not** be merged. It's just a hacked together proof of principal to show that https://gitlab.cern.ch/atlas/athena/-/merge_requests/32267 will work once we update `atlasexternals`.This should **absolutely not** be merged. It's just a hacked together proof of principal to show that https://gitlab.cern.ch/atlas/athena/-/merge_requests/32267 will work once we update `atlasexternals`.https://gitlab.cern.ch/atlas/athena/-/merge_requests/32183WIP: Cherry pick HDF5Utils to 21.92020-04-22T12:35:23+02:00Dan GuestWIP: Cherry pick HDF5Utils to 21.9This is a cherry pick of code from `master`, to the extent that it was possible. Some other packages that were merged more "manually" (i.e. by copying files) caused conflicts so I had to resolve a bit by hand.
The commits add `HDF5Uti...This is a cherry pick of code from `master`, to the extent that it was possible. Some other packages that were merged more "manually" (i.e. by copying files) caused conflicts so I had to resolve a bit by hand.
The commits add `HDF5Utils` and should give something which is identical to that in `master`.
Note that this also requires turning on HDF5 in `AthenaExternals`. This is a first: we don't currently build HDF5 in the 21 releases of Athena (only AthAnalysis and AnalysisBase), and in release 22 the version that comes with LCG is modern enough.https://gitlab.cern.ch/atlas/athena/-/merge_requests/32230thread-safe CSCcablingSvc2020-04-21T20:52:01+02:00Ke Lithread-safe CSCcablingSvcUse thread-safe atomic variable to replace the mutable variables in CSCablingSvc.Use thread-safe atomic variable to replace the mutable variables in CSCablingSvc.https://gitlab.cern.ch/atlas/athena/-/merge_requests/32188TrigCommon: Move flake8 checking from test to install.2020-04-21T13:45:27+02:00Scott SnyderTrigCommon: Move flake8 checking from test to install.Avoid timeouts.Avoid timeouts.https://gitlab.cern.ch/atlas/athena/-/merge_requests/32213Update checklog ignore patterns for GaudiConfig2 related issue2020-04-21T11:10:02+02:00Rafal Bielskirafal.bielski@cern.chUpdate checklog ignore patterns for GaudiConfig2 related issueFollow up from !31884 which introduced a fairly harmless issue which has to be ignored until fixed, as discussed in https://gitlab.cern.ch/atlas/athena/-/merge_requests/31884#note_3361194. This fixes two failing TrigP1Test tests which we...Follow up from !31884 which introduced a fairly harmless issue which has to be ignored until fixed, as discussed in https://gitlab.cern.ch/atlas/athena/-/merge_requests/31884#note_3361194. This fixes two failing TrigP1Test tests which were not covered by !31884 and makes the existing pattern more specific to match only this single problem and avoid masking other issues.
We have a ticket ATR-21246 open as a reminder to remove these ignore patterns once the issue is fixed.https://gitlab.cern.ch/atlas/athena/-/merge_requests/3217421.9 - Bug fix for test stream creation in RD53BEncodingTool2020-04-20T14:43:27+02:00Noemi Calace21.9 - Bug fix for test stream creation in RD53BEncodingToolNoemi CalaceNoemi Calacehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/32173H7 lhe interface2020-04-20T14:40:46+02:00Andrea Helen KnueH7 lhe interfaceWhen interfacing LHE events from aMC@NLO with Herwig72, the option "set /Herwig/Shower/KinematicsReconstructor:FinalStateReconOption Default" has to be disabled, because it does not exist any longer. Therefore I added a new file Herwig72...When interfacing LHE events from aMC@NLO with Herwig72, the option "set /Herwig/Shower/KinematicsReconstructor:FinalStateReconOption Default" has to be disabled, because it does not exist any longer. Therefore I added a new file Herwig72ConfigLHEF.py where this line is disabled. More info is given in AGENE-1846 .https://gitlab.cern.ch/atlas/athena/-/merge_requests/31647Add low-pT working point on the same footing as high-pT in muon quality variable2020-04-20T07:28:09+02:00Magnar Kopangen BuggeAdd low-pT working point on the same footing as high-pT in muon quality variableThis MR adds the functionality to store the low-pT working point decision in a bit in the muon quality variable. This should be a straightforward extension of what is already done for the "ID hits" and high-pT working point decisions. Th...This MR adds the functionality to store the low-pT working point decision in a bit in the muon quality variable. This should be a straightforward extension of what is already done for the "ID hits" and high-pT working point decisions. The corresponding set method in the MuonSelectionTool has been uncommented.
Tagging @nkoehler, @gartoni, @szambitohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/32142Revert "Merge branch 'TriggerMenuXMLBASH-master-20200416' into 'master'"2020-04-19T08:20:05+02:00Adam Edward BartonRevert "Merge branch 'TriggerMenuXMLBASH-master-20200416' into 'master'"This reverts merge request !32066This reverts merge request !32066https://gitlab.cern.ch/atlas/athena/-/merge_requests/31844TrigEDMConfig+TriggerMenuMT: Move EventBuildingInfo from TriggerMenuMT to Tri...2020-04-16T20:47:47+02:00Scott SnyderTrigEDMConfig+TriggerMenuMT: Move EventBuildingInfo from TriggerMenuMT to TrigEDMConfig.Clean up dependencies: TriggerMenuMT depends on TrigEDMConfig,
so we don't want TrigEDMConfig depending on TriggerMenuMT.Clean up dependencies: TriggerMenuMT depends on TrigEDMConfig,
so we don't want TrigEDMConfig depending on TriggerMenuMT.https://gitlab.cern.ch/atlas/athena/-/merge_requests/31988xAODMuon: Generate ElementLink dictionary for xAOD::MuonContainer.2020-04-16T17:57:04+02:00Scott SnyderxAODMuon: Generate ElementLink dictionary for xAOD::MuonContainer.Avoid auto-parsing, which was seen to casue crashes in 6.20.02.
See !31633.Avoid auto-parsing, which was seen to casue crashes in 6.20.02.
See !31633.https://gitlab.cern.ch/atlas/athena/-/merge_requests/31890WIP: FTAG - PCBT fix with fine maps2020-04-16T15:44:10+02:00Manuel GuthWIP: FTAG - PCBT fix with fine mapsFollowing the JIRA AFT-491 we agreed on changing the ftag software to fix this issue
pinging here @mstamenk @fdibello @cpollard @cschiavi @filthautFollowing the JIRA AFT-491 we agreed on changing the ftag software to fix this issue
pinging here @mstamenk @fdibello @cpollard @cschiavi @filthauthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/32047WIP: adding example config file for AnalysisTop2020-04-16T11:38:38+02:00Marco VanadiaWIP: adding example config file for AnalysisTopsimple MR to add a new example config file for AnalysisTop and fix a small problem with default configsimple MR to add a new example config file for AnalysisTop and fix a small problem with default confighttps://gitlab.cern.ch/atlas/athena/-/merge_requests/31283Assorted python 3 fixes2020-04-16T09:49:09+02:00Walter LamplAssorted python 3 fixesPython 3 fixes for 3 packages.
Aside: The code in CSCCalibAlgs looks really obsolete (hardwired castor commands)Python 3 fixes for 3 packages.
Aside: The code in CSCCalibAlgs looks really obsolete (hardwired castor commands)