athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2019-05-18T03:01:50+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/23414Muon ms-only trigger2019-05-18T03:01:50+02:00Savanna ShawMuon ms-only triggerAdding muon ms-only trigger to menu with empty step in place to be able to run this chain along with other muon chains.Adding muon ms-only trigger to menu with empty step in place to be able to run this chain along with other muon chains.https://gitlab.cern.ch/atlas/athena/-/merge_requests/23472Fix const correctness in TileGeoG4SDCalc2019-05-18T03:02:13+02:00Siarhei HarkushaFix const correctness in TileGeoG4SDCalcTileGeoG4SDCalc has been marked for checking tread safety
and const correctness found by checker has been fixed.TileGeoG4SDCalc has been marked for checking tread safety
and const correctness found by checker has been fixed.https://gitlab.cern.ch/atlas/athena/-/merge_requests/23455Master fix refitalg2019-05-18T03:01:59+02:00Edward MoyseMaster fix refitalgFixes for unchecked SC as mentioned in ATLASRECTS-4931.
Also did a bit of cleanup of the code to make it a little more readable. I also removed a deprecated jobProperty.
I added the jobOptions to RecExRecoTest, but haven't made th...Fixes for unchecked SC as mentioned in ATLASRECTS-4931.
Also did a bit of cleanup of the code to make it a little more readable. I also removed a deprecated jobProperty.
I added the jobOptions to RecExRecoTest, but haven't made this a proper ART test (ping @mhodgkin )https://gitlab.cern.ch/atlas/athena/-/merge_requests/23463Extend StreamSelectorTool to enable vetoing2019-05-18T03:02:16+02:00Jack CranshawExtend StreamSelectorTool to enable vetoing- Add 'VetoStreams' capability to StreamSelectorTool.
- Change property 'SelectedStreams' to 'AcceptStreams' to mirror
FilteredAlgorithm interface.- Add 'VetoStreams' capability to StreamSelectorTool.
- Change property 'SelectedStreams' to 'AcceptStreams' to mirror
FilteredAlgorithm interface.https://gitlab.cern.ch/atlas/athena/-/merge_requests/23456Including MET pufit chain in TMMT2019-05-18T03:02:03+02:00Antonia StrubigIncluding MET pufit chain in TMMTAdding tcpufit chain to LS2_v1.py including menu sequences, using a dictionary for MET chain assembly. Update of runMenuTest.ref. (ATR-19522)
Development for tcpufit + mht commented out for now as there were some problems, it'll go into ...Adding tcpufit chain to LS2_v1.py including menu sequences, using a dictionary for MET chain assembly. Update of runMenuTest.ref. (ATR-19522)
Development for tcpufit + mht commented out for now as there were some problems, it'll go into another MR.
ctest passed.
Tagging @bernius for information and @ggallard for MET AthenaMT.https://gitlab.cern.ch/atlas/athena/-/merge_requests/23508manually migrate the cell-time cut in TopoCluster from 21.0 to master2019-05-18T03:01:54+02:00Walter Lamplmanually migrate the cell-time cut in TopoCluster from 21.0 to masterThe MR 8046 (by @mspalla) in the athenaprivate1 repo was never swept to master. Doing this now in an entirely manual way. The code of CaloTopoClusterMaker has deviated so much from 21.0 that a patch file didn't work any more. This is mos...The MR 8046 (by @mspalla) in the athenaprivate1 repo was never swept to master. Doing this now in an entirely manual way. The code of CaloTopoClusterMaker has deviated so much from 21.0 that a patch file didn't work any more. This is mostly due to the CaloNoiseTool -> CondAlgo migration and the cleanup done at the same time.https://gitlab.cern.ch/atlas/athena/-/merge_requests/2352021.6 ChrisG update Rivet/YODA versions2019-05-17T22:39:17+02:00Christian Gutschow21.6 ChrisG update Rivet/YODA versionsUpdate Rivet to latest 2.7.1 release, YODA to latest 1.7.5.
FYI: @ewelina @chaysUpdate Rivet to latest 2.7.1 release, YODA to latest 1.7.5.
FYI: @ewelina @chayshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/23497New JO files to run standard btagging reco from ESD2019-05-20T03:01:49+02:00Emmanuel Le GuirriecNew JO files to run standard btagging reco from ESDTo allow ART tests in single mode and MT (threads = 1 and 2)To allow ART tests in single mode and MT (threads = 1 and 2)https://gitlab.cern.ch/atlas/athena/-/merge_requests/23335EventView configuration check for event-level algorithm reuse2019-05-20T22:28:20+02:00Benjamin Michael WynneEventView configuration check for event-level algorithm reusePrompted by a comment from @tbold, added a config-time check for the error noticed in https://its.cern.ch/jira/browse/ATR-19731
An algorithm running in two separate views is no problem, since these views have isolated algorithm states. ...Prompted by a comment from @tbold, added a config-time check for the error noticed in https://its.cern.ch/jira/browse/ATR-19731
An algorithm running in two separate views is no problem, since these views have isolated algorithm states. However, the whole-event level algorithm states are copied into a view sub-slot when it is initialised, and so algorithms that have already run at the whole-event level will not run within the view.
This change identifies configurations where whole-event level algorithms are scheduled within EventViews, throws an error, and exits.Benjamin Michael WynneBenjamin Michael Wynnehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/23507Move initialization to header files (SCT_ConditionsTools)2019-05-20T03:01:57+02:00Susumu OdaMove initialization to header files (SCT_ConditionsTools)Move initialization to header files in SCT_ConditionsTools package to collect initialization in one place.
RunTier0Tests.py was fine. [RunTier0Tests.log](/uploads/d84d2c6bb439a7bce21147b90ba992a1/RunTier0Tests.log)Move initialization to header files in SCT_ConditionsTools package to collect initialization in one place.
RunTier0Tests.py was fine. [RunTier0Tests.log](/uploads/d84d2c6bb439a7bce21147b90ba992a1/RunTier0Tests.log)https://gitlab.cern.ch/atlas/athena/-/merge_requests/23509Update to post processing of pflow test with one thread2019-05-20T03:01:47+02:00Mark HodgkinsonUpdate to post processing of pflow test with one threadUpdate CMakeLists.txt to put all the new test executable scripts into paths.
Update pflow test with one thread to get the psotprocessing script via central paths.Update CMakeLists.txt to put all the new test executable scripts into paths.
Update pflow test with one thread to get the psotprocessing script via central paths.https://gitlab.cern.ch/atlas/athena/-/merge_requests/23504Add Tile job configuration flags for Run 32019-05-20T03:01:52+02:00Siarhei HarkushaAdd Tile job configuration flags for Run 3https://gitlab.cern.ch/atlas/athena/-/merge_requests/22767Log-linear binning and compiled postprocessing executable for InDetPhysValMon...2019-05-20T10:15:56+02:00Maximilian Emanuel Goblirsch-KolbLog-linear binning and compiled postprocessing executable for InDetPhysValMonitoring ITk resolutionsThis MR implements a version of the log-linear binning used for the IDPVM ITk resolutions in the 20.20 release family in 21.9.
This fixes pathological resolution results for low- and high-pt single particle samples observed when the ...This MR implements a version of the log-linear binning used for the IDPVM ITk resolutions in the 20.20 release family in 21.9.
This fixes pathological resolution results for low- and high-pt single particle samples observed when the resolution approaches the histogram bin size or exceeds the histogram axis range.
In addition, the vmem requirement of an IDPVM run on Step 2.2 ITk ttbar MC is reduced by approximately 25%.
The non-linear binning results in a time increase per event on the order of 10%, since the ROOT bin lookup is slower for variable axis binnings.
The implementation of variable bin sizes in the `Book` methods of TrkValHistUtils was carried out in a way that should hopefully avoid collisions with the existing signatures, which were a problem in release 20.20.
A helper method to define log-linear binnings was added to the `InDetPlotBase` class, where it might be of use to other clients too.
In addition, the MR turns the postprocessing script, which was so far manually compiled in a shell script, into an executable built with the package by cmake and available from the release. The current version is a placeholder, which @lmijovic will eventually update to the final version.
Adding @lmijovic, @nstyles, @npetters in case they already have comments.https://gitlab.cern.ch/atlas/athena/-/merge_requests/23539InDetPhysValMonitoring: Fix gcc9 warnings2019-05-21T03:02:14+02:00Scott SnyderInDetPhysValMonitoring: Fix gcc9 warningswarnings:
- Unused local typedef.
- Using std::move in a return statement.warnings:
- Unused local typedef.
- Using std::move in a return statement.https://gitlab.cern.ch/atlas/athena/-/merge_requests/23541InDetPrepRawDataToxAOD: Fix clang warnings.2019-05-21T03:02:09+02:00Scott SnyderInDetPrepRawDataToxAOD: Fix clang warnings.clang warnings: missing override keywords.clang warnings: missing override keywords.https://gitlab.cern.ch/atlas/athena/-/merge_requests/23542AnalysisTriggerAlgs: Fix clang warning.2019-05-21T03:01:47+02:00Scott SnyderAnalysisTriggerAlgs: Fix clang warning.clang warning: unused variable.clang warning: unused variable.https://gitlab.cern.ch/atlas/athena/-/merge_requests/23544tauRecTools: Fix clang warning.2019-05-21T03:02:02+02:00Scott SnydertauRecTools: Fix clang warning.clang warning: unused private data member.clang warning: unused private data member.https://gitlab.cern.ch/atlas/athena/-/merge_requests/23545SCT_Monitoring: Fix clang warnings.2019-05-21T03:01:58+02:00Scott SnyderSCT_Monitoring: Fix clang warnings.Clang warnings: unused private data members.Clang warnings: unused private data members.https://gitlab.cern.ch/atlas/athena/-/merge_requests/23546MuonByteStream: Change printout of CscRawDataProvider::DoSeededDecoding to VE...2019-05-21T03:01:59+02:00Scott SnyderMuonByteStream: Change printout of CscRawDataProvider::DoSeededDecoding to VERBOSE.Remove unneeded verbosity.
Fixes unit test failures in MuonConfig.Remove unneeded verbosity.
Fixes unit test failures in MuonConfig.https://gitlab.cern.ch/atlas/athena/-/merge_requests/23540Define non-const surface method and change CachedUniquePtr to CachedUniquePtr...2019-05-21T03:02:19+02:00Susumu OdaDefine non-const surface method and change CachedUniquePtr to CachedUniquePtrT to fix ATLASRECTS-4957.Define non-const surface method and change CachedUniquePtr to CachedUniquePtrT to fix ATLASRECTS-4957.
This MR replaces MR !23535.Define non-const surface method and change CachedUniquePtr to CachedUniquePtrT to fix ATLASRECTS-4957.
This MR replaces MR !23535.