athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2020-03-03T03:02:21+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/30765AthenaPoolMultiTest: Avoid AttributeList copy.2020-03-03T03:02:21+01:00Scott SnyderAthenaPoolMultiTest: Avoid AttributeList copy.Copying an AttributeList is potentially not thread-safe.
Fix an instance of that here (which was also a memory leak!).Copying an AttributeList is potentially not thread-safe.
Fix an instance of that here (which was also a memory leak!).https://gitlab.cern.ch/atlas/athena/-/merge_requests/30764OutputStreamAthenaPool: Avoid AttributeList copies.2020-03-03T03:02:34+01:00Scott SnyderOutputStreamAthenaPool: Avoid AttributeList copies.Pending thread-safety checker changes warn about potentially unsafe
copies of coral::AttributeList. Avoid that here.Pending thread-safety checker changes warn about potentially unsafe
copies of coral::AttributeList. Avoid that here.https://gitlab.cern.ch/atlas/athena/-/merge_requests/30763RDBAccessSvc: Avoid directly AttributeList copy.2020-03-03T03:02:23+01:00Scott SnyderRDBAccessSvc: Avoid directly AttributeList copy.Copying an AttributeList may not be thread-safe.
Rewrite a copy here to avoid any sharing between the original
and the copy, to try to avoid thread-safety problems.Copying an AttributeList may not be thread-safe.
Rewrite a copy here to avoid any sharing between the original
and the copy, to try to avoid thread-safety problems.https://gitlab.cern.ch/atlas/athena/-/merge_requests/30762xAODCore: Fix undefined shift.2020-03-03T03:02:13+01:00Scott SnyderxAODCore: Fix undefined shift.If m_mantissaBits is 23, then the shift here
```
m_rounding = 0x1 << ( 32 - (1 + 8 + m_mantissaBits) - 1 );
```
is -1. This is undefined and gets an ubsan warning.
Try to fix.If m_mantissaBits is 23, then the shift here
```
m_rounding = 0x1 << ( 32 - (1 + 8 + m_mantissaBits) - 1 );
```
is -1. This is undefined and gets an ubsan warning.
Try to fix.https://gitlab.cern.ch/atlas/athena/-/merge_requests/30761LArRecUtils: Python 3 / flake8 fixes2020-03-03T03:02:15+01:00Scott SnyderLArRecUtils: Python 3 / flake8 fixesUpdate to work with python 3.
Also add flake8 checking and fix warnings.Update to work with python 3.
Also add flake8 checking and fix warnings.https://gitlab.cern.ch/atlas/athena/-/merge_requests/30760LArBadChannelTool: Python 3 / flake8 fixes2020-03-03T03:02:09+01:00Scott SnyderLArBadChannelTool: Python 3 / flake8 fixesUpdate to work with python 3.
Also add flake8 checking and fix warnings.Update to work with python 3.
Also add flake8 checking and fix warnings.https://gitlab.cern.ch/atlas/athena/-/merge_requests/30759tauRec/tauRecTools: use unique pointer to manage memory (ATLASRECTS-5155)2020-03-04T03:02:19+01:00Xiaozhong HuangtauRec/tauRecTools: use unique pointer to manage memory (ATLASRECTS-5155)To fix the memory leak (small) in tau reconstruction, we now use unique pointer to manage memory of ROOT objects, BDT reader, and containers.To fix the memory leak (small) in tau reconstruction, we now use unique pointer to manage memory of ROOT objects, BDT reader, and containers.https://gitlab.cern.ch/atlas/athena/-/merge_requests/30758Tile overlay new-style config and updates2020-03-05T03:02:40+01:00Tadej Novaktadej.novak@cern.chTile overlay new-style config and updatesEnable new-style configuration for tile overlay both for MC and data.
While at it also migrated to using `TileDQstatusAlg`.
/cc @solodkov @harkusha @jchapman @rtombsEnable new-style configuration for tile overlay both for MC and data.
While at it also migrated to using `TileDQstatusAlg`.
/cc @solodkov @harkusha @jchapman @rtombshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/30757OverlayCopyAlgs: properly handle data overlay2020-03-03T03:02:33+01:00Tadej Novaktadej.novak@cern.chOverlayCopyAlgs: properly handle data overlayCopy truth info from primary input in case of data overlay and from secondary in case of MC overlay.Copy truth info from primary input in case of data overlay and from secondary in case of MC overlay.https://gitlab.cern.ch/atlas/athena/-/merge_requests/30756Improve ByteStream handling for DoubleEventSelector2020-03-04T03:02:10+01:00Tadej Novaktadej.novak@cern.chImprove ByteStream handling for DoubleEventSelectorImprove ByteStream handling for `DoubleEventSelector`:
- unify attribute list names to be able to parse them using event loop managers
- always treat ByteStream as primary input to ensure proper event context generation
/cc @gemmeren ...Improve ByteStream handling for `DoubleEventSelector`:
- unify attribute list names to be able to parse them using event loop managers
- always treat ByteStream as primary input to ensure proper event context generation
/cc @gemmeren @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/30755DerivationFramework: MenuTruthThinning and HardTruthThinning for MT thinning.2020-03-04T03:02:54+01:00Scott SnyderDerivationFramework: MenuTruthThinning and HardTruthThinning for MT thinning.Convert MenuTruthThinning and HardTruthThinning to use MT-compatible thinning.
Update uses of them (pass stream name rather than thinning service).Convert MenuTruthThinning and HardTruthThinning to use MT-compatible thinning.
Update uses of them (pass stream name rather than thinning service).https://gitlab.cern.ch/atlas/athena/-/merge_requests/30754egamma monitoring with dual mode Run2/Run3 configuration2020-03-03T03:02:27+01:00Bertrand Laforgeegamma monitoring with dual mode Run2/Run3 configurationEgamma Performance package with a skeleton for Run III and the full set of run 2 algorithms too. I have setup a configuration file that should be able to have a dual use of either run2 or run3 setups.Egamma Performance package with a skeleton for Run III and the full set of run 2 algorithms too. I have setup a configuration file that should be able to have a dual use of either run2 or run3 setups.https://gitlab.cern.ch/atlas/athena/-/merge_requests/30753tauRecTools: Avoid potential null pointer dereference.2020-03-03T03:02:16+01:00Scott SnydertauRecTools: Avoid potential null pointer dereference.Fixes ubsan warning.Fixes ubsan warning.https://gitlab.cern.ch/atlas/athena/-/merge_requests/30752RecExAlgs: Python 3 / flake8 fixes2020-03-03T03:02:29+01:00Scott SnyderRecExAlgs: Python 3 / flake8 fixesUpdate to work with python 3.
Also add flake8 checking and fix warnings.Update to work with python 3.
Also add flake8 checking and fix warnings.https://gitlab.cern.ch/atlas/athena/-/merge_requests/30751MissingETGoodness: Python 3 fixes2020-03-03T03:02:19+01:00Scott SnyderMissingETGoodness: Python 3 fixesUpdate to work with python 3.Update to work with python 3.https://gitlab.cern.ch/atlas/athena/-/merge_requests/30750MissingETPerformance: Python 3 fixes2020-03-06T03:02:12+01:00Scott SnyderMissingETPerformance: Python 3 fixesUpdate to work with python 3.Update to work with python 3.https://gitlab.cern.ch/atlas/athena/-/merge_requests/30749JetValidation: Python 3 fixes2020-03-03T03:02:32+01:00Scott SnyderJetValidation: Python 3 fixesUpdate to work with python 3.Update to work with python 3.https://gitlab.cern.ch/atlas/athena/-/merge_requests/30745RootUtils: Work around clang 9 bug2020-03-03T03:02:30+01:00Scott SnyderRootUtils: Work around clang 9 bugclang 9 has a bug in compiling std::string::compare in some cases.
This causes it to crash while compiling the TClassEdit.h header from ROOT.
We don't use that header from very many places in Athena.
So, as a workaround, copy the header...clang 9 has a bug in compiling std::string::compare in some cases.
This causes it to crash while compiling the TClassEdit.h header from ROOT.
We don't use that header from very many places in Athena.
So, as a workaround, copy the header here. If we're not using clang 9,
then this just forwards to the ROOT header; otherwise, we read the
copy in RootUtils in which the compare() has been replaced with substr().
Change the #includes of TClassEdit.h to get it from RootUtils.
(Need to use a different name as well to avoid having to use the
non-standard include_next.)https://gitlab.cern.ch/atlas/athena/-/merge_requests/30744remove (obsolete) QuickAna package2020-03-04T03:02:44+01:00Nils Erik Krumnackremove (obsolete) QuickAna packageThis package is outdated and no longer supported. We may also remove
it in 21.2, but there is no point keeping it around in master.This package is outdated and no longer supported. We may also remove
it in 21.2, but there is no point keeping it around in master.https://gitlab.cern.ch/atlas/athena/-/merge_requests/30741Add a new test with ATLFASTIIF_G4MS simulator2020-04-29T03:04:16+02:00Tulay Cuhadar DonszelmannAdd a new test with ATLFASTIIF_G4MS simulatorAdding a new test in FastChain with ATLFASTIIF_G4MS simulator.
Discussed in https://its.cern.ch/jira/browse/ATLASSIM-4455
@jchapman, @vpascuzz.Adding a new test in FastChain with ATLFASTIIF_G4MS simulator.
Discussed in https://its.cern.ch/jira/browse/ATLASSIM-4455
@jchapman, @vpascuzz.