athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-19T14:22:45+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/69944Draft: Avoid additional ONNX thread spawning for FastCaloSim2024-03-19T14:22:45+01:00Joshua Falco Beirerjoshua.beirer@cern.chDraft: Avoid additional ONNX thread spawning for FastCaloSimhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66793Draft: Adding ART tests for four FastChain workflows2024-03-19T09:49:50+01:00Martina JavurkovaDraft: Adding ART tests for four FastChain workflowsAdding four ART tests for FastChain workflows which are planned to be run in production (using different MC campaigns).
* General setup
* MC21a ttbar sample
* CA-based configuration
* multiprocess mode
* Run 3 configuration
1....Adding four ART tests for FastChain workflows which are planned to be run in production (using different MC campaigns).
* General setup
* MC21a ttbar sample
* CA-based configuration
* multiprocess mode
* Run 3 configuration
1. Workflow
* ATLFAST3F_G4MS with MC-overlay
* running Sim_tf (Simulation), Reco_tf (Overlay+Trigger+Reconstruction) and Derivation_tf (Derivation)
* inputs: EVNT, RDO_BKG
* outputs: HITS, AOD, DAOD
2. Workflow
* ATLFAST3F_G4MS with MC-overlay
* running FastChain_tf (Simulation+Overlay+Trigger+Reconstruction+Derivation)
* inputs: EVNT, RDO_BKG
* output: AOD, DAOD
3. Workflow
* ATLFAST3F_G4MS with Track-overlay
* running Sim_tf (Simulation), Reco_tf (Overlay+Trigger+Reconstruction) and Derivation_tf (Derivation)
* inputs: EVNT, RDO_BKG
* outputs: HITS, AOD, DAOD
4. Workflow
* ATLFAST3F_G4MS with Track-overlay
* running FastChain_tf (Simulation+Overlay+Trigger+Reconstruction+Derivation)
* inputs: EVNT, RDO_BKG
* outputs: DAODhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66789Draft: Derivation step in FastChain transform2024-03-19T09:46:13+01:00Martina JavurkovaDraft: Derivation step in FastChain transformAdding derivation step to FastChain transform which allows FastChain to produce DAOD output files from EVNT input files without any intermediate files (HITS, RDO, AOD).Adding derivation step to FastChain transform which allows FastChain to produce DAOD output files from EVNT input files without any intermediate files (HITS, RDO, AOD).https://gitlab.cern.ch/atlas/athena/-/merge_requests/66510Draft: [AFT-676] Add GN2X support to the central FTAG tools2024-03-19T09:45:43+01:00Waltteri LeinonenDraft: [AFT-676] Add GN2X support to the central FTAG tools#### Work-in-progress
# Adding GN2X to FTAG Tools
This merge request aims to add support for running GN2X (and other jet-decoration-based central taggers), via JSON configuration files.
The benefits of this method of tagger configurati...#### Work-in-progress
# Adding GN2X to FTAG Tools
This merge request aims to add support for running GN2X (and other jet-decoration-based central taggers), via JSON configuration files.
The benefits of this method of tagger configuration are manyfold: namely, enabling analyses to use (as-of-yet un)calibrated taggers, which are available in DAOD and enabling flexible configuration of working points and labels.
More details will be covered here:
- https://indico.cern.ch/event/1330437/
- https://indico.cern.ch/event/1331900/https://gitlab.cern.ch/atlas/athena/-/merge_requests/64989Draft: all vector indexing in DuplicateSeedDetector2024-03-19T09:40:17+01:00Tim AdyeDraft: all vector indexing in DuplicateSeedDetectorAll vector indexing in `DuplicateSeedDetector`, no map
*(I reverted some unrelated changes, now in !65015)*All vector indexing in `DuplicateSeedDetector`, no map
*(I reverted some unrelated changes, now in !65015)*https://gitlab.cern.ch/atlas/athena/-/merge_requests/64122Draft: ATEAM-909: Try to lock flavor tagging decorations2024-03-19T09:39:44+01:00Dan GuestDraft: ATEAM-909: Try to lock flavor tagging decorationsI'm trying to prevent the bug we had in AFT-646 from happening again. In that bug, we were overwriting a decoration we saved on the `BTagging` object in a subsequent algorithm. This was allowed because the algorithm itself called another...I'm trying to prevent the bug we had in AFT-646 from happening again. In that bug, we were overwriting a decoration we saved on the `BTagging` object in a subsequent algorithm. This was allowed because the algorithm itself called another tool that added decorations, but those decorations were never locked.
This MR copies some code out of the `WriteDecorHandle` destructor to try to lock the derivations at the end of the algorithm.
-------
I've marked this MR as ready because it doesn't seem to break anything.
The only problem is that it doesn't work: I verified the `auxid` of the decorations that I'm adding, and verified that those `auxid` correspond to the ones I'm calling `lockDecoration` on. But I'm still allowed to overwrite the same decorations by calling two different versions of the same algorithm. I'm not sure if this is supposed to work, maybe @ssnyder can verify that this _should_ make altering the decoration further impossible.https://gitlab.cern.ch/atlas/athena/-/merge_requests/62169Draft: Demonstrator for Space Point BackEnd2024-03-19T09:39:05+01:00Carlo Varnicarlo.varni@cern.chDraft: Demonstrator for Space Point BackEndFirst implementation of the backend from the Athena side... need to go in tandem with ACTS PR
/cc @pagessin @tboldFirst implementation of the backend from the Athena side... need to go in tandem with ACTS PR
/cc @pagessin @tboldhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66315parabola sTGC positon reconstruction2024-03-19T09:35:19+01:00Michael Schernauparabola sTGC positon reconstructionAlternative to the weighted average position reconstruction for sTGC clusters: Find the peak of the cluster with a parabola defined by the strip with the largest charge and its left and right neighbor. Apply a non-linear correction funct...Alternative to the weighted average position reconstruction for sTGC clusters: Find the peak of the cluster with a parabola defined by the strip with the largest charge and its left and right neighbor. Apply a non-linear correction function to obtain the cluster position. Returns a result in all cases, no optional failure. Error conditions are encoded in PARABOLA_FLAGS, but not returned (yet). As a work-around, the flags are multiplied by 20 microns and added to the error estimate, but only for problem clusters. The position of the strip with the largest charge is returned in case of errors. Parameters positionResolution and angularResolution enter in the estimate of the error on the mean position.https://gitlab.cern.ch/atlas/athena/-/merge_requests/64948Added diff-root test to PHYS and PHYSLITE outputs2024-03-19T09:34:22+01:00Nurcan OzturkAdded diff-root test to PHYS and PHYSLITE outputsAdded diff-root test to PHYS and PHYSLITE outputs produced from the CPAlgorithms tests running in CI already
Discussed in https://its.cern.ch/jira/browse/ATLASG-2425Added diff-root test to PHYS and PHYSLITE outputs produced from the CPAlgorithms tests running in CI already
Discussed in https://its.cern.ch/jira/browse/ATLASG-2425https://gitlab.cern.ch/atlas/athena/-/merge_requests/68189Draft: FPGATrackSim -> AOD2024-03-18T16:41:51+01:00Federica PiazzaDraft: FPGATrackSim -> AODTool to convert FPGATrackSim output into xAOD format.
Trigger/EFTracking/FPGATrackConverterTool to convert FPGATrackSim output into xAOD format.
Trigger/EFTracking/FPGATrackConverterhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69900Fix VP1 crash when cleaning input paths2024-03-18T16:17:22+01:00Riccardo Maria Bianchiriccardo.maria.bianchi@cern.chFix VP1 crash when cleaning input pathsThis MR fixes a crash happenning when VP1 tries to clean the input paths where it looks for plugins and libraries.
That comes from the use of the `removeAll("string")` Qt5 method, which apparently has (and the Qt5 docs states that) unex...This MR fixes a crash happenning when VP1 tries to clean the input paths where it looks for plugins and libraries.
That comes from the use of the `removeAll("string")` Qt5 method, which apparently has (and the Qt5 docs states that) unexpected behavior when used within a loop.
I replaced that with a more standard `removeAt(idx)` method.
**NOTE:** we need this fix in 24.0 for P1 and for debugging DD. The MR is **NOT** output-changing, and no Athena packages depend on VP1, so it is safe to merge this in 24.0.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68810Draft: RootStorageSvc+RootAuxDynIO: Switch from RPageSource to RNTupleReader2024-03-18T15:35:07+01:00Alaettin Serhan MeteDraft: RootStorageSvc+RootAuxDynIO: Switch from RPageSource to RNTupleReaderThis MR goes back to using `RNTupleReader` instead of `RPageSource` for reading `RNTuple` objects. I also changed the way we read `index_ref` a bit to better utilize the intended API. Currently a draft for testing/review.
cc: @gemmeren ...This MR goes back to using `RNTupleReader` instead of `RPageSource` for reading `RNTuple` objects. I also changed the way we read `index_ref` a bit to better utilize the intended API. Currently a draft for testing/review.
cc: @gemmeren @mnowakAlaettin Serhan MeteAlaettin Serhan Metehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69638Add config to make Topo Towers at all eta2024-03-18T14:19:02+01:00Dylan Sheldon RankinAdd config to make Topo Towers at all etaThis MR adds a config that can be used to create topo towers without a restriction on eta while leaving the nominal forward topo towers untouched. This is needed for Upgrade studies/samples.
@mswiatlo @tmhong @sch @htorreThis MR adds a config that can be used to create topo towers without a restriction on eta while leaving the nominal forward topo towers untouched. This is needed for Upgrade studies/samples.
@mswiatlo @tmhong @sch @htorrehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69838Draft: Add a helper to condense a little code.2024-03-15T01:50:01+01:00Lucy LewittDraft: Add a helper to condense a little code.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69821Draft: 2024-03-14: merge of UNKNOWN into main2024-03-14T14:32:05+01:00Walter LamplDraft: 2024-03-14: merge of UNKNOWN into mainThis sweep contains the following MRs:
* !69294 ConfigBlock: change groupName, noneAction and duplicateAction ~Analysis, ~CPAlgorithms, ~Egamma, ~JetEtmiss, ~Tau, ~TriggerThis sweep contains the following MRs:
* !69294 ConfigBlock: change groupName, noneAction and duplicateAction ~Analysis, ~CPAlgorithms, ~Egamma, ~JetEtmiss, ~Tau, ~Triggerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69746Add configurable property for jet-fat-jet OR in OverlapAnalysisConfig2024-03-14T09:55:22+01:00Thomas StreblerAdd configurable property for jet-fat-jet OR in OverlapAnalysisConfigSelf-explanatorySelf-explanatoryhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69795Some updates to the LArSuperCell Monitoring...2024-03-14T08:55:16+01:00Denis Oliveira DamazioSome updates to the LArSuperCell Monitoring...fixes some details of the task, container names and updates file to be used.
@pavol might want to comment.fixes some details of the task, container names and updates file to be used.
@pavol might want to comment.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69762Draft: Various flag cleanup2024-03-13T20:06:09+01:00Dan GuestDraft: Various flag cleanupwork in progresswork in progresshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69537Draft: Delete legacy DumpGeo configs2024-03-13T14:51:10+01:00Thomas StreblerDraft: Delete legacy DumpGeo configshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69340Draft: TriggerMenuMT: centralize AccumulatorCache for steps and disable deepcopy2024-03-13T12:03:59+01:00Frank WinklmeierDraft: TriggerMenuMT: centralize AccumulatorCache for steps and disable deepcopyThis is a (for the moment) experimental change to the menu generation that should be discussed amongst experts and in a trigger core SW meeting.
Move the `AccumulatorCache` to the `getStep` method and remove it from the signature-specif...This is a (for the moment) experimental change to the menu generation that should be discussed amongst experts and in a trigger core SW meeting.
Move the `AccumulatorCache` to the `getStep` method and remove it from the signature-specific files. The actual change to review is in `ChainConfigurationBase.py` .
In addition, do not `deepcopy` the result of the sequence configuration (`ChainStep`) as it is not being re-used or modified afterwards. This was also the behavior of the original `RecoFragmentsPool` before it was migrated to `AccumulatorCache`. The deepcopy can be enabled again by setting `Trigger.fastMenuGeneration=False`.
**Reduces the menu generation time of Dev_pp_run3_v1 by a factor 2**. It does however introduce (harmless) changes in the order of some of the `HypoTools` and `InputMakerInputDecisions` properties. In case we decide to move forward with this we would definitely want to add an ART test that checks the configuration is equivalent with/without `fastMenuGeneration` (see this recent [confTool improvement](https://gitlab.cern.ch/atlas/athena/-/merge_requests/69329 "confTool: add ignoreOrder command line option")).
E.g. in the HI menu, the following properties change order (many more in the pp menu):
```plaintext
IM_EFMuMSReco_RoI.InputMakerInputDecisions
IM_L2MuCombReco.InputMakerInputDecisions
SPCountHypoAlg.HypoTools
TrigHIFwdGapHypoAlg.HypoTools
TrigL2MuCBHypoAlg.HypoTools
TrigL2MufastHypoAlg.HypoTools
TrigMuonEFCombinerHypoAlg.HypoTools
TrigMuonEFMSonlyHypo_RoI.HypoTools
```
cc @tbold @fpastore @tamartin
Relates to [ATR-26996](https://its.cern.ch/jira/browse/ATR-26996).