athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-28T11:33:00+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/70161Clean up TRT-only tracking pass flags2024-03-28T11:33:00+01:00Thomas StreblerClean up TRT-only tracking pass flagsEither setting those in place in the config or promoting them to global flags
Should reduce already by 7*31 the amount of tracking flags.
Similar clean ups to be expected in the near future.
Relevant for ATLASRECTS-7947Either setting those in place in the config or promoting them to global flags
Should reduce already by 7*31 the amount of tracking flags.
Similar clean ups to be expected in the near future.
Relevant for ATLASRECTS-7947https://gitlab.cern.ch/atlas/athena/-/merge_requests/70160fix Large R accessor in jet calibration2024-03-28T09:41:26+01:00Frederic Rennerfix Large R accessor in jet calibrationI ran into the issue that this [accessor|
https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/Reconstruction/Jet/JetUncertainties/Root/FlavourUncertaintyComponent.cxx#0368] needs to be non-static in order to work with several jet ca...I ran into the issue that this [accessor|
https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/Reconstruction/Jet/JetUncertainties/Root/FlavourUncertaintyComponent.cxx#0368] needs to be non-static in order to work with several jet calibrations that might need different truth labels. @khoo
https://its.cern.ch/jira/browse/ATLJETMET-1714https://gitlab.cern.ch/atlas/athena/-/merge_requests/70159TileTBRec: Remove legacy JO configurations (ATLASRECTS-7939)2024-03-28T10:50:40+01:00Siarhei HarkushaTileTBRec: Remove legacy JO configurations (ATLASRECTS-7939)Legacy JO configurations have been removed from TileTBRec package.Legacy JO configurations have been removed from TileTBRec package.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70157TileCosmicAlgs: Remove legacy JO configurations (ATLASRECTS-7939)2024-03-28T11:46:18+01:00Siarhei HarkushaTileCosmicAlgs: Remove legacy JO configurations (ATLASRECTS-7939)Legacy JO configurations have been removed from TileCosmicAlgs package.Legacy JO configurations have been removed from TileCosmicAlgs package.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70156Draft: write in-file metadata using RootKeyContainer2024-03-27T17:50:55+01:00Maciej Pawel SzymanskiDraft: write in-file metadata using RootKeyContainerAn experiment to check what's needed to switch metadata storage technologyAn experiment to check what's needed to switch metadata storage technologyhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70154athena.py: remove defaults for concurrency arguments (legacy)2024-03-28T08:35:04+01:00Frank Winklmeierathena.py: remove defaults for concurrency arguments (legacy)Remove the defaults of the `--threads`, `--concurrent-events` and
`--nprocs` command line arguments and update the code accordingly.
No change in behavior but makes it compatible with what we use in
CA-mode.
Only impacts legacy job opti...Remove the defaults of the `--threads`, `--concurrent-events` and
`--nprocs` command line arguments and update the code accordingly.
No change in behavior but makes it compatible with what we use in
CA-mode.
Only impacts legacy job options running.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70152Draft: barcode -> ID migration for HGTD/InDet/MuonDigitization (2nd attempt)2024-03-28T11:16:53+01:00John Derek ChapmanDraft: barcode -> ID migration for HGTD/InDet/MuonDigitization (2nd attempt)The first attempt at this !69655 caused issues in the case that pile-up background HITS with intact truth information and using a barcode-based persistent were read into a pile-up digitization job. In this case there was no way for the i...The first attempt at this !69655 caused issues in the case that pile-up background HITS with intact truth information and using a barcode-based persistent were read into a pile-up digitization job. In this case there was no way for the initial HepMcParticleLink member variables of the transient hit classes generated from the persistent classes to know whether they should be linking to an event other than the first event in the McEventCollection (The hard-scatter GenEvent is always first in the McEventCollection). This meant that calls to `HepMcParticleLink::id()` would return zero as the links often appear to be invalid.
This second version of the migration is less aggressive as it allows the possibility of barcode-based inputs. It avoids the issue seen in ATLSWUPGR-242 according to my local tests, but I will avoid marking the merge request as ready until we have a CI test to catch such an issue.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70150PyUtils: Make ##Params storage technology explicit2024-03-28T10:28:42+01:00Grigori RybkinPyUtils: Make ##Params storage technology explicitTools/PyUtils/python/AthFileLite.py: Extract file GUID in a more Pythonic way
Tools/PyUtils/python/MetaReader.py: idem
Related to ATEAM-960Tools/PyUtils/python/AthFileLite.py: Extract file GUID in a more Pythonic way
Tools/PyUtils/python/MetaReader.py: idem
Related to ATEAM-960https://gitlab.cern.ch/atlas/athena/-/merge_requests/70146Draft: Improve consistency of InDetSimEventTPCnv behaviour.2024-03-27T09:46:05+01:00John Derek ChapmanDraft: Improve consistency of InDetSimEventTPCnv behaviour.In recent updates to HepMcParticleLink, it was observed that the behaviour of `TRT_HitCollectionCnv_p4` and `SiHitCollectionCnv_p3`
differed from the behaviour of TP converter classes using `HepMcParticleLinkCnv_p2` directly.
This merge...In recent updates to HepMcParticleLink, it was observed that the behaviour of `TRT_HitCollectionCnv_p4` and `SiHitCollectionCnv_p3`
differed from the behaviour of TP converter classes using `HepMcParticleLinkCnv_p2` directly.
This merge request attempts to make the behaviour of `SiHitCollectionCnv_p3/4`and `TRT_HitCollectionCnv_p4/5`
consistent with `HepMcParticleLinkCnv_p2/3`.
Relates to ATLASSIM-6999.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70144PMGSystematicsTools: migrated from the legacy AthFile to MetaReader2024-03-28T08:53:43+01:00Vakhtang TsulaiaPMGSystematicsTools: migrated from the legacy AthFile to MetaReaderRelated to ATEAM-528Related to ATEAM-528https://gitlab.cern.ch/atlas/athena/-/merge_requests/70142Draft: HF classification added to PHYSLITE2024-03-26T22:26:43+01:00Abhishek SharmaDraft: HF classification added to PHYSLITEI'm adding the heavy flavour classification to PHYSLITE, backing up off work done for [PHYS](https://its.cern.ch/jira/browse/ATLASG-2374). The addition necessitated moving the extra variables list to the bottom of the script to allow for...I'm adding the heavy flavour classification to PHYSLITE, backing up off work done for [PHYS](https://its.cern.ch/jira/browse/ATLASG-2374). The addition necessitated moving the extra variables list to the bottom of the script to allow for easy adding of the variables HF_Classification and HF_SimpleClassification.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70140distinguish two steps with different name in muComb (ATR-29040)2024-03-28T10:35:24+01:00Francesca Pastoredistinguish two steps with different name in muComb (ATR-29040)https://gitlab.cern.ch/atlas/athena/-/merge_requests/70139Less verbose output from BTaggingEfficiencyTool2024-03-27T17:54:32+01:00Dan GuestLess verbose output from BTaggingEfficiencyToolWe should probably only print a lot of info if the user asks for a lot of info.We should probably only print a lot of info if the user asks for a lot of info.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70137[ATR-29000] Enable supercell output for Run 4 MC-MC overlay2024-03-27T10:52:15+01:00Tim Martin[ATR-29000] Enable supercell output for Run 4 MC-MC overlayFollows on from !68314
Applies the same change (`== Run 3` -> `>= Run 3`) also to the Overlay workflow.
cc @damazio, @pavolFollows on from !68314
Applies the same change (`== Run 3` -> `>= Run 3`) also to the Overlay workflow.
cc @damazio, @pavolhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70136Draft: Add possiblity to use Geant4 transport instead of ATLAS tracking tools...2024-03-27T18:52:44+01:00Joshua Falco Beirerjoshua.beirer@cern.chDraft: Add possiblity to use Geant4 transport instead of ATLAS tracking tools in FCS in G4https://gitlab.cern.ch/atlas/athena/-/merge_requests/70123Read jFEX calibration values from the database in MC2024-03-27T11:48:58+01:00Paul ThompsonRead jFEX calibration values from the database in MCTowards having the jFEX read database values from the DB also for MC.
The first version of the database values aim to replicate the results of the present hard coded defaults.
Allows to overwrite the DB values for MC during commissioning...Towards having the jFEX read database values from the DB also for MC.
The first version of the database values aim to replicate the results of the present hard coded defaults.
Allows to overwrite the DB values for MC during commissioning of the jFEX in 2024.https://gitlab.cern.ch/atlas/athena/-/merge_requests/701201) added all-event diagnostic histograms 2) deleted obsolete initializing file2024-03-27T10:59:48+01:00Yuhan Guo1) added all-event diagnostic histograms 2) deleted obsolete initializing file(cherry picked from commit 65b93be7fafcf0a250934ebd9876f0b1dbdb0191)
@steinber @bcole(cherry picked from commit 65b93be7fafcf0a250934ebd9876f0b1dbdb0191)
@steinber @bcolehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70119Draft: Improvements to truth vertex labelling2024-03-26T11:59:04+01:00Nikita Ivvan PondDraft: Improvements to truth vertex labellingThis MR will (eventually) aim to overhaul vertex labelling in flavour tagging. The idea is to start from a PV, iterate through the truth decays, and associated to features measured in the detector, rather than starting with tracks and wo...This MR will (eventually) aim to overhaul vertex labelling in flavour tagging. The idea is to start from a PV, iterate through the truth decays, and associated to features measured in the detector, rather than starting with tracks and working up. The hope is this will allow us to have vertex properties for a broader range of vertex types.
cc @svanstrohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70111CaloMonitoring: delete legacy job options and ROOT macros2024-03-28T10:46:26+01:00Frank WinklmeierCaloMonitoring: delete legacy job options and ROOT macrosDelete legacy job options, root macros and updates link dependencies.Delete legacy job options, root macros and updates link dependencies.Pavol StrizenecPavol Strizenechttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70110Draft: Template clustering alg2024-03-26T10:24:24+01:00Carlo Varnicarlo.varni@cern.chDraft: Template clustering algTemplate Clusterization alg on a bool (`useCache`) and then use `if constexpr` in the code
Also, move it to the `src/details` folderTemplate Clusterization alg on a bool (`useCache`) and then use `if constexpr` in the code
Also, move it to the `src/details` folder