athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-12T09:36:46+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/69686athena.py: remove athena-specific history and readline setup2024-03-12T09:36:46+01:00Frank Winklmeierathena.py: remove athena-specific history and readline setupRemove the code that customizes the athena command history and readline settings for interactive mode and just re-use what the user has setup for usual python prompts. This is another step in unifying the legacy/CA experience of athena.Remove the code that customizes the athena command history and readline settings for interactive mode and just re-use what the user has setup for usual python prompts. This is another step in unifying the legacy/CA experience of athena.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69661added ZBTopo to L1excluded thresholds (ATR-28938)2024-03-08T23:01:52+01:00Francesca Pastoreadded ZBTopo to L1excluded thresholds (ATR-28938)fix for trigger operation, see e-log: https://atlasop.cern.ch/elisa/display/536933 and related JIRA
tagging @shanischfix for trigger operation, see e-log: https://atlasop.cern.ch/elisa/display/536933 and related JIRA
tagging @shanischhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69587DQ sqlalchemy fixes backport (APR-130)2024-03-07T20:51:17+01:00Peter OnyisiDQ sqlalchemy fixes backport (APR-130)Backport oracle fixes from mainBackport oracle fixes from mainhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69563Fix for error "No TOBs found passing the threshold NSWMon" (ATR-28915)2024-03-06T19:09:12+01:00Francesca PastoreFix for error "No TOBs found passing the threshold NSWMon" (ATR-28915)added NSWMon as excluded L1 thresholds in HLTSeeding
@sfrancesadded NSWMon as excluded L1 thresholds in HLTSeeding
@sfranceshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69513Use config flags in analysis config2024-03-28T13:34:35+01:00Tadej Novaktadej.novak@cern.chUse config flags in analysis configMake config flags the main way to steer analysis config. This will help people working on analysis and Athena to feel at home and prevent accumulation of arguments of the `ConfigAccumulator`.
The naming is not fixed, I will probably als...Make config flags the main way to steer analysis config. This will help people working on analysis and Athena to feel at home and prevent accumulation of arguments of the `ConfigAccumulator`.
The naming is not fixed, I will probably also convert more items to flags. This is mainly to start the discussion and freeze the API as soon asp possible. I will probably then break this into multiple MRs.
Also some core flags should be renamed (see https://its.cern.ch/jira/browse/ATEAM-964).
Tagging @krumnack, @jolamber, @gwatts, @ekourlit for core AMG. Also tagging interested parties @ravinab, @omajersk, @tstreble, @khoo, @jchapman.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69485Avoid triggering ROOT #14156 (APR-130)2024-03-06T00:27:10+01:00Peter OnyisiAvoid triggering ROOT #14156 (APR-130)Do not do str(obj) in PyROOT, this will trigger a memory exhaustion
See: https://github.com/root-project/root/issues/14156Do not do str(obj) in PyROOT, this will trigger a memory exhaustion
See: https://github.com/root-project/root/issues/14156https://gitlab.cern.ch/atlas/athena/-/merge_requests/69481fix skip test if file not present, for 24.02024-03-06T00:27:10+01:00Tadej Novaktadej.novak@cern.chfix skip test if file not present, for 24.0fix skip test if file not present
Closes ATLASRECTS-7925
See merge request atlas/athena!69446
(cherry picked from commit d6d150a8befe748bee197d6f7717d286fbe5a22e)
469fdd30 skip test if file not present
d908f92a use default test filefix skip test if file not present
Closes ATLASRECTS-7925
See merge request atlas/athena!69446
(cherry picked from commit d6d150a8befe748bee197d6f7717d286fbe5a22e)
469fdd30 skip test if file not present
d908f92a use default test filehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69448ATLASDQ-1130 fix2024-03-04T23:05:03+01:00Peter OnyisiATLASDQ-1130 fix[R24 version] This fixes a failure in applying regex expressions for files retrieved from remote URLs instead of local files. This was triggered in production by ROOT 6.28 which replaces local EOS paths with xrootd URLs. Urgent for trigg...[R24 version] This fixes a failure in applying regex expressions for files retrieved from remote URLs instead of local files. This was triggered in production by ROOT 6.28 which replaces local EOS paths with xrootd URLs. Urgent for trigger DQ studies.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69447ATLASDQ-1130 fix2024-03-04T12:36:46+01:00Peter OnyisiATLASDQ-1130 fixThis fixes a failure in applying regex expressions for files retrieved from remote URLs instead of local files. This was triggered in production by ROOT 6.28 which replaces local EOS paths with xrootd URLs. Urgent for trigger DQ studies.This fixes a failure in applying regex expressions for files retrieved from remote URLs instead of local files. This was triggered in production by ROOT 6.28 which replaces local EOS paths with xrootd URLs. Urgent for trigger DQ studies.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69446fix skip test if file not present2024-03-04T22:17:00+01:00Ruggero Turrafix skip test if file not presentthe skip decorator was not effective since in Python `TFile::Open` raises an exception if the file is not present. The test was failing if the file was not present, while it should have been skipped.
Also, move to a default test file (o...the skip decorator was not effective since in Python `TFile::Open` raises an exception if the file is not present. The test was failing if the file was not present, while it should have been skipped.
Also, move to a default test file (on cvmfs).
Closes ATLASRECTS-7925
Labelling as urgent since this is breaking nightlies since the file was deleted by mistake.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69399ATR-28836 - ATR-28871 - Assorted Menu actions for Delayed Jet signature2024-03-04T13:13:36+01:00Marco MontellaATR-28836 - ATR-28871 - Assorted Menu actions for Delayed Jet signatureAdded Mongroup to delayed jet triggers and added reference chains for delayed jet signature in Dev Menu
*Edited to indicate the trigger signature more precisely -- unfortunately too late for the commit.*Added Mongroup to delayed jet triggers and added reference chains for delayed jet signature in Dev Menu
*Edited to indicate the trigger signature more precisely -- unfortunately too late for the commit.*https://gitlab.cern.ch/atlas/athena/-/merge_requests/69397ATR-28888 -- Reimplement End-of-Event processing in HLT2024-03-01T20:36:12+01:00Teng Jian KhooATR-28888 -- Reimplement End-of-Event processing in HLTWe operate LAr noise burst detection and MET trigger reconstruction for monitoring in events accepted by the HLT. This sequence was lost in the CA menu generation refactoring, so reintroducing it here.
It fits more naturally in `Generat...We operate LAr noise burst detection and MET trigger reconstruction for monitoring in events accepted by the HLT. This sequence was lost in the CA menu generation refactoring, so reintroducing it here.
It fits more naturally in `GenerateMenuMT.py` than where it was previously in `HLTCFConfig.py`. Arguably even more apt [here](https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/Trigger/TriggerCommon/TriggerJobOpts/python/TriggerConfig.py#0669) in `TriggerConfig.py` c.f. an old TODO note, but that option would require us to separately extract the `chainDicts`.
Sequence doesn't seem to be added correctly to `HLTFinalizeSeq` currently, needs more debugging.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69396Update ThinCAWrapper.sh - also allow scripts to be located in the joboption...2024-03-04T10:07:36+01:00Will ButtingerUpdate ThinCAWrapper.sh - also allow scripts to be located in the joboption...Update ThinCAWrapper.sh - also allow scripts to be located in the joboption path instead of the python path.Update ThinCAWrapper.sh - also allow scripts to be located in the joboption path instead of the python path.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69390Adding the old calratio triggers to the Physics Menu2024-03-06T00:27:10+01:00Tatiana OvsiannikovaAdding the old calratio triggers to the Physics Menureverse naming of the calratio algorithm (calrtold->calratio, calratio->calratiovar) and move old calratio chains with additional emf cut for CPU reduction to the Physics Menu
- High ET chain
- 'HLT_j30_CLEANllp_momemfrac006_calratio_L1j...reverse naming of the calratio algorithm (calrtold->calratio, calratio->calratiovar) and move old calratio chains with additional emf cut for CPU reduction to the Physics Menu
- High ET chain
- 'HLT_j30_CLEANllp_momemfrac006_calratio_L1jJ160'
- 'HLT_j30_CLEANllp_momemfrac006_calratiormbib_L1jJ160'
- Calratio backup for jJ160
- 'HLT_j30_CLEANllp_momemfrac006_calratio_L1eTAU140'
- 'HLT_j30_CLEANllp_momemfrac006_calratiormbib_L1eTAU140'
- 'HLT_j30_CLEANllp_momemfrac006_calratio_L1eTAU80'
- 'HLT_j30_CLEANllp_momemfrac006_calratiormbib_L1eTAU80'
- Calratio LLP-NoMATCH analogs
- 'HLT_j30_CLEANllp_momemfrac006_calratio_L1eTAU40HT'
- 'HLT_j30_CLEANllp_momemfrac006_calratiormbib_L1eTAU40HT'
- 'HLT_j30_CLEANllp_momemfrac006_calratio_L1eTAU60HM'
- 'HLT_j30_CLEANllp_momemfrac006_calratiormbib_L1eTAU60HM'
- Calratio support chains
- 'HLT_j30_CLEANllp_momemfrac006_calratio_L1TAU40_EMPTY'
- 'HLT_j30_CLEANllp_momemfrac006_calratiormbib_L1TAU40_EMPTY'
- 'HLT_j30_CLEANllp_momemfrac006_calratio_L1TAU40_UNPAIRED_ISO'
- 'HLT_j30_CLEANllp_momemfrac006_calratiormbib_L1TAU40_UNPAIRED_ISO'
- new version of triggers with pileup recalculation, should be prescaled
- 'HLT_j30_CLEANllp_momemfrac012_calratiovar_roiftf_preselj20emf12_L1jJ160'https://gitlab.cern.ch/atlas/athena/-/merge_requests/69378MuonReadoutGeometry - Streamline the caching flags & fix B-Lines2024-03-15T08:04:53+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuonReadoutGeometry - Streamline the caching flags & fix B-LinesMoin everybody,
this MR is simplifying the cache filling logic of the R3 readout geometry and also unfortunately revealed a bug in the application of the B-Line parameters for the Mdts.
For the Mdts, the B-line parameters are conceptio...Moin everybody,
this MR is simplifying the cache filling logic of the R3 readout geometry and also unfortunately revealed a bug in the application of the B-Line parameters for the Mdts.
For the Mdts, the B-line parameters are conceptionally baked into the transform of the ReadoutElement. Following the paradigms of the ATLAS-EDM the transform needs to be cached, which is happening in the [initCache()](https://gitlab.cern.ch/atlas/athena/-/blob/0edea5ebd6bff5b239bb21b45f67cd28d8a6d81b/MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry/src/MdtReadoutElement.cxx#L1002) method. So, now the question is when has this method been invoked for the last time, it's when the [A-Line parameters are set](https://gitlab.cern.ch/atlas/athena/-/blob/0edea5ebd6bff5b239bb21b45f67cd28d8a6d81b/MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry/src/MuonDetectorManager.cxx#L444-445). In contrast, the update of the B-Lines only triggers the caching of the [deformed transformation](https://gitlab.cern.ch/atlas/athena/-/blob/main/MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry/src/MuonDetectorManager.cxx#L589-591) and not of the complete transformation which is fed to the surface. Essentially, the same conclusion holds for the as-built parameters. Alright, let's take a look at the order in which the alignment corrections are [parsed](https://gitlab.cern.ch/atlas/athena/-/blob/main/MuonSpectrometer/MuonGeoModel/src/MuonDetectorCondAlg.cxx#L109-159):
1. Mdt - As-built
2. Nsw - As built
3. A-Lines
4. B-Lines
--> The B-Lines are not propagated to the surface transformation, but to the globalTubePositions as the corresponding transforms are recalculated at every function call
Tagging from muon side: @kluit, @stavrop, @pscholer, @giraudpf, @amelung, @mvozak, @pfleisch, @plengo
from the software side: @jcatmore, @nstyles, @jchapman, @jdandoy, @christos, @dta, @ahabouelhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69376Allow DigitizationTests ART jobs to find 24.0-specific reference files (ATLAS...2024-03-01T20:36:13+01:00John Derek ChapmanAllow DigitizationTests ART jobs to find 24.0-specific reference files (ATLASSIM-7095)This update is necessary for the comparisons against fixed reference files in 24.0 to work properly.
The script is only used in Digitization ART jobs so will not affect the CI output.This update is necessary for the comparisons against fixed reference files in 24.0 to work properly.
The script is only used in Digitization ART jobs so will not affect the CI output.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69326Demote ERROR to WARNING and ignore status check2024-02-29T07:27:17+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chDemote ERROR to WARNING and ignore status checkDemote the ERROR messages to WARNINGS and ignore the returned status code for the time being. @epasqual has a better understanding of the decoder than me and he might want to assess the severity of the particular failure codes.
Tagging...Demote the ERROR messages to WARNINGS and ignore the returned status code for the time being. @epasqual has a better understanding of the decoder than me and he might want to assess the severity of the particular failure codes.
Tagging: @kluit
Closes ATLASRECTS-7920https://gitlab.cern.ch/atlas/athena/-/merge_requests/69322LumiBlockComps: restore txt configuration for tests2024-02-29T07:27:17+01:00Tadej Novaktadej.novak@cern.chLumiBlockComps: restore txt configuration for testsRestore txt configuration for tests in `LumiBlockComps` that was accidentally removed.
Fixes unit test failures.
/cc @fwinklRestore txt configuration for tests in `LumiBlockComps` that was accidentally removed.
Fixes unit test failures.
/cc @fwinklhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69321Do not use LABELS property for unit test since that breaks the nightly2024-02-28T11:24:22+01:00Carlo Varnicarlo.varni@cern.chDo not use LABELS property for unit test since that breaks the nightlyThis test is breaking the nightly due to the `LABEL` property. Removing it
/cc @tadej @fwinklThis test is breaking the nightly due to the `LABEL` property. Removing it
/cc @tadej @fwinklhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69276DumpTheFullLog2024-02-27T14:16:51+01:00Carlo Varnicarlo.varni@cern.chDumpTheFullLog/cc @tadej
Dumping the full log/cc @tadej
Dumping the full log