athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2019-11-27T03:02:39+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/28216Filter which data can be loaded in Views from the main store2019-11-27T03:02:39+01:00Benjamin Michael WynneFilter which data can be loaded in Views from the main storeA number of algorithms running in EventViews are accidentally loading data objects that exist in the main event store, using the view fallthrough mechanism.
Fallthrough itself is necessary - objects like Identifiable Container Caches mu...A number of algorithms running in EventViews are accidentally loading data objects that exist in the main event store, using the view fallthrough mechanism.
Fallthrough itself is necessary - objects like Identifiable Container Caches must exist in the main store but be accessible in views without creating copies. However, for most objects this is not the case.
So, I have added a filter to the fallthrough mechanism to ensure that only these intended objects are loaded, as suggested by @tbold
Note that this will not prevent an algorithm from trying to load these objects, it will simply create an error rather than an incorrect result. But, at least it'll help us track down the problem.https://gitlab.cern.ch/atlas/athena/-/merge_requests/28215Fix for stall in muon trigger2019-11-26T03:02:10+01:00Savanna ShawFix for stall in muon triggerAdding an ID container to our view data verifier to prevent a stall in the muon trigger (ATR-20524).Adding an ID container to our view data verifier to prevent a stall in the muon trigger (ATR-20524).https://gitlab.cern.ch/atlas/athena/-/merge_requests/28214Cleaning up unused code for ITK pixel clustering2019-11-26T03:02:09+01:00Noemi CalaceCleaning up unused code for ITK pixel clusteringPart of the pixel clustering tool was modified for ITk reconstuction. It turned out not to be used anymore, therefore I'm cleaning it. I have also cleaned the indentation.
RunTier0Tests.py runs successfully.Part of the pixel clustering tool was modified for ITk reconstuction. It turned out not to be used anymore, therefore I'm cleaning it. I have also cleaned the indentation.
RunTier0Tests.py runs successfully.Noemi CalaceNoemi Calacehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/28213Cleanups of (I)SCTRawDataProviderTool.h2019-11-26T03:02:31+01:00Susumu OdaCleanups of (I)SCTRawDataProviderTool.hCleanups of (I)SCTRawDataProviderTool.h
* Remove unnecessary includes
* Make ISCTRawDataProviderTool of TrigSCTRawDataProvider privateCleanups of (I)SCTRawDataProviderTool.h
* Remove unnecessary includes
* Make ISCTRawDataProviderTool of TrigSCTRawDataProvider privatehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/28212Jet calib tools master configure gs cdepth 211120192019-11-27T03:02:37+01:00Jonathan BossioJet calib tools master configure gs cdepth 21112019This fixes ATR-20581.
Changes:
- JetCalibTools now have a new property 'GSCDepth' that allows to neglect the GSCDepth from the provided config file and use the one set as property. The default still is to use the one defined in the conf...This fixes ATR-20581.
Changes:
- JetCalibTools now have a new property 'GSCDepth' that allows to neglect the GSCDepth from the provided config file and use the one set as property. The default still is to use the one defined in the config file. This allows to use offline config files for online jets.
- GSC Jet Trigger chains now set GSCDepth to "trackWIDTH" to remove WARNING about missing "GhostMuonSegmentCount"
Tagging @khoo to let him knowhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/28211Reorganisation of TrigMuonRoITool2019-12-03T03:02:24+01:00Savanna ShawReorganisation of TrigMuonRoIToolAttempting some reorganistaion/updating of the TrigMuonRoITool:
TrigMuonRoITool:
- Remove EventInfo object (as per ATR-20579)
- Since the EventInfo object was being used to check if the tool was all ready called, changed the tool to...Attempting some reorganistaion/updating of the TrigMuonRoITool:
TrigMuonRoITool:
- Remove EventInfo object (as per ATR-20579)
- Since the EventInfo object was being used to check if the tool was all ready called, changed the tool to return the vectors of in time and out of time RoIs instead of the iterators for the start and end of each vector. This way, we shouldn't need to call the tool multiple times from one algorithm.
- Made the access to the MuCTPi RDO to go through data handle
- Some other moinor updates to use the ATH_MSG macros
L1Muctpi:
- Changed recording of MuCTPi RDO to go through data handles
Updates to TrigmuRoIMT and other legacy algorithms using the TrigMuonRoITool (TrigmuRoI, DetectorTimingAlgo, L1CorrelationAlgo) to retrieve the vectors of RoIs from the tool instead of the iterators, and then loop over the vectors.https://gitlab.cern.ch/atlas/athena/-/merge_requests/28210schedule TRTToTCondAlg in the legacy trigger config. Fixes ATR-202292019-11-26T03:02:29+01:00Jiri Masikschedule TRTToTCondAlg in the legacy trigger config. Fixes ATR-20229add missing condition algorithm to the condSeqadd missing condition algorithm to the condSeqhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/28209BTrig: Add missing monitoring variable ATR-203022019-11-27T03:01:58+01:00Adam Edward BartonBTrig: Add missing monitoring variable ATR-20302Fill a missing monitoring variable
@tursom please check
cc @jakoubekFill a missing monitoring variable
@tursom please check
cc @jakoubekhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/28208Add "pure virtual method called" to check_log patterns2019-11-25T03:01:59+01:00Rafal Bielskirafal.bielski@cern.chAdd "pure virtual method called" to check_log patternsAdding this pattern to be able to better track errors like the one in ATR-20586
I don't add it to the perl version of the check_log script which is obsolete and should be removed soon. Trigger ART tests now use the python version only.Adding this pattern to be able to better track errors like the one in ATR-20586
I don't add it to the perl version of the check_log script which is obsolete and should be removed soon. Trigger ART tests now use the python version only.https://gitlab.cern.ch/atlas/athena/-/merge_requests/28207Decorate Ntrk of parent jet to trimmed jet2019-11-26T03:03:01+01:00Takuya NobeDecorate Ntrk of parent jet to trimmed jetRequired by several analysis teams to decorate Ntrk of parent jet to trimmed jet, when 3-variable W/Z tagger is applied.
Tagging @adattagu @jveatch
Also, configurations in test script are update.Required by several analysis teams to decorate Ntrk of parent jet to trimmed jet, when 3-variable W/Z tagger is applied.
Tagging @adattagu @jveatch
Also, configurations in test script are update.https://gitlab.cern.ch/atlas/athena/-/merge_requests/28206IOVSvc: Add option to avoid preloading extensible folders2019-11-27T03:02:49+01:00Frank WinklmeierIOVSvc: Add option to avoid preloading extensible foldersAdd `IOVSvc.preLoadExtensibleFolders` property that can be used to avoid
preloading of extensible folders while still preloading regular folders.
This is useful in the HLT where a valid content for extensible folders
may not be availa...Add `IOVSvc.preLoadExtensibleFolders` property that can be used to avoid
preloading of extensible folders while still preloading regular folders.
This is useful in the HLT where a valid content for extensible folders
may not be available by the time the preloading happens.
Relates to ATR-19392https://gitlab.cern.ch/atlas/athena/-/merge_requests/28205Makes generation of the HLT Control Flow dot files configurable2020-01-01T03:01:59+01:00Tomasz BoldMakes generation of the HLT Control Flow dot files configurableWith this MR the "dot" menu visualisation files are only generated in a few specific tests that are used for CF development.
Tagging @fpastore
This MR should wait until one with combined chains is included. Unless Francesca thinks tha...With this MR the "dot" menu visualisation files are only generated in a few specific tests that are used for CF development.
Tagging @fpastore
This MR should wait until one with combined chains is included. Unless Francesca thinks that this one is not interfering.
Related to: ATR-20565https://gitlab.cern.ch/atlas/athena/-/merge_requests/28204Manual sweep of !26791 from 21.3 to 21.9: Fix output file naming in SimCoreTe...2019-11-22T17:26:00+01:00John Derek ChapmanManual sweep of !26791 from 21.3 to 21.9: Fix output file naming in SimCoreTests and ISF_Validation ART jobs (ATLASSIM-4309)Fix output file naming in SimCoreTests and ISF_Validation ART jobs (ATLASSIM-4309)
See merge request atlas/athena!26791
(cherry picked from commit c9084e4c2aeffcf7286068dd52a93d961a2477ba)
3aa9aad7 Fix output file naming in SimCoreTes...Fix output file naming in SimCoreTests and ISF_Validation ART jobs (ATLASSIM-4309)
See merge request atlas/athena!26791
(cherry picked from commit c9084e4c2aeffcf7286068dd52a93d961a2477ba)
3aa9aad7 Fix output file naming in SimCoreTests and ISF_Validation ART jobs (ATLASSIM-4309)
Should fix ATLASSIM-4346https://gitlab.cern.ch/atlas/athena/-/merge_requests/28203Truth Derivation Tests2019-11-23T03:03:03+01:00Zach MarshallTruth Derivation TestsThis implements a new test package for derivations, with a first script to test truth derivations. It has a simple executable inside it that runs and tests a variety of derivation functionality. There is a single ART job to run the execu...This implements a new test package for derivations, with a first script to test truth derivations. It has a simple executable inside it that runs and tests a variety of derivation functionality. There is a single ART job to run the executable. The ultimate goal is to compare the histograms from each night.
This was discussed a bit with @jcatmore , @egramsta , and @boeriu .https://gitlab.cern.ch/atlas/athena/-/merge_requests/28202xAODDataSource, 21.2 branch (2019.11.22.)2020-01-03T18:41:13+01:00Attila KrasznahorkayxAODDataSource, 21.2 branch (2019.11.22.)After keeping this project on the back burner for a **very** long time, I now spent a few hours to make the code that I kept in [akraszna/xAODDataSource](https://gitlab.cern.ch/akraszna/xAODDataSource), a part of the analysis release. As...After keeping this project on the back burner for a **very** long time, I now spent a few hours to make the code that I kept in [akraszna/xAODDataSource](https://gitlab.cern.ch/akraszna/xAODDataSource), a part of the analysis release. As is written in the code's comments, I wrote the code based on the work that Umesh Worlikar did a while ago. (I didn't find his user ID in GitLab anymore, I think he left ATLAS by now...:frowning:)
The code itself is not super trivial, so probably an expert review will be warranted. (@krumnack :wink:)
The main/only user interface of the code are the 2 overloads of the `xAOD::MakeDataFrame(...)` function. People should really only use that, they shouldn't have to interact with any other implementation detail inside the package.
More documentation will have to be written later on, for now the unit tests of the package could serve as examples of what the code allows the users to do.
Finally, I've only added the package to the `AnalysisBase` and `AnalysisTop` projects for now. Since I've only done tests on top of those projects for now. In the past I did test the code with `AthAnalysis` as well (see for instance: https://gitlab.cern.ch/akraszna/xAODDataSource/pipelines/574135), so maybe I'm too careful here. :thinking: We may just want to keep this MR open until I'm back in front of a CentOS 7 machine, where I'll be able to make some additional tests before adding the package to `AthAnalysis` as well...https://gitlab.cern.ch/atlas/athena/-/merge_requests/28201xAODTauAthenaPool: Remove unneeded custom pool converters.2019-11-23T03:02:32+01:00Scott SnyderxAODTauAthenaPool: Remove unneeded custom pool converters.xAOD objects no longer need custom pool converters.
Remove those that are no longer needed.
Change xAOD converters with versioning to use the templated pool converter,
and make the TP class interfaces const.
ATR-20402 should be solved now.xAOD objects no longer need custom pool converters.
Remove those that are no longer needed.
Change xAOD converters with versioning to use the templated pool converter,
and make the TP class interfaces const.
ATR-20402 should be solved now.https://gitlab.cern.ch/atlas/athena/-/merge_requests/28200WIP: Sweeping !28070 from 21.3 to master.Update of the NSW cluster builders2019-11-22T11:35:39+01:00Atlas NightlybuildWIP: Sweeping !28070 from 21.3 to master.Update of the NSW cluster buildersUpdate of the NSW cluster builders
See merge request atlas/athena!28070Update of the NSW cluster builders
See merge request atlas/athena!28070https://gitlab.cern.ch/atlas/athena/-/merge_requests/28199Updates to Pythia8 LHEF examples2019-11-27T21:55:25+01:00Zach MarshallUpdates to Pythia8 LHEF examplesThe current LHEF example is meant to run as athena job options; adding a
note inside it to be explicit about that.
The include file uses the runArgs to make an input file and then
hard-codes the location of the input file; changing that...The current LHEF example is meant to run as athena job options; adding a
note inside it to be explicit about that.
The include file uses the runArgs to make an input file and then
hard-codes the location of the input file; changing that to use the
runArgs as seems to be intended.
Adding a working example of LHEF usage with the transforms. This was
rather non-trivial, so I think it's useful.
FYI: @mshapiro , @abuckley , @gpanizzo (Pythia8 experts), @fladias (whose email triggered this)https://gitlab.cern.ch/atlas/athena/-/merge_requests/28198Correct bug in ParametersT.2019-11-27T03:02:00+01:00Anthony MorleyCorrect bug in ParametersT.updateParameters: Charge was not being updated when calling function.
@christos -- This should speed up the GSF as it will stop some oscillationsupdateParameters: Charge was not being updated when calling function.
@christos -- This should speed up the GSF as it will stop some oscillationshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/28197JetMonitoring: Fix clang warnings.2019-11-23T03:02:47+01:00Scott SnyderJetMonitoring: Fix clang warnings.clang warnings:
Missing override keyword.
Non-virtual dtor for class with virtual methods.
Unused class member (commented out because it's still referenced in comments).clang warnings:
Missing override keyword.
Non-virtual dtor for class with virtual methods.
Unused class member (commented out because it's still referenced in comments).