athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-11T14:18:38+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/68479Draft: Fixes for https://github.com/acts-project/acts/pull/27122024-03-11T14:18:38+01:00Tomasz BoldDraft: Fixes for https://github.com/acts-project/acts/pull/2712Subsequently added:
- Default xAOD backend to pion particle hypo for #2712
- Remove m_particleHypothesis from TrackStorage (unneeded after #2712)Subsequently added:
- Default xAOD backend to pion particle hypo for #2712
- Remove m_particleHypothesis from TrackStorage (unneeded after #2712)https://gitlab.cern.ch/atlas/athena/-/merge_requests/69566Draft: Script for data dependencies2024-03-08T12:50:51+01:00Carlo Varnicarlo.varni@cern.chDraft: Script for data dependenciesThis adds a python script for parsing a reco job log file and create a graph of the data dependencies of the algorithms (`.md` extension).
Requirement: the reco job must be in MT mode (at least 1 thread) and the flag `Scheduler.ShowData...This adds a python script for parsing a reco job log file and create a graph of the data dependencies of the algorithms (`.md` extension).
Requirement: the reco job must be in MT mode (at least 1 thread) and the flag `Scheduler.ShowDataDeps` must be set on `True`
I found this extremely useful while debugging what was going on in our ACTS chains, especially in understanding why the scheduler was complaining about stalls or why read handles were not valid. So I guess I could simply put this in Athena so that it can be used by others as well.
It creates graphs like this one: https://codimd.web.cern.ch/s/4JEJMBm1P
Example of use: `python3 makeDataDependencyGraph.py --inputLog ../utils/output.multithreaded.txt --pattern '.*Acts.*' --output graph.md`
/cc @adye @pagessin @tbold @bkerridg @ncalacehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66929Draft: Algorithm to Output Ringer per Cell in 23.02024-03-08T10:55:36+01:00Denis Oliveira DamazioDraft: Algorithm to Output Ringer per Cell in 23.0https://gitlab.cern.ch/atlas/athena/-/merge_requests/66226Draft: TrigHLTJet Hypo - add Multiplity Condition - counts number of jets fil...2024-03-08T10:54:42+01:00Peter SherwoodDraft: TrigHLTJet Hypo - add Multiplity Condition - counts number of jets filtered...The changes on this merge request allow selecting on the number of jets in the HLT jet trigger.
This Condition comes with a fdefault filter, so the number of jets counted are after filtering
This functionality was requested by the HI t...The changes on this merge request allow selecting on the number of jets in the HLT jet trigger.
This Condition comes with a fdefault filter, so the number of jets counted are after filtering
This functionality was requested by the HI trigger group.
ATR-22067
@mrybar @angerami @cantel @xingguo @miochoa @peterPeter SherwoodPeter Sherwoodhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67482Draft: add efficiency2024-03-08T08:58:21+01:00Kai ZhengDraft: add efficiencyadd road efficiency printed out, but the efficiency is low
Command:
python -m FPGATrackSimConfTools.FPGATrackSimAnalysisConfig --evtMax=1000 Trigger.FPGATrackSim.wrapperFileName=/eos/atlas/atlascerngroupdisk/det-htt//HTTsim/ATLAS-P2-RU...add road efficiency printed out, but the efficiency is low
Command:
python -m FPGATrackSimConfTools.FPGATrackSimAnalysisConfig --evtMax=1000 Trigger.FPGATrackSim.wrapperFileName=/eos/atlas/atlascerngroupdisk/det-htt//HTTsim/ATLAS-P2-RUN4-03-00-00/FPGATrackSimWrapper.root Trigger.FPGATrackSim.mapsDir=../1117_Kai_maps
Generated map files: https://cernbox.cern.ch/s/881ZeDH2E6tJuEX
Default map files: https://cernbox.cern.ch/s/yYDHLL0QaeVrIMlhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69643Draft: added back ditau chain for commissioning2024-03-08T05:31:10+01:00Gianantonio Pezzullog.pezzullo@yale.eduDraft: added back ditau chain for commissioningAdding back in the Physics menu a ditau chain for commissioning the corresponding phase-I version
tau trigger
tagging: @astruebi @lidiaz @smwangAdding back in the Physics menu a ditau chain for commissioning the corresponding phase-I version
tau trigger
tagging: @astruebi @lidiaz @smwanghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69619Fix import in TRTCalibrationMgrConfig.py2024-03-07T23:14:31+01:00Thomas StreblerFix import in TRTCalibrationMgrConfig.pyThis could lead to error in case `AlignTrkTools` is set but `FitTools` is not.
FYI @serodrigThis could lead to error in case `AlignTrkTools` is set but `FitTools` is not.
FYI @serodrighttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69095Draft: Move FTagEventSF to standalone analysis config2024-03-08T02:18:58+01:00Thomas StreblerDraft: Move FTagEventSF to standalone analysis configBuilt on top of !69002
Use similar config to JVT analysis config, to be able to define overlap removal dependency in the same wayBuilt on top of !69002
Use similar config to JVT analysis config, to be able to define overlap removal dependency in the same wayhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69553Remove HLTbphys references for physics_BphysDelayed stream2024-03-07T18:24:31+01:00Semen TurchikhinRemove HLTbphys references for physics_BphysDelayed streamThis fixes the errors about missed HLT B-physics references for physics_BphysDelayed stream in han config reported in ATR-28651.
Tagging @sawyer - if you're working on this and have already put this fix, please comment, I'll cancel my MR...This fixes the errors about missed HLT B-physics references for physics_BphysDelayed stream in han config reported in ATR-28651.
Tagging @sawyer - if you're working on this and have already put this fix, please comment, I'll cancel my MR then.
cc: @ebergeashttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69503Add new code to allow creation of electron and muon free particle flow jets (V2)2024-03-07T14:58:54+01:00Mark HodgkinsonAdd new code to allow creation of electron and muon free particle flow jets (V2)This includes updates to JetPFlowSelectionAlg.cxx to add options to remove all neutral contributions from particle flow jets that belong to electrons or muons of a given particle ID level.
On the python side new configuration functional...This includes updates to JetPFlowSelectionAlg.cxx to add options to remove all neutral contributions from particle flow jets that belong to electrons or muons of a given particle ID level.
On the python side new configuration functionality has been added to allow users to make use of these workflows.
This should not change the output of standard particle flow jets and hence should preserve frozen tier0 for jets.
The new muon free jets rely on an additional decoration that is added to charged FlowElement - thus this aspect violates frozen tier0 and adds a new decoration.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69589Draft: Rely on callables to deffer createion of sequences in HLT menu generation2024-03-07T11:51:19+01:00Tomasz BoldDraft: Rely on callables to deffer createion of sequences in HLT menu generationFor preview by @fwinkl @fpastore @suttFor preview by @fwinkl @fpastore @sutthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68323Draft: PyUtils: Poor man's workaround for ATLASSIM-69772024-03-06T21:26:32+01:00Alaettin Serhan MeteDraft: PyUtils: Poor man's workaround for ATLASSIM-6977Force load the `LArTPCnv` dictionary to work around the `diff-root` crash reported in ATLASSIM-6977.Force load the `LArTPCnv` dictionary to work around the `diff-root` crash reported in ATLASSIM-6977.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69370Draft: Tests2024-03-06T11:44:35+01:00Carlo Varnicarlo.varni@cern.chDraft: Testshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69521Draft: ATR-28844 - MonitorDef2024-03-05T20:31:29+01:00Lidija ZivkovicDraft: ATR-28844 - MonitorDefChanges and updates in MonitorDef, details are in JIRAChanges and updates in MonitorDef, details are in JIRAhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69500Draft: Add new code to allow creation of electron and muon free particle flow...2024-03-05T12:11:42+01:00Mark HodgkinsonDraft: Add new code to allow creation of electron and muon free particle flow jetsThis includes updates to JetPFlowSelectionAlg.cxx to add options to remove all neutral contributions from particle flow jets that belong to electrons or muons of a given particle ID level.
On the python side new configuration functional...This includes updates to JetPFlowSelectionAlg.cxx to add options to remove all neutral contributions from particle flow jets that belong to electrons or muons of a given particle ID level.
On the python side new configuration functionality has been added to allow users to make use of these workflows.
This should not change the output of standard particle flow jets and hence should preserve frozen tier0.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68235Draft: Import HGTD Track and Vertex Time Tools2024-03-05T10:12:04+01:00Jernej DebevcDraft: Import HGTD Track and Vertex Time ToolsTo start the process of integrating vertex time into standard AODs at reconstruction, this MR imports the Vertex Time Tool used to reconstruct the vertex time, together with the Track Time Tool that is required for this task.To start the process of integrating vertex time into standard AODs at reconstruction, this MR imports the Vertex Time Tool used to reconstruct the vertex time, together with the Track Time Tool that is required for this task.Jernej DebevcJernej Debevchttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69262Draft: remove SIMPLE_FLIP and update FLIP_SIGN2024-03-05T08:52:23+01:00Ligang XiaDraft: remove SIMPLE_FLIP and update FLIP_SIGN- extend the flipping variables in the scheme FLIP_SIGN to work for GN2
- delete SIMPLE_FLIP
@jabarr @dguest @bdong- extend the flipping variables in the scheme FLIP_SIGN to work for GN2
- delete SIMPLE_FLIP
@jabarr @dguest @bdonghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69053MuonGeoModelTestR4: run unit test in private working directory2024-03-05T08:43:33+01:00Frank WinklmeierMuonGeoModelTestR4: run unit test in private working directoryUnit tests that actually run athena, need their own private working directory to avoid overwriting each others files (e.g. pool catalogue) when they happen to run concurrently (as seen on https://gitlab.cern.ch/atlas/athena/-/merge_reque...Unit tests that actually run athena, need their own private working directory to avoid overwriting each others files (e.g. pool catalogue) when they happen to run concurrently (as seen on https://gitlab.cern.ch/atlas/athena/-/merge_requests/68990). Also use `noerror.sh` for post-processing to detect any errors printed by the test.
Also update simulation flags to avoid error message (see ATLASSIM-7094).
cc @jojunggehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69455Update GenericMonitoringTool.py - default ymin and ymax values when specifyin...2024-03-04T22:46:13+01:00Will ButtingerUpdate GenericMonitoringTool.py - default ymin and ymax values when specifying...Update GenericMonitoringTool.py - default ymin and ymax values when specifying ylabels, if not specifiedUpdate GenericMonitoringTool.py - default ymin and ymax values when specifying ylabels, if not specifiedhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69447ATLASDQ-1130 fix2024-03-04T12:36:46+01:00Peter OnyisiATLASDQ-1130 fixThis fixes a failure in applying regex expressions for files retrieved from remote URLs instead of local files. This was triggered in production by ROOT 6.28 which replaces local EOS paths with xrootd URLs. Urgent for trigger DQ studies.This fixes a failure in applying regex expressions for files retrieved from remote URLs instead of local files. This was triggered in production by ROOT 6.28 which replaces local EOS paths with xrootd URLs. Urgent for trigger DQ studies.