athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-02-27T09:34:06+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/69215LArConditionsTest: remove POOL catalog on test re-run2024-02-27T09:34:06+01:00Tadej Novaktadej.novak@cern.chLArConditionsTest: remove POOL catalog on test re-runRemove POOL catalog on test re-run in `LArConditionsTest` to try to fix spurious failures in incremental builds.
/cc @wlampl @fwinklRemove POOL catalog on test re-run in `LArConditionsTest` to try to fix spurious failures in incremental builds.
/cc @wlampl @fwinklhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69212SUSYTool - Change default systematic strategy for flavor tagging2024-02-28T19:36:33+01:00Michael HolzbockSUSYTool - Change default systematic strategy for flavor taggingPropagate the adjustment which is done for main in !69079 also to 21.2
For reference: a first attempt of this was done in !69078 but aborted as the CI tests failed due to outdated reference files. These have been already updated so the...Propagate the adjustment which is done for main in !69079 also to 21.2
For reference: a first attempt of this was done in !69078 but aborted as the CI tests failed due to outdated reference files. These have been already updated so the CI should work now.
Tagging @mhank .https://gitlab.cern.ch/atlas/athena/-/merge_requests/69200add a change forgotten in MR 691222024-02-24T13:58:39+01:00Ewelina Maria Lobodzinskaadd a change forgotten in MR 69122I forgotten to add to https://gitlab.cern.ch/atlas/athena/-/merge_requests/69122 one modified file, so adding it nowI forgotten to add to https://gitlab.cern.ch/atlas/athena/-/merge_requests/69122 one modified file, so adding it nowhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69173AthenaConfiguration: delete OldFlags2NewFlags2024-02-28T07:26:39+01:00Frank WinklmeierAthenaConfiguration: delete OldFlags2NewFlagsDelete the legacy to new flags conversion helper module.
Requires https://gitlab.cern.ch/atlas/athena/-/merge_requests/69192
cc @tadej @wlamplDelete the legacy to new flags conversion helper module.
Requires https://gitlab.cern.ch/atlas/athena/-/merge_requests/69192
cc @tadej @wlamplhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69122GeneratorFilters: protect xAOD filters aginst barcode zero and duplicated par...2024-02-23T17:25:12+01:00Ewelina Maria LobodzinskaGeneratorFilters: protect xAOD filters aginst barcode zero and duplicated particlesGeneratorFilters: protect xAOD filters aginst barcode zero and duplicated particles
It was observed recently, that when EvtGen is used in MC production some barcode=0 or duplicated particles appear in the TruthParticle container. This me...GeneratorFilters: protect xAOD filters aginst barcode zero and duplicated particles
It was observed recently, that when EvtGen is used in MC production some barcode=0 or duplicated particles appear in the TruthParticle container. This merge request protect the filters against these particles.
Since all xAOD filters are affected the MR is rather big, but the changes are similar in all files.
It is rather urgent as we have 2 production requests using xAOD filters waiting for a new release with this fix.
In addition Powheg version is increased to 06-04.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69078Draft: ATLSUSYBGF-694, AFT-706: Change default systematic strategy for flavor...2024-02-24T10:52:47+01:00Dan GuestDraft: ATLSUSYBGF-694, AFT-706: Change default systematic strategy for flavor taggingWe noticed that a few frameworks were setting the default ftag strategy to something that might be problematic, see the attached ticket.
Marked as a draft because I don't know if we want to change the default behavior in an release we'r...We noticed that a few frameworks were setting the default ftag strategy to something that might be problematic, see the attached ticket.
Marked as a draft because I don't know if we want to change the default behavior in an release we're trying to deprecate ASAP.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69049MuonPhaseII -- Remove unit tests2024-02-22T10:49:24+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuonPhaseII -- Remove unit testsThe unit tests will soon stop working as we're changing the layout files in ~main. To avoid a sweeping of the phase II developments from ~"24.0" , I just remove the unit tests here
Tagging: @jchapman, @emoyse, @jcatmore, @nstylesThe unit tests will soon stop working as we're changing the layout files in ~main. To avoid a sweeping of the phase II developments from ~"24.0" , I just remove the unit tests here
Tagging: @jchapman, @emoyse, @jcatmore, @nstyleshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68968reinstate accidentally deleted file LArNoiseBursts_tf.py2024-02-16T18:29:44+01:00Walter Lamplreinstate accidentally deleted file LArNoiseBursts_tf.pyThe file LArNoiseBursts_tf.py runs the CA-based skeleton, it was accedentally deleted as part of a cleanup done in MR !68524.The file LArNoiseBursts_tf.py runs the CA-based skeleton, it was accedentally deleted as part of a cleanup done in MR !68524.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68955added "art-include: 24.0" ahead of r24 branching2024-02-16T18:48:02+01:00Duc Taadded "art-include: 24.0" ahead of r24 branchingIncluded "art-include: 24.0" where appropriate in Tools/Tier0ChainTests/test scripts (basically where art-include: 23.0 was used)Included "art-include: 24.0" where appropriate in Tools/Tier0ChainTests/test scripts (basically where art-include: 23.0 was used)https://gitlab.cern.ch/atlas/athena/-/merge_requests/68938Disable ESD metadata check in workflow tests2024-02-16T16:54:15+01:00Tadej Novaktadej.novak@cern.chDisable ESD metadata check in workflow testsDisable ESD metadata check in workflow tests.
Fixes ATLASRECTS-7908 and should be merged ASAP to avoid updating references for some MRs.
/cc @tsulaiaDisable ESD metadata check in workflow tests.
Fixes ATLASRECTS-7908 and should be merged ASAP to avoid updating references for some MRs.
/cc @tsulaiahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68932TriggerMenuMT: add menu consistency checks for CA menus2024-02-15T18:42:30+01:00Frank WinklmeierTriggerMenuMT: add menu consistency checks for CA menus@mark noticed that we are missing the consistency checks in the CA menu generation. That's why the failures
seen in ATR-28793 were only visible in the few remaining legacy tests.
Requires https://gitlab.cern.ch/atlas/athena/-/merge_req...@mark noticed that we are missing the consistency checks in the CA menu generation. That's why the failures
seen in ATR-28793 were only visible in the few remaining legacy tests.
Requires https://gitlab.cern.ch/atlas/athena/-/merge_requests/68860 to be merged first.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68927Fix CA flag modifications2024-02-15T17:01:47+01:00Mark SuttonFix CA flag modificationsWas still using old ConfigFlags for the LRT CA job configuration
Addresses ATR-28802Was still using old ConfigFlags for the LRT CA job configuration
Addresses ATR-28802https://gitlab.cern.ch/atlas/athena/-/merge_requests/68881Add ability to ignore trigger in meta-diff and enable it for workflow tests2024-02-15T01:34:07+01:00Tadej Novaktadej.novak@cern.chAdd ability to ignore trigger in meta-diff and enable it for workflow testsAdd ability to ignore trigger in `meta-diff` and enable it for workflow tests.
This could probably be done with regexes but as this is ~urgent, let's hardcode keys for now.
/cc @tsulaia @tamartin @martindl @khooAdd ability to ignore trigger in `meta-diff` and enable it for workflow tests.
This could probably be done with regexes but as this is ~urgent, let's hardcode keys for now.
/cc @tsulaia @tamartin @martindl @khoohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68860Physics Menu cleanup of legacy tau+x chains and fixed a typo in group name2024-02-15T16:57:08+01:00Gianantonio Pezzullog.pezzullo@yale.eduPhysics Menu cleanup of legacy tau+x chains and fixed a typo in group namePhysics Menu cleanup of legacy tau+x chains, moving them to the MC Menu: ATR-28791
Fixed typo in chains' group field: ATR-28784Physics Menu cleanup of legacy tau+x chains, moving them to the MC Menu: ATR-28791
Fixed typo in chains' group field: ATR-28784https://gitlab.cern.ch/atlas/athena/-/merge_requests/68839Debug recovery, updates for trigRecoExe, dbgAnalysis and dbgEventInfo2024-02-14T18:15:18+01:00Jennifer Rachel CurranDebug recovery, updates for trigRecoExe, dbgAnalysis and dbgEventInfoUpdate to check if the number of status words is not zero in dbgEventInfo.py to ensure crashes don't occur when recovered events have no status word.
Removal of the functions getPrePosdif_branch and getPrePosdiff from dbgAnalysis.py (a...Update to check if the number of status words is not zero in dbgEventInfo.py to ensure crashes don't occur when recovered events have no status word.
Removal of the functions getPrePosdif_branch and getPrePosdiff from dbgAnalysis.py (and where they are called in trigRecoExe.py) as this step is being added to the script that reads the values in the root files for the debug recovery web application so is not needed here.
ATR-26595
@mark @wiedenmahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68837TileByteStream: Fix Tile ROD decoder initialization (ATR-28780)2024-02-13T20:10:04+01:00Siarhei HarkushaTileByteStream: Fix Tile ROD decoder initialization (ATR-28780)Tile ROD decoder has been fixed to explicitely retrieve (initialize)
Tile cabling service since it is used during initialization.
Tile ROD decoder test, JO and reference files have been updated accordingly.Tile ROD decoder has been fixed to explicitely retrieve (initialize)
Tile cabling service since it is used during initialization.
Tile ROD decoder test, JO and reference files have been updated accordingly.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68827TrigAnalysisTest: move CI test to CA2024-02-15T20:33:44+01:00Bertrand Martin Dit LatourTrigAnalysisTest: move CI test to CAHello,
This MR is migrating to CA the MC trigger test used in the CI.
The addition of `--preInclude "all:Campaigns.MC23c"` will be done later, as it is expected to change the trigger counts.
Marking as urgent as it blocks the removal of...Hello,
This MR is migrating to CA the MC trigger test used in the CI.
The addition of `--preInclude "all:Campaigns.MC23c"` will be done later, as it is expected to change the trigger counts.
Marking as urgent as it blocks the removal of RecExCommon in !68693.
A follow up MR will migrate the other tests in this package.
Tagging @fwinkl .
Cheers,
Bertrandhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68819Adjustment for the calratio triggers to adress high rate2024-02-16T18:54:00+01:00Tatiana OvsiannikovaAdjustment for the calratio triggers to adress high rate- bring back old calratio triggers for comparison with new triggers
- make some adjustment to the new triggers to fix high rates
- add triggers with bib removal as well
-- HLT_j20_CLEANllp_momemfrac006_calratiormbib_roiftf_preselj20emf6...- bring back old calratio triggers for comparison with new triggers
- make some adjustment to the new triggers to fix high rates
- add triggers with bib removal as well
-- HLT_j20_CLEANllp_momemfrac006_calratiormbib_roiftf_preselj20emf6_L1jJ160
-- HLT_j20_CLEANllp_momemfrac006_calratiormbib_roiftf_preselj20emf6_L1eTAU60_EMPTY
-- HLT_j20_CLEANllp_momemfrac006_calratiormbib_roiftf_preselj20emf6_L1eTAU60_UNPAIRED_ISO
-- HLT_j20_CLEANllp_momemfrac006_calratiormbib_roiftf_preselj20emf6_L1eTAU40HT
-- HLT_j20_CLEANllp_momemfrac006_calratiormbib_roiftf_preselj20emf6_L1eTAU60HM
-- HLT_j20_CLEANllp_momemfrac006_calratiormbib_roiftf_preselj20emf6_L1eTAU140
- add few more chains for emf preselection comparison:
- HLT_j20_CLEANllp_momemfrac024_calratio_roiftf_preselj20emf24_L1TAU60
- HLT_j20_CLEANllp_momemfrac012_calratio_roiftf_preselj20emf12_L1T
- HLT_j30_CLEANllp_momemfrac006_calrtold_L1TAU60https://gitlab.cern.ch/atlas/athena/-/merge_requests/68791Build Script Fixes, main branch (2024.02.12.)2024-02-13T00:54:12+01:00Attila KrasznahorkayBuild Script Fixes, main branch (2024.02.12.)This is a sibling / replacement for !68785.
I fixed the GeoModel setup in the build scripts by getting rid of the spaces in `ATLAS_GEOMODEL_FORCEDOWNLOAD_MESSAGE`. Unfortunately BASH can be a primadonna with propagating quotes correctly...This is a sibling / replacement for !68785.
I fixed the GeoModel setup in the build scripts by getting rid of the spaces in `ATLAS_GEOMODEL_FORCEDOWNLOAD_MESSAGE`. Unfortunately BASH can be a primadonna with propagating quotes correctly. :frowning: I tried a few things, but this seemed the easiest / most pragmatic. :thinking:
As !68785, this is meant to fix ATLINFR-5244.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68785Projects: fix quotes in GEOMODEL_FORCEDOWNLOAD_MESSAGE2024-02-12T17:08:00+01:00Frank WinklmeierProjects: fix quotes in GEOMODEL_FORCEDOWNLOAD_MESSAGEQuotes need to be escaped, otherwise we loose them and everything after the first space gets lost.
Closes ATLINFR-5244. cc @akraszna @tsulaiaQuotes need to be escaped, otherwise we loose them and everything after the first space gets lost.
Closes ATLINFR-5244. cc @akraszna @tsulaia