athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-28T11:30:34+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/70122TileMonitoring: Remove legacy config from TileDQFragMonitorAlgorithm (ATLASRE...2024-03-28T11:30:34+01:00Siarhei HarkushaTileMonitoring: Remove legacy config from TileDQFragMonitorAlgorithm (ATLASRECTS-7939)New-style (CA-based) configuration of the TileDQFragMonitorAlgorithm
has been updated to remove legacy part (compatibility with legacy JO).New-style (CA-based) configuration of the TileDQFragMonitorAlgorithm
has been updated to remove legacy part (compatibility with legacy JO).https://gitlab.cern.ch/atlas/athena/-/merge_requests/70124TileMonitoring: Remove legacy config from TileMBTSMonitorAlgorithm (ATLASRECT...2024-03-28T11:30:34+01:00Siarhei HarkushaTileMonitoring: Remove legacy config from TileMBTSMonitorAlgorithm (ATLASRECTS-7939)New-style (CA-based) configuration of the TileMBTSMonitorAlgorithm algorithm
has been updated to remove legacy part (compatibility with legacy JO).New-style (CA-based) configuration of the TileMBTSMonitorAlgorithm algorithm
has been updated to remove legacy part (compatibility with legacy JO).https://gitlab.cern.ch/atlas/athena/-/merge_requests/70125remove obsolete job-config files from CaloRec/share2024-03-28T11:30:34+01:00Walter Lamplremove obsolete job-config files from CaloRec/shareThe title says it all ...The title says it all ...https://gitlab.cern.ch/atlas/athena/-/merge_requests/69231Implementing the MuonSelectionTool for selecting muon tracks.2024-03-28T11:30:34+01:00Michele D'AndreaImplementing the MuonSelectionTool for selecting muon tracks.I am opening this merge request to implement the `MuonSelectionTool` within the `TrackLeptonDecoratorAlg`. The changes related to this MR are as follows:
* The muon quality is now retrieved directly from the MuonSelectionTool output rat...I am opening this merge request to implement the `MuonSelectionTool` within the `TrackLeptonDecoratorAlg`. The changes related to this MR are as follows:
* The muon quality is now retrieved directly from the MuonSelectionTool output rather than from the xAODMuon object.
* The `MuonSelectionTool` and the `ElectronSelectionTool` are initialized in the `FtagDerivationConfig.py` and retrieved by the `TrackLeptonDecoratorAlg`
Tagging for information: @dguest, @fdibello, @svanstro and @hartman.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70128TileRecAlgs: Remove legacy JO configurations (ATLASRECTS-7939)2024-03-28T11:30:34+01:00Siarhei HarkushaTileRecAlgs: Remove legacy JO configurations (ATLASRECTS-7939)Legacy JO configurations have been removed from TileRecAlgs package.Legacy JO configurations have been removed from TileRecAlgs package.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70126TileMuId: Remove legacy JO configurations (ATLASRECTS-7939)2024-03-28T11:30:34+01:00Siarhei HarkushaTileMuId: Remove legacy JO configurations (ATLASRECTS-7939)Legacy JO configurations have been removed from TileMuId package.Legacy JO configurations have been removed from TileMuId package.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70121TileMonitoring: Remove legacy JO configurations (ATLASRECTS-7939)2024-03-28T11:30:34+01:00Siarhei HarkushaTileMonitoring: Remove legacy JO configurations (ATLASRECTS-7939)Legacy JO configurations have been removed.Legacy JO configurations have been removed.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70105gFEX update jwoj threshold2024-03-28T11:30:34+01:00Cecilia ToscirigFEX update jwoj thresholdWith this MR the gFEX JwoJ thresholds defined in the Trigger Menu are updated as discussed in ATR-29036.With this MR the gFEX JwoJ thresholds defined in the Trigger Menu are updated as discussed in ATR-29036.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70083Dev new histograms2024-03-28T11:30:34+01:00Grigorii TolkachevDev new histogramsNew selections for histograms used for LAr Monitoring have been added.
Bugs and typos have been fixed as well.New selections for histograms used for LAr Monitoring have been added.
Bugs and typos have been fixed as well.Grigorii TolkachevGrigorii Tolkachevhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70138Add HLT_noalg_L1MU14EOF to express2024-03-28T11:30:33+01:00Muhammad AlhroobAdd HLT_noalg_L1MU14EOF to expresshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70085remove old taggers and add GN2v01 in PhysVal monitoring2024-03-28T11:30:33+01:00Ligang Xiaremove old taggers and add GN2v01 in PhysVal monitoring- remove old taggers: DL1dv00, GN1, GN2v00
- add GN2v01 for monitoring
- update physval automation scripts from python2 to python3
tagging @xuyang and @bdong- remove old taggers: DL1dv00, GN1, GN2v00
- add GN2v01 for monitoring
- update physval automation scripts from python2 to python3
tagging @xuyang and @bdonghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70130TileSimAlgs: Remove legacy JO configurations (ATLASRECTS-7939)2024-03-28T11:30:33+01:00Siarhei HarkushaTileSimAlgs: Remove legacy JO configurations (ATLASRECTS-7939)Legacy JO configurations have been removed from TileSimAlgs package.Legacy JO configurations have been removed from TileSimAlgs package.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70134LArROD: remove legacy configuration2024-03-28T11:30:33+01:00Frank WinklmeierLArROD: remove legacy configurationRemove legacy configuration. `LArRODFlags` remains for the moment and needs to be removed separately as it has still quite a few references to it.
cc @pavol @wlamplRemove legacy configuration. `LArRODFlags` remains for the moment and needs to be removed separately as it has still quite a few references to it.
cc @pavol @wlamplhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70135LArConfiguration: delete legacy job option fragments2024-03-28T11:30:33+01:00Frank WinklmeierLArConfiguration: delete legacy job option fragmentscc @pavol @wlamplcc @pavol @wlamplhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70127Improvements in Run2 to Run 3 nav conversion2024-03-28T11:30:33+01:00Tomasz BoldImprovements in Run2 to Run 3 nav conversionCouple of fixes and small improvements:
- the option of tester to report an issue an continue is now functional
- conversion test is now part of unit test
- streamlined internal comparison of relevant features
From my limited testing...Couple of fixes and small improvements:
- the option of tester to report an issue an continue is now functional
- conversion test is now part of unit test
- streamlined internal comparison of relevant features
From my limited testing the only problem we have now is excessive number of combinations in Run3 format for certian muon chains.
Tagging @wprzygod @tamartin @mrimoldihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/6940624.0 TRT high threshold tune2024-03-28T11:30:33+01:00Christian Grefe24.0 TRT high threshold tuneSignificantly improves the modelling of the number of TRT high-threshold hits, by updating the digitisation parameters.
The threshold values were tuned by comparing MC with Run 3 low-mu data. The pile-up dependence is taken into account ...Significantly improves the modelling of the number of TRT high-threshold hits, by updating the digitisation parameters.
The threshold values were tuned by comparing MC with Run 3 low-mu data. The pile-up dependence is taken into account in the pile-up overlay correction values. These have been tuned using several Run 3 runs at usual pile-up conditions.
A summary of the results was presented in the Simulation Group Meeting on Feb. 13: https://indico.cern.ch/event/1381473/contributions/5806705/attachments/2800131/4884883/TRT_mc23e_tune_2014_02_13.pdf
More details can be found in these slides by @hadenizl: https://indico.cern.ch/event/1335684/contributions/5622451/attachments/2795220/4876744/TrtDays_7Feb2024_haluk.pdf
The impact on tracking is negligible. A significant change is expected for the number of TRT HT hits and derived quantities like eProbability_HT, which is used for example in electron identification, photon reconstruction and tau electron veto. In https://its.cern.ch/jira/browse/ATLPHYSVAL-1008 the impact has been validated: everything looks as expected.
If possible, this change should go into the release for MC23e, since it significantly improves the modelling of electron identification observables. No significant side effects have been observed in the PhysVal checks.
Tagging: @beddall, @ludovica, @kristin, @ademaria, @sineadf, @martindlhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70103Optimization of the Trigger Menu generation: move CA generation after the ali...2024-03-28T11:30:33+01:00Francesca PastoreOptimization of the Trigger Menu generation: move CA generation after the alignment (ATR-29039)Within the optimization of the menu generation, this MR moves the ability to generate the CAs after the menu alignment, so during the createDataFlow(). This requires few changes
1. When creating a ChainStep, the sequence generators are ...Within the optimization of the menu generation, this MR moves the ability to generate the CAs after the menu alignment, so during the createDataFlow(). This requires few changes
1. When creating a ChainStep, the sequence generators are stored in self.sequenceFunctions, passed via functools.partial
2. the ChainStep has self.create() function to create the CAs when needed, and store them in the self.sequences
3. all loops on self.sequences must be replaced by self.sequenceFucntions
4. in the alignment, use isEmptySequenceCfg to recognise an empty sequence
5. Changes in the emulation tests to use functools.partial
6. Changes in the jet and MET signatures code to handle functools.partial
7. the NoAlg chains that run PEBInfoWriter appears with one step during the sequence generation, so this requires a change in isNoAlg() function
Configuration comparison:
`Run with arguments: confTool.py --diff HLTJobOptions.json ../test_orig/HLTJobOptions.json Step 1: reference file #components: 79030 Step 2: file to check #components: 79030 Legend: Differences in components Settings in 1st file Settings in 2nd file Component PerfMonMTSvc may differ wallTimeOffset = 1711385097450.0 vs 1711129147120.0 << but all are suppressed by renaming/known differences/...`https://gitlab.cern.ch/atlas/athena/-/merge_requests/70155TileMonitoring: Update Tile online monitoring script for cosmics2024-03-28T11:30:33+01:00Siarhei HarkushaTileMonitoring: Update Tile online monitoring script for cosmicsScript to run online Tile monitoring has been modified to
add possibility to monitor onlline events from cosmics streams seperately,
and to increase events buffer sizes of monitoring tasks for online monitoring.Script to run online Tile monitoring has been modified to
add possibility to monitor onlline events from cosmics streams seperately,
and to increase events buffer sizes of monitoring tasks for online monitoring.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70151athena.py: remove cppyy_minvmem command line option2024-03-28T11:30:32+01:00Frank Winklmeierathena.py: remove cppyy_minvmem command line optionRemove obsolete `--cppyy_minvmem` command line option and the special
handling of the "expert" group and help message.
Closes ATEAM-970.Remove obsolete `--cppyy_minvmem` command line option and the special
handling of the "expert" group and help message.
Closes ATEAM-970.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70149Update collisions_run.config - add the new han configuration for all the l1ca...2024-03-28T11:30:32+01:00Will ButtingerUpdate collisions_run.config - add the new han configuration for all the l1calo monitoring changes