athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-28T11:30:34+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/70124TileMonitoring: Remove legacy config from TileMBTSMonitorAlgorithm (ATLASRECT...2024-03-28T11:30:34+01:00Siarhei HarkushaTileMonitoring: Remove legacy config from TileMBTSMonitorAlgorithm (ATLASRECTS-7939)New-style (CA-based) configuration of the TileMBTSMonitorAlgorithm algorithm
has been updated to remove legacy part (compatibility with legacy JO).New-style (CA-based) configuration of the TileMBTSMonitorAlgorithm algorithm
has been updated to remove legacy part (compatibility with legacy JO).https://gitlab.cern.ch/atlas/athena/-/merge_requests/70122TileMonitoring: Remove legacy config from TileDQFragMonitorAlgorithm (ATLASRE...2024-03-28T11:30:34+01:00Siarhei HarkushaTileMonitoring: Remove legacy config from TileDQFragMonitorAlgorithm (ATLASRECTS-7939)New-style (CA-based) configuration of the TileDQFragMonitorAlgorithm
has been updated to remove legacy part (compatibility with legacy JO).New-style (CA-based) configuration of the TileDQFragMonitorAlgorithm
has been updated to remove legacy part (compatibility with legacy JO).https://gitlab.cern.ch/atlas/athena/-/merge_requests/70116Fixes for TauAntiTauJetOverlapTool2024-03-27T08:55:47+01:00Thomas StreblerFixes for TauAntiTauJetOverlapToolFollow up to !69115
Basically
```if(!m_decHelper->isSurvivingObject(*tau) || !isSurvivingAntiTau(*tau)) continue;```
should be used instead of
```if(!m_decHelper->isSurvivingObject(*tau) && !isSurvivingAntiTau(*tau)) continue;```
Adde...Follow up to !69115
Basically
```if(!m_decHelper->isSurvivingObject(*tau) || !isSurvivingAntiTau(*tau)) continue;```
should be used instead of
```if(!m_decHelper->isSurvivingObject(*tau) && !isSurvivingAntiTau(*tau)) continue;```
Added extra clean up also to remove taus failing both ID and antiTauID, to have them failing OR for sure
FYI @princke @pbokan @bmoserhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70002CPAlgorithms: allow for event selection at particle-level2024-03-28T12:00:11+01:00Baptiste Ravinabaptiste.ravina@cern.chCPAlgorithms: allow for event selection at particle-levelSome users need to run the event selection algorithms using so-called "particle-level" objects (`TruthElectrons`, `TruthMuons`, etc.). This requires the following changes to the event selectors:
- make the MET term a configurable option:...Some users need to run the event selection algorithms using so-called "particle-level" objects (`TruthElectrons`, `TruthMuons`, etc.). This requires the following changes to the event selectors:
- make the MET term a configurable option: at reco-level it's most likely "Final" (new default), at truth-level it's most likely "NonInt"
- replace `xAOD::ElectronContainer` etc. by `xAOD::IParticleContainer` to be able to pass either reco- or truth-level containers
- in a couple of cases, event selectors need to access `charge()`, which is not available for `xAOD::IParticle`. There I simply added dedicated `xAOD::TruthParticleContainer` handles, and I populate the correct type of handle based on a switch in the python config.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70114main-cppcheck-FakeBkgTools2024-03-26T14:49:18+01:00Shaun Roemain-cppcheck-FakeBkgToolscppcheck performance defect: pass parameters by const ref instead of valuecppcheck performance defect: pass parameters by const ref instead of valuehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70080Clean-up of TrackRecord header ahead of further updates2024-03-26T14:16:07+01:00John Derek ChapmanClean-up of TrackRecord header ahead of further updatesCleaning up the TrackRecord header in preparation to migrate it from
being based on truth barcodes to be-based on truth status and id.
Most changes relate to renaming `GetBarCode()` to the more standard `barcode()` and `SetBarCode()` to...Cleaning up the TrackRecord header in preparation to migrate it from
being based on truth barcodes to be-based on truth status and id.
Most changes relate to renaming `GetBarCode()` to the more standard `barcode()` and `SetBarCode()` to `SetBarcode()`.
I may make a follow-up MR further standardising method names, but I prefer to get the current changes in first.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70098Extend TRT_HitCollectionCnv unit tests2024-03-26T14:15:27+01:00John Derek ChapmanExtend TRT_HitCollectionCnv unit testsThis merge request extends the TRT_HitCollectionCnv unit tests to examine the level of compression achieved in the persistent versions.This merge request extends the TRT_HitCollectionCnv unit tests to examine the level of compression achieved in the persistent versions.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70104RNTupleART: Add two new tests that compare RNTuple and TTree DAODs2024-03-26T14:15:06+01:00Alaettin Serhan MeteRNTupleART: Add two new tests that compare RNTuple and TTree DAODsAdd two more tests (one for data and one for MC) to `RNTupleART` that:
1. Produce `DAOD_PHYS` and `DAOD_PHYSLITE` storing event data into `TTree`,
2. Produce `DAOD_PHYS` and `DAOD_PHYSLITE` storing event data into `RNTuple`,
3. Convert ...Add two more tests (one for data and one for MC) to `RNTupleART` that:
1. Produce `DAOD_PHYS` and `DAOD_PHYSLITE` storing event data into `TTree`,
2. Produce `DAOD_PHYS` and `DAOD_PHYSLITE` storing event data into `RNTuple`,
3. Convert 2. into `TTree` by (ab)using `Merge_tf.py`,
4. Compare both formats via `diff-root`.
For some reason `diff-root` doesn't seem to work properly in the `main--dev3LCG` in my local tests but that can be followed up independently.
cc: @gemmeren @mnowakhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70090ATR-28985 Trigger request for Multijet TLA2024-03-26T14:38:22+01:00Francesco CurcioATR-28985 Trigger request for Multijet TLAhttps://its.cern.ch/jira/browse/ATR-28985https://its.cern.ch/jira/browse/ATR-28985https://gitlab.cern.ch/atlas/athena/-/merge_requests/70086Add missing TruthMetaData to LLP12024-03-26T14:13:29+01:00Jonathan LongAdd missing TruthMetaData to LLP1!61980 changed the way metadata is stored and !63100 fixed this for PHYS and PHYSLITE.!61980 changed the way metadata is stored and !63100 fixed this for PHYS and PHYSLITE.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70107Removed all remaining references to the InputFilePeeker2024-03-26T14:13:04+01:00Vakhtang TsulaiaRemoved all remaining references to the InputFilePeekerDropped either complete files or individual functions that unconditionally relied on the `InputFilePeeker`.
Also dropped the clients of such files/functions.
Closes ATEAM-716
CC @fwinkl @harkusha @amete @ssnyder (Please feel free to t...Dropped either complete files or individual functions that unconditionally relied on the `InputFilePeeker`.
Also dropped the clients of such files/functions.
Closes ATEAM-716
CC @fwinkl @harkusha @amete @ssnyder (Please feel free to tag more people as needed. Thanks)https://gitlab.cern.ch/atlas/athena/-/merge_requests/70099Clean-up of MDTSimHit.h2024-03-26T14:12:38+01:00John Derek ChapmanClean-up of MDTSimHit.hWas previously part of !69655, which had to be reverted while other changes
are debugged. This part is still safe to go in though.
It allows deformations to be applied to an already created MDTSimHit instance.Was previously part of !69655, which had to be reverted while other changes
are debugged. This part is still safe to go in though.
It allows deformations to be applied to an already created MDTSimHit instance.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69753Add algorithm to compute technical performance for Acts tracks.2024-03-26T14:12:21+01:00Goetz GayckenAdd algorithm to compute technical performance for Acts tracks.The algorithm computes particle reconstruction efficiency of particles
which are considered reconstructible, the hit efficiency and purity.
These values are computed in eta bins (or optionally in PDG ID bins),
and can be further divided...The algorithm computes particle reconstruction efficiency of particles
which are considered reconstructible, the hit efficiency and purity.
These values are computed in eta bins (or optionally in PDG ID bins),
and can be further divided by pt. The reference truth particles can be
selected.
Also added algorithm to count measurements associated to truth particles.
The output of the latter is needed for the former.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70088Use APRDefaults to name the Event Data TTree/RNTuple2024-03-26T14:10:45+01:00Marcin NowakUse APRDefaults to name the Event Data TTree/RNTupleMake the AtheaPool Conversion Service use by default the prefix defined in APRDefaults as the name prefix for POOL containers. This prefix in most cases corresponds to the name of the main Event Data TTree/RNTuple.
There should be no...Make the AtheaPool Conversion Service use by default the prefix defined in APRDefaults as the name prefix for POOL containers. This prefix in most cases corresponds to the name of the main Event Data TTree/RNTuple.
There should be no change for the standard "CollectionTree" name in normal Athena jobs. But by configuring the Output.StorageTechnology.EventData="ROOTRNTUPLE" the main RNTuple will be now by default called "EventData" (or whatever is specified in APRDefaults).
These defaults can be still overridden in the usual way by setting the Prefix property of this service.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70113MuonDQA: remove references to Run-2 monitoring config2024-03-26T14:38:22+01:00Frank WinklmeierMuonDQA: remove references to Run-2 monitoring confighttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70115LArMonitoring: delete legacy job options2024-03-26T14:38:22+01:00Frank WinklmeierLArMonitoring: delete legacy job optionshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70117Pixel Calibration - adding getters and fixing typos2024-03-26T14:38:22+01:00Sergi Rodriguez BoscaPixel Calibration - adding getters and fixing typosThis MR is meant to add the getters in the Calibration info files as well as to fix some typos in the variable names.
Output remains unchanged.This MR is meant to add the getters in the Calibration info files as well as to fix some typos in the variable names.
Output remains unchanged.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70112ZdcMonitoring: cleanup references to legacy config2024-03-26T14:38:22+01:00Frank WinklmeierZdcMonitoring: cleanup references to legacy configRemove references to legacy config and updates link dependencies.Remove references to legacy config and updates link dependencies.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70087CaloNoise: Add method to get getEffectiveSigma by IdentiiferHash2024-03-26T13:35:24+01:00Walter LamplCaloNoise: Add method to get getEffectiveSigma by IdentiiferHashCaloNoise: Add method to get getEffectiveSigma by IdentiiferHash to avoid unnecessary back-and-forth conversion of identifiersCaloNoise: Add method to get getEffectiveSigma by IdentiiferHash to avoid unnecessary back-and-forth conversion of identifiershttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70094ActsTrackFinding: simplify filling of helper objects2024-03-26T13:34:08+01:00Tim AdyeActsTrackFinding: simplify filling of helper objects* `TrackingSurfaceHelper` vector can now be filled element-by-element. This simplifies (and maybe slightly speeds up) its use in `CoreStripSpacePointFormationTool`, `ProtoTrackCreationAndFitAlg`, and `TrackFindingAlg`.
* `TrackFindingMea...* `TrackingSurfaceHelper` vector can now be filled element-by-element. This simplifies (and maybe slightly speeds up) its use in `CoreStripSpacePointFormationTool`, `ProtoTrackCreationAndFitAlg`, and `TrackFindingAlg`.
* `TrackFindingMeasurements::addDetectorElements()` call doesn't need the whole `clusterContainer`, just the measurement type.
* Remove `gatherGeoIds()`, moving functionality into `TrackFindingMeasurements::addDetectorElements`
* Improve `MeasurementRangeList` API
* Avoid taking reference to temporary object when constructing `CkfBranchStopper`. This was only used by `TrackStatePrinter`.
* Rationalise some names in `TrackFindingMeasurements`: `m_measurementOffset` → `m_measurementOffsets`, `measurementOffsets()` → `measurementContainerOffsets()`, and `measurementOffsetVector()` → `measurementOffsets()`.