athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2018-12-29T03:02:31+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/20127ForwardRegionGeoModel: Avoid use of non-bound DataHandle.2018-12-29T03:02:31+01:00Scott SnyderForwardRegionGeoModel: Avoid use of non-bound DataHandle.Deprecating use of non-bound DataHandle, especially non-const.Deprecating use of non-bound DataHandle, especially non-const.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20130RegSelLUT: Fix gcc9 warnings.2018-12-29T03:02:33+01:00Scott SnyderRegSelLUT: Fix gcc9 warnings.In C++11, implicit declarations of copy and assignment are deprecated if the
class has a user defined destructor or copy or assignment. gcc9 now warns
about this by default.
Adjust to avoid the warning.In C++11, implicit declarations of copy and assignment are deprecated if the
class has a user defined destructor or copy or assignment. gcc9 now warns
about this by default.
Adjust to avoid the warning.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20080athenaHLT: Write histograms into their own directory for child processes2018-12-29T03:02:34+01:00Frank WinklmeierathenaHLT: Write histograms into their own directory for child processesWe were getting basically empty histogram files when running in `athenaHLT.py` because the mother overwrote the ROOT file of the children. This MR fixes this by placing the ROOT files into their own directory when running with the offlin...We were getting basically empty histogram files when running in `athenaHLT.py` because the mother overwrote the ROOT file of the children. This MR fixes this by placing the ROOT files into their own directory when running with the offline `THistSvc`.
- Add the missing call to `updateDFProps` after the fork to
individualize the child properties (e.g. app name).
- Use the `IoComponentMgr` to mange the I/O for child processes as done in
athenaMP. This creates a sub-directory for each child into which histogram
files are being written.
- With the above we can run also in `athenaHLT.py` using the offline
`THistSvc`.
TODO: It's not nice that we are creating empty directories in case the
online `THistSvc` is used. Can probably add a check on the number of
registered files and if zero, don't bother with the I/O component
manager. But this is for a future MR.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20131LArG4H6SD: Fix gcc9 warnings.2018-12-29T03:02:38+01:00Scott SnyderLArG4H6SD: Fix gcc9 warnings.In C++11, implicit declarations of copy and assignment are deprecated if the
class has a user defined destructor or copy or assignment. gcc9 now warns
about this by default.
Adjust to avoid the warning.In C++11, implicit declarations of copy and assignment are deprecated if the
class has a user defined destructor or copy or assignment. gcc9 now warns
about this by default.
Adjust to avoid the warning.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20112Code cleanup and addition of TestSCT_DistortionsTool (ATLASRECTS-4575)2018-12-29T03:02:40+01:00Susumu OdaCode cleanup and addition of TestSCT_DistortionsTool (ATLASRECTS-4575)Code cleanup and addition of TestSCT_DistortionsTool
https://its.cern.ch/jira/browse/ATLASRECTS-4575Code cleanup and addition of TestSCT_DistortionsTool
https://its.cern.ch/jira/browse/ATLASRECTS-4575https://gitlab.cern.ch/atlas/athena/-/merge_requests/20093Adds missing L1 triggers to MC skim for H5D32018-12-30T03:02:31+01:00Matthew Henry KleinAdds missing L1 triggers to MC skim for H5D3Adds 2017-18 L1 triggers for MC skim for HIGG5D3.Adds 2017-18 L1 triggers for MC skim for HIGG5D3.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20140LArGeoTBEC: cmake fix2018-12-31T03:02:11+01:00Scott SnyderLArGeoTBEC: cmake fixRemoving dangling use of CLHEP_LIBRARIES.Removing dangling use of CLHEP_LIBRARIES.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20090ATR-19014 Pseudomerge muon trigger 21.0-TrigMC to master2018-12-31T03:02:14+01:00Marcus Matthias MorgensternATR-19014 Pseudomerge muon trigger 21.0-TrigMC to masterPseudomerge for muon trigger
Started from scratch and all test passing now.
Update packages:TrigmuComb TrigmuIso TrigMuonEF TrigmuRoI TrigMuSuperEF TrigTileMuId TrigMuonCoinHierarchy TrigMuonMatching muon from upstream/21.0-TrigMC...Pseudomerge for muon trigger
Started from scratch and all test passing now.
Update packages:TrigmuComb TrigmuIso TrigMuonEF TrigmuRoI TrigMuSuperEF TrigTileMuId TrigMuonCoinHierarchy TrigMuonMatching muon from upstream/21.0-TrigMC to upstream/master via pseudo-mergehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20071Cleanup of SCTCalib for ATLASRECTS-45752018-12-31T03:02:16+01:00Susumu OdaCleanup of SCTCalib for ATLASRECTS-4575Code cleanup of SCTCalib algorithm only for the SCT Calibration Loop.
For https://its.cern.ch/jira/browse/ATLASRECTS-4575Code cleanup of SCTCalib algorithm only for the SCT Calibration Loop.
For https://its.cern.ch/jira/browse/ATLASRECTS-4575https://gitlab.cern.ch/atlas/athena/-/merge_requests/20138MuonGeoModel: Fix clang warning.2018-12-31T03:02:19+01:00Scott SnyderMuonGeoModel: Fix clang warning.clang warning: unused variable.clang warning: unused variable.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20142MuonCondSvc: Comply with ATLAS naming convention.2018-12-31T03:02:22+01:00Scott SnyderMuonCondSvc: Comply with ATLAS naming convention.Private data members should start with m_.Private data members should start with m_.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20141CavernInfraGeoModel: camke fix2018-12-31T03:02:24+01:00Scott SnyderCavernInfraGeoModel: camke fixRemove danging uses of CLHEP macros.Remove danging uses of CLHEP macros.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20139TRT_GeoModel: Fix clang warnings.2018-12-31T03:02:25+01:00Scott SnyderTRT_GeoModel: Fix clang warnings.Clang warnings: missing override keywords.Clang warnings: missing override keywords.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20023New map in ElectronEfficiencyCorrection and example for 2e17 in TrigGlobalEff...2019-01-03T11:24:25+01:00Philip SommerNew map in ElectronEfficiencyCorrection and example for 2e17 in TrigGlobalEfficiencyCorrectionChanges related to an update in the trigger scale factors:
- new map file in ElectronEfficiencyCorrection which includes the full set of supported electron triggers, see ATR-18843, ATR-18903
- amongst others, this includes the 2e17 diel...Changes related to an update in the trigger scale factors:
- new map file in ElectronEfficiencyCorrection which includes the full set of supported electron triggers, see ATR-18843, ATR-18903
- amongst others, this includes the 2e17 dielectron trigger which was accidentally prescaled for a short period in 2017, see discussion in ATR-17746
- a small example how the scale factors for 2e17 can be used in TrigGlobalEfficiencyCorrection
Cheers,
Philip and @jmaurer, @thrynova, @fernandohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/20095fix copy2019-01-03T11:58:06+01:00Tulay Cuhadar Donszelmannfix copyCloses #216Closes #216https://gitlab.cern.ch/atlas/athena/-/merge_requests/20143Add more tests to SCT_ConditionsAlgorithms package2019-01-04T03:02:08+01:00Susumu OdaAdd more tests to SCT_ConditionsAlgorithms packageAdd more tests to SCT_ConditionsAlgorithms package.Add more tests to SCT_ConditionsAlgorithms package.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20157TrigValTools: Fix gcc9 warnings.2019-01-04T03:02:10+01:00Scott SnyderTrigValTools: Fix gcc9 warnings.In C++11, implicit declarations of copy and assignment are deprecated if the
class has a user defined destructor or copy or assignment. gcc9 now warns
about this by default.
Adjust to avoid the warning.
Also avoid potential memory prob...In C++11, implicit declarations of copy and assignment are deprecated if the
class has a user defined destructor or copy or assignment. gcc9 now warns
about this by default.
Adjust to avoid the warning.
Also avoid potential memory problem copying TFileLooper objects.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20159AthenaMonitoring: Fix clang warnings.2019-01-04T03:02:12+01:00Scott SnyderAthenaMonitoring: Fix clang warnings.Clang warnings: unused private data members.Clang warnings: unused private data members.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20155BeamEffects: Fixes for unit test.2019-01-04T03:02:14+01:00Scott SnyderBeamEffects: Fixes for unit test.Lengthen timeout; ignore messages with filenames.
Allow overriding location of input file.
Fix unmerged component.Lengthen timeout; ignore messages with filenames.
Allow overriding location of input file.
Fix unmerged component.https://gitlab.cern.ch/atlas/athena/-/merge_requests/20150RegSelLUT: Fix clang warnings.2019-01-04T03:02:15+01:00Scott SnyderRegSelLUT: Fix clang warnings.Clang warnings: unused private data members.Clang warnings: unused private data members.