athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-17T15:43:11+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/67647Draft: Online Event Displays to CA2024-03-17T15:43:11+01:00Melissa YexleyDraft: Online Event Displays to CAThis is a WIP for the Online Event Displays reconstruction using CA.This is a WIP for the Online Event Displays reconstruction using CA.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67630Draft: Use PropertyProxy from Gaudi2024-02-19T11:20:40+01:00Frank WinklmeierDraft: Use PropertyProxy from GaudiExperimental MR to migrate to Gaudi's `PropertyProxy` (and `ConfigurableDb`). In principle there are only very few differences and this would avoid having to maintain our own copy each time a new property type gets added.
Ideally, we wo...Experimental MR to migrate to Gaudi's `PropertyProxy` (and `ConfigurableDb`). In principle there are only very few differences and this would avoid having to maintain our own copy each time a new property type gets added.
Ideally, we would do the same for the (legacy) `Configurable` class but that requires more cleanup first (i.e. removing the support of the CA behavior once we no longer need it).https://gitlab.cern.ch/atlas/athena/-/merge_requests/67596Draft: Convert source links to EL2024-02-19T11:02:10+01:00Tomasz BoldDraft: Convert source links to ELWith this change the sourceLinks are converted to EL to UncalibratedMeasurements (on the spot - may be optimised out in the future).
However in particular usecases the object pointed to by the sourceLink does not seem to this EL type.
R...With this change the sourceLinks are converted to EL to UncalibratedMeasurements (on the spot - may be optimised out in the future).
However in particular usecases the object pointed to by the sourceLink does not seem to this EL type.
Running:
../athena/AtlasTest/CITest/test/ActsGSFInEgamma.sh + debugger indicates the issue in MeasurementCalibrator.
@pagessin this is the issue mentioned in !67561
```
#0 0x00007f9bf2ab4350 in __cxa_throw () from /cvmfs/sft.cern.ch/lcg/releases/gcc/13.1.0-b3d18/x86_64-el9/lib64/libstdc++.so.6
#1 0x00007f9bafa4528f in Acts::AnyBase<16ul>::operator= (other=..., this=<optimized out>)
at /cvmfs/atlas-nightlies.cern.ch/repo/sw/main_Athena_x86_64-el9-gcc13-opt/2023-12-04T2101/AthenaExternals/24.0.17/InstallArea/x86_64-el9-gcc13-opt/include/Acts/Utilities/Any.hpp:210
#2 0x00007f9bafa453bf in Acts::AnyBase<16ul>::as<ElementLink<DataVector<xAOD::UncalibratedMeasurement_v1, DataModel_detail::NoBase> > > (
this=this@entry=0x7fffb69ebca0) at /srv/athena/Tracking/Acts/ActsEvent/Root/MultiTrajectory.cxx:233
#3 Acts::SourceLink::get<ElementLink<DataVector<xAOD::UncalibratedMeasurement_v1, DataModel_detail::NoBase> > > (this=this@entry=0x7fffb69ebca0)
at /cvmfs/atlas-nightlies.cern.ch/repo/sw/main_Athena_x86_64-el9-gcc13-opt/2023-12-04T2101/AthenaExternals/24.0.17/InstallArea/x86_64-el9-gcc13-opt/include/Acts/EventData/SourceLink.hpp:66
#4 ActsTrk::MutableMultiTrajectory::setUncalibratedSourceLink_impl (this=<optimized out>, istate=<optimized out>, sourceLink=...)
at /srv/athena/Tracking/Acts/ActsEvent/Root/MultiTrajectory.cxx:393
#5 0x00007f9baf66d853 in Acts::MultiTrajectory<ActsTrk::MutableMultiTrajectory>::setUncalibratedSourceLink<false, void> (sourceLink=...,
istate=<optimized out>, this=<optimized out>)
at /cvmfs/atlas-nightlies.cern.ch/repo/sw/main_Athena_x86_64-el9-gcc13-opt/2023-12-04T2101/AthenaExternals/24.0.17/InstallArea/x86_64-el9-gcc13-opt/include/Acts/EventData/MultiTrajectory.hpp:1494
#6 Acts::detail_lt::TrackStateProxy<ActsTrk::MutableMultiTrajectory, 6ul, false>::setUncalibratedSourceLink<false, void> (sourceLink=...,
this=0x7fffb69ebd00)
at /cvmfs/atlas-nightlies.cern.ch/repo/sw/main_Athena_x86_64-el9-gcc13-opt/2023-12-04T2101/AthenaExternals/24.0.17/InstallArea/x86_64-el9-gcc13-opt/include/Acts/EventData/MultiTrajectory.hpp:744
#7 ActsTrk::TrkMeasurementCalibrator<ActsTrk::MutableMultiTrajectory>::operator() (this=0x4f523ce0, gctx=..., cctx=..., sl=..., trackState=...)
at /srv/athena/Tracking/Acts/ActsTrackReconstruction/src/MeasurementCalibrator.h:206
#8 0x00007f9baf64c06b in std::__invoke_impl<void, void (ActsTrk::TrkMeasurementCalibrator<ActsTrk::MutableMultiTrajectory>::*)(Acts::ContextType const&, std::any const&, Acts::SourceLink const&, Acts::detail_lt::TrackStateProxy<ActsTrk::MutableMultiTrajectory, 6ul, false>) const, ActsTrk::TrkMeasurementCalibrator<ActsTrk::MutableMultiTrajectory> const*&, Acts::ContextType const&, std::any const&, Acts::SourceLink const&, Acts::detail_lt::TrackStateProxy<ActsTrk::MutableMultiTrajectory, 6ul, false> > (__f=<optimized out>, __t=<synthetic pointer>: <optimized out>)
at /cvmfs/sft.cern.ch/lcg/releases/gcc/13.1.0-b3d18/x86_64-el9/include/c++/13.1.0/bits/invoke.h:74
...
```https://gitlab.cern.ch/atlas/athena/-/merge_requests/67578Draft: MuonReadoutGeomtetryCnv - Add translation of Rpc detectors2024-03-24T09:32:22+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chDraft: MuonReadoutGeomtetryCnv - Add translation of Rpc detectorshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67505Draft: Update TruthIncidents and ISFParticle to know about uniqueID2024-03-28T11:19:33+01:00John Derek ChapmanDraft: Update TruthIncidents and ISFParticle to know about uniqueID(ATLASSIM-6978)(ATLASSIM-6978)https://gitlab.cern.ch/atlas/athena/-/merge_requests/67450Draft: Adding HGTD_Altiroc2Tool with basic info for smearing2024-02-26T08:07:02+01:00Alexander LeopoldDraft: Adding HGTD_Altiroc2Tool with basic info for smearingTo assess the impact of effects seen in the ASIC prototype (Altiroc 2) on track-time performance, a specific smearing tool will be implemented that should run only when configured for specific sample requests.To assess the impact of effects seen in the ASIC prototype (Altiroc 2) on track-time performance, a specific smearing tool will be implemented that should run only when configured for specific sample requests.Alexander LeopoldAlexander Leopoldhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67422Draft: Columnar egamma SF tool2024-03-14T22:36:37+01:00Matthias ViglDraft: Columnar egamma SF toolMatthias ViglMatthias Viglhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67388Try to use C++20 starts_with2024-03-21T13:16:05+01:00Andrii VerbytskyiTry to use C++20 starts_withTry to use C++20 starts_withTry to use C++20 starts_withhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67306Draft: Test script to run ActsTrackFinding, Athena ambi, and IDPVM2024-02-19T11:03:50+01:00Tim AdyeDraft: Test script to run ActsTrackFinding, Athena ambi, and IDPVMFor development testing, not maintained for production or anything else.
Is it OK to include this in Athena to aid development collaboration?For development testing, not maintained for production or anything else.
Is it OK to include this in Athena to aid development collaboration?https://gitlab.cern.ch/atlas/athena/-/merge_requests/67271Run3 Derivations for heavy Ion group (part of my QT) v02024-03-19T09:35:52+01:00Sebastian Alonso Infante CabanasRun3 Derivations for heavy Ion group (part of my QT) v0Migration for HION4 almost done, lacking augmentations and string triggers for run3, some smart collections of run2 HION4 not working for now
Migration for HION7 in progress, in need of the "pt" needed and the triggers
Rest of migratio...Migration for HION4 almost done, lacking augmentations and string triggers for run3, some smart collections of run2 HION4 not working for now
Migration for HION7 in progress, in need of the "pt" needed and the triggers
Rest of migrations not started as of november 21 of 2023
No derivative is made to get truth data as i dont have truth data files for testinghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67195Draft: Added new TruthParticle and TruthVertex aux containers.2024-03-13T11:57:38+01:00John Derek ChapmanDraft: Added new TruthParticle and TruthVertex aux containers.Extra changes on top of !66561
Tagging @akraszna, @averbyts and @pclarkExtra changes on top of !66561
Tagging @akraszna, @averbyts and @pclarkhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66794Draft: ComponentAccumulator: implement async merges2024-02-19T10:59:01+01:00Frank WinklmeierDraft: ComponentAccumulator: implement async mergesProof-of-concept (not proposing to merge this in its current form) to implement asynchronous merging in `ComponentAccumulator`, e.g.:
```py
acc = ComponentAccumulator()
acc.async_merge(MyCfg, flags)
acc.async_merge(MyOtherCfg, flags)
.....Proof-of-concept (not proposing to merge this in its current form) to implement asynchronous merging in `ComponentAccumulator`, e.g.:
```py
acc = ComponentAccumulator()
acc.async_merge(MyCfg, flags)
acc.async_merge(MyOtherCfg, flags)
...
acc.async_wait()
```
Changed `RecoSteering` to apply this for the various reco domains. Results in speedup from 2:00 (91% CPU) minutes to 1:35 (136%) with a process Pool of size 4. This means there is unfortunately not enough parallelism to even fully utilize two cores.
Notes:
- Requires the [`multiprocess`](https://pypi.org/project/multiprocess) module (available in LCG) which uses `dill` for object serialization (the default `pickle` cannot handle the `lamba`s in `AthConfigFlags`)
- Apart from differences in the order of some property values the final config pkl is the same
- By splitting the configuration into sub-processes we loose potential optimizations from the `AccumulatorCache` and cache statics are not reported back to the main process
- Cannot be applied "blindly", e.g. post-processing still needs to run last
- Process pool size would need to be made configurable
- Log output is messy
To reproduce one needs to setup the full LCG release:
```sh
export LCG_RELEASE_BASE=/cvmfs/sft.cern.ch/lcg/releases
asetup --noLcgReleaseBase Athena,main,latest
```https://gitlab.cern.ch/atlas/athena/-/merge_requests/66790Draft: Revise the TgcDigitMaker2024-02-19T10:58:27+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chDraft: Revise the TgcDigitMaker* Consistently use `double` for floating point arithmetric
* Use Gaudi::Units everywhere
* Deploy the `TgcDigitJitterData` to replace the mutlidimensional `m_vecAngle_Time` variable and its filling mechanism
* Remove the `m_isDeadChamber...* Consistently use `double` for floating point arithmetric
* Use Gaudi::Units everywhere
* Deploy the `TgcDigitJitterData` to replace the mutlidimensional `m_vecAngle_Time` variable and its filling mechanism
* Remove the `m_isDeadChamber` array + filling mechanism in favour of the `TgcCondDbData`
* Remove the `m_energyThreshold` array + filling mechanism in favour of the `TgcDigitThresholdData`
* Useage of the `MuonDetectorManager` from the conditions store
Tagging: @masato, @junpeihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66616Draft: TgcReadoutGeometry clean up & removal of a couple of bugs2024-03-27T00:33:16+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chDraft: TgcReadoutGeometry clean up & removal of a couple of bugs- Clean up interface of the TgcReadoutElement
- Optimize calculation of the wire group position. Remove recursive calculation approach in favour of a caching
- Fix the calculation of the trapezoidal width for negative z- Clean up interface of the TgcReadoutElement
- Optimize calculation of the wire group position. Remove recursive calculation approach in favour of a caching
- Fix the calculation of the trapezoidal width for negative zhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66502Draft: MR for triggering jobs for CI training and tests on EL9, please never ...2024-01-02T19:56:34+01:00Alexander UndrusDraft: MR for triggering jobs for CI training and tests on EL9, please never acceptThis MR is created to trigger test jobs in the CI system. Please do not accept it.This MR is created to trigger test jobs in the CI system. Please do not accept it.Alexander UndrusAlexander Undrushttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66329Draft: Nsw fast segment maker2024-03-16T20:25:28+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chDraft: Nsw fast segment makerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66109Draft: Migrating POOL internal containers to the main event storage technology2024-02-19T10:56:32+01:00Alaettin Serhan MeteDraft: Migrating POOL internal containers to the main event storage technologyCreating this placeholder MR to follow-up on the work and interact among ourselves...
Closes ATEAM-926
cc: @gemmeren @mnowakCreating this placeholder MR to follow-up on the work and interact among ourselves...
Closes ATEAM-926
cc: @gemmeren @mnowakhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/65802Draft: VP1: Fix local time with dynamic "CET"/"CEST" label instead of using h...2024-02-19T11:59:55+01:00Riccardo Maria Bianchiriccardo.maria.bianchi@cern.chDraft: VP1: Fix local time with dynamic "CET"/"CEST" label instead of using hardcoded "CEST"Currently, VP1 appends a hardcoded "CEST" (Central European Summer Time) to all time labels without checking if the local timestamp is under DST or not.
The EventInfo stores time-zone-independent, UTC Posix time, which VP1 converts to l...Currently, VP1 appends a hardcoded "CEST" (Central European Summer Time) to all time labels without checking if the local timestamp is under DST or not.
The EventInfo stores time-zone-independent, UTC Posix time, which VP1 converts to local time by using the `<ctime>` and the `QDateTime` classes in `VP1ExecutionScheduler` and `VP1EventDisplayEditor` respectively.
However, since the "CEST" label is appended to all time labels, it looks wrong when an event has been recorded during not DST, for example, Autumn time.
This MR fixes the issue that can arise from the hardcoded label by checking the DST flag and then adds "CEST" or "CEST" accordingly.
**NOTE:** This is also compatible with the time labels computed and shown in Atlantis.
----
Cc: @lshihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63853Draft: Rolling MR for ACTS nightly2024-03-28T09:33:35+01:00Paul Gessinger-BefurtDraft: Rolling MR for ACTS nightlyhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63422Draft: Start of Q.T for Vertex construction from outputs of GNN2024-03-26T12:15:37+01:00Luke Francis McelhinneyDraft: Start of Q.T for Vertex construction from outputs of GNNImplements a secondary vertex reconstruction algorithm based on the vertex groupings identified by GN2. Work in progress.
Tagging @svanstro @pgadow @hartman @dguest @fdibelloImplements a secondary vertex reconstruction algorithm based on the vertex groupings identified by GN2. Work in progress.
Tagging @svanstro @pgadow @hartman @dguest @fdibello