athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-28T11:30:34+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/70083Dev new histograms2024-03-28T11:30:34+01:00Grigorii TolkachevDev new histogramsNew selections for histograms used for LAr Monitoring have been added.
Bugs and typos have been fixed as well.New selections for histograms used for LAr Monitoring have been added.
Bugs and typos have been fixed as well.Grigorii TolkachevGrigorii Tolkachevhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70082LArByteStrean+LArCondAthenaPool: remove legacy job options2024-03-25T14:01:59+01:00Frank WinklmeierLArByteStrean+LArCondAthenaPool: remove legacy job optionshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70081main-cppcheck-DataQualityUtils2024-03-26T10:29:45+01:00Shaun Roemain-cppcheck-DataQualityUtilscppcheck: unused return value, now formally ignored.cppcheck: unused return value, now formally ignored.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70080Clean-up of TrackRecord header ahead of further updates2024-03-26T14:16:07+01:00John Derek ChapmanClean-up of TrackRecord header ahead of further updatesCleaning up the TrackRecord header in preparation to migrate it from
being based on truth barcodes to be-based on truth status and id.
Most changes relate to renaming `GetBarCode()` to the more standard `barcode()` and `SetBarCode()` to...Cleaning up the TrackRecord header in preparation to migrate it from
being based on truth barcodes to be-based on truth status and id.
Most changes relate to renaming `GetBarCode()` to the more standard `barcode()` and `SetBarCode()` to `SetBarcode()`.
I may make a follow-up MR further standardising method names, but I prefer to get the current changes in first.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70079main-cppcheck-InDetPhysValMonitoring2024-03-25T14:54:12+01:00Shaun Roemain-cppcheck-InDetPhysValMonitoringMove to at-declaration initialisation of members in InDetPerfPlot_Vertex, solving uninitialised members warning in the processMove to at-declaration initialisation of members in InDetPerfPlot_Vertex, solving uninitialised members warning in the processhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70078Harmonize data preparation for secondary passes and trigger view filler2024-03-28T17:50:45+01:00Carlo Varnicarlo.varni@cern.chHarmonize data preparation for secondary passes and trigger view fillerThis creates an algorithm that produces a data prep collection (cluster or space point) with `VIEW_ELEMENT` owning policy. Input can be either a same type collection (e.g. cluster collection from main pass data prep stage) or an IDC.
The...This creates an algorithm that produces a data prep collection (cluster or space point) with `VIEW_ELEMENT` owning policy. Input can be either a same type collection (e.g. cluster collection from main pass data prep stage) or an IDC.
The ViewFiller algorithm is thus included into this. The original implementation of the View filler algorithm has been removed.
At offline level, this can be used on secondary passes to retrieve the desired collections and possibly applying some selection criteria on them.
The class is templated on the data prep collection as well as on a boolean for determining if the cache mechanism has to be used or not
/cc @pagessin @bkerridghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70077Revert merge request !69655 (ATLSWUPGR-242)2024-03-25T14:46:45+01:00John Derek ChapmanRevert merge request !69655 (ATLSWUPGR-242)Merge request !69655 causes unintended output changes in some ART tests: ATLSWUPGR-242
Therefore reverting for now to allow me to do some further testing/tweaking of the changes before reintroducing them.Merge request !69655 causes unintended output changes in some ART tests: ATLSWUPGR-242
Therefore reverting for now to allow me to do some further testing/tweaking of the changes before reintroducing them.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70076DerivationFrameworkMCTruth: add read handles to ClassifyAndCalculateHFAugment...2024-03-26T10:29:09+01:00Bertrand Martin Dit LatourDerivationFrameworkMCTruth: add read handles to ClassifyAndCalculateHFAugmentationHello,
This MR is replacing `evtStore()->retrieve` with ReadHandles, to be able to run derivations in MT (ATLASG-2470).
It fixes the error:
```
19:55:08 StoreGateSvc 0 0 WARNING retrieve(con...Hello,
This MR is replacing `evtStore()->retrieve` with ReadHandles, to be able to run derivations in MT (ATLASG-2470).
It fixes the error:
```
19:55:08 StoreGateSvc 0 0 WARNING retrieve(const): No valid proxy for object AntiKt4TruthWZJets of type xAOD::JetContainer(CLID 1244316195)
19:55:08 ToolSvc.DFCommonClassifyAndCalculateHFAugmentation 0 0 ERROR could not retrieve JetContainer ' 'jetCollectionName':'AntiKt4TruthWZJets''
19:55:08 HFClassificationCommonKernel 0 0 ERROR Augmentation failed!
```
Decorators are also replaced with DecorHandles.
Cheers,
Bertrandhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70075Updating/expanding JetRecConfig README2024-03-25T09:59:26+01:00Chris Malena DelitzschUpdating/expanding JetRecConfig READMEIn light of the documentation week, some examples are added to JetRecConfig.
Tagging @mswiatlo and @bhodkinsIn light of the documentation week, some examples are added to JetRecConfig.
Tagging @mswiatlo and @bhodkinshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70074AFP monitoring update code style2024-03-26T14:38:23+01:00Viktoriia LysenkoAFP monitoring update code styleAFP monitoring, dqm algorithms: update code style + bug fixAFP monitoring, dqm algorithms: update code style + bug fixViktoriia LysenkoViktoriia Lysenkohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70073fix StepName2024-03-26T14:38:24+01:00Tatiana Ovsiannikovafix StepNameremove the chain name in the stepName definition for Calratio hypos (ATR-29044)remove the chain name in the stepName definition for Calratio hypos (ATR-29044)https://gitlab.cern.ch/atlas/athena/-/merge_requests/70072Create HIGG1D3 for Higgs->yy + eta_c->4pi2024-03-25T11:16:45+01:00Xin ChenCreate HIGG1D3 for Higgs->yy + eta_c->4piCreating a new derivation format HIGG1D3 for Higgs->yy + eta_c->4pi search. Borrowing the good stuff from HIGG1D1 about Higgs->yy and adding the facility class EtacTo4TracksVertex in BPhys for eta_c. The new format's python file lives in...Creating a new derivation format HIGG1D3 for Higgs->yy + eta_c->4pi search. Borrowing the good stuff from HIGG1D1 about Higgs->yy and adding the facility class EtacTo4TracksVertex in BPhys for eta_c. The new format's python file lives in DerivationFrameworkHiggs.Xin ChenXin Chenhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/700712024-03-23: merge of 24.0 into main2024-03-24T15:44:57+01:00Frank Winklmeier2024-03-23: merge of 24.0 into mainThis sweep contains the following MRs:
* !69782 cTAU algorithm upgrade - added eTAU rCore/BDT and rHad score cuts ~Tau, ~Trigger, ~TriggerMenu
* !70013 xAODCnv: delete legacy job options referencing RecExConfig ~EDM, ~Tau, ~Trigger
* !7...This sweep contains the following MRs:
* !69782 cTAU algorithm upgrade - added eTAU rCore/BDT and rHad score cuts ~Tau, ~Trigger, ~TriggerMenu
* !70013 xAODCnv: delete legacy job options referencing RecExConfig ~EDM, ~Tau, ~Trigger
* !70031 Cherry pick - 69552 ~MuonSpectrometer, ~Trigger
* !70027 Reduce INFO to DEBUG in RorSeqFilter ( ATR-28971) ~Triggerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70070Fixed clang warnings2024-03-23T14:35:53+01:00Vakhtang TsulaiaFixed clang warnings1. `AFPToFAlgorithm`. Uninitialized variable (plus a few cosmetic changes)
2. `MuonSpacePoint`. Unused local variable1. `AFPToFAlgorithm`. Uninitialized variable (plus a few cosmetic changes)
2. `MuonSpacePoint`. Unused local variablehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70069Fix for the multi-threaded event service configuration2024-03-26T14:38:23+01:00Vakhtang TsulaiaFix for the multi-threaded event service configurationWith this change, the multi-threaded event service can be activated by
the combination of the `--multithreaded=True` and the `--eventService=True`
command-line arguments of the job transform
The reason why we submit this MR to the ~"24....With this change, the multi-threaded event service can be activated by
the combination of the `--multithreaded=True` and the `--eventService=True`
command-line arguments of the job transform
The reason why we submit this MR to the ~"24.0" branch is because we may need
to run the next round of Event Service / Raythena validations with one of the
upcoming 24.0.X releases.
CC @juesseivhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70068Run the TIDA Tier0 monitoring correctly2024-03-26T14:38:24+01:00Mark SuttonRun the TIDA Tier0 monitoring correctlyWasn't running because the hist service was not being configured correctly
Fixes ATR-28759Wasn't running because the hist service was not being configured correctly
Fixes ATR-28759https://gitlab.cern.ch/atlas/athena/-/merge_requests/70067Draft: add option to patch bug in micromegas simulation when deriving muon tr...2024-03-22T18:00:27+01:00Valerio IppolitoDraft: add option to patch bug in micromegas simulation when deriving muon trigger SFsThis MR is meant to address, at the level of muon trigger SF retrieval, the bug in the micromegas simulation discussed in [ATR-28607](https://its.cern.ch/jira/browse/ATR-28607).
A configuration option (which by default is set to `false`...This MR is meant to address, at the level of muon trigger SF retrieval, the bug in the micromegas simulation discussed in [ATR-28607](https://its.cern.ch/jira/browse/ATR-28607).
A configuration option (which by default is set to `false`) is added to the `MuonTriggerScaleFactors` tool. Whenever this option is activated, if an event is a MC event and if the MC run number (as emulated from the pileup reweighting tool) is a 2022 or 2023 run number then, instead of accessing the scale factors prepared for the corresponding periods of data taking - for example period `F` - the code accesses special maps prepared for period `FX`.
This implies that efficiency maps in the 2022 and 2023 files are duplicated for each period, and that the periods ending with `X` contain the efficiency map corresponding to the case in which the micromegas simulation bug is present.
The underlying approximation is that the check performed by the function `MuonTriggerScaleFactors::hasMMbug()` is accurate enough to discriminate the set of events which have no micromegas hits, and those which do.
Tagging @yoyamagu, and the muon trigger SF team (@ffabbri, @gwmyers, @syan and @nkyriaco). The MR is still in draft mode, as I am just exploring the technical feasibility of this solution - we still need to agree this is the best way to address the bug.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70066Inclusion of grid tests for GPUs and fix of build test for GPUCalo2024-03-24T11:20:31+01:00Denis Oliveira DamazioInclusion of grid tests for GPUs and fix of build test for GPUCaloContinuing on the direction of ATR-28790. Inclusion of grid tests for GPUs and fix of build test for GPU Calo.Continuing on the direction of ATR-28790. Inclusion of grid tests for GPUs and fix of build test for GPU Calo.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70065CPAlgorithms: updated experimental OverlapRemoval2024-03-25T14:51:10+01:00Baptiste Ravinabaptiste.ravina@cern.chCPAlgorithms: updated experimental OverlapRemovalNew overlap removal scheme based on the nominal-OR decision, but run also for systematically-varied kinematic selections.
This is for experimental tests only at this stage, tagging @mdubovsk @ekourlit. I tested it locally on a small sam...New overlap removal scheme based on the nominal-OR decision, but run also for systematically-varied kinematic selections.
This is for experimental tests only at this stage, tagging @mdubovsk @ekourlit. I tested it locally on a small sample, and I see the intended behaviour in one electron event: the branch `el_select_or` is set to 1, and at the same time we have `el_select_loose_NOSYS` (the nominal ID+Iso+Pt+Eta cuts) set to 0, and all but one systematic variations also set to 0. Using the previous setup (run nominal-OR only, and only on the nominal kinematic selection), this electron event is not present at all.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70064PhysicsAnalysis: required modifications to allow for online and conditional b...2024-03-27T09:03:42+01:00Sven MenkePhysicsAnalysis: required modifications to allow for online and conditional b-tagging treatment in TopPhysThe recommendations for b-tagging scale factors and efficiencies that combine offline WPs with online WPs require changes to JetTagging/JetTagPerformanceCalibration/xAODBTaggingEfficiency and 11 TopPhys packages in order to include b-tag...The recommendations for b-tagging scale factors and efficiencies that combine offline WPs with online WPs require changes to JetTagging/JetTagPerformanceCalibration/xAODBTaggingEfficiency and 11 TopPhys packages in order to include b-tagging systematics and MC to data scale factors in 21.1-based top analyses. The proposed changes here allow to combine one offline WP with a online WP via the provided conditional (online given offline) probabilities provided by the CP-group. The offline trigger confirmation requires furthermore to combine two offline WP (from the same tagger) with the online WP. Also this functionality is provided in the MR.