athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-01-30T12:16:59+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/66880Update to Gaudi v382024-01-30T12:16:59+01:00Frank WinklmeierUpdate to Gaudi v38Update athena projects to [Gaudi v38r0](https://gitlab.cern.ch/gaudi/Gaudi/-/releases/v38r0).
The main braking change is that in Gaudi v38, `std::unordered_set` properties are now represented as python `set` instead of `list`. This most...Update athena projects to [Gaudi v38r0](https://gitlab.cern.ch/gaudi/Gaudi/-/releases/v38r0).
The main braking change is that in Gaudi v38, `std::unordered_set` properties are now represented as python `set` instead of `list`. This mostly affects `CondInputLoader.Load` and the Algorithm's `ExtraInputs/Outputs` property. For details see https://gitlab.cern.ch/gaudi/Gaudi/-/merge_requests/1503 but in practice it means that code like
```py
MyAlg.ExtraInputs += ['foo']
```
has been updated to
```py
MyAlg.ExtraInputs.add('foo')
```
For the moment only `std::unordered_set` is mapped to a Python `set`. Regular `std::set` remains as Python `list` to maintain insertion order.
For backwards compatibility, we allow implicit conversion from `list`, i.e. the following still works:
```py
MyAlg.ExtraInputs = ['foo'] # implicitly converted to {'foo'}
```
In addition some minor `const` interface changes in `DataHandle` that propagate to our `VarHandleKey`.
cc @leggetthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66861import CA-style ConfigFlags object from RecoUsefulFlags to swallow pre-Execs ...2023-11-02T08:00:59+01:00Walter Lamplimport CA-style ConfigFlags object from RecoUsefulFlags to swallow pre-Execs in q-testSome q-type AMI tags have preExecs written in CA-based syntax, eg setting members of the `AthConfigFlags` container. This leads to an early failure in legacy tests. With this MR, the python object `ConfigFlags` (and its alias `flags`) ex...Some q-type AMI tags have preExecs written in CA-based syntax, eg setting members of the `AthConfigFlags` container. This leads to an early failure in legacy tests. With this MR, the python object `ConfigFlags` (and its alias `flags`) exists at the time the preExec is executed by the transform, even w/o the `--CA` method. If the flag set this way is taken into account later is a different question.
Possibly a better fix than !66847https://gitlab.cern.ch/atlas/athena/-/merge_requests/66842main-bugfix-PixelDigitization2023-11-01T16:22:50+01:00Shaun Roemain-bugfix-PixelDigitizationAddresses ATLASSIM-6930; updates legacy configuration so that run1 sim test should pass. Tested locally with test_Digi_tf_mc15_2012_ttbar_no_pileup.sh.Addresses ATLASSIM-6930; updates legacy configuration so that run1 sim test should pass. Tested locally with test_Digi_tf_mc15_2012_ttbar_no_pileup.sh.https://gitlab.cern.ch/atlas/athena/-/merge_requests/66823SCT Heavy Ion webdsiplay update: add coverage plot2023-11-01T07:52:52+01:00Cristiano SebastianiSCT Heavy Ion webdsiplay update: add coverage plotAdding SCT coverage histogram to heavy ion webdisplay. Used by the remote shifters for Data Quality assessment.
tag: @grancagnAdding SCT coverage histogram to heavy ion webdisplay. Used by the remote shifters for Data Quality assessment.
tag: @grancagnhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66781Fix Muon combined config unit test2023-10-30T18:18:02+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chFix Muon combined config unit testCloses ATLASRECTS-7791
Tagging: @sroe. That should probably superseed https://gitlab.cern.ch/atlas/athena/-/merge_requests/66776Closes ATLASRECTS-7791
Tagging: @sroe. That should probably superseed https://gitlab.cern.ch/atlas/athena/-/merge_requests/66776https://gitlab.cern.ch/atlas/athena/-/merge_requests/66775Bump Acts Tag to v30.3.22023-10-28T09:42:05+02:00Carlo Varnicarlo.varni@cern.chBump Acts Tag to v30.3.2This bumps ACTS from v30.3.1 to v30.3.2.
Release notes of in-between versions:
* [v30.3.2](https://github.com/acts-project/acts/releases/tag/v30.3.2)
Last minute patch that is needed to resolve compilation warning in https://gitlab.ce...This bumps ACTS from v30.3.1 to v30.3.2.
Release notes of in-between versions:
* [v30.3.2](https://github.com/acts-project/acts/releases/tag/v30.3.2)
Last minute patch that is needed to resolve compilation warning in https://gitlab.cern.ch/atlas/athena/-/merge_requests/66290https://gitlab.cern.ch/atlas/athena/-/merge_requests/66746Bugfix for ATLASG-26232023-10-26T21:43:32+02:00Baptiste Ravinabaptiste.ravina@cern.chBugfix for ATLASG-2623https://its.cern.ch/jira/browse/ATLASG-2623https://its.cern.ch/jira/browse/ATLASG-2623https://gitlab.cern.ch/atlas/athena/-/merge_requests/66736added top path ZDC/ for all histograms for web display2023-10-27T00:03:19+02:00Yuhan Guoadded top path ZDC/ for all histograms for web displayadded top path ZDC/ for all ZDC & ZDC LED monitoring histograms for web displayadded top path ZDC/ for all ZDC & ZDC LED monitoring histograms for web displayhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66693implemented paths for monitoring histograms2023-10-26T00:06:05+02:00Yuhan Guoimplemented paths for monitoring histogramsimplemented paths for ZDC & RPD monitoring histogramsimplemented paths for ZDC & RPD monitoring histogramshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66643HLT_Calo: Adding FS topocluster in HI hanconfig2023-10-24T00:28:13+02:00Debottam Bakshi GuptaHLT_Calo: Adding FS topocluster in HI hanconfigAs discussed in https://its.cern.ch/jira/browse/ATR-28287?focusedId=4970988&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-4970988 we are FS topocluster monitoring to HeavyIon hanConfig for HLT_Calo. Addi...As discussed in https://its.cern.ch/jira/browse/ATR-28287?focusedId=4970988&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-4970988 we are FS topocluster monitoring to HeavyIon hanConfig for HLT_Calo. Adding @damazio (@ebergeas )https://gitlab.cern.ch/atlas/athena/-/merge_requests/66591Sweeping !66528 from main to 21.2.
correctly pass x509userproxy to condorClos...2023-12-11T16:36:23+01:00Atlas NightlybuildSweeping !66528 from main to 21.2.
correctly pass x509userproxy to condorCloses ATLASG-2561correctly pass x509userproxy to condor
Closes ATLASG-2561
See merge request atlas/athena!66528correctly pass x509userproxy to condor
Closes ATLASG-2561
See merge request atlas/athena!66528https://gitlab.cern.ch/atlas/athena/-/merge_requests/66556Add L1_eEM15_EMPTY to heavy ion menu2023-10-19T10:51:12+02:00Varsha SenthilkumarAdd L1_eEM15_EMPTY to heavy ion menuhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66551adding new UPC EB chains and ID calib chain for HI2023-10-19T10:51:12+02:00Agnieszka Ewa Ogrodnikadding new UPC EB chains and ID calib chain for HIThis MR adds three new EB chains for UPC following as well as new chain for ID calib, ATR-28393
Tagging @jkremer @lidiaz @astruebi @shanisch @tnobe @vsenthil @qhu @angeramiThis MR adds three new EB chains for UPC following as well as new chain for ID calib, ATR-28393
Tagging @jkremer @lidiaz @astruebi @shanisch @tnobe @vsenthil @qhu @angeramihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66529ZdcTrigSimFix2023-10-19T10:51:11+02:00Matthew Caleb HoppeschZdcTrigSimFix2 changes in this MR
1. If we are in a trigger reprocessing, do not use the trigValidTool, it caused a crash from a circular dependency
2. For normal reprocessing, have the trigValidTool use the new ZDC LUT w/ correct thresholds
taggi...2 changes in this MR
1. If we are in a trigger reprocessing, do not use the trigValidTool, it caused a crash from a circular dependency
2. For normal reprocessing, have the trigValidTool use the new ZDC LUT w/ correct thresholds
tagging @asmaga @jkremer @steinber @bcole @rlongohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66525FTAG: add another truth label for light jet studies & improve alg config2023-10-20T15:41:58+02:00Samuel Van StroudFTAG: add another truth label for light jet studies & improve alg configThis MR makes three changes:
- updating the `ftagTruthTypeLabel` to include a category for lambdas
- adding a new `ftagTruthSourceLabel` (someone please let me know if you have a better name), which gives info about the immediate parent...This MR makes three changes:
- updating the `ftagTruthTypeLabel` to include a category for lambdas
- adding a new `ftagTruthSourceLabel` (someone please let me know if you have a better name), which gives info about the immediate parent of the TP (rather than the `ftagTruthOriginLabel` which gives origin info further up the chain in general). This is added to facilitate studies of mis-tagging in light jets.
- adds configurable accessors which is needed for re-running the labelling downstream (see https://gitlab.cern.ch/atlas-flavor-tagging-tools/training-dataset-dumper/-/merge_requests/556)
cc @fdibellohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66513Externals Update, main branch (2023.10.16.)2023-10-16T21:42:22+02:00Attila KrasznahorkayExternals Update, main branch (2023.10.16.)Updated all projects to [atlasexternals-2.0.173](https://gitlab.cern.ch/atlas/atlasexternals/-/tags/2.0.173). The changes wrt. [atlasexternals-2.0.172](https://gitlab.cern.ch/atlas/atlasexternals/-/tags/2.0.172) are (https://gitlab.cern....Updated all projects to [atlasexternals-2.0.173](https://gitlab.cern.ch/atlas/atlasexternals/-/tags/2.0.173). The changes wrt. [atlasexternals-2.0.172](https://gitlab.cern.ch/atlas/atlasexternals/-/tags/2.0.172) are (https://gitlab.cern.ch/atlas/atlasexternals/-/compare/2.0.172...2.0.173):
- Updated the [lwtnn](https://github.com/lwtnn/lwtnn) version to `2.14.1` (thanks to @dguest, helping with ATEAM-905);
- Updated `FindHDF5.cmake` to provide `HDF5_BINARY_PATH` (fixing ATLINFR-5105).
The latter one is relatively ~urgent, as it should be put in place for ATLINFR-5094. Neither of the updates require ~"full-build" but a ~"full-unit-tests" for the modified runtime environment could still be a good idea. (Just to make sure that the improvements are not having unforeseen negative effects. :thinking:)https://gitlab.cern.ch/atlas/athena/-/merge_requests/66460Bugfix for status values of quasi-stable particles in the new-style truth han...2023-10-13T15:43:00+02:00John Derek ChapmanBugfix for status values of quasi-stable particles in the new-style truth handlingFollows !63059. In the case that we are removing quasi-stable particle decays and child
particles from the `GenEvent` before starting the (Geant4) simulation, then the status values
of child particles produced by pre-defined quasi-stable...Follows !63059. In the case that we are removing quasi-stable particle decays and child
particles from the `GenEvent` before starting the (Geant4) simulation, then the status values
of child particles produced by pre-defined quasi-stable particle decays should be set to 1
(or 2 if they themselves have pre-defined decays) rather than 20001 (the status value usually
used to indicate a new secondary particle created during simulation).
Needed for ATLPHYSVAL-960
For reference:
A quasi-stable particle is defined as one which has been decayed by the generator, but could
potentially deposit energy in sensitive regions of the detector. It is therefore passed to
Geant4, which propagates it through the detector then allows it to undergo its pre-defined decay.
Sketch of how `GenParticle` status should be updated for the new scheme.
| Scenario | Old status | Old barcode | New status |
| ------ | ------ | ------ | ------ |
| Nth Truth particle created+decayed during evgen (including particles produced in pre-defined decays) | 2 | N | 2 |
| Nth Truth Particle created, but not decayed during evgen (including particles produced in pre-defined decays) | 1| N | 1 |
| Nth Secondary particle created by an interaction/decay during sim | 1 | 200000 + N | 20001 |
| Generator created particle with has survived M interactions during sim (B = original barcode) |1| B + M*1000000 | 1 + M*100000 |
| Secondary particle created during sim, which has survived M interactions (B = original barcode) |1|B + M*1000000|20001 + M*100000|
Sketch of how `GenVertex` status should be updated for the new scheme.
| Scenario | Old status | Old barcode | New status |
| ------ | ------ | ------ | ------ |
| Nth Truth vertex created during evgen | <1000 (generator specific) | -N | <1000 (same as old scheme) |
| Nth Truth vertex created during sim | 1000 + G4 process | -200000 - N | 20000 + 1000 + G4 process |https://gitlab.cern.ch/atlas/athena/-/merge_requests/66441shortcut for 'lhapdf-config --version' call, which is slow and responsible fo...2023-10-12T21:42:28+02:00Hannes Mildnershortcut for 'lhapdf-config --version' call, which is slow and responsible for timeout errors in MGWe are seeing timeout errors in madgraph, when it calls 'lhapdf-config --version'.
Indeed, our (custom) lhapdf-config is sometimes quite slow as we need to look up paths on cvmfs to find lib and data directories.
However, if we are only...We are seeing timeout errors in madgraph, when it calls 'lhapdf-config --version'.
Indeed, our (custom) lhapdf-config is sometimes quite slow as we need to look up paths on cvmfs to find lib and data directories.
However, if we are only interested in the lhapdf version, we can get this information simply from $LHAPDFVER, which is obviously faster and implemented here.
This is marked as urgent as the issue blocks the creation of a new AthGeneration release.https://gitlab.cern.ch/atlas/athena/-/merge_requests/66432ZDC monitoring updates2023-10-17T11:08:13+02:00Yuhan GuoZDC monitoring updatesadded ZDC module & RPD channel versus LB histograms for calibration, and require module mask for average timeadded ZDC module & RPD channel versus LB histograms for calibration, and require module mask for average timehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66429Sweeping !66424 from main to 21.2.
EventLoop: fix gcc13 compilation2023-10-12T03:43:24+02:00Atlas NightlybuildSweeping !66424 from main to 21.2.
EventLoop: fix gcc13 compilationEventLoop: fix gcc13 compilation
See merge request atlas/athena!66424EventLoop: fix gcc13 compilation
See merge request atlas/athena!66424