athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-26T14:38:24+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/70046DumpGeo: delete legacy job options2024-03-26T14:38:24+01:00Frank WinklmeierDumpGeo: delete legacy job optionshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70045CaloSamplingFractionAnalysis: delete legacy job options2024-03-26T14:38:24+01:00Frank WinklmeierCaloSamplingFractionAnalysis: delete legacy job optionshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70044adding missing et conversion factor for KFMET definition for Ph1Topo2024-03-26T14:38:24+01:00Ralf Gugelralf.gugel@cern.chadding missing et conversion factor for KFMET definition for Ph1TopoThis MR updates the final cut values/thresholds for the Ph1Topo based KFMET algorithm to more realistic values. The algorithm itself is still under commissioning and will certainly require more updates (thresholds but also filter coeffic...This MR updates the final cut values/thresholds for the Ph1Topo based KFMET algorithm to more realistic values. The algorithm itself is still under commissioning and will certainly require more updates (thresholds but also filter coefficients) once technically commissioned. Also the L1Topo simulation for this algorithm will still need updates. Yet, having more realistic thresholds configured in hardware at P1 is desirable to ease the commissioning of the firmware implementation, especially once LHC provides high energy+rate collisions again.
Related to https://its.cern.ch/jira/browse/ATR-28657https://gitlab.cern.ch/atlas/athena/-/merge_requests/70042pT filter for groomed jets before moment calculation2024-03-26T14:38:24+01:00Bertrand Martin Dit LatourpT filter for groomed jets before moment calculationCherry-picking of !70012 from main to 24.0, in case one would attempt to produce DAODs at T0.
pT filter for groomed jets before moment calculation
See merge request atlas/athena!70012
(cherry picked from commit 76ee2287646674958b7f2a8...Cherry-picking of !70012 from main to 24.0, in case one would attempt to produce DAODs at T0.
pT filter for groomed jets before moment calculation
See merge request atlas/athena!70012
(cherry picked from commit 76ee2287646674958b7f2a80e86fa64f39a95267)
b4ee62fd pT filter for groomed jets before moment calculationhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70040Adding originalObjectLink for origin-corrected clusters2024-03-22T10:46:21+01:00Chris Malena DelitzschAdding originalObjectLink for origin-corrected clustersMR simply adds originalObjectLink for `LCOriginTopoClusters` and `EMOriginTopoClusters` to be able to navigate to the underlying `CaloCalTopoClusters` container.MR simply adds originalObjectLink for `LCOriginTopoClusters` and `EMOriginTopoClusters` to be able to navigate to the underlying `CaloCalTopoClusters` container.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70039MuonChamberAssembleTool -- Split BOL7 chambers from the generic BOL sector2024-03-22T17:22:44+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuonChamberAssembleTool -- Split BOL7 chambers from the generic BOL sectorThe BOL7 chamber is actually the BOE chamber and should not belong to the generic BOL sector
Tagging: @goblirsc, @damperiaThe BOL7 chamber is actually the BOE chamber and should not belong to the generic BOL sector
Tagging: @goblirsc, @damperiahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70038MuonSpacePoints - Fix Tgc covariance under the stereo angle2024-03-22T17:22:21+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chMuonSpacePoints - Fix Tgc covariance under the stereo angleTagging: @goblirscTagging: @goblirschttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70037New GeoModel: use CALIBPATH instead of DATAPATH for locating SQLite Geometry ...2024-03-22T10:42:21+01:00Vakhtang TsulaiaNew GeoModel: use CALIBPATH instead of DATAPATH for locating SQLite Geometry DB filesThe CVMFS directory for storing SQLite Geometry Database files is listed in the `CALIBPATH`
environment and not in `DATAPATH`
Thanks @jmaurer for spotting this problem!
CC @jferrand @boudreauThe CVMFS directory for storing SQLite Geometry Database files is listed in the `CALIBPATH`
environment and not in `DATAPATH`
Thanks @jmaurer for spotting this problem!
CC @jferrand @boudreauhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70036sTGC raw data monitoring: fix problem with shifter occupancy plots2024-03-26T14:38:23+01:00Sebastian Julio Fuenzalida GarridosTGC raw data monitoring: fix problem with shifter occupancy plots- Issue with shifter occupancy plots for pads, wires and strips (station eta vs sector), which looked exactly the same.
- The purpose of this MR is to fix this problem by assigning an unique group name for each channel, which makes thes...- Issue with shifter occupancy plots for pads, wires and strips (station eta vs sector), which looked exactly the same.
- The purpose of this MR is to fix this problem by assigning an unique group name for each channel, which makes these plots looks different as expected.
Tagging: @estel @carquinhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70035Update gfex parameters in trigger menu2024-03-26T14:38:23+01:00Cecilia TosciriUpdate gfex parameters in trigger menuWith this MR the gFEX parameters in the Trigger Menu are changed as discussed in ATR-29036.With this MR the gFEX parameters in the Trigger Menu are changed as discussed in ATR-29036.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70034Correcting the nameing for firstPadPhiDivision and PadPhiShift in R42024-03-22T14:12:11+01:00Ishan Kiritbhai VyasCorrecting the nameing for firstPadPhiDivision and PadPhiShift in R4@jojungge @pscholer@jojungge @pscholerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70033Update to Gaudi v38r0.0012024-03-22T14:29:08+01:00Frank WinklmeierUpdate to Gaudi v38r0.001Update Gaudi to v38r0.001 in ~main. See https://gitlab.cern.ch/atlas/athena/-/merge_requests/70025 for details.
cc @leggettUpdate Gaudi to v38r0.001 in ~main. See https://gitlab.cern.ch/atlas/athena/-/merge_requests/70025 for details.
cc @leggetthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70032fix for ATR-29037 - No such flag: minTRTonTrk2024-03-21T19:59:47+01:00Jiri Masikfix for ATR-29037 - No such flag: minTRTonTrkquick fix for ATR-29037 - No such flag: minTRTonTrkquick fix for ATR-29037 - No such flag: minTRTonTrkhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70031Cherry pick - 695522024-03-23T12:23:16+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chCherry pick - 69552bug fix with off by one pointer check
See merge request atlas/athena!69552
(cherry picked from commit 3de6ba47a4dde15da2d68d4208b96387df5f1eb8)
eb67be97 bug fix with off by one pointer check
Tagging: @ekajomov, @pscholerbug fix with off by one pointer check
See merge request atlas/athena!69552
(cherry picked from commit 3de6ba47a4dde15da2d68d4208b96387df5f1eb8)
eb67be97 bug fix with off by one pointer check
Tagging: @ekajomov, @pscholerhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70030ATR-28968: Reduce INFO messages from central trigger configuration code2024-03-26T14:38:23+01:00Teng Jian KhooATR-28968: Reduce INFO messages from central trigger configuration codeChange all of these to DEBUG:
- ATR-28977: cloneAndReplace info message
- ATR-28983: RoI unpacking tool messages
- ATR-28979: GapFiller
- ATR-28984: Athena scheduler Data Flow/Control Flow printouts in a full menu job, full menu CA d...Change all of these to DEBUG:
- ATR-28977: cloneAndReplace info message
- ATR-28983: RoI unpacking tool messages
- ATR-28979: GapFiller
- ATR-28984: Athena scheduler Data Flow/Control Flow printouts in a full menu job, full menu CA dump
I anticipate that people may have opinions on the last of these, but hopefully if we enable these printouts automatically in reduced menu jobs (i.e. for debugging), and they are already easy to enable via flags, this is a good compromise.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70029Moved APRDefaults.h from POOLCore to RootUtils2024-03-22T08:41:02+01:00Marcin NowakMoved APRDefaults.h from POOLCore to RootUtilsThe new location makes the ROOT file structure naming information from this header accessible also in AnalysisBase.
I was also thinking about AthenaKernel as a good location for the header. I can move it there is people think it woul...The new location makes the ROOT file structure naming information from this header accessible also in AnalysisBase.
I was also thinking about AthenaKernel as a good location for the header. I can move it there is people think it would be a better idea.
Relates to ATEAM-969.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70027Reduce INFO to DEBUG in RorSeqFilter (ATR-28971)2024-03-23T12:23:16+01:00Francesca PastoreReduce INFO to DEBUG in RorSeqFilter (ATR-28971)https://gitlab.cern.ch/atlas/athena/-/merge_requests/700262024-03-21: merge of 24.0 into main2024-03-22T08:46:02+01:00Frank Winklmeier2024-03-21: merge of 24.0 into mainThis sweep contains the following MRs:
* !70032 fix for ATR-29037 - No such flag: minTRTonTrk ~Trigger, ~TriggerID
* !70018 Fix issue with incomplete hashing in HLT Nav conversion ~Trigger
* !70014 AthenaPython: delete copy_file and ...This sweep contains the following MRs:
* !70032 fix for ATR-29037 - No such flag: minTRTonTrk ~Trigger, ~TriggerID
* !70018 Fix issue with incomplete hashing in HLT Nav conversion ~Trigger
* !70014 AthenaPython: delete copy_file and read_file utilities ~Core
* !69991 LArCafJobs: delete legacy config referencing RecExConfig ~LAr
* !69714 MuonConfig: drop RPC cabling map override ~MuonSpectrometer, ~Run3-MCReco-output-changed, ~Tools
* !70015 TrigPSC+TrigServices: set ConcurrencyFlags::numProcs ~Core, ~Trigger
* !69969 ID trigger: dynamic creation of flags ~Trigger, ~TriggerID
* !70001 L1calo efex tau bdt add max and min thresholds ~L1Calo, ~Trigger
* !69992 Remove HLT_e5_lhvloose_bBeeM6000_L1BKeePrimary from T0 monitoring ~Trigger, ~TriggerMenu
* !69865 More fixes for !68913: hasFlag and iterators ~Core
* !69996 Fixes for wrong stream assignment VBFDelayed -> PhysicsStream ~Trigger, ~TriggerMenu
* !69833 AFP ToF monitoring new hist + bugfix ~DQ, ~ForwardDetectors
* !69984 Fix physval memory leak, ATLASDQ-1136 ~DQ
* !69988 TBDetDescrAlg: delete legacy config and cleanup ~TestBeam
* !69987 ForwardTransport[Svc]: delete legacy configuration ~ForwardDetectors
* !69958 Adding versioning in ZDC calibration files via parameter for TDirectory name ~ForwardDetectors
* !69796 fixes some details of the task, container names and updates file to be used. ~DQ, ~LAr
* !69945 Prevent ONNX from spawning additional threads ~Simulation
* !69930 ZDC CA synchronized with Tier0 version ~ForwardDetectors
* !69886 StoreGate: add SG::HiveMgrSvc::setNumProcs helper ~Core
* !68579 AFT-702: Add heterogeneous input support for GN2 ~Analysis, ~BTagging, ~JetEtmiss
* !69899 Fix LAr CAF jobs ~LAr
* !69857 CA-based script to populate the LAr Bad Feb database ~LAr
* !69981 AFP_GeoModel+Digitization: delete legacy job options ~Digitization, ~ForwardDetectors
* !69949 Protect possible rare FPEs in trigger ~Tracking
* !69963 gFEX pileup threshold update ~EDM, ~JetEtmiss, ~L1Calo, ~Trigger
* !69917 ZdcRec: delete legacy configuration ~ForwardDetectors
* !69967 NTUPtoNTUPCore: delete unused package ~Analysis
* !69971 ForwardRec: delete legacy job options ~ForwardDetectors
* !69966 LArL1Sim: delete legacy job options ~LAr
* !69959 Remove custom JetSuper Roi zedHalfWidth ~JetEtmiss, ~Trigger, ~TriggerID
* !69970 Disable ONNXRuntime CUDA Support, 24.0 branch (2024.03.20.) ~Build
* !69939 ATR-28870: add hh4b GN2 80% chain to physics ~Trigger, ~TriggerMenu, ~changes-trigger-countshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70025Update to Gaudi v38r0.0012024-03-25T16:45:17+01:00Frank WinklmeierUpdate to Gaudi v38r0.001A very minor patch to our current Gaudi version. Changes compared to v38r0.000 (see [diff](https://gitlab.cern.ch/atlas/Gaudi/-/compare/v38r0.000...v38r0.001?from_project_id=6676&straight=false)):
- New `maxParallelismExtra` property in...A very minor patch to our current Gaudi version. Changes compared to v38r0.000 (see [diff](https://gitlab.cern.ch/atlas/Gaudi/-/compare/v38r0.000...v38r0.001?from_project_id=6676&straight=false)):
- New `maxParallelismExtra` property in `AvalancheSchedulerSvc` to adjust the maximum TBB parallelism ( gaudi/Gaudi!1567)
This is required for the new async I/O HltEventLoopMgr ( ATR-26285) to be usable at Point-1. The default behavior is unchanged.
cc @ssottoco @leggetthttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70023Do not create views at offline level but only RoIs2024-03-26T10:30:38+01:00Carlo Varnicarlo.varni@cern.chDo not create views at offline level but only RoIsThis will replace the ACTS Event View maker with a simple algorithm for creating an RoI for later use in (e.g.) the clustering
Current sequence:
![graphviz__11_](/uploads/2cc97bd7ba463b023533d57ac638c6d3/graphviz__11_.png)This will replace the ACTS Event View maker with a simple algorithm for creating an RoI for later use in (e.g.) the clustering
Current sequence:
![graphviz__11_](/uploads/2cc97bd7ba463b023533d57ac638c6d3/graphviz__11_.png)