athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-02-19T10:59:17+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/68409Draft: Changing path of ReadKeyStatic, ITk Pixel & Strip2024-02-19T10:59:17+01:00Xilin WangDraft: Changing path of ReadKeyStatic, ITk Pixel & StripReadKeyStatic path is modified for ITk pixel and strip, to make sure it's reading into ITk align folder.ReadKeyStatic path is modified for ITk pixel and strip, to make sure it's reading into ITk align folder.Nicholas StylesXilin WangNicholas Styleshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66794Draft: ComponentAccumulator: implement async merges2024-02-19T10:59:01+01:00Frank WinklmeierDraft: ComponentAccumulator: implement async mergesProof-of-concept (not proposing to merge this in its current form) to implement asynchronous merging in `ComponentAccumulator`, e.g.:
```py
acc = ComponentAccumulator()
acc.async_merge(MyCfg, flags)
acc.async_merge(MyOtherCfg, flags)
.....Proof-of-concept (not proposing to merge this in its current form) to implement asynchronous merging in `ComponentAccumulator`, e.g.:
```py
acc = ComponentAccumulator()
acc.async_merge(MyCfg, flags)
acc.async_merge(MyOtherCfg, flags)
...
acc.async_wait()
```
Changed `RecoSteering` to apply this for the various reco domains. Results in speedup from 2:00 (91% CPU) minutes to 1:35 (136%) with a process Pool of size 4. This means there is unfortunately not enough parallelism to even fully utilize two cores.
Notes:
- Requires the [`multiprocess`](https://pypi.org/project/multiprocess) module (available in LCG) which uses `dill` for object serialization (the default `pickle` cannot handle the `lamba`s in `AthConfigFlags`)
- Apart from differences in the order of some property values the final config pkl is the same
- By splitting the configuration into sub-processes we loose potential optimizations from the `AccumulatorCache` and cache statics are not reported back to the main process
- Cannot be applied "blindly", e.g. post-processing still needs to run last
- Process pool size would need to be made configurable
- Log output is messy
To reproduce one needs to setup the full LCG release:
```sh
export LCG_RELEASE_BASE=/cvmfs/sft.cern.ch/lcg/releases
asetup --noLcgReleaseBase Athena,main,latest
```https://gitlab.cern.ch/atlas/athena/-/merge_requests/66790Draft: Revise the TgcDigitMaker2024-02-19T10:58:27+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chDraft: Revise the TgcDigitMaker* Consistently use `double` for floating point arithmetric
* Use Gaudi::Units everywhere
* Deploy the `TgcDigitJitterData` to replace the mutlidimensional `m_vecAngle_Time` variable and its filling mechanism
* Remove the `m_isDeadChamber...* Consistently use `double` for floating point arithmetric
* Use Gaudi::Units everywhere
* Deploy the `TgcDigitJitterData` to replace the mutlidimensional `m_vecAngle_Time` variable and its filling mechanism
* Remove the `m_isDeadChamber` array + filling mechanism in favour of the `TgcCondDbData`
* Remove the `m_energyThreshold` array + filling mechanism in favour of the `TgcDigitThresholdData`
* Useage of the `MuonDetectorManager` from the conditions store
Tagging: @masato, @junpeihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68286Draft: Enable truth-stitching in AnalysisTop2024-02-19T10:57:25+01:00Waltteri LeinonenDraft: Enable truth-stitching in AnalysisTop# Draft : do not merge!
Some changes to the AnalysisTop code to enable truth-stitching - these changes primarly just combine all the truthparticles from all containers in tthpartonhistory.h, and apply a decoration to them to show which c...# Draft : do not merge!
Some changes to the AnalysisTop code to enable truth-stitching - these changes primarly just combine all the truthparticles from all containers in tthpartonhistory.h, and apply a decoration to them to show which container they come from.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68582Draft: [ATR-28536][ATR-28717] Working towards a trigger EDM refactor and inte...2024-02-19T10:57:11+01:00Tim MartinDraft: [ATR-28536][ATR-28717] Working towards a trigger EDM refactor and integrating R4 into the EDM (part B)Follows from !68370
I would like some input on these proposed changes, cc @cantel, @okuprash, @wiedenma, @fwinkl before un-drafting (also I am trampling over some bjet changes I need to undo before un-drafting)
Here in part B, I aim to...Follows from !68370
I would like some input on these proposed changes, cc @cantel, @okuprash, @wiedenma, @fwinkl before un-drafting (also I am trampling over some bjet changes I need to undo before un-drafting)
Here in part B, I aim to make the following changes
* Change the signature of `getTriggerEDMList` to require the config flags (but make it such that it doesn't crash if you supply `None` for some e.g. standalone test use cases). Update all clients.
* Introduce a new function, `getRawTriggerEDMList` which takes `flags`. Every user of the `TriggerEDMRun3.TriggerHLTListRun3` should obtain this list via this function such that every client gets a consistent copy. Updated all clients.
* Mark the internal functions inside `TriggerEDM` with an initial underscore.
* Removed unused functions inside `TriggerEDM`.
* Move the `addExtraCollectionsToEDMList` function from the `TriggerEDMRun3` file to the `TriggerEDM` file.
To follow in the next part:
* Attempt to refactor `addHLTNavigationToEDMList` using the new `flags.Trigger.ExtraEDMFunction` - this will be hard...
* Add caching to the `getRawTriggerEDMList` function.
* Make it harder to obtain `TriggerEDMRun3.TriggerHLTListRun3` without going via `getRawTriggerEDMList(flags, 3)`, maybe wrap this list in a simple class.
* Connect up the Run 4 EDM filehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66109Draft: Migrating POOL internal containers to the main event storage technology2024-02-19T10:56:32+01:00Alaettin Serhan MeteDraft: Migrating POOL internal containers to the main event storage technologyCreating this placeholder MR to follow-up on the work and interact among ourselves...
Closes ATEAM-926
cc: @gemmeren @mnowakCreating this placeholder MR to follow-up on the work and interact among ourselves...
Closes ATEAM-926
cc: @gemmeren @mnowakhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68107Draft: Add a few showershape variables for photons and electrons to DAOD_LLP12024-02-19T10:55:13+01:00Andrew Caldon SmithDraft: Add a few showershape variables for photons and electrons to DAOD_LLP1Add a selection of strip variables to DAOD_LLP1 derivation for electrons and photons. These variables are useful for the Run 3 SUSY displaced leptons analysis to distinguish displaced electrons reconstructed as photons from fakes backgro...Add a selection of strip variables to DAOD_LLP1 derivation for electrons and photons. These variables are useful for the Run 3 SUSY displaced leptons analysis to distinguish displaced electrons reconstructed as photons from fakes background.
Marked as draft while I check the size difference on some data/MC sampleshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67750Draft: Add truth particle to secondaries2024-02-19T10:53:17+01:00Rui WangDraft: Add truth particle to secondaries@jchapman Adding truth particle to secondaries using the ITruthSvc
Getting error
`ServiceManager FATAL No Service factory for ISF_TruthRecordSvc available.`
when running `test_MC16_ATLFAST3F_ACTSMT_ttbar.sh`
- /Simulation/ISF/I...@jchapman Adding truth particle to secondaries using the ITruthSvc
Getting error
`ServiceManager FATAL No Service factory for ISF_TruthRecordSvc available.`
when running `test_MC16_ATLFAST3F_ACTSMT_ttbar.sh`
- /Simulation/ISF/ISF_Acts/ISF_ActsTools/CMakeLists.txt
- /Simulation/ISF/ISF_Acts/ISF_ActsTools/src/ActsFatrasSimTool.h
- /Simulation/ISF/ISF_Acts/ISF_ActsTools/src/ActsFatrasSimTool.cxxRui WangRui Wanghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67745Draft: Legacy EM Final Removal - ATR-28612.2024-02-19T10:52:39+01:00John Patrick Mc GowanDraft: Legacy EM Final Removal - ATR-28612.Remove legacy EM items from physics menu and move to MC menu.
Add L1_eEM5_EMPTY and L1_eEM9_FIRSTEMPTY to L1 EM items.
Remove legacy EM triggers from reference countsRemove legacy EM items from physics menu and move to MC menu.
Add L1_eEM5_EMPTY and L1_eEM9_FIRSTEMPTY to L1 EM items.
Remove legacy EM triggers from reference countshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61052Allow overriding of compression algorithm and level2024-02-19T10:51:49+01:00Tadej Novaktadej.novak@cern.chAllow overriding of compression algorithm and levelAllow overriding of compression algorithm and level similar to what was implemented for the auto flush.
Fixes ATLASRECTS-7504.
/cc @gemmeren @ameteAllow overriding of compression algorithm and level similar to what was implemented for the auto flush.
Fixes ATLASRECTS-7504.
/cc @gemmeren @ametehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/63005Draft: Add IDTrig_MC23a_preInclude.py to the default MC23a.py preInclude2024-02-13T09:18:50+01:00Tadej Novaktadej.novak@cern.chDraft: Add IDTrig_MC23a_preInclude.py to the default MC23a.py preIncludeAdd `IDTrig_MC23a_preInclude.py` to the default `MC23a.py` preInclude.
Related to ATR-27486.
/cc @martindl @hartjAdd `IDTrig_MC23a_preInclude.py` to the default `MC23a.py` preInclude.
Related to ATR-27486.
/cc @martindl @hartjhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66502Draft: MR for triggering jobs for CI training and tests on EL9, please never ...2024-01-02T19:56:34+01:00Alexander UndrusDraft: MR for triggering jobs for CI training and tests on EL9, please never acceptThis MR is created to trigger test jobs in the CI system. Please do not accept it.This MR is created to trigger test jobs in the CI system. Please do not accept it.Alexander UndrusAlexander Undrushttps://gitlab.cern.ch/atlas/athena/-/merge_requests/62617Draft: MR for triggering jobs for CI training and tests, please never accept2023-09-01T00:43:54+02:00Alexander UndrusDraft: MR for triggering jobs for CI training and tests, please never acceptThis MR is created to trigger test jobs in the CI system. Please do not accept it.This MR is created to trigger test jobs in the CI system. Please do not accept it.Alexander UndrusAlexander Undrus