athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2023-12-13T19:01:29+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/67794gFEX JetAlgo: fix blkOutAB2023-12-13T19:01:29+01:00Cecilia ToscirigFEX JetAlgo: fix blkOutABThe MR is meant to fix a bug reported in ATR-28625. The arguments to `gFEXJetAlgo::blkOutAB` are now passed by reference.The MR is meant to fix a bug reported in ATR-28625. The arguments to `gFEXJetAlgo::blkOutAB` are now passed by reference.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67788Adding a new UserHook to compute the DJRs for CKKW_L merging scheme and the t...2024-01-10T19:28:11+01:00Safa Gaidsafa.gaid@cern.chAdding a new UserHook to compute the DJRs for CKKW_L merging scheme and the tutorial about the use of the UserHookI Added a new UserHook for Pythia8 to compute the DJRs for the CKKW_L merging algorithm.
Furthermore, in the Pythia8_i README, I integrated a tutorial providing a detailed explanation of the steps for using the UserHook and interpreting ...I Added a new UserHook for Pythia8 to compute the DJRs for the CKKW_L merging algorithm.
Furthermore, in the Pythia8_i README, I integrated a tutorial providing a detailed explanation of the steps for using the UserHook and interpreting the resulting histograms.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67772MuonReadoutGeometry: fix compilation problems in debug.2023-12-12T11:50:41+01:00Edward MoyseMuonReadoutGeometry: fix compilation problems in debug.The problem was here:
```cpp
#ifdef NDEBUG
float TgcReadoutElement::gangThickness(int /*gasGap*/, int /*gang*/) const
#else
float TgcReadoutElement::gangThickness(int gasGap, int gang) const
#endif
{
assert(validGang(...The problem was here:
```cpp
#ifdef NDEBUG
float TgcReadoutElement::gangThickness(int /*gasGap*/, int /*gang*/) const
#else
float TgcReadoutElement::gangThickness(int gasGap, int gang) const
#endif
{
assert(validGang(gasGap, gang));
return 0.05 * CLHEP::mm;
}
```
const was removed in opt but not dbg. But we cannot remove const here too because `validGang` is const, and changing this will have knock-on consequences in all the other const methods.
Reverting the static change for this function.
Fixes ATLASRECTS-7858https://gitlab.cern.ch/atlas/athena/-/merge_requests/67760TrigInDetTrackFitter: Fix clang warnings.2023-12-11T21:01:40+01:00Scott SnyderTrigInDetTrackFitter: Fix clang warnings.Braces in initializers.
Unused variables.Braces in initializers.
Unused variables.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67752decoder compatibility with stgc l1av2 and l1av12023-12-14T16:48:48+01:00Enrique Kajomovitz Mustdecoder compatibility with stgc l1av2 and l1av1There is a new version of the l1a module for the trigger processor.
This version of the decoder includes a workaround that makes it compatible with the two versions without configuration.
There may be changes needed downstream with re...There is a new version of the l1a module for the trigger processor.
This version of the decoder includes a workaround that makes it compatible with the two versions without configuration.
There may be changes needed downstream with respect to the container. since some fields have updated names in the decoder (which are in line with the two versions)https://gitlab.cern.ch/atlas/athena/-/merge_requests/67748Remove unused test file2023-12-11T14:47:27+01:00Stewart Martin-HaughRemove unused test fileUnused test script not migrated to CA (ATR-28619). Can just remove this.Unused test script not migrated to CA (ATR-28619). Can just remove this.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67734Fix rpcHashId in NRPC for consistency with legacy RPCs2023-12-10T23:03:39+01:00Matteo NegriniFix rpcHashId in NRPC for consistency with legacy RPCsFix the definition of rpcHashId in NRPC for consistency with legacy RPCs as can be seen here:
https://gitlab.cern.ch/atlas/athena/-/blob/main/MuonSpectrometer/MuonCnv/MuonRPC_CnvTools/src/RpcRdoToPrepDataToolMT.cxx?ref_type=heads#L962Fix the definition of rpcHashId in NRPC for consistency with legacy RPCs as can be seen here:
https://gitlab.cern.ch/atlas/athena/-/blob/main/MuonSpectrometer/MuonCnv/MuonRPC_CnvTools/src/RpcRdoToPrepDataToolMT.cxx?ref_type=heads#L962https://gitlab.cern.ch/atlas/athena/-/merge_requests/67719DerivationFrameworkMCTruth: Fix clang warning.2023-12-10T18:55:38+01:00Scott SnyderDerivationFrameworkMCTruth: Fix clang warning.Unused variable.Unused variable.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67673[ATR-24829] Switch on ERROR mode for HLT seeding validation2023-12-07T14:05:06+01:00Tim Martin[ATR-24829] Switch on ERROR mode for HLT seeding validationWas not able to easily reproduce a seeding violation offline like last time I tried, might have made some mistake then.
Hence trying to flip this flag to pick up low-level violations in a weekly reprocessing instead.Was not able to easily reproduce a seeding violation offline like last time I tried, might have made some mistake then.
Hence trying to flip this flag to pick up low-level violations in a weekly reprocessing instead.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67641BPHY22: added container with two-tracks candidates2023-12-11T09:18:50+01:00Laily SultanaliyevaBPHY22: added container with two-tracks candidatesNow container BPHY22DiTrkCandidates is stored in the output DAODs.Now container BPHY22DiTrkCandidates is stored in the output DAODs.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67636Draft: ATR-28329: Revert MR640182024-01-22T09:33:50+01:00Binbin DongDraft: ATR-28329: Revert MR64018Revert https://gitlab.cern.ch/atlas/athena/-/merge_requests/64018/ as it caused difference on `DL1dv01` b-tagger.\
See details of discussion here: https://gitlab.cern.ch/atlas/athena/-/merge_requests/64018#note_7391147
cc @dguest, @fdib...Revert https://gitlab.cern.ch/atlas/athena/-/merge_requests/64018/ as it caused difference on `DL1dv01` b-tagger.\
See details of discussion here: https://gitlab.cern.ch/atlas/athena/-/merge_requests/64018#note_7391147
cc @dguest, @fdibello, @ligang.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67609Draft: Use more DecayProducts in MCTruthClassifier2023-12-11T07:28:04+01:00Andrii VerbytskyiDraft: Use more DecayProducts in MCTruthClassifierUse more DecayProducts in MCTruthClassifierUse more DecayProducts in MCTruthClassifierhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67562Add convertor for PRD to xAOD PROD2024-01-10T18:48:27+01:00Edward MoyseAdd convertor for PRD to xAOD PROD
This introduces a new algorithm to convert PRD to xAOD PRDs for Muons (it could easily be extended to e.g. ITK as well).
This also adds the start of a unit test (more to come), and I renamed the existing Track conversion test (to make ...
This introduces a new algorithm to convert PRD to xAOD PRDs for Muons (it could easily be extended to e.g. ITK as well).
This also adds the start of a unit test (more to come), and I renamed the existing Track conversion test (to make the naming more precise).
cc @jojunggehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67513Ensure release-specific compatibility for HepMC2 and HepMC32023-12-01T00:25:35+01:00Kartik Deepak Bhidekartik.deepak.bhide@cern.chEnsure release-specific compatibility for HepMC2 and HepMC3Some Athena releases are built with HepMC2, others with HepMC3. The Python wrappers in Pythonizations.py have been updated to ensure that the appropriate HepMC version is used when this file is imported.Some Athena releases are built with HepMC2, others with HepMC3. The Python wrappers in Pythonizations.py have been updated to ensure that the appropriate HepMC version is used when this file is imported.Kartik Deepak Bhidekartik.deepak.bhide@cern.chKartik Deepak Bhidekartik.deepak.bhide@cern.chhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67512Draft: Add a dummy sandbox for EF tracking tests2023-12-14T16:51:53+01:00Maximilian Emanuel Goblirsch-KolbDraft: Add a dummy sandbox for EF tracking tests@sabidi @jojungge @ncalace@sabidi @jojungge @ncalacehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67482Draft: add efficiency2024-03-08T08:58:21+01:00Kai ZhengDraft: add efficiencyadd road efficiency printed out, but the efficiency is low
Command:
python -m FPGATrackSimConfTools.FPGATrackSimAnalysisConfig --evtMax=1000 Trigger.FPGATrackSim.wrapperFileName=/eos/atlas/atlascerngroupdisk/det-htt//HTTsim/ATLAS-P2-RU...add road efficiency printed out, but the efficiency is low
Command:
python -m FPGATrackSimConfTools.FPGATrackSimAnalysisConfig --evtMax=1000 Trigger.FPGATrackSim.wrapperFileName=/eos/atlas/atlascerngroupdisk/det-htt//HTTsim/ATLAS-P2-RUN4-03-00-00/FPGATrackSimWrapper.root Trigger.FPGATrackSim.mapsDir=../1117_Kai_maps
Generated map files: https://cernbox.cern.ch/s/881ZeDH2E6tJuEX
Default map files: https://cernbox.cern.ch/s/yYDHLL0QaeVrIMlhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67468Draft: Switch MTJ dynamic content to work with Aux containers2023-11-29T15:54:10+01:00Tomasz BoldDraft: Switch MTJ dynamic content to work with Aux containersstart of moving MTJ decorations to talk to Aux
@imaznasstart of moving MTJ decorations to talk to Aux
@imaznashttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67441Draft: PoorMansIpAugmenterAlg - get dummy vertex2023-12-05T13:19:08+01:00Stefano FranchellucciDraft: PoorMansIpAugmenterAlg - get dummy vertexChanging the return to dummy vertex instead of `nullptr` when no PV is found, and set tracks to not valid.
This should make it easier to handle for algorithms downstream.
Tagging @dguest and @lbezioChanging the return to dummy vertex instead of `nullptr` when no PV is found, and set tracks to not valid.
This should make it easier to handle for algorithms downstream.
Tagging @dguest and @lbezioStefano FranchellucciStefano Franchelluccihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67428Draft: tauRecoTools additional cleanup2023-12-05T14:10:46+01:00Antonio De MariaDraft: tauRecoTools additional cleanuphttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67393TrigValSteering: increase timeout for build tests2023-11-27T15:41:19+01:00Bertrand Martin Dit LatourTrigValSteering: increase timeout for build testsHello,
This MR is increasing the timeout of local trigger ART tests from 1h to 1.5h, as we getting timeouts very often now, in main (ATR-28384).
Cheers,
BertrandHello,
This MR is increasing the timeout of local trigger ART tests from 1h to 1.5h, as we getting timeouts very often now, in main (ATR-28384).
Cheers,
Bertrand