athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2023-09-01T00:43:54+02:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/62617Draft: MR for triggering jobs for CI training and tests, please never accept2023-09-01T00:43:54+02:00Alexander UndrusDraft: MR for triggering jobs for CI training and tests, please never acceptThis MR is created to trigger test jobs in the CI system. Please do not accept it.This MR is created to trigger test jobs in the CI system. Please do not accept it.Alexander UndrusAlexander Undrushttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61557Draft: Attempt to make EntryLayerTool(MT)::registerParticle() method more rob...2024-02-19T11:09:38+01:00John Derek ChapmanDraft: Attempt to make EntryLayerTool(MT)::registerParticle() method more robust (ATLASSIM-6425)By tweaking how the {{GeoIDSvc::inside}} method works, it was possible to recover most of the entries in the MuonEntryLayer TrackRecordCollection. The issue is that the `ISFParticles` returned to ISF by Geant4 after the Calorimeter simul...By tweaking how the {{GeoIDSvc::inside}} method works, it was possible to recover most of the entries in the MuonEntryLayer TrackRecordCollection. The issue is that the `ISFParticles` returned to ISF by Geant4 after the Calorimeter simulation in ATLFAST3 jobs are often classified as being outside the calorimeter envelope and inside the muon system envelope by the {{GeoIDSvc}} as the ISF and Geant4 envelopes do not exactly line up in the endcap regions.
The {{GeoIDSvc::inside}} method creates two positions offset from the current position of the {{ISFParticle}} and uses those too assess if the {{ISFParticle}} is inside, outside or on the surface of the envelope corresponding to the geoID provided in the arguments.
The {{EntryLayerTool(MT)}} relies on the {{ISFParticles}} being classified as being on the surface of one or more of these envelopes to figure out which entry layer they lie on:
https://gitlab.cern.ch/atlas/athena/-/blob/master/Simulation/ISF/ISF_Geant4/ISF_Geant4CommonTools/src/EntryLayerToolMT.cxx#L75-86
By making the offset of these two positions configurable:
https://gitlab.cern.ch/atlas/athena/-/blob/master/Simulation/ISF/ISF_Core/ISF_Services/src/GeoIDSvc.cxx#L271-272
we can increase the separation when needed making it more likely that the ISFParticle will be classified as being on the surface of the envelopes.
Leaving the changes as draft for now as I need to tidy up the code a bit, but I think it's a reasonable solution. Comments welcome. This should not alter the FullSim output, but will run the CI now as a cross-check.https://gitlab.cern.ch/atlas/athena/-/merge_requests/61052Allow overriding of compression algorithm and level2024-02-19T10:51:49+01:00Tadej Novaktadej.novak@cern.chAllow overriding of compression algorithm and levelAllow overriding of compression algorithm and level similar to what was implemented for the auto flush.
Fixes ATLASRECTS-7504.
/cc @gemmeren @ameteAllow overriding of compression algorithm and level similar to what was implemented for the auto flush.
Fixes ATLASRECTS-7504.
/cc @gemmeren @ametehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/60463Draft: MR for triggering jobs for CI training and tests, please never accept2024-03-16T04:57:48+01:00Alexander UndrusDraft: MR for triggering jobs for CI training and tests, please never acceptThis MR is created to trigger test jobs in the CI system. Please do not accept it.This MR is created to trigger test jobs in the CI system. Please do not accept it.Alexander UndrusAlexander Undrus