athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-02-01T15:01:07+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/68518Draft: Fix more bugs2024-02-01T15:01:07+01:00Samuel Van StroudDraft: Fix more bugshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68489ATR-28679: L1 XE items legacy removal2024-02-01T14:51:56+01:00Marta Lanzac BerrocalATR-28679: L1 XE items legacy removalEdits to the L1 menu to remove L1 XE legacy items from the Physics and added to the MC Menu and to add L1 jXE/gXE Phase-I items. This task has required to edit the input files in /L1 package and some edits in the HLT Menu.
tagging Trigg...Edits to the L1 menu to remove L1 XE legacy items from the Physics and added to the MC Menu and to add L1 jXE/gXE Phase-I items. This task has required to edit the input files in /L1 package and some edits in the HLT Menu.
tagging Trigger Menu Coordinators: @astruebi @lidiazhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68515Draft: Reduce menu duplication2024-02-01T14:37:28+01:00Tomasz BoldDraft: Reduce menu duplicationhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68256Draft: Adding an example JO showing how to use the new Pythia8 UserHook2024-02-01T08:18:09+01:00Safa Gaidsafa.gaid@cern.chDraft: Adding an example JO showing how to use the new Pythia8 UserHookI added an example JO that shows how to use the new Pythia8 UserHook mergingDJRs.I added an example JO that shows how to use the new Pythia8 UserHook mergingDJRs.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68468Fixed clang warnings in two packages2024-01-31T12:18:15+01:00Vakhtang TsulaiaFixed clang warnings in two packages1. `PhysicsAnalysis/JetTagging/JetTagValidation/JetTagDQA`
Removed unused private data members
2. `LArCalorimeter/LArClusterCellDumper/LArClusterCellDumper`
Added missing override keyword. Removed unused local variables1. `PhysicsAnalysis/JetTagging/JetTagValidation/JetTagDQA`
Removed unused private data members
2. `LArCalorimeter/LArClusterCellDumper/LArClusterCellDumper`
Added missing override keyword. Removed unused local variableshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/66375Draft: AthSimulation: cleanup package filters2024-01-31T08:50:18+01:00Frank WinklmeierDraft: AthSimulation: cleanup package filtersOur cmake package configuration time scales badly with the number of patterns in the `package_filters.txt`. Use regular expressions to reduce the number of patterns from to 384 to 214, which reduces the cmake configuration time by <span ...Our cmake package configuration time scales badly with the number of patterns in the `package_filters.txt`. Use regular expressions to reduce the number of patterns from to 384 to 214, which reduces the cmake configuration time by <span dir="">\~</span>90 seconds for this project.
Due to slightly more generic selection rules, the following additional packages are now built as part of AthSimulation:
```plaintext
Control/AthenaExamples/AthExThinning
Control/CoWTools
Control/PerformanceMonitoring/PerfMonTests
Control/StoreGateTests
Control/Valkyrie
Database/APR/APRTests
Database/CoolConvUtilities
Database/CoolRunQuery
Database/CoralUtilities
DetectorDescription/DetDescrCond/DetDescrCondExample
DetectorDescription/DetDescrCond/DetectorStatus
DetectorDescription/GeoModel/GeoModelExamples
Simulation/ISF/ISF_Geant4/ISF_Geant4Config
```
If needed, we could tune this further but these packages don't seem to hurt either.
cc @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68456IDAlignMon add protection against non existing TrackName2024-01-30T16:58:20+01:00Salvador Marti I Garciasalvador.marti@cern.chIDAlignMon add protection against non existing TrackNameIDAlignMonGenericTracksAlgCfg.py: add protection against non existing TrackName in dict. Add also <mu> histogram in the Tracks group.IDAlignMonGenericTracksAlgCfg.py: add protection against non existing TrackName in dict. Add also <mu> histogram in the Tracks group.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68390Draft: Cookie cutting for forward electrons2024-01-29T15:26:46+01:00Lucy LewittDraft: Cookie cutting for forward electronsThis is the fourth in a chain of MRs that will add cookie cutting to forward electron reconstruction.
Implement cookie cutting for forward electron reconstruction.
Preceeding MR: https://gitlab.cern.ch/atlas/athena/-/merge_requests/683...This is the fourth in a chain of MRs that will add cookie cutting to forward electron reconstruction.
Implement cookie cutting for forward electron reconstruction.
Preceeding MR: https://gitlab.cern.ch/atlas/athena/-/merge_requests/68385
https://gitlab.cern.ch/atlas/athena/-/merge_requests/68386
https://gitlab.cern.ch/atlas/athena/-/merge_requests/68389https://gitlab.cern.ch/atlas/athena/-/merge_requests/68389Draft: Factorisation for cookie cutting2024-01-29T15:26:40+01:00Lucy LewittDraft: Factorisation for cookie cuttingThis is the third in a chain of MRs that will add cookie cutting to forward electron reconstruction.
This MR factorises some code into functions in a namespace accessible via egammaCaloUtils.
Preceeding MR: https://gitlab.cern.ch/atlas...This is the third in a chain of MRs that will add cookie cutting to forward electron reconstruction.
This MR factorises some code into functions in a namespace accessible via egammaCaloUtils.
Preceeding MR: https://gitlab.cern.ch/atlas/athena/-/merge_requests/68385
https://gitlab.cern.ch/atlas/athena/-/merge_requests/68386https://gitlab.cern.ch/atlas/athena/-/merge_requests/68242Draft: Add Regional data caching to ACTS2024-01-29T14:49:54+01:00Benjamin Philip KerridgeDraft: Add Regional data caching to ACTSDraft MR to show changes, some changes made for testing which will not be in a final MR
Related JIRA: ATLIDTRKCP-505Draft MR to show changes, some changes made for testing which will not be in a final MR
Related JIRA: ATLIDTRKCP-505https://gitlab.cern.ch/atlas/athena/-/merge_requests/57920Draft: Initial sktech of McAuxEventCollection with dummy TP conversion2024-01-29T09:22:50+01:00John Derek ChapmanDraft: Initial sktech of McAuxEventCollection with dummy TP conversion This merge request includes an initial version of `McAuxEventCollection` - a class to hold the extra information in `McEventCollection_p6` compared to `McEventCollection_p5`. It also includes a dummy TP converter setup (where the persis... This merge request includes an initial version of `McAuxEventCollection` - a class to hold the extra information in `McEventCollection_p6` compared to `McEventCollection_p5`. It also includes a dummy TP converter setup (where the persistent classes are basically identical to the transient classes).
In order to test further I really need an EVNT file or two containing `McEventCollection_p6` (one of them with event numbers above the 32-bit limit). Then I can write the Algorithm to create a transient `McAuxEventCollection` from a transient `McEventCollection` and the Algorithm to merge `McAuxEventCollection` and a sparse transient `McEventCollection` generated from `McEventCollection_p5` into a new transient `McEventCollection` object with the combined information. This can also be used to optimize the formats particularly the persistent version.
Added `McAuxEventCollBuilder` Algorithm to create `McAuxEventCollection` objects. Added `PatchMcEventCollection` Algorithm to restore information from `McAuxEventCollection` back into `McEventCollection`. (Both intended to be run in HepMC3-based releases. To be tested by running a step in a HepMC2-based release in between.)
Part of the work for ATLINFR-4725.
Tagging @ewelina, @mgignac, @dhirsch, @nstyles, @jcatmore, @elmsheus, @tlari, @mbandierhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/57325Draft: First attempt to separate a G4VPhysicsConstructor instance from the At...2024-01-29T09:22:05+01:00John Derek ChapmanDraft: First attempt to separate a G4VPhysicsConstructor instance from the AthAlgTool which manages it.First attempt to separate a G4VPhysicsConstructor instance from the AthAlgTool which manages it.
Leaving as draft for now as further changes will be required most likely.
Part of fixes for ATLASSIM-6030
Tagging @akraszna, @bmorgan, @...First attempt to separate a G4VPhysicsConstructor instance from the AthAlgTool which manages it.
Leaving as draft for now as further changes will be required most likely.
Part of fixes for ATLASSIM-6030
Tagging @akraszna, @bmorgan, @mbandier, @tlarihttps://gitlab.cern.ch/atlas/athena/-/merge_requests/61658Draft: idcalib work rebased on 23.02024-01-26T13:04:13+01:00Sean GalantzanDraft: idcalib work rebased on 23.0As part of my QT (ATR-23204), I implemented a few changes to the IDCalib chains:
- Increased the rough track pT cut from 1GeV to 2GeV to reduce the number of tracks evaluated by the Hypo. This should not affect the output as the current ...As part of my QT (ATR-23204), I implemented a few changes to the IDCalib chains:
- Increased the rough track pT cut from 1GeV to 2GeV to reduce the number of tracks evaluated by the Hypo. This should not affect the output as the current cuts in the menus are 4 and 9 GeV.
- Added track quality cuts to the Hypo, which are based on the `TightPrimary` quality cuts. As explained by the alignment group, they preform those track quality cuts offline, and by moving those cuts online we would only save tracks that are relevant to the alignment, and allow us to run with lower rescales and have more useful tracks.
- Made the second pT cut dependent on eta, this allows to have strict cuts in the low eta regions and loose cuts in the high eta region where we have much less tracks for alignment. Currently, I didn't touch the Menu configuration yet, but added a support for a `trketa6` signature that enables a cut distribution that I optimised, with minimum pT of 6GeV at the high eta region, and higher pT cuts as eta gets lower such that the final eta distribution is somewhat flat. The current `trk4` and `trk9` chains will use my updated code, but with a flat cut distribution which is consistent with the current implementation.https://gitlab.cern.ch/atlas/athena/-/merge_requests/67265Draft: Duplicate removal for `MultiTrajectory` and `TrackStorageContainer`2024-01-25T17:43:12+01:00Ioannis MaznasDraft: Duplicate removal for `MultiTrajectory` and `TrackStorageContainer`This is a proposal on how to handle decorations in `MultiTrajectory` and `TrackStorageContainer` through a separate class(`ActsTrk::DecorationHandler`).
related to EFTRACK-325
@tbold @jahredaThis is a proposal on how to handle decorations in `MultiTrajectory` and `TrackStorageContainer` through a separate class(`ActsTrk::DecorationHandler`).
related to EFTRACK-325
@tbold @jahredahttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68262Draft: VarHandleKey: fix build with Gaudi v382024-01-25T14:03:44+01:00Frank WinklmeierDraft: VarHandleKey: fix build with Gaudi v38`setKey` and `updateKey` are no longer `const` (see gaudi/Gaudi!1543).`setKey` and `updateKey` are no longer `const` (see gaudi/Gaudi!1543).https://gitlab.cern.ch/atlas/athena/-/merge_requests/68312Draft: enable use of database for efex calibration settings with MC2024-01-25T10:39:01+01:00Will ButtingerDraft: enable use of database for efex calibration settings with MCWe want to take calibration settings from a conditions database even when running on MC ... this MR is a first attempt at this. The calibration settings hardcoded in the simulation have been uploaded to COOL and this MR aims to direct th...We want to take calibration settings from a conditions database even when running on MC ... this MR is a first attempt at this. The calibration settings hardcoded in the simulation have been uploaded to COOL and this MR aims to direct the code at these database values.
I am hoping all tests succeed, since no changes are expected if the correct values were uploaded.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68117Draft: New MicroMegas Readout Geometry + Comparison tests with legacy results2024-01-24T09:24:33+01:00Spyridon MerianosDraft: New MicroMegas Readout Geometry + Comparison tests with legacy resultshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/67636Draft: ATR-28329: Revert MR640182024-01-22T09:33:50+01:00Binbin DongDraft: ATR-28329: Revert MR64018Revert https://gitlab.cern.ch/atlas/athena/-/merge_requests/64018/ as it caused difference on `DL1dv01` b-tagger.\
See details of discussion here: https://gitlab.cern.ch/atlas/athena/-/merge_requests/64018#note_7391147
cc @dguest, @fdib...Revert https://gitlab.cern.ch/atlas/athena/-/merge_requests/64018/ as it caused difference on `DL1dv01` b-tagger.\
See details of discussion here: https://gitlab.cern.ch/atlas/athena/-/merge_requests/64018#note_7391147
cc @dguest, @fdibello, @ligang.https://gitlab.cern.ch/atlas/athena/-/merge_requests/68214Move L1CaloRampMaker to Athena Release 242024-01-19T08:25:11+01:00Damir Fabrice RassloffMove L1CaloRampMaker to Athena Release 24The changes were made in order to be able to run the L1CaloRampMaker with the latest Athena version.
This was in response to minor changes made by LAr.The changes were made in order to be able to run the L1CaloRampMaker with the latest Athena version.
This was in response to minor changes made by LAr.https://gitlab.cern.ch/atlas/athena/-/merge_requests/65901Draft: TrigEgamma:Migrating Electron precision tracks to ca2024-01-18T09:56:00+01:00Debottam Bakshi GuptaDraft: TrigEgamma:Migrating Electron precision tracks to caMigrating Electron precision tracks to ca (linking the jira ATR-26736 created for this)Migrating Electron precision tracks to ca (linking the jira ATR-26736 created for this)