athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-28T12:00:11+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/70002CPAlgorithms: allow for event selection at particle-level2024-03-28T12:00:11+01:00Baptiste Ravinabaptiste.ravina@cern.chCPAlgorithms: allow for event selection at particle-levelSome users need to run the event selection algorithms using so-called "particle-level" objects (`TruthElectrons`, `TruthMuons`, etc.). This requires the following changes to the event selectors:
- make the MET term a configurable option:...Some users need to run the event selection algorithms using so-called "particle-level" objects (`TruthElectrons`, `TruthMuons`, etc.). This requires the following changes to the event selectors:
- make the MET term a configurable option: at reco-level it's most likely "Final" (new default), at truth-level it's most likely "NonInt"
- replace `xAOD::ElectronContainer` etc. by `xAOD::IParticleContainer` to be able to pass either reco- or truth-level containers
- in a couple of cases, event selectors need to access `charge()`, which is not available for `xAOD::IParticle`. There I simply added dedicated `xAOD::TruthParticleContainer` handles, and I populate the correct type of handle based on a switch in the python config.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70001L1calo efex tau bdt add max and min thresholds2024-03-21T15:21:42+01:00David ReikherL1calo efex tau bdt add max and min thresholdsThis reflects the latest l1calo efex tau BDT modifications added in [this MR](https://gitlab.cern.ch/atlas-l1calo-efex/eFEXFirmware/-/merge_requests/322) to eFEXFirmware.
* Add min. ET threshold for the l1calo efex tau BDT condition sho...This reflects the latest l1calo efex tau BDT modifications added in [this MR](https://gitlab.cern.ch/atlas-l1calo-efex/eFEXFirmware/-/merge_requests/322) to eFEXFirmware.
* Add min. ET threshold for the l1calo efex tau BDT condition shown to improve performance (e.g. see [here](https://indico.cern.ch/event/1382847/contributions/5813534/attachments/2819559/4923306/L1CaloDaq.pdf), slide 18), integrated with the parameter added in [this MR](https://gitlab.cern.ch/atlas/athena/-/merge_requests/69862) (https://its.cern.ch/jira/browse/ATR-28991)
* Implement max. ET cutoff for BDT conditionhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70000Reduce the usage of signal_process_vertex and signal_process_id2024-03-21T15:17:04+01:00Andrii VerbytskyiReduce the usage of signal_process_vertex and signal_process_idReduce the usage of signal_process_vertex and signal_process_idReduce the usage of signal_process_vertex and signal_process_idhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69998Reduce the usage of #ifdef HEPMC32024-03-21T11:53:38+01:00Andrii VerbytskyiReduce the usage of #ifdef HEPMC3Reduce the usage of #ifdef HEPMC3
@pclark @jchapmanReduce the usage of #ifdef HEPMC3
@pclark @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69997tidy from TrackFindingAlg into TrackFindingMeasurements2024-03-21T14:23:26+01:00Tim Adyetidy from TrackFindingAlg into TrackFindingMeasurements* collect code from `TrackFindingAlg::execute()` into new `TrackFindingMeasurements::addDetectorElements()`
* restore missing `TrackStatePrinter.TrackingGeometryTool`* collect code from `TrackFindingAlg::execute()` into new `TrackFindingMeasurements::addDetectorElements()`
* restore missing `TrackStatePrinter.TrackingGeometryTool`https://gitlab.cern.ch/atlas/athena/-/merge_requests/69996Fixes for wrong stream assignment VBFDelayed -> PhysicsStream2024-03-21T15:21:42+01:00Damiano VannicolaFixes for wrong stream assignment VBFDelayed -> PhysicsStreamIt has been noticed that some chains have wrong stream assignment. VBFDelayed -> PhysicsStream
Closes ATR-29010It has been noticed that some chains have wrong stream assignment. VBFDelayed -> PhysicsStream
Closes ATR-29010https://gitlab.cern.ch/atlas/athena/-/merge_requests/69995Update EntryLayerFilter.h to remove unused include2024-03-21T09:43:07+01:00Andrii VerbytskyiUpdate EntryLayerFilter.h to remove unused includeUpdate EntryLayerFilter.h to remove unused includeUpdate EntryLayerFilter.h to remove unused includehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69994offline DQ for MMG trigger2024-03-26T14:38:24+01:00Michela Bigliettioffline DQ for MMG triggerthis MR will add to offline DQ the MMG trigger. Needed for incoming 2024 data.this MR will add to offline DQ the MMG trigger. Needed for incoming 2024 data.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69993RadialStripDesign - Calculate the strip length from the mounting points2024-03-21T09:43:40+01:00Johannes Junggeburthjohannes.josef.junggeburth@cern.chRadialStripDesign - Calculate the strip length from the mounting pointsTagging @goblirscTagging @goblirschttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69992Remove HLT_e5_lhvloose_bBeeM6000_L1BKeePrimary from T0 monitoring2024-03-21T15:21:42+01:00Semen TurchikhinRemove HLT_e5_lhvloose_bBeeM6000_L1BKeePrimary from T0 monitoringFollowing the introduction of prescales for HLT_e5_lhvloose_bBeeM6000_L1BKeePrimary (ATR-19501) we do not need to monitor this chain offline, hence removing it from the monGroup.
cc: @lyubushk , @abarton (for BLS trigger), @ebergeas , @...Following the introduction of prescales for HLT_e5_lhvloose_bBeeM6000_L1BKeePrimary (ATR-19501) we do not need to monitor this chain offline, hence removing it from the monGroup.
cc: @lyubushk , @abarton (for BLS trigger), @ebergeas , @jlieberm (for trigger DQ)https://gitlab.cern.ch/atlas/athena/-/merge_requests/69991LArCafJobs: delete legacy config referencing RecExConfig2024-03-21T15:21:41+01:00Frank WinklmeierLArCafJobs: delete legacy config referencing RecExConfigDelete two job options that are referencing the deleted `RecExConfig`.
cc @pavolDelete two job options that are referencing the deleted `RecExConfig`.
cc @pavolhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69989Remove the GenericBarcodeFilter2024-03-21T14:22:45+01:00Andrii VerbytskyiRemove the GenericBarcodeFilterRemove the GenericBarcodeFilter as it is not used anywhere. Part of the migration away from barcode usage. See ATLASSIM-6906.
@jchapman @pclarkRemove the GenericBarcodeFilter as it is not used anywhere. Part of the migration away from barcode usage. See ATLASSIM-6906.
@jchapman @pclarkhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69988TBDetDescrAlg: delete legacy config and cleanup2024-03-21T15:21:42+01:00Frank WinklmeierTBDetDescrAlg: delete legacy config and cleanupDelete legacy config and only build a component library.Delete legacy config and only build a component library.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69987ForwardTransport[Svc]: delete legacy configuration2024-03-21T15:21:42+01:00Frank WinklmeierForwardTransport[Svc]: delete legacy configurationDelete legacy config.
cc @jchapmanDelete legacy config.
cc @jchapmanhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69986move order of thinning block right before output2024-03-22T11:28:11+01:00Joseph Earl Lambertmove order of thinning block right before outputhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69985PyUtils: Go back to using regex for reading the number of entries in AthFileLite2024-03-20T18:46:18+01:00Alaettin Serhan MetePyUtils: Go back to using regex for reading the number of entries in AthFileLiteThis reverts !69921 and goes back to what I originally implemented in !67863 but uses the `APRDefaults` in the regex for the collection names. It looks like the former broke a unit-test where we were reading an `ESD` from **2011**, which...This reverts !69921 and goes back to what I originally implemented in !67863 but uses the `APRDefaults` in the regex for the collection names. It looks like the former broke a unit-test where we were reading an `ESD` from **2011**, which has `POOLContainer_DataHeader` instead of `POOLContainer` for the `DataHeader`.
Closes ATEAM-968
cc: @gemmerenhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69984Fix physval memory leak, ATLASDQ-11362024-03-21T15:21:42+01:00Peter OnyisiFix physval memory leak, ATLASDQ-1136Take care of a memory leak that appeared in ROOT 6.28 (and a couple of others)Take care of a memory leak that appeared in ROOT 6.28 (and a couple of others)https://gitlab.cern.ch/atlas/athena/-/merge_requests/69982Add TrigInDetTrackTruthMap_tlp4 based on HepMcParticleLink_p3 (ATLASSIM-6912)2024-03-20T17:45:48+01:00John Derek ChapmanAdd TrigInDetTrackTruthMap_tlp4 based on HepMcParticleLink_p3 (ATLASSIM-6912)Add TrigInDetTrackTruthMap_tlp4 based on HepMcParticleLink_p3 (ATLASSIM-6912)
Not used by default yet.Add TrigInDetTrackTruthMap_tlp4 based on HepMcParticleLink_p3 (ATLASSIM-6912)
Not used by default yet.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69981AFP_GeoModel+Digitization: delete legacy job options2024-03-21T15:21:42+01:00Frank WinklmeierAFP_GeoModel+Digitization: delete legacy job optionshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69980Update InDetPerfPlot_Efficiency.cxx to fix cpp check warnings uselessCallsSubstr2024-03-20T15:26:59+01:00Andrii VerbytskyiUpdate InDetPerfPlot_Efficiency.cxx to fix cpp check warnings uselessCallsSubstrUpdate InDetPerfPlot_Efficiency.cxx to fix cpp check warnings uselessCallsSubstr
@sroeUpdate InDetPerfPlot_Efficiency.cxx to fix cpp check warnings uselessCallsSubstr
@sroe