athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-28T10:35:24+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/70140distinguish two steps with different name in muComb (ATR-29040)2024-03-28T10:35:24+01:00Francesca Pastoredistinguish two steps with different name in muComb (ATR-29040)https://gitlab.cern.ch/atlas/athena/-/merge_requests/70064PhysicsAnalysis: required modifications to allow for online and conditional b...2024-03-27T09:03:42+01:00Sven MenkePhysicsAnalysis: required modifications to allow for online and conditional b-tagging treatment in TopPhysThe recommendations for b-tagging scale factors and efficiencies that combine offline WPs with online WPs require changes to JetTagging/JetTagPerformanceCalibration/xAODBTaggingEfficiency and 11 TopPhys packages in order to include b-tag...The recommendations for b-tagging scale factors and efficiencies that combine offline WPs with online WPs require changes to JetTagging/JetTagPerformanceCalibration/xAODBTaggingEfficiency and 11 TopPhys packages in order to include b-tagging systematics and MC to data scale factors in 21.1-based top analyses. The proposed changes here allow to combine one offline WP with a online WP via the provided conditional (online given offline) probabilities provided by the CP-group. The offline trigger confirmation requires furthermore to combine two offline WP (from the same tagger) with the online WP. Also this functionality is provided in the MR.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69513Use config flags in analysis config2024-03-28T13:34:35+01:00Tadej Novaktadej.novak@cern.chUse config flags in analysis configMake config flags the main way to steer analysis config. This will help people working on analysis and Athena to feel at home and prevent accumulation of arguments of the `ConfigAccumulator`.
The naming is not fixed, I will probably als...Make config flags the main way to steer analysis config. This will help people working on analysis and Athena to feel at home and prevent accumulation of arguments of the `ConfigAccumulator`.
The naming is not fixed, I will probably also convert more items to flags. This is mainly to start the discussion and freeze the API as soon asp possible. I will probably then break this into multiple MRs.
Also some core flags should be renamed (see https://its.cern.ch/jira/browse/ATEAM-964).
Tagging @krumnack, @jolamber, @gwatts, @ekourlit for core AMG. Also tagging interested parties @ravinab, @omajersk, @tstreble, @khoo, @jchapman.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70205CscRODReadOut TrigTauMonitorBase : Cppcheck and clang-tidy fixes2024-03-29T00:44:11+01:00Christos Anastopouloschristos.anastopoulos@cern.chCscRODReadOut TrigTauMonitorBase : Cppcheck and clang-tidy fixesCscRODReadOut TrigTauMonitorBase : Cppcheck and clang-tidy fixesCscRODReadOut TrigTauMonitorBase : Cppcheck and clang-tidy fixeshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70203remove old files in FPGATrackSim2024-03-28T21:55:13+01:00Jahred Adelmanjahreda@gmail.comremove old files in FPGATrackSimFix https://its.cern.ch/jira/browse/EFTRACK-516Fix https://its.cern.ch/jira/browse/EFTRACK-516https://gitlab.cern.ch/atlas/athena/-/merge_requests/70197Additional plots in IDPVM: residuals, pull and cluster size vs eta2024-03-28T17:36:01+01:00Noemi CalaceAdditional plots in IDPVM: residuals, pull and cluster size vs etaSelf-explanatory title.
FYI: @lgagnonSelf-explanatory title.
FYI: @lgagnonNoemi CalaceNoemi Calacehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70195refine Phase-2 eta hough transform2024-03-28T17:05:29+01:00Maximilian Emanuel Goblirsch-Kolbrefine Phase-2 eta hough transformMake the Phase-2 eta hough transform dynamically adapt its tan(theta) search space to the location of the current search bucket in the detector.
Gain a factor 10 speed and improve resolutions.
Also make some properties configurable.
...Make the Phase-2 eta hough transform dynamically adapt its tan(theta) search space to the location of the current search bucket in the detector.
Gain a factor 10 speed and improve resolutions.
Also make some properties configurable.
CC @jojungge and @minionshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/701872024-03-28: merge of 24.0 into main2024-03-29T07:32:06+01:00Edward Moyse2024-03-28: merge of 24.0 into mainThis sweep contains the following MRs:
* !70158 athena.py: allow --config-only without storing config (legacy) ~Core
* !70181 Fix bug in han configuration merging ~DQ
* !70149 Update collisions_run.config - add the new han configurati...This sweep contains the following MRs:
* !70158 athena.py: allow --config-only without storing config (legacy) ~Core
* !70181 Fix bug in han configuration merging ~DQ
* !70149 Update collisions_run.config - add the new han configuration for all the l1calo monitoring changes ~DQ, ~L1Calo
* !70151 athena.py: remove cppyy_minvmem command line option ~Core
* !70155 TileMonitoring: Update Tile online monitoring script for cosmics ~DQ, ~Tile
* !70103 Optimization of the Trigger Menu generation: move CA generation after the alignment (ATR-29039) ~JetEtmiss, ~Trigger, ~TriggerMenu
* !69406 24.0 TRT high threshold tune ~Digitization, ~InnerDetector, ~Overlay, ~Run2-DataOverlay-output-changed, ~Run2-MCOverlay-output-changed, ~Run2-MCReco-output-changed, ~Run3-MCOverlay-output-changed, ~Run3-MCReco-output-changed, ~Tools, ~frozen-tier0-violating
* !70127 Improvements in Run2 to Run 3 nav conversion ~Trigger
* !70135 LArConfiguration: delete legacy job option fragments ~LAr
* !70134 LArROD: remove legacy configuration ~LAr
* !70130 TileSimAlgs: Remove legacy JO configurations (ATLASRECTS-7939) ~Digitization, ~Tile
* !70085 remove old taggers and add GN2v01 in PhysVal monitoring ~Analysis, ~BTagging, ~Derivation, ~JetEtmiss
* !70138 Add HLT_noalg_L1MU14EOF to express ~Trigger, ~TriggerMenu
* !70083 Dev new histograms ~DQ, ~LAr, ~Trigger
* !70105 gFEX update jwoj threshold ~Trigger, ~TriggerMenu, ~changes-trigger-counts
* !70121 TileMonitoring: Remove legacy JO configurations (ATLASRECTS-7939) ~DQ, ~Tile
* !70126 TileMuId: Remove legacy JO configurations (ATLASRECTS-7939) ~Tile
* !70128 TileRecAlgs: Remove legacy JO configurations (ATLASRECTS-7939) ~Tile
* !69231 Implementing the MuonSelectionTool for selecting muon tracks. ~Analysis, ~BTagging, ~Derivation, ~JetEtmiss
* !70125 remove obsolete job-config files from CaloRec/share ~Calorimeter
* !70124 TileMonitoring: Remove legacy config from TileMBTSMonitorAlgorithm (ATLASRECTS-7939) ~DQ, ~Tile
* !70122 TileMonitoring: Remove legacy config from TileDQFragMonitorAlgorithm (ATLASRECTS-7939) ~DQ, ~Tile
There was one conflict (in `BTaggingValidationPlots.cxx`). As discussed in !70085, I resolved this by taking the `24.0` changes.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70180SUSYTools/jobOptions.py: migrated from AthFile to MetaReader2024-03-29T07:06:54+01:00Vakhtang TsulaiaSUSYTools/jobOptions.py: migrated from AthFile to MetaReaderRelated to ATEAM-528Related to ATEAM-528https://gitlab.cern.ch/atlas/athena/-/merge_requests/70123Read jFEX calibration values from the database in MC2024-03-28T22:42:05+01:00Paul ThompsonRead jFEX calibration values from the database in MCTowards having the jFEX read database values from the DB also for MC.
The first version of the database values aim to replicate the results of the present hard coded defaults.
Allows to overwrite the DB values for MC during commissioning...Towards having the jFEX read database values from the DB also for MC.
The first version of the database values aim to replicate the results of the present hard coded defaults.
Allows to overwrite the DB values for MC during commissioning of the jFEX in 2024.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69701Adding sTGC xAOD PRD output2024-03-28T21:13:45+01:00Edward MoyseAdding sTGC xAOD PRD outputAs with !69514, this adds the ability for the RDO to PRD convertor to output xAOD PRDs directly, and adds them to the test.
There is some missing functionality, since:
- we do not have access to the ReadoutElement
- I do not yet know ho...As with !69514, this adds the ability for the RDO to PRD convertor to output xAOD PRDs directly, and adds them to the test.
There is some missing functionality, since:
- we do not have access to the ReadoutElement
- I do not yet know how to handle merging xAOD PRDs
This will come in follow up MRs. This is all disabled by default.
cc @jojunggehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70175Clean up some backtracking tracking pass flags2024-03-29T00:39:22+01:00Thomas StreblerClean up some backtracking tracking pass flagsEither removing flags set to default C++ values and unlikely to be changed or promoting them to global flags.
Should reduce by 6*31 the amount of tracking flags.
Relevant for ATLASRECTS-7947Either removing flags set to default C++ values and unlikely to be changed or promoting them to global flags.
Should reduce by 6*31 the amount of tracking flags.
Relevant for ATLASRECTS-7947https://gitlab.cern.ch/atlas/athena/-/merge_requests/70174adding NSW combined offline DQ2024-03-29T00:42:28+01:00Michela Bigliettiadding NSW combined offline DQthis package is going to host combined NSW efficiencies for offline DQ purposes. For the time being is mainly an empty container.this package is going to host combined NSW efficiencies for offline DQ purposes. For the time being is mainly an empty container.https://gitlab.cern.ch/atlas/athena/-/merge_requests/69620btagging tool for json-based CDI2024-03-29T01:01:07+01:00Binbin Dongbtagging tool for json-based CDItowards the JSON-based CDI by adding a selection tool to handle JSON-based configuration.towards the JSON-based CDI by adding a selection tool to handle JSON-based configuration.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70201Clean up unused decisionTool in makeTriggerGlobalEffCorrAlg2024-03-29T00:54:44+01:00Thomas StreblerClean up unused decisionTool in makeTriggerGlobalEffCorrAlgFollow up to !69869
FYI @ravinabFollow up to !69869
FYI @ravinabhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70200Update L1CaloFEXSimCfg.py - enable heuristic eTAU when running DQ environment...2024-03-29T00:50:10+01:00Will ButtingerUpdate L1CaloFEXSimCfg.py - enable heuristic eTAU when running DQ environment...Update L1CaloFEXSimCfg.py - enable heuristic eTAU when running DQ environment at tier0, so that monitoring plots can compare BDT tau (new nominal) to themUpdate L1CaloFEXSimCfg.py - enable heuristic eTAU when running DQ environment at tier0, so that monitoring plots can compare BDT tau (new nominal) to themhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70198CaloRec: delete unused legacy python modules2024-03-29T00:54:02+01:00Frank WinklmeierCaloRec: delete unused legacy python modulesA few modules are still remaining that are referenced outside this package.
cc @wlamplA few modules are still remaining that are referenced outside this package.
cc @wlamplhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70193Fix timing monitoring histograms for ITk TrigInDetValidation ART tests (EFTRA...2024-03-29T00:46:03+01:00Elliot WattonFix timing monitoring histograms for ITk TrigInDetValidation ART tests (EFTRACK-463)Currently, the timing histograms for the ITk trigger ART tests are setup with x-axis ranges being too small, leading to many entries in overflow for certain situations (e.g fullscan chains when running on ttbar + 200 PU ITk RDO). This sm...Currently, the timing histograms for the ITk trigger ART tests are setup with x-axis ranges being too small, leading to many entries in overflow for certain situations (e.g fullscan chains when running on ttbar + 200 PU ITk RDO). This small change fixes the issue by sending the correct signature name to be checked against when setting up the monitoring. This only impacts the monitoring for ITk jobs, but targetting 24.0 to keep configurations in step. Changes will be eventually swept to main.
This work for running FTF with ITk in the trigger is tracked by EFTRACK-463
Tagging @baineshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70192HltAsyncEventLoopMgr: backport fixes from HltEventLoopMgr2024-03-29T00:45:05+01:00Frank WinklmeierHltAsyncEventLoopMgr: backport fixes from HltEventLoopMgrPort the following changes to the `HltAsyncEventLoopMgr` that were missed in the original fork (https://gitlab.cern.ch/atlas/athena/-/merge_requests/69464):
- set the default of `HltAsyncEventLoopMgr.setMagFieldFromPtree` to `true` (145e...Port the following changes to the `HltAsyncEventLoopMgr` that were missed in the original fork (https://gitlab.cern.ch/atlas/athena/-/merge_requests/69464):
- set the default of `HltAsyncEventLoopMgr.setMagFieldFromPtree` to `true` (145e0240)
- Use C++17 std::filesystem instead of boost::filesystem where possible (2b7217bc)
- only send event to debug stream if severely truncated (34b5d520)
None of these have any impact on P1 operations.
Relates to ATR-26285.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70191Suppress some PathResolver output2024-03-29T00:48:46+01:00Samuel Van StroudSuppress some PathResolver output- I don't think we need to `INFO` when a file is downloaded
- A `WARN` is better if the download fails than a `DEBUG`
- I'm disabling the progress bar in `TFile::Cp`- I don't think we need to `INFO` when a file is downloaded
- A `WARN` is better if the download fails than a `DEBUG`
- I'm disabling the progress bar in `TFile::Cp`