athena merge requestshttps://gitlab.cern.ch/atlas/athena/-/merge_requests2024-03-28T17:12:35+01:00https://gitlab.cern.ch/atlas/athena/-/merge_requests/70199Draft: Ef tracking map maker updates2024-03-28T17:12:35+01:00Jahred Adelmanjahreda@gmail.comDraft: Ef tracking map maker updateshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70182Revert "Merge branch 'sTgcPads' into 'main'"2024-03-28T17:01:03+01:00Edward MoyseRevert "Merge branch 'sTgcPads' into 'main'"This reverts merge request !69314
https://its.cern.ch/jira/browse/ATLASRECTS-7946This reverts merge request !69314
https://its.cern.ch/jira/browse/ATLASRECTS-7946https://gitlab.cern.ch/atlas/athena/-/merge_requests/70185AthConfigFlags: improve flags unit test2024-03-28T11:02:21+01:00Frank WinklmeierAthConfigFlags: improve flags unit test- use the full `AllConfigFlags` for testing command line parsing
- use a minimal parser to test `--help` message and ignore whitespace- use the full `AllConfigFlags` for testing command line parsing
- use a minimal parser to test `--help` message and ignore whitespacehttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69929Draft: Migrate EgammaAnalysisAlgorithms test to block config2024-03-27T19:38:02+01:00Thomas StreblerDraft: Migrate EgammaAnalysisAlgorithms test to block configOther CP algorithms to followOther CP algorithms to followhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69962CP algs: Move main tests to CA 242024-03-27T19:37:34+01:00Thomas StreblerCP algs: Move main tests to CA 24Cherry-pick of !69307 for ~"24.0"
Needed to convert old sequence to CA
FYI @tadej @krumnackCherry-pick of !69307 for ~"24.0"
Needed to convert old sequence to CA
FYI @tadej @krumnackhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/68368Draft: Add possiblity to use Geant4 transport instead of ATLAS tracking tools...2024-03-27T18:20:29+01:00Joshua Falco Beirerjoshua.beirer@cern.chDraft: Add possiblity to use Geant4 transport instead of ATLAS tracking tools in FCS in G4https://gitlab.cern.ch/atlas/athena/-/merge_requests/68428Draft: Adding Xbb support in SelectionTool2024-03-27T11:57:37+01:00Binbin DongDraft: Adding Xbb support in SelectionToolAs described in AFT-676, adding Xbb support in SelectionTool which access the posteriors and calculates the discriminant score based on the fractions from CDI.
Code is mainly from https://gitlab.cern.ch/atlas/athena/-/merge_requests/665...As described in AFT-676, adding Xbb support in SelectionTool which access the posteriors and calculates the discriminant score based on the fractions from CDI.
Code is mainly from https://gitlab.cern.ch/atlas/athena/-/merge_requests/66510.
cc @ligang, @wleinone
Not ready to be merged yet, need to be tested on a R22 Xbb CDI.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70028Add TauTrig collection in 24.0 for Trigger validation during 2024 ramp-up period2024-03-27T07:32:08+01:00Antonio De MariaAdd TauTrig collection in 24.0 for Trigger validation during 2024 ramp-up periodThis MR is meant to add HLT tau containers + L1 Phase 1 containers in PHYS for branch 24.0
These additional containers will be needed for the validation of the Phase-1 tau triggers during 2024 ramp-up period
Tagging @smwang, @slai, @gi...This MR is meant to add HLT tau containers + L1 Phase 1 containers in PHYS for branch 24.0
These additional containers will be needed for the validation of the Phase-1 tau triggers during 2024 ramp-up period
Tagging @smwang, @slai, @gipezzul, @martindl, @jbeaucam, @mashamim, @sshaw and @khoohttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69199athena.py: Add --noCA option (in preparation of making --CA the default)2024-03-26T17:04:22+01:00Walter Lamplathena.py: Add --noCA option (in preparation of making --CA the default)As discussed in yesterday's Software Weekly meetingAs discussed in yesterday's Software Weekly meetinghttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69976LArConditionsTestConfig.py: Temporarily add debug output to understand ATLINF...2024-03-26T08:37:00+01:00Walter LamplLArConditionsTestConfig.py: Temporarily add debug output to understand ATLINFR-5301As discussed in ATLINFR-5301, adding some debug output to understand the spurious test failures.As discussed in ATLINFR-5301, adding some debug output to understand the spurious test failures.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70082LArByteStrean+LArCondAthenaPool: remove legacy job options2024-03-25T14:01:59+01:00Frank WinklmeierLArByteStrean+LArCondAthenaPool: remove legacy job optionshttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69990Add unit test for FPGATrackSim and fix workflow for analysis on wrapper file2024-03-22T14:46:18+01:00Ioannis MaznasAdd unit test for FPGATrackSim and fix workflow for analysis on wrapper file1. This should fix the errors on `FPGATrackSimAnalysisConfig.py` (related to unit test failure) when running with wrapper input.
2. Also added a test for analysis with rdo input.
tagging @jahreda @tbold1. This should fix the errors on `FPGATrackSimAnalysisConfig.py` (related to unit test failure) when running with wrapper input.
2. Also added a test for analysis with rdo input.
tagging @jahreda @tboldhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70047More test chains for delayed jets2024-03-22T13:20:55+01:00Lucas BezioMore test chains for delayed jetsAs discussed on [ATR-28836](https://its.cern.ch/jira/browse/ATR-28836), more test chains are added. Some are requiring 2jets to be delayed aiming to reduce the rate even with low pt threshold. Copies of the test chains with upper limit o...As discussed on [ATR-28836](https://its.cern.ch/jira/browse/ATR-28836), more test chains are added. Some are requiring 2jets to be delayed aiming to reduce the rate even with low pt threshold. Copies of the test chains with upper limit on timing are also added.https://gitlab.cern.ch/atlas/athena/-/merge_requests/70024Draft: RNTuple reading improvements2024-03-22T10:43:14+01:00Marcin NowakDraft: RNTuple reading improvementsRepeating previous RNTuple update (!69909 - rolled back) but without MetaReader changes - they were causing issues with AnalysisBase.
Now this MR should only affect dev3 RNTuple nightlies.
Removed redundant #includes
Cache RNTuple...Repeating previous RNTuple update (!69909 - rolled back) but without MetaReader changes - they were causing issues with AnalysisBase.
Now this MR should only affect dev3 RNTuple nightlies.
Removed redundant #includes
Cache RNTupleView objects so they are not recreated every read
MetaReader update rolled back and postponed for a subsequent MRhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/70043Merge branch 'main-substructure-FPE' into 'main'2024-03-22T09:18:09+01:00Bertrand Martin Dit LatourMerge branch 'main-substructure-FPE' into 'main'pT filter for groomed jets before moment calculation
See merge request atlas/athena!70012
(cherry picked from commit 76ee2287646674958b7f2a80e86fa64f39a95267)
b4ee62fd pT filter for groomed jets before moment calculationpT filter for groomed jets before moment calculation
See merge request atlas/athena!70012
(cherry picked from commit 76ee2287646674958b7f2a80e86fa64f39a95267)
b4ee62fd pT filter for groomed jets before moment calculationhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69972TrigEFMissingET CMake Fixes, main branch (2024.03.20.)2024-03-20T15:24:56+01:00Attila KrasznahorkayTrigEFMissingET CMake Fixes, main branch (2024.03.20.)This is to undo a mistake introduced in !69806, and to fix another issue that was present in the code for even longer.
- Since the shared library still needs ROOT, it has to be found explicitly by the code.
- To make sure that the co...This is to undo a mistake introduced in !69806, and to fix another issue that was present in the code for even longer.
- Since the shared library still needs ROOT, it has to be found explicitly by the code.
- To make sure that the component library would see the [LWTNN](https://github.com/lwtnn/lwtnn) headers reliably, `${LWTNN_INCLUDE_DIRS}` also needs to be used.
The reason I noticed these mistakes is because of the "serious warnings" in the latest nightlies.
https://bigpanda.cern.ch/nview/?nightly=main_Athena_x86_64-el9-gcc13-opt
![image](/uploads/e0908bc1f653f0f135c80032b903351c/image.png)
Something that the shifters should've really picked up on... :frowning:https://gitlab.cern.ch/atlas/athena/-/merge_requests/69205Protect possible rare FPEs2024-03-19T18:09:08+01:00Vadim KostyukhinProtect possible rare FPEsAdd some protection in an attempt to avoid rare FPEs observed in trigger ATLASRECTS-7659Add some protection in an attempt to avoid rare FPEs observed in trigger ATLASRECTS-7659https://gitlab.cern.ch/atlas/athena/-/merge_requests/66838Draft: MuonReadoutGeometryR4 - Add diamondStripDesign for sTgc2024-03-19T17:46:57+01:00Ishan Kiritbhai VyasDraft: MuonReadoutGeometryR4 - Add diamondStripDesign for sTgcNew MR to add diamondStripDesign inheriting from stripDesign.
@alainb @jojungge @pscholerNew MR to add diamondStripDesign inheriting from stripDesign.
@alainb @jojungge @pscholerIshan Kiritbhai VyasIshan Kiritbhai Vyashttps://gitlab.cern.ch/atlas/athena/-/merge_requests/69935Draft: New efficiency DQ criteria for HLTmuon hanconfig2024-03-19T17:04:10+01:00Valerio IppolitoDraft: New efficiency DQ criteria for HLTmuon hanconfigThis MR addresses https://its.cern.ch/jira/browse/ATR-28965 by adding a new DQ monitoring algorithm able to perform Fermi fits to TEfficiency input (based on the TGraph contained in the TEfficiency). The code is effectively a copy of [Ro...This MR addresses https://its.cern.ch/jira/browse/ATR-28965 by adding a new DQ monitoring algorithm able to perform Fermi fits to TEfficiency input (based on the TGraph contained in the TEfficiency). The code is effectively a copy of [RootFitGraph](https://gitlab.cern.ch/atlas/athena/-/blob/24.0/DataQuality/dqm_algorithms/dqm_algorithms/RootFitGraph.h), adapted for the changed input.
The thresholds for muons are also tuned based on the [webdisplay](https://atlasdqm.cern.ch/webdisplay/test/2403151/express_express/run_456729/run/HLT/TRMUO/Expert/Efficiency/muChainMSonly/L1MU18VFCH/wrtUpstream/EffL2SA_muPt_wrt_Upstream) produced from the same input as https://its.cern.ch/jira/browse/ATR-28651.
Tagging @yoyamaguhttps://gitlab.cern.ch/atlas/athena/-/merge_requests/65445Draft: Add tooling for hard scatter GNN selection2024-03-19T15:10:26+01:00Jackson Carl BurzynskiDraft: Add tooling for hard scatter GNN selectionThis WIP MR adds a new GNNTool for xAOD::Vertex objects, to eventually be used in a new hard scatter vertex selection algorithm. Runs currently but needs further development.
Tagging @gfrattar, @tqiu, @dgillber from TVPD
Tagging @dgues...This WIP MR adds a new GNNTool for xAOD::Vertex objects, to eventually be used in a new hard scatter vertex selection algorithm. Runs currently but needs further development.
Tagging @gfrattar, @tqiu, @dgillber from TVPD
Tagging @dguest from FTAG