Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 157
    • Merge requests 157
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !25400

Master more ca debugging output / protections

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Edward Moyse requested to merge emoyse/athena:master-more-CA-debugging-output into master Aug 06, 2019
  • Overview 28
  • Commits 6
  • Pipelines 2
  • Changes 1

There are two main things added here:

  • if getPrimary() is called with no primary component being defined, then raise an exception. This avoids the case that properties are silently set to None, and anyway, if you call getPrimary() then you obviously expect to get something.
  • on creation of a CA, store the filename and line where it is created. This can then be used for debugging, and here I added this to the message about unmerged CAs (which are hard to track down otherwise).

It might turn out that unrolling the stack is too time consuming, in which case we can make this second point configurable. But it seems useful enough to have on by default for the moment.

I'm kind of expecting these changes to make other tests fail, but let's see...

@wlampl

Edited Aug 06, 2019 by Edward Moyse
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: master-more-CA-debugging-output