Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 126
    • Merge requests 126
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !27207

21.9: adding new Xml version checks to allow step 3.1 (P2-ITK-22) services to be built

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Nicholas Styles requested to merge nstyles/athena:21.9-step3p1XmlVersioningUpdates into 21.9 Oct 15, 2019
  • Overview 3
  • Commits 1
  • Pipelines 1
  • Changes 1

Following !25698 (merged) some further updates were needed to allow ATLAS-P2-ITK-22-XX-XX geometries to be built, due to new structures being used in the services.

In future Xml versions and geometry code updates, the different services shapes (TUBE/TUBS/CONE) will be properly separated such that no attempts will be made to retrieve parameters for shapes where they are not defined.

cc @nreadiof @todorova

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 21.9-step3p1XmlVersioningUpdates