Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 144
    • Merge requests 144
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !27572

CaloTPCnv+TPTools: Workaround for problem with *WithKey and TrigSerializeTP.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Scott Snyder requested to merge ssnyder/athena:withKeyWorkaround.CaloTPCnv-20191029 into master Oct 29, 2019
  • Overview 2
  • Commits 2
  • Pipelines 1
  • Changes 5

Adjust CaloTPCnv converters so they won't give an error if persToTrans is called instead of persToTransWithKey. This prevents a crash when the converters are called from TrigSerializeTP. This will eventually be fixed in TrigSerializeTP, after which this workaround can be removed.

Also need to temporarily remove the final qualifier from TPConverterWithKeyBase::persToTrans.

See ATR-20445.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: withKeyWorkaround.CaloTPCnv-20191029