Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 157
    • Merge requests 157
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !28216

Filter which data can be loaded in Views from the main store

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Benjamin Michael Wynne requested to merge bwynne/athena:ViewFilter into master Nov 22, 2019
  • Overview 27
  • Commits 4
  • Pipelines 3
  • Changes 9

A number of algorithms running in EventViews are accidentally loading data objects that exist in the main event store, using the view fallthrough mechanism.

Fallthrough itself is necessary - objects like Identifiable Container Caches must exist in the main store but be accessible in views without creating copies. However, for most objects this is not the case.

So, I have added a filter to the fallthrough mechanism to ensure that only these intended objects are loaded, as suggested by @tbold

Note that this will not prevent an algorithm from trying to load these objects, it will simply create an error rather than an incorrect result. But, at least it'll help us track down the problem.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: ViewFilter