Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 137
    • Merge requests 137
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !29696

Move from MuonIdHelperTool to MuonIdHelperSvc (4)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Nicolas Koehler requested to merge nkoehler/athena:muIdHelp4 into master Jan 22, 2020
  • Overview 45
  • Commits 6
  • Pipelines 4
  • Changes 42

Hi,

this MR uses MuonIdHelperSvc instead of MuonIdHelperTool in several muon packages. Furthermore, some cleanup is done (e.g. using ATH_CHECK macros where possible, removing unneeded includes, not using TMath...). Also in case ToolHandles/ServiceHandles are defined inline in the headers, the interfaces are also included there and the forward declarations are removed.

Best, Nico

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: muIdHelp4