Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 127
    • Merge requests 127
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !30181

split old- and new-style configuration of MagFieldService into two seprate files

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Walter Lampl requested to merge wlampl/athena:MagFieldCfgSplit into master Feb 07, 2020
  • Overview 10
  • Commits 2
  • Pipelines 2
  • Changes 3

The file MagFieldServicesConfig.py contained both, old- and new style configuration of the AtlasFieldSvc. It imported elements of both configuration systems at module level with is very fragile. Not sure how we ended up in this situation, I suspect my semi-automated migration to CompFactory in !28944 (merged) contributed to the mess.

This MR disentangles old and new configuration by splitting it into two files.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: MagFieldCfgSplit