Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 137
    • Merge requests 137
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !30831

Add NSWCalibTool to NSWCalibToolsConfigDb and use it

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Nicolas Koehler requested to merge nkoehler/athena:nswCalibConf into 21.9 Mar 03, 2020
  • Overview 41
  • Commits 7
  • Pipelines 5
  • Changes 8

Hi,

this MR adds the NSWCalibTool to NSWCalibToolsConfigDb and configures its MuonIdHelperTool property explicitly to avoid the creation of an unconfigured MuonIdHelperTool inside the NSWCalibTool.

This MR hopefully fixes running reconstruction of the combined ITK+NSW layout for @nstyles.

I am adding also @jchapman who can comment whether I understood the logic behind using the Db files correctly?

Also adding @rosati to inform him about the change which should also go to 21.3 and master.

Best, Nico

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: nswCalibConf