From 4b92e8f7980d39607476fd9f57f7635231725bb7 Mon Sep 17 00:00:00 2001
From: fernando <Fernando.Monticelli@cern.ch>
Date: Thu, 30 Apr 2020 14:22:23 +0200
Subject: [PATCH 1/2] Added OnlineMon for ElectronPrecisionReco at HLT

---
 .../PrecisionElectronRecoSequences.py         |  4 +-
 .../Electron/TrigElectronFactories.py         | 38 ++++++++++++-------
 2 files changed, 27 insertions(+), 15 deletions(-)

diff --git a/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Electron/PrecisionElectronRecoSequences.py b/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Electron/PrecisionElectronRecoSequences.py
index aba42d585d80..c5fb21c3145c 100644
--- a/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Electron/PrecisionElectronRecoSequences.py
+++ b/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Electron/PrecisionElectronRecoSequences.py
@@ -64,7 +64,7 @@ def precisionElectronRecoSequence(RoIs):
     electronPrecisionTrack += ViewVerifyPrecisionCluster
 
     """ Retrieve the factories now """
-    from TriggerMenuMT.HLTMenuConfig.Electron.TrigElectronFactories import TrigEgammaRecElectron, TrigElectronSuperClusterBuilder, TrigTopoEgammaElectron
+    from TriggerMenuMT.HLTMenuConfig.Electron.TrigElectronFactories import TrigEgammaRecElectron, TrigElectronSuperClusterBuilder, TrigTopoEgammaElectronCfg
     from TriggerMenuMT.HLTMenuConfig.Egamma.TrigEgammaFactories import  TrigEMTrackMatchBuilder
 
      
@@ -86,7 +86,7 @@ def precisionElectronRecoSequence(RoIs):
     trigElectronAlgo.InputEgammaRecContainerName = TrigEgammaAlgo.egammaRecContainer
     thesequence += trigElectronAlgo
 
-    trigTopoEgammaAlgo = TrigTopoEgammaElectron()
+    trigTopoEgammaAlgo = TrigTopoEgammaElectronCfg()
     trigTopoEgammaAlgo.SuperElectronRecCollectionName = trigElectronAlgo.SuperElectronRecCollectionName
     collectionOut = trigTopoEgammaAlgo.ElectronOutputName
     thesequence += trigTopoEgammaAlgo
diff --git a/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Electron/TrigElectronFactories.py b/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Electron/TrigElectronFactories.py
index f8ea466a3db5..3e0fe53039f1 100644
--- a/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Electron/TrigElectronFactories.py
+++ b/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Electron/TrigElectronFactories.py
@@ -1,4 +1,5 @@
 # Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
+from AthenaCommon.Logging import logging
 
 __doc__ = "ToolFactories to configure egammaAlgs to be used at the HLT" 
 
@@ -45,18 +46,29 @@ TrigElectronSuperClusterBuilder = AlgFactory( egammaAlgsConf.electronSuperCluste
                                              )
 
 
-TrigTopoEgammaElectron = AlgFactory( egammaAlgsConf.topoEgammaBuilder, name = 'TrigTopoEgammaElectron',
-        SuperElectronRecCollectionName = TrigEgammaKeys.SuperElectronRecCollectionName,
-        SuperPhotonRecCollectionName = TrigEgammaKeys.SuperPhotonRecCollectionName,
-        ElectronOutputName = TrigEgammaKeys.outputElectronKey,
-        PhotonOutputName = TrigEgammaKeys.outputPhotonKey,  
-        AmbiguityTool = EGammaAmbiguityTool,
-        EMClusterTool = TrigEMClusterTool,
-        EMShowerTool=TrigEMShowerBuilder,
-        egammaTools = FcnWrapper(TrigEgammaDecorationTools),
-        doAdd = False,
-        doPhotons = False,
-        doElectrons = True
-        )
 
+def TrigTopoEgammaElectronCfg(name='topoEgammaBuilder_TrigElectrons'):
+    from AthenaMonitoringKernel.GenericMonitoringTool import GenericMonitoringTool, defineHistogram
+    monTool = GenericMonitoringTool("MonTool_topoEgammaBuilder")
+    monTool.Histograms = [ defineHistogram('EldeltaEta',type='TH1F', title='#Delta#eta',    path='EXPERT',xbins=80, xmin=-0.01,xmax=0.01),
+                           defineHistogram('EldeltaPhi',type='TH1F', title='#Delta#phi',    path='EXPERT',xbins=80, xmin=-0.01, xmax=0.01),
+                           defineHistogram('EleT',      type='TH1F', title='p#_{T} [GeV]',  path='EXPERT',xbins=80, xmin=0., xmax=100),
+    
+    mlog = logging.getLogger("TrigElectronFactories")
+    mlog.info('Starting configuration')
+    TrigTopoEgammaElectron = AlgFactory( egammaAlgsConf.topoEgammaBuilder, name = name,
+            SuperElectronRecCollectionName = TrigEgammaKeys.SuperElectronRecCollectionName,
+            SuperPhotonRecCollectionName = TrigEgammaKeys.SuperPhotonRecCollectionName,
+            ElectronOutputName = TrigEgammaKeys.outputElectronKey,
+            PhotonOutputName = TrigEgammaKeys.outputPhotonKey,  
+            AmbiguityTool = EGammaAmbiguityTool,
+            EMClusterTool = TrigEMClusterTool,
+            EMShowerTool=TrigEMShowerBuilder,
+            egammaTools = FcnWrapper(TrigEgammaDecorationTools),
+            doAdd = False,
+            doPhotons = False,
+            doElectrons = True,
+            #MonTool = monTool
+            )
+    return TrigTopoEgammaElectron()
 
-- 
GitLab


From 3bcb8dbb7f03357344d6b164b480aee3f1d2f2a6 Mon Sep 17 00:00:00 2001
From: fernando <Fernando.Monticelli@cern.ch>
Date: Thu, 30 Apr 2020 15:03:52 +0200
Subject: [PATCH 2/2] TrigElectronFactories.py updated

---
 .../python/HLTMenuConfig/Electron/TrigElectronFactories.py      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Electron/TrigElectronFactories.py b/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Electron/TrigElectronFactories.py
index 3e0fe53039f1..4dbfeb3ae47b 100644
--- a/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Electron/TrigElectronFactories.py
+++ b/Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Electron/TrigElectronFactories.py
@@ -52,7 +52,7 @@ def TrigTopoEgammaElectronCfg(name='topoEgammaBuilder_TrigElectrons'):
     monTool = GenericMonitoringTool("MonTool_topoEgammaBuilder")
     monTool.Histograms = [ defineHistogram('EldeltaEta',type='TH1F', title='#Delta#eta',    path='EXPERT',xbins=80, xmin=-0.01,xmax=0.01),
                            defineHistogram('EldeltaPhi',type='TH1F', title='#Delta#phi',    path='EXPERT',xbins=80, xmin=-0.01, xmax=0.01),
-                           defineHistogram('EleT',      type='TH1F', title='p#_{T} [GeV]',  path='EXPERT',xbins=80, xmin=0., xmax=100),
+                           defineHistogram('EleT',      type='TH1F', title='p#_{T} [GeV]',  path='EXPERT',xbins=80, xmin=0., xmax=100)]
     
     mlog = logging.getLogger("TrigElectronFactories")
     mlog.info('Starting configuration')
-- 
GitLab