From aefdfee185159ee4e3a2b39f119eff750626fa2c Mon Sep 17 00:00:00 2001
From: Iskander Ibragimov <iskander.ibragimov@cern.ch>
Date: Thu, 5 Nov 2020 12:15:41 +0100
Subject: [PATCH 1/2] fix pp0 histos filling
---
.../PixelMonitoring/src/PixelAthMonitoringBase.cxx | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/InnerDetector/InDetMonitoring/PixelMonitoring/src/PixelAthMonitoringBase.cxx b/InnerDetector/InDetMonitoring/PixelMonitoring/src/PixelAthMonitoringBase.cxx
index a7a417d6baa6..5bce360ba810 100644
--- a/InnerDetector/InDetMonitoring/PixelMonitoring/src/PixelAthMonitoringBase.cxx
+++ b/InnerDetector/InDetMonitoring/PixelMonitoring/src/PixelAthMonitoringBase.cxx
@@ -128,7 +128,7 @@ void PixelAthMonitoringBase::fillFromArrays( const std::string& namePP0, Accumul
// in the same plot
// the shift (b-1)*8 applies per disk counter b
// (there are in total 8 sectors/disk)
- auto pospp0x = Monitored::Scalar<int>( pospp0varx, (a-1)/6 + (b-1)*8 + 1);
+ auto pospp0x = Monitored::Scalar<int>( pospp0varx, a/6 + b*8);
auto posx = Monitored::Scalar<int>( posvarx, b);
auto valp = Monitored::Scalar<float>( valvarp, pixarrays.DA[a][b]);
auto valm = Monitored::Scalar<float>( valvarm, pixarrays.DA[a][b]*weightPix);
@@ -195,7 +195,7 @@ void PixelAthMonitoringBase::fillFromArrays( const std::string& namePP0, Accumul
auto valp = Monitored::Scalar<float>( valvarp, pixarrays.IBL[a][b]);
auto valm = Monitored::Scalar<float>( valvarm, pixarrays.IBL[a][b]*weightIBL);
if (pixarrays.IBL[a][b]>-1) {
- if (b>0.5*nbinb) {
+ if ( b > (0.5*nbinb-1) ) {
fill("IBLA", pospp0x, valp);
} else {
fill("IBLC", pospp0x, valp);
--
GitLab
From 34b6b0aa478a47a06ff5b487a735a1b8022d0b47 Mon Sep 17 00:00:00 2001
From: Iskander Ibragimov <iskander.ibragimov@cern.ch>
Date: Thu, 5 Nov 2020 12:17:53 +0100
Subject: [PATCH 2/2] Map_Of_Modules_Status now for every LB for defect setting
---
.../PixelMonitoring/python/PixelAthClusterMonAlgCfg.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/InnerDetector/InDetMonitoring/PixelMonitoring/python/PixelAthClusterMonAlgCfg.py b/InnerDetector/InDetMonitoring/PixelMonitoring/python/PixelAthClusterMonAlgCfg.py
index 42469ac5cfcb..2736a14aec74 100644
--- a/InnerDetector/InDetMonitoring/PixelMonitoring/python/PixelAthClusterMonAlgCfg.py
+++ b/InnerDetector/InDetMonitoring/PixelMonitoring/python/PixelAthClusterMonAlgCfg.py
@@ -34,7 +34,7 @@ def PixelAthClusterMonAlgCfg(helper, alg, **kwargs):
if doLumiBlock:
title = 'Modules Status (0=Active+Good 1=Active+Bad 2=Inactive)'
- define2DProfHist(helper, alg, histoGroupName, title, pathLowStat, type='TProfile2D', lifecycle='lowStat', histname='Map_Of_Modules_Status_LB')
+ define2DProfHist(helper, alg, histoGroupName, title, pathLowStat, type='TProfile2D', lifecycle='lumiblock', histname='Map_Of_Modules_Status_LB')
histoGroupName = 'BadModules_per_lumi'
title = 'Number of bad modules (bad+active) per event per LB'
--
GitLab